[Detnet] DetNet MPLS over UDP draft -02 review

"Grossman, Ethan A." <eagros@dolby.com> Fri, 25 October 2019 02:04 UTC

Return-Path: <eagros@dolby.com>
X-Original-To: detnet@ietfa.amsl.com
Delivered-To: detnet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8B9F912006A for <detnet@ietfa.amsl.com>; Thu, 24 Oct 2019 19:04:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=dolby.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6oLsD19Jfnbt for <detnet@ietfa.amsl.com>; Thu, 24 Oct 2019 19:03:57 -0700 (PDT)
Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-eopbgr770119.outbound.protection.outlook.com [40.107.77.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 99FD6120018 for <DetNet@ietf.org>; Thu, 24 Oct 2019 19:03:57 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XSag0Ln8JnhUf+t+Wflp/DPZ8+49dT6vK2gSwujSqE+zdRkN+dTojQOMalrLWPNZZ5GmfaDJzliNyUQfXtm7oJsIU1adceIZUmv38w4TkQJkbmGY74uAT5+LZScrNkDjqsViHKpueummPs3N5RwgiXFih7RjrfNOreAlrf7JKjMHxaNbkgpmTgTU77OzHR7LnsSOWcIjlUg7uJLJVfzlvesV72zN3p2Qp9J0VCag2YWSKevBu3juFFCMLDvuW1tHUhwMQ7Vb3OFv4MT7e5O3HNhIckNQhrIXelKD+/6AqCKSW5BAVyFkO4DoRVKVY5VVCsNriEcQt+XJ1Y+Xt3XsZA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L8qPL6j8ee09u5GWxryfwDKvZ9i5E6LfhMIF0ik/Hq0=; b=lBxA++80t172uqEuhowPdb6xPJ0QaPTCbHVSDphavvQrkB0zlcaaK3rqrpl4eOurIG04PVZrYVQarpDjbX6qVUL0UrffoOqIAsnAxOhlZd+RfhfRfshjBD4BoRutaynPWuEth1z5alGeYnI53uGFNL3H9jc62w9GwIepG+DeVdsjPk8wifS8kFrLGptVdhSbJZCS7VpSEOV7yi6WyTLZBoVwtYbqte+s92QrC8KZSsRwj0bufToZwod9t4CwUliFXdyZM7ZgxyEm0GdHV3pBkzpks6TSwo8agNu4rL9x2soR0sIgcrv+Li+cs4OJClRSW06tcDLh/hyz9R7Jvxr2RQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=dolby.com; dmarc=pass action=none header.from=dolby.com; dkim=pass header.d=dolby.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolby.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L8qPL6j8ee09u5GWxryfwDKvZ9i5E6LfhMIF0ik/Hq0=; b=YMk5riCJDiJt7+CZqY2BXl8/FvogQPqNyG9M9MWDQIenep5iU790877KyNxuI6DJOUTFwtmzxgXQmw+NcaNl55zdvVfBqsTuDrtsufimaBjLT47NyQIY+Wz+kJUhQMJOMGSGFtn10tdobiIEjRb/sPxU6iJNCbPr2x6jFveyepI=
Received: from BYAPR06MB4325.namprd06.prod.outlook.com (52.135.240.140) by BYAPR06MB4677.namprd06.prod.outlook.com (52.135.235.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.24; Fri, 25 Oct 2019 02:03:55 +0000
Received: from BYAPR06MB4325.namprd06.prod.outlook.com ([fe80::4133:d57b:b32e:99b8]) by BYAPR06MB4325.namprd06.prod.outlook.com ([fe80::4133:d57b:b32e:99b8%3]) with mapi id 15.20.2347.030; Fri, 25 Oct 2019 02:03:55 +0000
From: "Grossman, Ethan A." <eagros@dolby.com>
To: Balázs Varga A <balazs.a.varga@ericsson.com>, "DetNet@ietf.org" <DetNet@ietf.org>
Thread-Topic: DetNet MPLS over UDP draft -02 review
Thread-Index: AdWK1tcisbQ7GM0DQp254YI4sm8L+g==
Date: Fri, 25 Oct 2019 02:03:55 +0000
Message-ID: <BYAPR06MB43252E99E4748007BEA64278C4650@BYAPR06MB4325.namprd06.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5Lmh0bWwiIHA9ImM6XHVzZXJzXGVhZ3Jvc1xhcHBkYXRhXHJvYW1pbmdcMDlkODQ5YjYtMzJkMy00YTQwLTg1ZWUtNmI4NGJhMjllMzViXG1zZ3NcbXNnLWFkNDZlNjdhLWY2Y2ItMTFlOS1iOTBmLTg0ZmRkMTNjZDRjZlxhbWUtdGVzdFxhZDQ2ZTY3Yi1mNmNiLTExZTktYjkwZi04NGZkZDEzY2Q0Y2Zib2R5Lmh0bWwiIHN6PSI3Nzc1IiB0PSIxMzIxNjQ0MjYzNDMxNDE4MDUiIGg9InZiWE5WOU1qbzlIN08ybU54WjJhQUpEblRCST0iIGlkPSIiIGJsPSIwIiBibz0iMSIvPjwvbWV0YT4=
authentication-results: spf=none (sender IP is ) smtp.mailfrom=eagros@dolby.com;
x-originating-ip: [8.39.141.5]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 71f8cd80-c787-4295-835d-08d758ef974a
x-ms-traffictypediagnostic: BYAPR06MB4677:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-prvs: <BYAPR06MB46771FDD85AAC903D77D7324C4650@BYAPR06MB4677.namprd06.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 02015246A9
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(39860400002)(366004)(346002)(376002)(136003)(189003)(199004)(66556008)(99286004)(7736002)(6116002)(55016002)(66476007)(81156014)(81166006)(6436002)(74316002)(66446008)(64756008)(14454004)(110136005)(86362001)(6506007)(25786009)(236005)(2906002)(316002)(71200400001)(76116006)(66946007)(71190400001)(6306002)(966005)(8676002)(54896002)(478600001)(102836004)(2501003)(476003)(186003)(486006)(9686003)(606006)(52536014)(7696005)(66066001)(256004)(33656002)(26005)(5660300002)(3846002)(8936002)(790700001); DIR:OUT; SFP:1102; SCL:1; SRVR:BYAPR06MB4677; H:BYAPR06MB4325.namprd06.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: dolby.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: MRx1KGju+PKbZO1Zo9NZMu33R/WnilK0IeSyX00iNDNjxJ5kbV519aO26bAaTDFVG7zRIF/QWPCq/SN4LW7YdaKOuvDoyKjcfPBpG/97G+KNXnOPv6xFN5Hbr5smckHKkI7KJzHMQlRuPPiYj+hq+gJqbzlkNUreltRnlqWNInw7z0nco2J62/AKujCrioNfTXbYlnViY81I8J4fyHgg6vJvnTh1bKsSu+CK4dKmMpoSiE6nrRrNyPab9tzCgfsNCSMjzru/mVsQEMer/DA4yd25ovsh+bheLjNX1NGFGtvesIGBcg4kQQNdHcO5CoYs70GPfOrShWAwUXHByQtLyoM6KZYpq2uV1/qlhylJU7nJj8oBPqZS+FeU6ZpwPBRxr8OuTzsTUHa4EcQtGypEJgiK7U78tS3ugb9TPUIvDHkTf4/WtA5MF5BcXRKPpvC0vnT4Y7LwDE343kZyTAMVqT8+G1OfHJilM5/2sj/gEIc=
x-ms-exchange-transport-forked: True
Content-Type: multipart/alternative; boundary="_000_BYAPR06MB43252E99E4748007BEA64278C4650BYAPR06MB4325namp_"
MIME-Version: 1.0
X-OriginatorOrg: dolby.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71f8cd80-c787-4295-835d-08d758ef974a
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2019 02:03:55.3196 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 05408d25-cd0d-40c8-8962-5462de64a318
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +ehH6nO03MvZHBLz3eGtGKYp/fneURSmP0dh6wYCAAUDmtKbkFlsJmpgX0qQIuWcVtjPqACG3FDYp7hf2QAHyg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR06MB4677
Archived-At: <https://mailarchive.ietf.org/arch/msg/detnet/5Xqgkmyg70U9jFMvNk9t5BJ6YeY>
Subject: [Detnet] DetNet MPLS over UDP draft -02 review
X-BeenThere: detnet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussions on Deterministic Networking BoF and Proposed WG <detnet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/detnet>, <mailto:detnet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/detnet/>
List-Post: <mailto:detnet@ietf.org>
List-Help: <mailto:detnet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/detnet>, <mailto:detnet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Oct 2019 02:04:01 -0000

Hi Balazs et al,
Finally, the last of the my candidate DP draft reviews complete. Let me know when you have done as much editing and re-submitting as you are going to do on the 5 drafts, then we can start WG LC for all of them. I assume we are going to re-LC the Framework draft since it has had a fair number of changes - is that correct?

It would be great if we could finish LC for the whole set in the same period, before IETF 106, so we have about 3 weeks. Maybe we can start WG LC Monday or so? Please let me know.

BTW, my motivation for doing these reviews is to enable others to more comfortably review the sense of the documents without getting bogged down in grammar or inconsistent wording. I.e. I am not trying to just pick nits. I hope this strategy is OK with you.

Thanks,
Ethan.
--------------------------------------------------------------

  1.  "DetNet provides these flows with a low packet loss rates" - "DetNet provides these flows with low packet loss rates" or maybe use the phrasing from the other drafts which I think is consistent: "DetNet provides these flows extremely low packet loss rates and assured maximum end-to-end delivery latency."
  2.  "To carry DetNet flows" - "To carry DetNet MPLS flows" - right?
  3.  "identifying the DetNet flow group" - This phrase "flow group" is not used anywhere else -  can we say "identifying DetNet flows" ?
  4.  "A method of" - I think this should be  "A method for" however it is a matter of meaning, since apparently both are grammatically correct (e.g. see https://english.stackexchange.com/questions/133310/methods-to-do-vs-methods-for-doing).
  5.  "PRF           Packet Replication Function" - Missing def of PREOF.
  6.  "nodes that implement also" - "nodes that also implement"
  7.  "d-CW, S-Labels and zero or more F-Labels" - Looks weird like that, better to start sentence with a capital letter: "S-Labels, d-CW, and zero or more F-Labels"
  8.  "The headers for each outgoing packet MUST be formatted on the configuration information and as defined in [RFC7510]" - "The headers for each outgoing packet MUST be formatted according to the configuration information defined in [RFC7510]"
  9.  "IPv4 and IPv6 source address field" - don't you mean "IPv4 or IPv6 source address field" ? Same for next bullet item.
  10. "IPv4 Type of Service and IPv6 Traffic Class Fields." - this should be in the same form as the above, e.g. "IPv4 Type of Service or IPv6 Traffic Class field."
  11. "draft-ietf- detnet-architecture-13" - can now be RFC 8655!

--------------------------------------------------------------