Re: [Detnet] Comments on detnet-yang-15 Re: [Last-Call] Yangdoctors last call review of draft-ietf-detnet-yang-14

Don Fedyk <dfedyk@labn.net> Mon, 21 February 2022 14:29 UTC

Return-Path: <dfedyk@labn.net>
X-Original-To: detnet@ietfa.amsl.com
Delivered-To: detnet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7AD713A0C2F; Mon, 21 Feb 2022 06:29:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=labn.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ws3_MODX581G; Mon, 21 Feb 2022 06:29:09 -0800 (PST)
Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2139.outbound.protection.outlook.com [40.107.236.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 12BFA3A0AE4; Mon, 21 Feb 2022 06:29:08 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kyrrfq4eIssibjuTvN9VNd+VnElEGJZjXBniKwtDAIzpCaw1soC3AvaSY96LO9iDbmeJYxzWSAlrvY5nUIX711+MBvZ/5IQ+gTFmkmBpXQ4DI3GRaV4HpYUzSKB1wprmqoWu826uzNJPLXkqH18/u8wifiTXM25Z5zb/1Y9BPwDYVXEYRx5aRlB9Og243+FaoXsYLLB4/XwNsGcxgIVi+tgeyX0yltIpViCDFacmvoTR93RCoCK5l/PhvsHCaDCv5+fRmHkVhueE8ld1eJhabFdvti2iaF1vI02AJE3bfGigA8dBXMvTR731uUtH3AlNgmmvPwFqVqQ0sI6orUzP+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zCgXCE4O03dAn824Oy6oFG2A8axfbEbPF0TeXUookAo=; b=XWO2KbgjHhuaYlvrWcFq7kr84Yd7AR/JGAK/H870JIxOtdYdgTdTpCP8NSz7Lshi4fIyXpo60GYOtDOwq4mRgADLkK1A0M8iF18zy2yKnl6D05WCFFDe2ijgXS4oUmmt2jW4M2jBAwK+6+M884wm7snhF0xMjqssSLZPzZo1x8JUPY4Q8DeeC0pFn5syUl+s3QLJq8ttXHMkJB4oG8l19WOZK9P0d4zz4EKJI3HOaZdMC/7pzXSyP+FCKF93Av/aHDkr4qEnqWmORf75DfyWubsitc1Pog1q7yY2JaO9ZNeMx4SaMZxV5B9GNPMpIFlE/fypB5BnDF1ocQxTz/UH+w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=labn.net; dmarc=pass action=none header.from=labn.net; dkim=pass header.d=labn.net; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labn.onmicrosoft.com; s=selector2-labn-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zCgXCE4O03dAn824Oy6oFG2A8axfbEbPF0TeXUookAo=; b=RmU7uUszuHWDjwwY4AlRM/LnkzHmCUoZqqxApgRIPLVdrI3afg8rExK9H1Mkr6JGgklx3eC9e+2sQjc38E55cqlVG3A0e+Yq36TBbYK0AqKs7L7LGYT68XNODHa0I8IUxsrvlUBEN3Jp3h/hhTWl62scFC8PleheECr60CWnlMU=
Received: from MN2PR14MB4030.namprd14.prod.outlook.com (2603:10b6:208:1dc::14) by CH2PR14MB3960.namprd14.prod.outlook.com (2603:10b6:610:ae::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Mon, 21 Feb 2022 14:28:56 +0000
Received: from MN2PR14MB4030.namprd14.prod.outlook.com ([fe80::4ce2:9d0c:ff32:928d]) by MN2PR14MB4030.namprd14.prod.outlook.com ([fe80::4ce2:9d0c:ff32:928d%9]) with mapi id 15.20.4995.027; Mon, 21 Feb 2022 14:28:54 +0000
From: Don Fedyk <dfedyk@labn.net>
To: tom petch <daedulus@btconnect.com>
CC: "detnet@ietf.org" <detnet@ietf.org>, "draft-ietf-detnet-yang.all@ietf.org" <draft-ietf-detnet-yang.all@ietf.org>
Thread-Topic: Comments on detnet-yang-15 Re: [Last-Call] Yangdoctors last call review of draft-ietf-detnet-yang-14
Thread-Index: AQHX1aVVzOJCkt7zEEO2OKLaojNpkKxAOHCAgBTg/mCAAXLNAIAABy7wgAk64MCANvKogIABvJnggALuK4CAAz/qQA==
Date: Mon, 21 Feb 2022 14:28:54 +0000
Message-ID: <MN2PR14MB40306D6132CA9D2F48EC306CBB3A9@MN2PR14MB4030.namprd14.prod.outlook.com>
References: <163648840575.19216.561627083204230489@ietfa.amsl.com> <61C46025.5040800@btconnect.com> <MN2PR14MB403066E8D1953043A52D3FE3BB4B9@MN2PR14MB4030.namprd14.prod.outlook.com> <61D71AE6.80502@btconnect.com> <MN2PR14MB403051ABB0AFCAFEDD34E1BBBB4C9@MN2PR14MB4030.namprd14.prod.outlook.com> <MN2PR14MB4030A544B79E73DE20248DA4BB529@MN2PR14MB4030.namprd14.prod.outlook.com> <620CF703.9030605@btconnect.com> <MN2PR14MB4030082721A510DA7A466FA6BB379@MN2PR14MB4030.namprd14.prod.outlook.com> <6210E141.4020607@btconnect.com>
In-Reply-To: <6210E141.4020607@btconnect.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=labn.net;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: fe945854-8231-4db0-7730-08d9f5467d2f
x-ms-traffictypediagnostic: CH2PR14MB3960:EE_
x-microsoft-antispam-prvs: <CH2PR14MB396066E9B466B7525EF4638ABB3A9@CH2PR14MB3960.namprd14.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: +BoOPZgr/0ixDqnpRATDSQyG7XFoY0oqWmqaVTy9BbsyU5qgPwNVx+4xWmGM5pNu+b6D4FLJ88RTGWUPEiQhnQz/c2z4WOmcIGSByWU+z0RhL+WbLXCRS2QLtBnh43YijFZy6RWhXwaBO+fTQwxgbU/vQMPv4qYbsNID06HjVLzX0aX3AkwMcbgdWVDiAEgNR3Fslj2ownFO++bRTeBOUgoVy/gm2t1N+Z4pVRTmKdaY+cN90Nc3kw6aJpnGVTaJTKNzPAfK5EASJgADgXh/z6uGJQlnTCxFEFMZxGiQGSyuHN1eHLFOBe1Z63pejKqu8i2+cNhTB7YuePanLd/8cPkCDcx98Koy+N+Pv6P+iYoNbXR0aSpe7gc6mFwL9kiQVUVHecDYXGSGVJUNJJbhgF640UfFV0pWon84hOtbYijBQumWRzUenngQ2XsmR8uAYwd9uo1z0AQwHpVIMgn/Cn3vmA2BK3AN/IUTm25BtPXzEwuTBpTebuY41PKVtMWiBTvdxrbCNF1hEmasyEMdL1l+z+z2c90nA6ZOqxPmjNIJx4A99g2qqPdiZ5II/ed7z0AWAs7KVxMlbEJP7eKdcE6CbobfoI1xcHENW6eIagj9nr4uzX7ysoBGqd61sEMBa7+eI8w1LMucSksKffVxZ7iuO8/JueRwY0sUuWSqk8s9O09pmExtEgQvyso9b3okAindvCETl8pz6me7NRxs6zMjdPSzCUf0zShJv0+dzzsSX8CjjjliQxz0Di6yYLikCMd2jmMdd1GHFMj5ZVi1NtWOz44MRKzt+9mk06ZwlIs=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR14MB4030.namprd14.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(376002)(366004)(136003)(396003)(39830400003)(346002)(26005)(6506007)(15974865002)(71200400001)(7696005)(86362001)(186003)(2906002)(53546011)(122000001)(38070700005)(38100700002)(76116006)(83380400001)(296002)(316002)(508600001)(54906003)(6916009)(66476007)(8676002)(66556008)(66446008)(4326008)(966005)(66946007)(64756008)(9686003)(8936002)(5660300002)(33656002)(55016003)(52536014); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dmdheHpRMUZLMXZZMWpMcWdWczdGTXhEalRwbklxVFVZUDNjT29kcWsrLytw?= =?utf-8?B?MC96NUNiMHZjM0ttak51NVNoYXBDb3diTytzdHNpMWlCWUNxMVc1L2JZMkV3?= =?utf-8?B?NXdlTTYwazY0ZHNWTi81aU95SW5qK0c1UlZ1RGxITlM5TTNvQ1JOODBWaGdN?= =?utf-8?B?TUdBK29Zbkx6LzhmbFpKNyt1eG5iQzlhWWdFL09aK3JaSEJ4Nkt1dHRwaFJT?= =?utf-8?B?bnZ4U3dkTDRDTmtwRVBhUHRyRTE0cWR1OTZYb2ZNb25IczZUSmxiZzF5MXpZ?= =?utf-8?B?MU1HU0tmZi8rcE5YalovZWpZd3FBOXFPZlJ3N3NOai9JRUpPcGxZZjVQU1hl?= =?utf-8?B?QTdEWTJwd3VQZFR2dFN1WUV2WklOSUZLZlljSy91anhZUEhlSFNwamNCSkdv?= =?utf-8?B?Y2hISXNoK0xUYU1TdXp2YU9wOHp2QzhHN1drbFFjcStTVkxScDEzRlFJRWVV?= =?utf-8?B?NUlpREtxY2ZuZmMyQmE2cENjV1oxSExJbWUyek53TTNiMy8zQ2tqNjB3QmlJ?= =?utf-8?B?VWRnWnZyME95blprRWNJS3ZGMEtIWXg4QmU4TlNXdlVGSFpjZS8xdW56VVZS?= =?utf-8?B?UWJyajZna2EzYlB1WUhHZGVjYllzYmUvQ1ZPaHQvOVp2cXJuWUQxaldNNmQx?= =?utf-8?B?NGI3VXRUK3V4SWZ6eFlTcXFvNUIvMnRBZHgwQnBPL2ZrOXpBVi9NcVU1c1ZK?= =?utf-8?B?aHB3UVUxQ3NoR2JBV3BKWFNUaTZVU1BCQldTVGdkR0ZpOU5hQnFiM1ljd1dJ?= =?utf-8?B?emdFa2R4M3lPY1Q0L2lCRWdaWUpDYzNTYmYrMUlVQ3ZlU0g1dmlDZDhlVndO?= =?utf-8?B?UDFSM2I4anZPZlViamxZV0JrSzY0UFVEU3EydW5SYlFYSWNFTjVPc3h5MTFp?= =?utf-8?B?RC92dStHZlVxWHdxRWNGODQ5RU1yTGlvSEl3WGRocWdKTWlvejNlM3c5eG9W?= =?utf-8?B?dmFBZ3VEbStyM2gyT0JuVlVzOVJNc2JEY0xRTnBLNjFtYWhCalZlcW5UUnkv?= =?utf-8?B?SGpKWkw2MlUzOG9HdFc1aUJvMW5oZDBRbjM0dFJvWGFIM3VvZCtKTDZSZDV1?= =?utf-8?B?M3lzRUJwU05tdTFzMVlVaWJoNytiOWwvRDRXd3ErYm9rbXJiK2Z3V3A3ZzF2?= =?utf-8?B?MlgvQllOUVFSVWxSaWgwUXdjdGlST3dUQitBRExSaGw2T09oM2x0UTE5ZXkz?= =?utf-8?B?MlkvODJIeXFqeG9idHE1OFVaWFpiaVBUcEdkZHo0cEFDZy8wcm1VaVIxQ0xQ?= =?utf-8?B?b3UxaXFaem5zVnRta0pZYVFSdFJGZVpKRjBEMWRTSWVhZ0JNY05sN1ZORUhK?= =?utf-8?B?MDQyQkJzMU1IQXQxSitpNGFoeTduMGhOTEVzK1Ira3hEUmhSQjlaTmxncnBU?= =?utf-8?B?WFg1NzhpTW9ZSlIrVnpEcHNIaFE3a3MzZjNwYVNJdUhqcE41NXlWNklBUHVq?= =?utf-8?B?T0tWQUZJbHMrZEVZWmdMckN0dUNwWmVTN0QrOVdBK0tvYSsyT2xsd0JrQzAr?= =?utf-8?B?S0UwUVh1MFlybFEzK2tLL1lDejNySHYzNDkzZ3ZRN29CLzdkalVYK0Qxa0Y3?= =?utf-8?B?YzAzZWVCZW9WVmpqTis1K0lEMm92MitQMjltT1FRajBLY2o0ZkFscCtOSDJh?= =?utf-8?B?RGZ5YThkdFhlK3k4WnJYNDRxWEUrUVd6M1JJSkJnanVkbE1zUlAzM2FBVTZD?= =?utf-8?B?eW9yVjVBeWk2eE1hSFlaZjliRkZaNjhMRDN6L3FPY0ZzWmQ4K0FaR2R6V0xE?= =?utf-8?B?ZFUwcCtTRHkrdDZ6amdiZDBRZk5xelNwWHFBRkhFQ1lCK0duUGNVeVZBUEl4?= =?utf-8?B?YmljbWRQOHk0VTVGMkxzeFNldmJzL1FaUWhZZ0swSXNQMURQMm93dERSaEFw?= =?utf-8?B?OElUOWdDVHZpWi80aElNQ3FZd0UvdWRqWXIxWnk4YnVjNG5paStYZm90NVR2?= =?utf-8?B?NXpvcU5SYkFFVzJRNlVTMllBWXJBQ0prZFV6enhScktMSnhWeDU5b2E1dXBX?= =?utf-8?B?R092YzJhWkczNHBtK1N4eVVPYUE2amtObklNWDV3TnVycXFpTUhURW1SeVpo?= =?utf-8?B?WXFBcEdhSmd6RVF6b1BnQW5TbDRmVVlWMERrb0JZcjlvcFdEc1NrZmFmR1Uz?= =?utf-8?B?TkFSS0FMUzlvaEhXNFdib3h3alRlM1BmNlpSRElHQ1ZQWkppaERuZS9UTVNX?= =?utf-8?Q?IXfRrxfgL7oT9AonkPg7fOc=3D?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: labn.net
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR14MB4030.namprd14.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe945854-8231-4db0-7730-08d9f5467d2f
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2022 14:28:54.4695 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eb60ac54-2184-4344-9b60-40c8b2b72561
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tShE90Wwy9w7jbjLxPK3PAqhbiDb4sia2O0Ze6XLCb/BDCapeDBRrND79eD7/yhoXi7ivgVgCr5usc54k5wuBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR14MB3960
Archived-At: <https://mailarchive.ietf.org/arch/msg/detnet/AGEi-gTcQfOs9BDmczHhYtQ2_rw>
Subject: Re: [Detnet] Comments on detnet-yang-15 Re: [Last-Call] Yangdoctors last call review of draft-ietf-detnet-yang-14
X-BeenThere: detnet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussions on Deterministic Networking BoF and Proposed WG <detnet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/detnet>, <mailto:detnet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/detnet/>
List-Post: <mailto:detnet@ietf.org>
List-Help: <mailto:detnet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/detnet>, <mailto:detnet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Feb 2022 14:29:15 -0000

Hi Tom

I realized I was mainly looking at the JSON output which uses only name spaces. I find them easier to read. Most of our output files were JSON for that reason but we put a few XML examples in. Yanglint can produce XML output as well. 
Here is the actual XML format of the output test cases generated by the Yanglint. 

  <type xmlns:ianaift="urn:ietf:params:xml:ns:yang:iana-if-type">ianaift:ethernetCsmacd</type>

Our input file for XML uses some short form local prefixes due to an initial practice where I was prefixing every element - it was less readable so we dropped it, but we didn't update the prefixes. The input test data is not what we should have in the XML examples - it should be the Yanglint output (Which is should identical and has the full prefixes as above I missed that). I have been meaning to update the script to ensure that XML output from Yanglint is equal to the XML input as a test that data is not being missed.  I will update the XML examples which I believe satisfies your point. 

Inline [Don] 

Thanks.
-----Original Message-----
From: tom petch <daedulus@btconnect.com> 
Sent: Saturday, February 19, 2022 7:23 AM
To: Don Fedyk <dfedyk@labn.net>
Cc: detnet@ietf.org; draft-ietf-detnet-yang.all@ietf.org
Subject: Re: Comments on detnet-yang-15 Re: [Last-Call] Yangdoctors last call review of draft-ietf-detnet-yang-14

On 18/02/2022 15:57, Don Fedyk wrote:
> Hi Tom
>
> Looked into this and found RFC 7224 iana-if-type.yang uses this:
>
> module iana-if-type {
>    namespace "urn:ietf:params:xml:ns:yang:iana-if-type";
>    prefix ianaift;
>
> In the examples the string "iana-if-type" comes from the XML namespace not the prefix declared. Detnet YANG does not import iana-if-type.yang but it imports ietf-interface.yang module that imports iana-if-type.yang. When validating with Yanglint I have no control of the display "iana-if-yang" in examples - I use short form prefixes for those on input that do not show up in the Yanglint output. Yanglint expands the prefix used in the XML test files to the namespace.
> While we can add a reference RFC 7224, it is a namespace not a prefix that shows up in the output. Every object in the examples has its specified namespace. You pointed to a part of an example using ietf-interfaces namespace which prepends the iana-if-type namespace just for the typedef object.

Two thoughts.  First, the IETF advice is strongly that when an IETF module is referenced, then the prefix used should be that that module itself declares.  Since this is the common practice, then using any other is likely to cause confusion.  Yes, tools have to cope with deviations such as 'xmlns:ia=...' but that does not make them right.

Second, iana-if-type is an IANA maintained module so RFC7224 is no longer relevant.  Any reference should be to www.iana.org/assignments/iana-if-type/ .... (where the prefix is 'ianaift').

Since I see 'xmlns: ...' in the text of the RFC-to-be, in the examples, then my take is that understanding the RFC will to some extent depend on being familiar with iana-if-type.  I think you need a statement at the start of the examples that the examples include references to YANG module 'iana-if-type ' [Informative reference to IANA website]
[Don] Noted. 

Tom Petch
>
> Cheers,
>
> Don
>
>
> -----Original Message-----
> From: tom petch <daedulus@btconnect.com>
> Sent: Wednesday, February 16, 2022 8:07 AM
> To: Don Fedyk <dfedyk@labn.net>
> Cc: detnet@ietf.org; draft-ietf-detnet-yang.all@ietf.org
> Subject: Re: Comments on detnet-yang-15 Re: [Last-Call] Yangdoctors 
> last call review of draft-ietf-detnet-yang-14
>
> On 12/01/2022 14:07, Don Fedyk wrote:
>
> Don
>
> I am not sure where this is in processing terms - I see no Telechat date yet.
>
> I have (finally) looked at the examples having been put off by the size previously.
>
> I see that they reference iana-if-type but
> - there is no I-D reference for this IANA-maintained YANG module and I 
> think that there should be
> - the wrong prefix is used - the module declares a prefix of ianaft so that is what an IETF document should use.
>
> I am still looking at the examples.
>
> Tom Petch
>
>> FYI
>>
>> After Tom pointed this out, I did find the new site under author tools that generates all formats correctly including SVG from the latest version 3 xml.
>> https://author-tools.ietf.org/
>>
>>
>> Cheers
>> Don
>>
>> -----Original Message-----
>> From: Don Fedyk <dfedyk@labn.net>
>> Sent: Thursday, January 6, 2022 2:01 PM
<snip>