Re: [Detnet] Some more Comments on detnet-yang-15 Re: [Last-Call] Yangdoctors last call review of draft-ietf-detnet-yang-14

Don Fedyk <dfedyk@labn.net> Wed, 05 January 2022 19:58 UTC

Return-Path: <dfedyk@labn.net>
X-Original-To: detnet@ietfa.amsl.com
Delivered-To: detnet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D0CBB3A040A; Wed, 5 Jan 2022 11:58:23 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=labn.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V-yR-qdW0AG0; Wed, 5 Jan 2022 11:58:19 -0800 (PST)
Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2091.outbound.protection.outlook.com [40.107.92.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 54EA43A0408; Wed, 5 Jan 2022 11:58:19 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MeyY74aTkq/YtCRiDj2Zvv8SPZ88wOZB7jL/I84xiC99/W7BlmQ94jsxynbVYTgZT95tda5xvh4KhM4RCpXiI0ApnkGyjGaUVWuorU6egObzLwJ3DUydPA7A3HXl/ZWQWByVw7+DotEPw80K32qvmn6JUa/yYUtoFekm/3tSyEjP465jNPe6AapWDG6fwTQbIQOsnSMRy02/sFVH8/gddZC8kBo45xEyfiIFAUKSvTplWfqKbeQjiibjfyDuwxxsJUUJH0TUDb8HKLT4lGCwzDgVGh17ILfiVk4uBISoZrsGR25vfZES3zQSt1OoPKjtM3vejfGdJeCTZCQkfqIrlw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lSNGAmXjaTJtIhvHSa4dNo7Sf9VZCS6dlBGBSdnnv/E=; b=haRnNhwSVuwRLSfTfTyCIrMqhlVL8BZ0PbL7Fa2y2xqFzY35y3WpYD0MwQfsEbrQiCunuv6EK3r5pQNz2kw/8N/759L4sZseusqG++JwITVwyzD5jD/RQ/ixzx7bKtE+uFeO5sPoA0rcDtwuvJhC4zoH9zMHNUj8O0K3vX88kImEVNSniWP2NIVQoifHfq3nZbcgrZb1+7O/LfIImEmB26G6vKNFgHET6ugQG2bo80q7XuYNqaet5m/Xqq9qddzSiOXjA3yebyv9AZgLkGRZxzGcowHVH2EiPIsFFlYBG9RUJ2IpheXqVjuMQSa4pJyc+4oHqMwLG8bnRylfaMLmPQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=labn.net; dmarc=pass action=none header.from=labn.net; dkim=pass header.d=labn.net; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labn.onmicrosoft.com; s=selector2-labn-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lSNGAmXjaTJtIhvHSa4dNo7Sf9VZCS6dlBGBSdnnv/E=; b=mbED3FiXDlHcxYFhgvqTb4012Nc2VWmP6Wn+3hRWkHivc5ia8iYOwolYTOCy5hriORS4ZhzDlhfpU2LGn5De7PApjOAe3UiKsQu+7qRZmRnh4sqEs9zA5jErT9VpFflP9S5cMHPM0KJBiihCueyXYiNWbMqTexnE5PkHX18k4wI=
Received: from MN2PR14MB4030.namprd14.prod.outlook.com (2603:10b6:208:1dc::14) by BL1PR14MB5063.namprd14.prod.outlook.com (2603:10b6:208:319::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.9; Wed, 5 Jan 2022 19:58:12 +0000
Received: from MN2PR14MB4030.namprd14.prod.outlook.com ([fe80::29a7:f994:54f5:b486]) by MN2PR14MB4030.namprd14.prod.outlook.com ([fe80::29a7:f994:54f5:b486%5]) with mapi id 15.20.4844.017; Wed, 5 Jan 2022 19:58:12 +0000
From: Don Fedyk <dfedyk@labn.net>
To: tom petch <daedulus@btconnect.com>
CC: "detnet@ietf.org" <detnet@ietf.org>, "draft-ietf-detnet-yang.all@ietf.org" <draft-ietf-detnet-yang.all@ietf.org>
Thread-Topic: Some more Comments on detnet-yang-15 Re: [Last-Call] Yangdoctors last call review of draft-ietf-detnet-yang-14
Thread-Index: AQHX1aVVzOJCkt7zEEO2OKLaojNpkKxAOHCAgAfSxICAC08KsA==
Date: Wed, 5 Jan 2022 19:58:12 +0000
Message-ID: <MN2PR14MB40305E14718B672AAA8C084FBB4B9@MN2PR14MB4030.namprd14.prod.outlook.com>
References: <163648840575.19216.561627083204230489@ietfa.amsl.com> <61C46025.5040800@btconnect.com> <61CAF02F.4090602@btconnect.com>
In-Reply-To: <61CAF02F.4090602@btconnect.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=labn.net;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 80cc089a-8338-4081-67ad-08d9d085b456
x-ms-traffictypediagnostic: BL1PR14MB5063:EE_
x-microsoft-antispam-prvs: <BL1PR14MB50636E88DF302F73BE6BE651BB4B9@BL1PR14MB5063.namprd14.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: L2ZbL23uerAkCU7gvzK25apSSUnRpUeTRiAEYCsAVjR8qKmmUTtI4btcEgzxxnm/t9Yn/fTPdnaRV7Qka8WlVv3uKZkZkbBB5k4Rtz5Y3RLXTn/Gsa6RE3sOBJ8GdM0d+Yu3cFLCEXOKwHDQFf/q4VyFHxDTc2TSZThJkUbRM759IDGCSI9BWYIdVaSwimEkCEpAX/cx988vYjA9HWy6oaTKlGCQtdsu+ntGCVOTuqhmI8rbNB/sRRd+/1UdAOUd4VmNQ0KEy7wZnY8lDJEZyRrP+KVNODc6RroMgN1G8UJ8+d5plg07I1+KpbHBNnUML6YPBYk03vHRDLio4XgWrlPlmFkpaR1BysYtSfnZUeISxqitHnd8vRQuGQ6/u5/HcWZHHmOQeLXG/cGdzTmJMG8cYK3+OaZNmvFkf/m+20suqbQnyDTOlEBgoSVu1I6VI1MdekeCYJgZ+6/OKvljy451kOwY12J++89pZ8I+K5kGoH2ZEH1Xy0indM4sF1kxWn1IgvwBKZLg+PkWwOzGTEOj6xbxwQVsvzD9n4QjUEHC+jC463iF2GI7qeS77WvdjV7TQxw8rf5+YA3K+s+RBuXkXw9MevTSCr2CpRNVGCeeqayNsuJZSPbFOyqI8pj+zn/wyGf6NtiyUIqG7NkuKrTDk0kyX2BhyHc16HYvlQTU9HpmbJWSyqPnWUqnZ9S736V/9Gs9niNuowKMwsvb66bBUWbSDVtBpkQm2ktW4b2CVfnMlt2BdN5RwAP98gpwTWVFeIeRwLjWVoODzmpkEy+0noGK/dqJ55+0UHov80Y=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR14MB4030.namprd14.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(39830400003)(366004)(136003)(396003)(376002)(52536014)(71200400001)(26005)(2906002)(9686003)(6506007)(966005)(33656002)(122000001)(53546011)(316002)(296002)(76116006)(38100700002)(508600001)(66476007)(7696005)(66556008)(66946007)(8936002)(8676002)(5660300002)(55016003)(83380400001)(86362001)(54906003)(186003)(38070700005)(66446008)(64756008)(4326008)(6916009); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?U3MrckgvNmVTK0pKd2swcTNLZWRIYUVaenl0bWFJRjFGRWpLRTVkV0R2bWE0?= =?utf-8?B?b3lybUJpV05XbDBSMytCOTAwcGd3MDhYWkVSeWwyKy9qdW9ocHluYnE4cmI0?= =?utf-8?B?ckRkYVJmYkF1ZnhZenNlRC9xTjRVOGZ1T0MrNVpKeWdGNllsdTlmSWF5cmVP?= =?utf-8?B?YTVuU25jM2pRUVZ1aUY2a2ZCcXBlbDh1MVpVWDRsMmE0TjNLZ3VmNDlVSjgw?= =?utf-8?B?U3kxRDJDRUp6cjZwK25sdnptREZGYlRyM1NZU2hJY1Jza3RaeWUxT093d25Y?= =?utf-8?B?UDlDZTEwTmJHM1RwaUdBNWI5QUl2OHNiYVNwQjd2VklFck5QSExIVm5BMUtq?= =?utf-8?B?VWx6cERnamliNXFDcHB4UStTb0VnYVhWTGxLdU5qcTFsMDdPMHRXRUI5ZnhI?= =?utf-8?B?MjdNRjAxRDBjaGxMK25NY2VwTGtLR3BXaTFCR3d0UndQOFRFUjFoTThrSDFU?= =?utf-8?B?NHkraStzeHdOWkJDU3FDSDU3TmdJcTFZWEVUOVowUDQxcENTSU95V0lidWoz?= =?utf-8?B?SVZ0VkNBbEgvbTZOdTd6TElhZkZYTHZJVGRoMlZabUpvemFNN3VaUHJUTHF2?= =?utf-8?B?cDFzWjlxOHhCWUhjS1BMY3E0c3JQR0RLQVpIMzRQNVpzMEFRREYraUpTQ2Rp?= =?utf-8?B?d3VYMVV4OS9weHIxYXo4bDMySWtKaWs4VnRIclkyYkh2QUp4SnpMa0FxNXJj?= =?utf-8?B?Tkk1YU1NbmJLMURyTDVGZy9IUzc0dnJ4K1hhNTRUYkhMM3d5QkFIVFJPVEZt?= =?utf-8?B?UGhwZWJtNU10d1UvK3FyZFRyS0pPSUtpRVNIZURTV3dhOTdvWFZTcENWS1cy?= =?utf-8?B?R2piSElsRDZyTzhxb0liTkJKR3E2dFlZdXBhVmJsbTR0WEJMdUUwd2hCMTVJ?= =?utf-8?B?VGc4alRxQjE2Vng4VHJwSXA1dFNMSFlZaDVWL0JpRmxoK0I2WDJFVFhMa0Jn?= =?utf-8?B?UlRKS0E1VkNVaFJONVl3TFd4dldDaHpHUS9XVW9UcUh6d0xyb09WNmtkOUpv?= =?utf-8?B?WlVtQ2xrY3lZYnV5d25NREdVUFFsTGZkMGN1ek1Lakk1VjJYVVdVV1dRd24x?= =?utf-8?B?cy9MZVR5NytOWEIrbjduaTRmamsyQUI2d1VUTUtFYlhEYkM1WUttRGMva0U2?= =?utf-8?B?SE1abG5QR0FCMVVIOVJBMkhGWitNWWdzei93TjMwcnZaZFNtQ0xTUWNjY1JZ?= =?utf-8?B?ZEU0ZEcrRldTV3JGSndMQ0orcEFnNVRWM01QVVllMWJDcDlyNllZK21NNDRq?= =?utf-8?B?bHlLN3lJUVliaXliT0ovRElWamhneGFqN2ZHbDdUWmlzd1dCbkltQmZFZjRL?= =?utf-8?B?K1AvbVF2U2RNblZFR1ljVHA2L25zYnpZZWVNMVNnS1h3cDJ2b3IxQVNuSXQr?= =?utf-8?B?OU5HTkd1ZkxJQlVjK0FZSWdRTlpOcVpFaVBwbnlkS1lRS25Oemd1ZTVYYVFv?= =?utf-8?B?RmdTUWUxemQvVmlOWW1MenBmUGRmRlBGZmd1Tit0UmZzZEZJNHdiaEZSMG5S?= =?utf-8?B?K3A3ZWREZU1CTkRTdmdyelNZQ0ZwQ1krMGxzcTR5Zm1JRkFNV0JGSUFQTHRt?= =?utf-8?B?Y0Nmek8vNmNRTUZpNTlXWHRDNWZLUUpyTitlR0FCTTN2Snk3SlYwWHNSRXZS?= =?utf-8?B?aEU2amZUM01jV3JYUVN2Rk1Db3ZwOTlFQlFXR2JWSTFYWlBGVlhIVlkzWTZY?= =?utf-8?B?MHJ5YXBvbzdYUzRiV0N0cmtsbVRMTDBFM1UzZk1yN2pyYVhlVWFrckNPTlQ1?= =?utf-8?B?N2NnVkpyMitTbnFFYWZvLzQ1bHFraEFpbllBcythRDBpaDFkL3ZCMDBGdXV5?= =?utf-8?B?dUhkTHRaUGswQi9KTVRBSnd4MHNNbm4vSzFrQ3ozUnoySDhlRlNsbGpnc2ZU?= =?utf-8?B?YkVVYjJaRklweFE4L2JvNy93bHFGb3lHRncvd1hTNU5TV1k4NFo2dG1lMHZt?= =?utf-8?B?cWVsb2VLRXE2a0tBb1Y3a3owMnhzcm52S1BTaEFrQ2lXYk5CV2VzZVVITVFk?= =?utf-8?B?ZjI4V0tWa2gvMUhqTEpCUVNwdVNxWHZSdlBRa0JVamdpUHlyeWNadkQxdTRV?= =?utf-8?B?RmJ5MDFnYXBVSkN0Qk5PWG11R0hTTG9YeTNQMC9hakxEMmIwQjZzV3dlSTJ6?= =?utf-8?B?M3QzUW80SVhHaEhZeUViWDNISVk4VndIV0tNdVBJR1hYcDJ5bnJjamdyZ1FE?= =?utf-8?B?aUE9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: labn.net
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR14MB4030.namprd14.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80cc089a-8338-4081-67ad-08d9d085b456
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2022 19:58:12.2237 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eb60ac54-2184-4344-9b60-40c8b2b72561
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hvKSS0+oi3qj1pjmJXnrAEtJf19QUdjuFoRyQl1sjH9Qy9SOMv/AA7a/ulvXG77AeDKLcOeWcJAn4kgyeis2fQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR14MB5063
Archived-At: <https://mailarchive.ietf.org/arch/msg/detnet/BL2Q3EKQo-UKirF_Dw9VQpiKlPU>
Subject: Re: [Detnet] Some more Comments on detnet-yang-15 Re: [Last-Call] Yangdoctors last call review of draft-ietf-detnet-yang-14
X-BeenThere: detnet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussions on Deterministic Networking BoF and Proposed WG <detnet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/detnet>, <mailto:detnet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/detnet/>
List-Post: <mailto:detnet@ietf.org>
List-Help: <mailto:detnet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/detnet>, <mailto:detnet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jan 2022 19:58:24 -0000

Hi Tom

Thanks for the comments. See Inline [Don]
I have pushed updates into https://github.com/detnet-wg/draft-ietf-detnet-yang

Cheers
Don

-----Original Message-----
From: tom petch <daedulus@btconnect.com> 
Sent: Tuesday, December 28, 2021 6:09 AM
Cc: detnet@ietf.org; draft-ietf-detnet-yang.all@ietf.org
Subject: Some more Comments on detnet-yang-15 Re: [Last-Call] Yangdoctors last call review of draft-ietf-detnet-yang-14

On 23/12/2021 11:40, tom petch wrote:
Also

"IP six tuple"
perhaps 'sextuple' That said, I do not know what the six are and cannot find a reference to six in either RFC8939 or RFC8964

[Don]It is 6-tuple in RFC8939.  We can use the exact same spelling to make it easier to find.   


"   Outgoing is viewed as going up the stack from"
Looking at fig 1 I would have assumed the opposite, going down the 
stack; perhaps IETF versus IEEE.
[Don] The diagram Figure 1 is consistent with the architecture. 
Down is pointing from the application. So, OK. Yes, I the text "up the stack should" 
be "down the stack" to be consistent with the diagram and with the architecture.   



" enum copy-from-app-flow {
     description
       "This type means copy the app-flow sequence number to the "
Mmm it looks like an enum to me and not a type
[Don] Agree. 

"  enum generate-by-detnet-flow {
      description
         "This type means generate the sequence number by the "
Ditto
[Don] Agree.

"     grouping detnet-flow-spec {
        choice detnet-flow-type {
          case ip-detnet-flow {
          case mpls-detnet-flow { "
elsewhere the case are 'ip' and 'mpls'; is this different?
[Don] Yes this is a bit different. For IP, this refers to IP as a DetNet flow identifier.
It uses an IP - wild card capable grouping. This allows Aggregation with IP headers.
 
In the other cases it is IP forwarding. For a specific IP header.
It uses a specific IP address grouping. 

For MPLS it is the same - Matching an MPLS DetNet flow (a label/label stack)
You could be matching just an outer label. 
Compared to the other cases using an MPLS label/label stack. MPLS is more subtle than the IP case where prefixes are used but it parallels the IP cases.

I think the distinction was deliberate and is useful.
I will leave this as is.   
 

      "RFC 9016 Section 5.5, IEEE802.1Q";
I would find this clearer with the two references on two separate lines
[Don] Sure. 


"       F-label for DetNet service or service-to-forwarding "
Perhaps a reference to "RFC 8964 Section 4.2.3";
[Don] Sure.

Tom Petch


> Borrowing a useful cc: with a related topic
>
> two documents in the YANG module need adding to the I-D References
> RFC8938
> IEEE 802.1Qcx-2020
>
> contact URL
> insecure, obsolete - https://datatracker ...
>
> Editor: Mach Chen
> not in the authors of the I-D
>
> TLP out of date
>
> Reference: this ID when published
> Reference: "RFC XXXX: Deterministic Networking (DetNet) YANG Model
>
>
> Tom Petch
>
>
> On 09/11/2021 20:06, Xufeng Liu via Datatracker wrote:
>> Reviewer: Xufeng Liu
>> Review result: Ready with Nits
>>
>> Thanks to authors for addressing the previous review comments.
>>
>> The updates look good. The followings are a few additional nits:
>>
>> 1) In the model, “container flow-spec” has been changed to “container
>> traffic-spec”, but the description has not been updated, shown as below:
>>
>>           container traffic-spec {
>>             description
>>               "Flow-specification specifies how the Source transmits
>>                packets for the flow.  This is the promise/request of the
>>                Source to the network.  The network uses this flow
>>                specification to allocate resources and adjust queue
>>                parameters in network nodes.";
>>
>> 2) Most names of list and leaf-list have been fixes. The following
>> three were
>> missed: “leaf-list member-apps” should be “leaf-list member-app”
>> “leaf-list
>> member-services” should be “leaf-list member-service” “leaf-list
>> member-fwd-sublayers” should be “leaf-list member-fwd-sublayer”
>>
>> 3) Section 10.  Security Considerations would need to include a list of
>> “sensitive or vulnerable” nodes.  RFC 8349 shows an example.
>>
>> Thanks,
>> - Xufeng