Re: [Detnet] Comments on detnet-yang-15 Re: [Last-Call] Yangdoctors last call review of draft-ietf-detnet-yang-14

tom petch <daedulus@btconnect.com> Thu, 06 January 2022 16:38 UTC

Return-Path: <daedulus@btconnect.com>
X-Original-To: detnet@ietfa.amsl.com
Delivered-To: detnet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E3CA33A0DF3; Thu, 6 Jan 2022 08:38:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.615
X-Spam-Level:
X-Spam-Status: No, score=-2.615 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, NICE_REPLY_A=-0.714, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nr30H6ixD0iP; Thu, 6 Jan 2022 08:38:06 -0800 (PST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2105.outbound.protection.outlook.com [40.107.20.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6EE113A0D6F; Thu, 6 Jan 2022 08:38:04 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=agYOf3L37dSo/7NWtPOOaRbJtPJfhn4S80AteYneociP0OzD5p1Au5NPkscLjlLLxlX6Vckp9v0Er5sQfFV73FA8KQIktkR01kCZvg9bdOCY3J0nFE9514T76fGD/LGzP5OWJhYrtSoNNiSWf6DjKoMTmCqvD9/reIBUHAhPOIANZ7EVYJWgCxuhQnmjyLYo8/G6DbhkOzEmmid6PCWBKIWL+2nHHAl7wu6zKCy7gOdaqDXkOPfhaYcKT5TI3Bhvn4xfgPW8o99NujerN0h/prxfz0lVQ2OqlQigE51wcx3J/zOKZZANr4SQ1mvuuE6y4ljYCxiETfobo+PX4l7RjQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mz5IjUxHGiASpV7wmgse5o0Sq2PKroX8YniKhNxuCn4=; b=az6W+einYv2WD8FzkFxrCFQ4zW7N2HE4c41cVYHwPAlf0J77klolpuiFyDWr8HhKBh3se08MdEXOfGsezoFZQF8itxSLjuoc/k/Mt9kpp+VURSQYsXGU3eSbnpDjDlLlkpLWkK0epZTHzRdRnZfkNRNc/wXRynH5q/s3EAuybY18kUOpYsZ/L74NVsSzzFe+6rvK8N2jYiY/aJIxduDDyJObSvQSQ713H/nCDK3FRN4p+XBmEqcDaIpXqiNQL6oFSJBYEHIQTm4l60Uh8re8qnI9ZiqApsEziV57v82hJH1ltbDjGqTkrDor7gYRjJBWlgK5h9ZMYlCOHDfeQHtZ4Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mz5IjUxHGiASpV7wmgse5o0Sq2PKroX8YniKhNxuCn4=; b=toIFiD/d032tYzWC7Fwp20QFkGjWb+VlUmYwkyfnd26P1W34qLDXiRUF+eszcpTuElO1gTHyafenpBkFMG7YhMXqaYzdamhgmwvRl2kXo8JkIldkj4aCJ+M+WH+KRhy11ldFViuMksE0+cmZ0ePzF5jMedwf9xvJEGPjABOg16M=
Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=btconnect.com;
Received: from VI1PR07MB6704.eurprd07.prod.outlook.com (2603:10a6:800:18b::8) by AM6PR07MB4648.eurprd07.prod.outlook.com (2603:10a6:20b:15::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.7; Thu, 6 Jan 2022 16:38:01 +0000
Received: from VI1PR07MB6704.eurprd07.prod.outlook.com ([fe80::60fd:157e:c5e3:1a18]) by VI1PR07MB6704.eurprd07.prod.outlook.com ([fe80::60fd:157e:c5e3:1a18%5]) with mapi id 15.20.4867.009; Thu, 6 Jan 2022 16:38:01 +0000
To: Don Fedyk <dfedyk@labn.net>
References: <163648840575.19216.561627083204230489@ietfa.amsl.com> <61C46025.5040800@btconnect.com> <MN2PR14MB403066E8D1953043A52D3FE3BB4B9@MN2PR14MB4030.namprd14.prod.outlook.com>
Cc: "detnet@ietf.org" <detnet@ietf.org>, "draft-ietf-detnet-yang.all@ietf.org" <draft-ietf-detnet-yang.all@ietf.org>
From: tom petch <daedulus@btconnect.com>
Message-ID: <61D71AE6.80502@btconnect.com>
Date: Thu, 6 Jan 2022 16:37:58 +0000
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
In-Reply-To: <MN2PR14MB403066E8D1953043A52D3FE3BB4B9@MN2PR14MB4030.namprd14.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0455.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::35) To VI1PR07MB6704.eurprd07.prod.outlook.com (2603:10a6:800:18b::8)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0358331f-8ced-4fc6-7918-08d9d132e776
X-MS-TrafficTypeDiagnostic: AM6PR07MB4648:EE_
X-Microsoft-Antispam-PRVS: <AM6PR07MB4648E52248002FDAB7804BB6C64C9@AM6PR07MB4648.eurprd07.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: L64jAgOahdXwaIcv3QaqGLPsEREDzgkxevWoNsMSYsVjizfl64HGhbKLTU1Wl0qdnwJU8k4apg8DGLbjxn0nlt+8nSrTuObqWE5Z7Vjdz/k6jnFuhMT6xWazzQTb0T4Pi5BcBAdv3t1btE7JF/dSvy3ltQssAAfFnkRbW5KaCM/kYK64xaMD4svqXcj5PtLdJxuPhiqt7HRfzb6WhVCh6Xmm4CkKGXqDrtbKSiAzORPNGmVv7PJTcvWuF4/fn5LqY0lJz0jUq+mL4u40EXN7QfzO9uznV0ybRJNEIlzSNmoC+7mqyQ0XLlzTVusKcrNay8UQ0XIk4XBo2tzmir83TPTc8hzR4t87vPi/Gr2Wv5VXYcyH53udhviNuqJPRWSDXd6WteHtfJ74+SiYMTuy2E9AhRXJp2ZgFYqvuzFLbZWyu3b7F946k25nGf4H5sQVyzLls9u9k2KGTa4Zf1cJ/RG2rnVKHUVpgpFoW5H0kREJR5uqXYdX/52qK8v337GEZGRaKeQzHy6NEInrTLycxtC4FqkoGvkFsDj1mcQOWc+7Kqu+f4KPf+A//XKCTTq2vQD2UkCUPzo9+7t8QgZ2Zk3enlrTwKQvUZgS0+FTbZO6OVwP2xRsoGy6Atvtv3hu6tVxPY9UIPQuPW5DJdZyS9X3HD60PWlpgdsgMnuOhVs7334rPGB9uBq/s9DKi9xfxWV6VG75EKnZauIVyX15mHgl2V/Q/x6Hk73b/VHc0Aw53UftRiro1iY8gSOlwDhbFjeTRCMoSL03xYWiRQYSgRUsF0OMJuJsdMweB6129Brte0irOQpeagmG74CNdajF
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR07MB6704.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8936002)(66476007)(186003)(6486002)(6512007)(6666004)(66946007)(26005)(508600001)(66556008)(4326008)(8676002)(54906003)(82960400001)(966005)(52116002)(53546011)(316002)(6916009)(38100700002)(2616005)(6506007)(38350700002)(2906002)(86362001)(83380400001)(36756003)(33656002)(5660300002)(43740500002)(20210929001); DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFkvV05mSjlnTloxSGJGdHJnaThPNFFZS2NVRmVnYjd6N1lDdE5QdnZ1dzRK?= =?utf-8?B?SG9xYXBDR3M0eXJrZndPTHpFc1NkWU9ITzR3NE1GZkhVWFdnSERJbVJUd0F5?= =?utf-8?B?SUlXbEhqUkxxbUtHSGJLMloza3hJN0RBUnJaMDM2ZzJnUTdSUi85WVNhbVNE?= =?utf-8?B?cTQzSEFScUNjMHB2MlVFcTZoSDVOeC94RFNBZ2YxYkRjZlY1UHlxWHErU0FH?= =?utf-8?B?Yk5CNVNxR08wNWJDQ1BqV2JYclZPbWVDdTZRempXelBGQ1ZGUDYxd3lEYksx?= =?utf-8?B?NnJNSnJORkxqcUY2OWsxelBwRkFTK2xic291S2xUcW9GTnJwK29aMStsMjdi?= =?utf-8?B?dlJwbWQzanBkMEVES1JUcE9jMFFSTGl5V0p4dXk1eXVIakgrN3VlMU9aRTAz?= =?utf-8?B?RlRnT3BTSGRUU2dKTEt3RTF3d1lOaXhvaXBhTDhNSnBhYjA0cVh0Y3FjM1J2?= =?utf-8?B?QXRwRGpuaHRZZzZhSXIvell1Qk1FUHFtM3Aydi9ZMVVuS1p3NG1QSHRkdjdC?= =?utf-8?B?M3Z0cWNRWWFkSkxUd2tnUHk1WkpqdHJnRVcrRVFpTkRyL3lwQU9mcHk4M3Nh?= =?utf-8?B?SFlESjFBZU9jZUZXUVZHZzhpKzRYekVtYXpYTUs4R0V4Q3l1c0dXRTdLMm5H?= =?utf-8?B?L1BTZEMyaHJGMVhMT1ZRMmJ3aGpiMGxKNWlOM0RpTzlYV0lKSjRCVlZVMVlX?= =?utf-8?B?STZNK3FmaE1TcDBrQmQwek4rUUFQVkpRdXN5VnJiWjh6U2dNNVFaTlVESTlC?= =?utf-8?B?dUo5U0dueG1reVE2WnFObmNuemJBQ200R3J2a1Y2SXhDTW9HY2t4S0JLb1Ix?= =?utf-8?B?d2QrZ0NkWDVsNy84OEo3ZnFZdmF0bjkwN005MTRxajljM2FtY25Oa0QyWmNu?= =?utf-8?B?Z0YzSzl0Y3lWTmVtTks3ak9HTG1iSlZwa3g5WFpzMWdaT2EyaDZvVXYzNmZ6?= =?utf-8?B?UGFGSHlSdEdvdTF5V0ZONWRrWHB2dWNWUVNQZkhnQmRoZUtwVEd0TlJPUEpz?= =?utf-8?B?VXU3MHh5OEV0NmdvMUFWSFB6eHVCVlhpRnBsVXJCTjl3ZmprUktKZk1lMENW?= =?utf-8?B?Rmg3eDZxODhON3B6SG9tczVXVWRPQVdIVjNYUnhwMVZ1UVVqZVZTdU5Kanh1?= =?utf-8?B?VTZaYnB1ckw3WFV1dkRqbHpBcDVzNThqVTFsc0NyVmVoMUtoaVA0QUtSeGhr?= =?utf-8?B?eGhnQ1ZYVmk1SzRsYy8xdzYreTRsZFY2NE5jNUw5TnV1TytNbXBqd2FTNFhN?= =?utf-8?B?K3g2N24zcWs1aElJek1NNER0YlJURVRhc05mdkprRUU2OW4xZXpsYWVNYWxJ?= =?utf-8?B?ZUR2RUNiQ0R0SDhacXRKenVKbWZjV2ZIc3V2R2Y3SHJCZVJVSzgwOUNNazJx?= =?utf-8?B?S2c4S3ZkNElhTHB3VHpvajR5Z08zNXNqaE0wcVcydzZkdnMzTURGelNKYmlJ?= =?utf-8?B?TTI3T0Q0SVNsU3d2ZSsxVDB5MEl4bHRUNnRyY3J4cmFidjk1U0tFVzA0L1N2?= =?utf-8?B?WmoxT3d3Z0pMUm5zTW0xbFFISE1WOE1JSzk4Qy9ubGRnRUk3ZlRkb3JnZzl5?= =?utf-8?B?cE83VFhkdGxkWmVaTEJiWGo1SWI2aHlkNlY2bWRJeXR2NThzUHpWeWg5d0du?= =?utf-8?B?NXMweXFqYmlsbTJjb3JCTDlacUc3aXp1R2p1UVJaZGx2RU53Z0JOVUtyVmVD?= =?utf-8?B?QXJML0poQnY1a2NPOWlrbUp4YnpuL0ZMeEJma3ZDUDZ5THR6RHdLRitvUjBF?= =?utf-8?B?eHlxckxhM0NVeCtXZVNKeEZNTHR4MFREa2xwUjZoOG02TEF2aHBZeWN4WGVX?= =?utf-8?B?em1HQkdrQzdnUlEvbTUrRUtFb0hMcXhvV05DUlN4aFpCN3lOUVhOcC9CcmFL?= =?utf-8?B?blA1UG83NFdPYWtkSWtmTTJ3VUc1cUt5NTRrMVhrY09WbWFTSGdzQzd2ZXN6?= =?utf-8?B?d29KRjNHOTBGY3pMdDIyZE0xMXYzU0pKTzNmTzdhaFNTdDFqQTR4Y3VjclpT?= =?utf-8?B?YlhIU0tVRjJ6WFR6SnUvaGV1cGRpMXNhRTdVdE5LTmIrRkw2enJPR08xY0Vq?= =?utf-8?B?dlBwUGY1ektoN1NoQkZSOU9XMVZvclYwRzJxUnJKT1QwTFdDcks1YVJ3MUpO?= =?utf-8?B?T2g2aC9RVU9mOElqNDJIVVBsUjhPczJwQWExWGg2STlaMlBFVzBQS0pzRUhr?= =?utf-8?Q?ny534s/LZQ3f4hINuN9UhvE=3D?=
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0358331f-8ced-4fc6-7918-08d9d132e776
X-MS-Exchange-CrossTenant-AuthSource: VI1PR07MB6704.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2022 16:38:01.4787 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7jGk2ripLZlP3pVWze9iHKDKSSZiKrIEQjoifCfZCVAq3IWbaW4nHqBB6oh3Q1I7qFObSy+tXHUq28Gf/1x1mg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR07MB4648
Archived-At: <https://mailarchive.ietf.org/arch/msg/detnet/Ct2ng0zzNdBpDF9LC05qAPKdkdk>
Subject: Re: [Detnet] Comments on detnet-yang-15 Re: [Last-Call] Yangdoctors last call review of draft-ietf-detnet-yang-14
X-BeenThere: detnet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussions on Deterministic Networking BoF and Proposed WG <detnet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/detnet>, <mailto:detnet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/detnet/>
List-Post: <mailto:detnet@ietf.org>
List-Help: <mailto:detnet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/detnet>, <mailto:detnet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Jan 2022 16:38:11 -0000

On 05/01/2022 20:04, Don Fedyk wrote:
> Hi Tom
>
> Comments Inline [Don]
> Also incorporated, https://github.com/detnet-wg/draft-ietf-detnet-yang

One follow-up in line

Tom Petch

> Thanks
> Don
>
> -----Original Message-----
> From: tom petch <daedulus@btconnect.com>
> Sent: Thursday, December 23, 2021 6:40 AM
>
> Borrowing a useful cc: with a related topic
>
> two documents in the YANG module need adding to the I-D References
> RFC8938
> [Don] OK on this one
> IEEE 802.1Qcx-2020
> [Don] I see. Yes
>
> contact URL
> insecure, obsolete - https://datatracker ...
> [Don] Fixed
>
> Editor: Mach Chen
> not in the authors of the I-D
> [Don] Fixed
>
> TLP out of date
> [Don] TLP?  I changed the date reference in the XML header.  It should line up with the module date.

Look in the YANG module and the TLP refer to Simplified BSD License [sic].

This changed in 2020 - I cannot recall an announcement thereof - and the 
new one is Revised BSD License as in 
draft-ietf-lsr-isis-yang-augmentation-v1

Tom Petch


> Reference: this ID when published
> Reference: "RFC XXXX: Deterministic Networking (DetNet) YANG Model
> [Don] I think the RFC editor correct this on publication.
>
>
> Tom Petch
>
>
> On 09/11/2021 20:06, Xufeng Liu via Datatracker wrote:
>> Reviewer: Xufeng Liu
>> Review result: Ready with Nits
>>
>> Thanks to authors for addressing the previous review comments.
>>
>> The updates look good. The followings are a few additional nits:
>>
>> 1) In the model, “container flow-spec” has been changed to “container
>> traffic-spec”, but the description has not been updated, shown as below:
>>
>>            container traffic-spec {
>>              description
>>                "Flow-specification specifies how the Source transmits
>>                 packets for the flow.  This is the promise/request of the
>>                 Source to the network.  The network uses this flow
>>                 specification to allocate resources and adjust queue
>>                 parameters in network nodes.";
>>
>> 2) Most names of list and leaf-list have been fixes. The following
>> three were
>> missed: “leaf-list member-apps” should be “leaf-list member-app”
>> “leaf-list member-services” should be “leaf-list member-service”
>> “leaf-list member-fwd-sublayers” should be “leaf-list member-fwd-sublayer”
>>
>> 3) Section 10.  Security Considerations would need to include a list
>> of “sensitive or vulnerable” nodes.  RFC 8349 shows an example.
>>
>> Thanks,
>> - Xufeng