Re: [Detnet] Genart last call review of draft-ietf-detnet-ip-over-mpls-05

"Tim Evens (tievens)" <tievens@cisco.com> Tue, 28 April 2020 21:43 UTC

Return-Path: <tievens@cisco.com>
X-Original-To: detnet@ietfa.amsl.com
Delivered-To: detnet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 581F53A097C; Tue, 28 Apr 2020 14:43:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.598
X-Spam-Level:
X-Spam-Status: No, score=-9.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=ATZdLYOc; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=HWP4LeD5
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XsG5NPXleKep; Tue, 28 Apr 2020 14:43:21 -0700 (PDT)
Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8AA983A0986; Tue, 28 Apr 2020 14:43:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4574; q=dns/txt; s=iport; t=1588110199; x=1589319799; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=6BNQ8R3y0CV/93F1ifgbABABdu0RFeW8BG8extvF1/0=; b=ATZdLYOcl0/8nfit/E9Q8NMiW2WhM/O47494eJkIyUKXPmGwJ0C4LBJB MujsBVOYS1vDdhxgOHprs2Wp8NBLTZJyaKAmq+s35y+MmOYjzq+X5xiWM oTG2vksnQAw8Qe6saEWq4SYqzvP+LdPNkJD/wDkF/rcVFwT4OP295Oy// k=;
IronPort-PHdr: 9a23:pvR2MhW8tah3f3DFNYpTeVcbCQnV8LGuZFwc94YnhrRSc6+q45XlOgnF6O5wiEPSBN+Duf9eiuHNqKfmH2cH5MXJvHMDdclKUBkIwYUTkhc7CcGIQUv8MLbxbiM8EcgDMT0t/3yyPUVPXsqrYVrUry6/9z8ZAQ74M0x+IeGmUoLXht68gua1/ZCbag5UhT27NLV1Khj+rQjYusQMx4V4LaNkwRrSqXwOcONTlm4=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0ApAABQoqhe/4gNJK1mGgEBAQEBAQEBAQMBAQEBEQEBAQICAQEBATyBNgIBAQEBCwGBU1EFbFgvKgqEFYNGA40vJZgvglIDVAsBAQEMAQEjCgIEAQGERAIXghEkNwYOAgMBAQsBAQUBAQECAQUEbYVWDIVxAQEBAQMSEREMAQE3AQsEAgEIEQQBAQMCIwMCAgIwFAEICAIEAQ0FIoMEAYJLAy4BDqkiAoE5iGF2gTKDAAEBBYFGQYM7GIIOAwaBDioBgmKJXhqBQT+BEScMEIJNPoJnAgMBgWEHMQKCWDKCLZE8oHMKgkWIEI9zHYJbmiSPfoFXh3KTPgIEAgQFAg4BAQWBaCOBVnAVZQGCPlAYDZI7g3KFFIVCdAIzAgYBBwEBAwl8kF4BgQ8BAQ
X-IronPort-AV: E=Sophos;i="5.73,328,1583193600"; d="scan'208";a="754264369"
Received: from alln-core-3.cisco.com ([173.36.13.136]) by rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 28 Apr 2020 21:43:18 +0000
Received: from XCH-ALN-003.cisco.com (xch-aln-003.cisco.com [173.36.7.13]) by alln-core-3.cisco.com (8.15.2/8.15.2) with ESMTPS id 03SLhH1c018791 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 28 Apr 2020 21:43:18 GMT
Received: from xhs-rcd-002.cisco.com (173.37.227.247) by XCH-ALN-003.cisco.com (173.36.7.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 28 Apr 2020 16:43:17 -0500
Received: from xhs-rtp-002.cisco.com (64.101.210.229) by xhs-rcd-002.cisco.com (173.37.227.247) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 28 Apr 2020 16:43:16 -0500
Received: from NAM11-CO1-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 28 Apr 2020 17:43:16 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V/w0jxIFuXHZiesHN3hi3U0jQuRiLt5e1R9sO1CvKlzf0w3VKVaDxhORrxdhxEp/Z29+3Tm6/9oyq7WCR6BlVeXjoaTgq5I6Jfee9s4PVxNkQt2ZI4fBu8i9eMU8VlDTnM+SJlHkfV1vKn7czCH0CCahfSQMqQ8ZxUdJnRJyLBcWzJKmxRC5+kEu7B3OwGPIek9QgkPcUpV+NieR366PWGTI2hSrhcNgQlI5HmIrkRdnu0DrIthQNm5WeRdJasHMwgO/sp7ZV8wSPQNDkZQPOWWUr1DmUMDeutsdWiYm7UoSx8AFFSH2l9+w6sRzH31SBoYXJPtcWAscP+PWcAivQA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6BNQ8R3y0CV/93F1ifgbABABdu0RFeW8BG8extvF1/0=; b=G1iOdmMZ1j8JtIBDTJ2cHpmvarHsansPAZnRZRstUL+UtDSazLEO/KR/bOaxVeUpE2rVlHCaxPbWBxZhLYl2T9LHi9WO6sPbhRkb5QgEACcqISbH1btSTq8jpfVX+d3XTpSP76jJh3W1hBxGCcI/2nBN98gg00gflWVXJBaCUV/Vi0DwH1InynFoYk8mfWgXF/pPpGCJm/EA5jB0H5sgJcjxUc+R2tqZfyYLBmXJ8JByqCG2YgF6qnNbS8OM6Y45WhcW2mvoXps+kp/vYH98/qnMuOlh7YxKp4+vz+lp/VHpoaXh0BbGYLDVEM1i0JnXkCXs3OKTbNKUZN4X4fKMMQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6BNQ8R3y0CV/93F1ifgbABABdu0RFeW8BG8extvF1/0=; b=HWP4LeD5D7vXlg5smZq+Aal6FxBMD8pw3JvCzwlN7o3gwW9CVlnR8iP6JbzGsEeyDUAvPIudiSh7K2tmWp/OJbb1u7ZI3sPGWjjXuMSPz56TKn6OVo0BV0s2qACZ4rXzTFe7BAuztfInUx0t0kivj0RCEUR8wIIWRf5HJQhP79g=
Received: from MW3PR11MB4651.namprd11.prod.outlook.com (2603:10b6:303:2c::21) by MW3PR11MB4588.namprd11.prod.outlook.com (2603:10b6:303:54::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Tue, 28 Apr 2020 21:43:15 +0000
Received: from MW3PR11MB4651.namprd11.prod.outlook.com ([fe80::2000:f0e8:ae9f:31a8]) by MW3PR11MB4651.namprd11.prod.outlook.com ([fe80::2000:f0e8:ae9f:31a8%6]) with mapi id 15.20.2937.023; Tue, 28 Apr 2020 21:43:15 +0000
From: "Tim Evens (tievens)" <tievens@cisco.com>
To: Balázs Varga A <balazs.a.varga@ericsson.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-detnet-ip-over-mpls.all@ietf.org" <draft-ietf-detnet-ip-over-mpls.all@ietf.org>, "detnet@ietf.org" <detnet@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-detnet-ip-over-mpls-05
Thread-Index: AQHWHJ9IQx9qJN4N80m+hXdjZ3kC2KiNLgwAgAEYtACAAFazgA==
Date: Tue, 28 Apr 2020 21:43:15 +0000
Message-ID: <42DE7184-DE48-4771-925B-31339015F9D7@cisco.com>
References: <158742114339.19382.10522767782147188556@ietfa.amsl.com> <AM0PR0702MB36033FFDB22B0D9572A85645ACAF0@AM0PR0702MB3603.eurprd07.prod.outlook.com> <E8DF16AB-45C2-4CA5-A5A8-DBAF1C8FED31@cisco.com> <AM0PR0702MB3603C422B308C33BE5D9F606ACAC0@AM0PR0702MB3603.eurprd07.prod.outlook.com>
In-Reply-To: <AM0PR0702MB3603C422B308C33BE5D9F606ACAC0@AM0PR0702MB3603.eurprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/16.36.20041300
authentication-results: ericsson.com; dkim=none (message not signed) header.d=none;ericsson.com; dmarc=none action=none header.from=cisco.com;
x-originating-ip: [128.107.241.171]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8b9846bd-bfd1-4964-fdbc-08d7ebbd2849
x-ms-traffictypediagnostic: MW3PR11MB4588:
x-microsoft-antispam-prvs: <MW3PR11MB4588935F7596875CD2B48F5AB6AC0@MW3PR11MB4588.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-forefront-prvs: 0387D64A71
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4651.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(39860400002)(396003)(346002)(366004)(136003)(316002)(86362001)(91956017)(2616005)(53546011)(6506007)(66574012)(26005)(33656002)(36756003)(8936002)(8676002)(4326008)(2906002)(110136005)(5660300002)(66556008)(76116006)(6512007)(66946007)(6486002)(186003)(478600001)(54906003)(66476007)(71200400001)(66446008)(64756008); DIR:OUT; SFP:1101;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: yFqCwsD1W9Sid7O5PnW0jQ8iyAJvAIICnNLml2wFDdF3fZdw8Ss9i/d6AKO9WxdI7Nqu7hVJ+BL7NQ1wI3vrSasl5uEFWhpSnjvzRQvv3873QQb9C4EnuABwVhqk2djk+cHN7mdlop+u7xiuLIZBda6ImJOBF3NgQehJYKkkSDPT0seDtKv2hKahmxv3RRrZOQN4v2TzOpm9dp346MXNVZsaWtIgw+fKsgi8/fKSAEfZsZ4HMPIhe0iUPgiBupTO+dUAFBaaRU6U5LS30G3ZCEFptjrNpQ2omhw6uYrGMW5e/OMUDui8JpM+To4Z3nABWdNFYUMgNEqiG7icObVwXwrXMTo76X7ub0coLgG3dy0251Hi4zNAfI+ckQtAvrJHd98tTOb77Dj7AVcmspoHo1l6VcSq9CSEgAAUvbO+n7E/AQ2CjKt/vJGqLXZ5IXoTHR72RkxvSzHG8aTFzFzuoE3MD1K8xwp67BjDoT5d09Tt3RtoL6Y8trxBZ+Wm6/lNiu3GokcasYbTcXk1W7tKfg==
x-ms-exchange-antispam-messagedata: FVoFW9XjGqVHEnpvRwQuSPDzB7CvUp5a2h9FPT7a0uAILh/Q6nVq79t+jgdPCiJtvwNu4FEBc0MElxpDhpmJoP/7dRmxy0LwtyJQydqPQsimV+5EBYFZHdiuTDVxyGOvF+/OBKzqUiTEgXkW8QQf2W3avmqUW5thB+LCDUQE1/wjO6LTqUSDf0gOWsCiK0mHk86ua7qG+E+ASr/G2S+QZZBWbhKowoG0gTdvlGz4lKKR/+u9Lxl1QScMcH8rEQ6nlQKFZs1+vnF7LsYLj7cEk6p0FhPRKayIOh01YUSQCBKMR+vvPcE/g1uhgshIvtYi5SN5kZmuKkuRxlK53rG29w6nVx7PQUebXuDhnx5R91+JI4BsuH2zMJ78a6wyGRatIcTDeRmbWc48cHQep3VOmiRoaZmlSP9tq6cy5Zoi7mOLLAYUHO+Hfs88KYC7QN81eCgEgkeE3o6giDBS51O3Clz/vez81XZEJ5YXnIAtkZvk5VEJ20xOjHPxUT2OS0HuLf0Tt1Bxo950oVydHQph/164ZEyts3cUGsfm3Jlyq9yW365dIQyWcBJGe058zXYzU5TdV/Gy+CHd0CNjKb7EbzoIYjUa9T278N3FRCmCmPPFhqpeYKK/GGZipTs7195QjhkZeAuh8e6tHE/MlCqreL54pD+0z0re78G2VpXGFI5rXY3z4b7Hq6ISTm+nipZagTBuchAPxii1o+1A8WK5/kyHUB/B/8oY9JHVIFc5xxJqkdplNcKIgKLUv8ZZLCf/e1NzY5eyXwItubnOAqvsBbvLqLxVT3mU3BP3rqDeIW2GCSHTesp/P2tdEFNE33K5
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <EE4907565A480A4CBBFC67F86EDD371C@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b9846bd-bfd1-4964-fdbc-08d7ebbd2849
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2020 21:43:15.0999 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GY1SVd7MXEY0EM21gPahazgUr0KlvmWtI9fw3kaSQImdxjgH7thYUowpQhOf0IOc7D55JAEx3ITKFJRfdlu75Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4588
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.13, xch-aln-003.cisco.com
X-Outbound-Node: alln-core-3.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/detnet/Tjc2oS9W0RRjbbiUYJhsHTU3_S8>
Subject: Re: [Detnet] Genart last call review of draft-ietf-detnet-ip-over-mpls-05
X-BeenThere: detnet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussions on Deterministic Networking BoF and Proposed WG <detnet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/detnet>, <mailto:detnet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/detnet/>
List-Post: <mailto:detnet@ietf.org>
List-Help: <mailto:detnet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/detnet>, <mailto:detnet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Apr 2020 21:43:25 -0000

Thanks. 

On 4/28/20, 2:33 AM, "Balázs Varga A" <balazs.a.varga@ericsson.com> wrote:

    Hi Tim,
    Thanks for the explicit suggestions, I agree that makes text clearer.
    I will update the draft accordingly in the suggested format.
    Cheers
    Bala'zs

    -----Original Message-----
    From: Tim Evens (tievens) <tievens@cisco.com> 
    Sent: Tuesday, April 28, 2020 1:48 AM
    To: Balázs Varga A <balazs.a.varga@ericsson.com>; gen-art@ietf.org
    Cc: draft-ietf-detnet-ip-over-mpls.all@ietf.org; detnet@ietf.org; last-call@ietf.org
    Subject: Re: Genart last call review of draft-ietf-detnet-ip-over-mpls-05

    Hi Bala'zs, 

    For the most part, great.   See comments inline marked [tievens]...


    On 4/27/20, 7:22 AM, "Balázs Varga A" <mailto:balazs.a.varga@ericsson.com> wrote:

    Hi Tim,
    Thanks for the review. Your comments will be incorporated in the next version.
    Feedbacks are inline below marked with <BV>.
    Many thanks
    Bala'zs

    -----Original Message-----
    Subject: Genart last call review of draft-ietf-detnet-ip-over-mpls-05

    Reviewer: Tim Evens
    Review result: Ready with Nits

    ... 

    In Section 4.2:

    * There is reference to section 5.1.1 and 5.1.2, but those sections do not exist in this draft.  Can you clarify which draft/RFC these sections are referring to? 
    <BV> Right, they are referring to "https://datatracker.ietf.org/doc/draft-ietf-detnet-ip/". Reference is at the end of the sentence. 
      "   ...   IP" and "NProto" indicate the fields described in
       Section 5.1.1.  IP Header Information and Section 5.1.2.  Other
       Protocol Header Information in [I-D.ietf-detnet-ip], respectively.

    [tievens] The reference is assumed instead of being direct, such as "as defined in Section 5.1.1 of [<draft>]"

    * "Per [I-D.ietf-detnet-mpls], the DetNet MPLS data plane uses a single
       S-Label to support a single app flow.  Section 5.1.  DetNet IP Flow
       Identification Procedures ..."  

       Why is Section 5.1 referenced like this?
    <BV> Again, this is referring to "https://datatracker.ietf.org/doc/draft-ietf-detnet-ip/".

    [tievens] the callout here is that this type of reference is on the side of being terse, not succinct and clear as to which document this section is belongs. Would it not be more succinct and clear as:

      "Per Section 5.1 of [I-D.ietf-detnet-mpls], the DetNet MPLS data plane uses a single
         S-Label to support a single app flow. DetNet IP Flow
         Identification Procedures in Section 4.4 of [I-D.ietf-detnet-ip] states that a
         single DetNet flow is identified based on IP, and next level
         protocol, header information."
    ?

    * "DetNet IP Flow Identification Procedures in [I-D.ietf-detnet-ip] states
       that a single DetNet flow is identified based on IP, and next level
       protocol, header information.  Section 4.4.  Aggregation..."  

       It would be more clear to specifically refer to the draft/rfc and section.
    <BV> Again, this is referring to "https://datatracker.ietf.org/doc/draft-ietf-detnet-ip/".

    [tievens] IMO, this would benefit from being more clear as stated above.  It doesn't add much verbosity to add "<section> of [<draft/rfc>].