[Detnet] Opsdir last call review of draft-ietf-detnet-mpls-over-tsn-05

Jürgen Schönwälder via Datatracker <noreply@ietf.org> Tue, 26 January 2021 21:48 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: detnet@ietf.org
Delivered-To: detnet@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 585FB3A0FD3; Tue, 26 Jan 2021 13:48:19 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: =?utf-8?q?J=C3=BCrgen_Sch=C3=B6nw=C3=A4lder_via_Datatracker?= <noreply@ietf.org>
To: <ops-dir@ietf.org>
Cc: detnet@ietf.org, draft-ietf-detnet-mpls-over-tsn.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.24.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <161169769915.24800.14331890465832309546@ietfa.amsl.com>
Reply-To: =?utf-8?b?SsO8cmdlbiBTY2jDtm53w6RsZGVy?= <j.schoenwaelder@jacobs-university.de>
Date: Tue, 26 Jan 2021 13:48:19 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/detnet/XpNqLDFMcpJuGQS8vTTsu6pf2EU>
Subject: [Detnet] Opsdir last call review of draft-ietf-detnet-mpls-over-tsn-05
X-BeenThere: detnet@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Discussions on Deterministic Networking BoF and Proposed WG <detnet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/detnet>, <mailto:detnet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/detnet/>
List-Post: <mailto:detnet@ietf.org>
List-Help: <mailto:detnet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/detnet>, <mailto:detnet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jan 2021 21:48:19 -0000

Reviewer: Jürgen Schönwälder
Review result: Has Nits

This is an informational document that claims to not state any new
requirements or recommendations. I am not following the DetNet work
and I only have a coarse understanding of MPLS. As such, I am not able
to comment on technical details.

There are quite a few sentences that use lowercase 'must' referring to
[IEEE8021CB] and [IEEEP8021CBdb]. These references are informational,
it seems that [1] suggests that more references should be moved to the
normative references section.

Since the document claims to not define requirements, I am wondering
whether all the "must" statements can be found in other documents. For
example:

   A TSN-aware MPLS (DetNet) node implementations must support the
   Sequencing function and the Sequence encode/decode function as
   defined in Clause 7.4 and 7.6 of IEEE 802.1CB [IEEE8021CB] if FRER is
   used inside the TSN sub-network.

In which document do I find this must requirement? I think there
should be references to those documents and the specific sections so
that it is clear where these "must"s are originating from. (Or the
initial promise that this document states not requirements is not
quite correct.)

[1] https://www.ietf.org/about/groups/iesg/statements/normative-informative-references/

Editorial nits:

s/flows with a low/flows with low/

s/provides congestion/provide congestion/

There are some grammar issues throughout the document, I guess the RFC
editor will deal with them.