Re: [Detnet] Iotdir telechat review of draft-ietf-detnet-ip-over-tsn-06

Balázs Varga A <balazs.a.varga@ericsson.com> Tue, 16 February 2021 17:34 UTC

Return-Path: <balazs.a.varga@ericsson.com>
X-Original-To: detnet@ietfa.amsl.com
Delivered-To: detnet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8ED503A0CE3; Tue, 16 Feb 2021 09:34:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.671
X-Spam-Level:
X-Spam-Status: No, score=-2.671 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.57, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LoSyUtbQkRDK; Tue, 16 Feb 2021 09:34:33 -0800 (PST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80059.outbound.protection.outlook.com [40.107.8.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9981B3A0CE2; Tue, 16 Feb 2021 09:34:32 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DLCPkdq+CWYM6A7cTsBq9kkRtny201txf8DiXJaCscDGdCqGJ4zD/J4kej2oBF4Jb92nQBToE4B/0XvFWgQpcLOVreYrUKe+CIfv1tPa02jIYIAUVWz9dRhEX6l3pLHewfPtqL8jYEqUOoKD3OJeoA5pu3w00fSmxNjagnbFQNT38QpcW6J+tAhXkNjqWfoOJtMc6y82oGM+mT4OQs1MueDegf7pZorssJrGspFXJTykO6oS2Fq2QTu3oG4UrVv2pqUSsOWUoUNwb20S5Zq/lMJPohp7ms16Uw/KuLQzBhBRaAmjiLzTHzz+IMyu++pgVMk905UsvsrefjsmaVg0VQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bk6/FgwoYPKtvMhzumFR15ZfyJUZpApmcqQ1Rr546Uc=; b=BhUtrrYNHbPSKthjKPFKsiqWgSh63ZcC8hgpHbLFCCRSlLfPWMyu3wbnK+3qncqk+F6HBCPwR6YLF0o85J293F6OkxFcjK3QNSOW7cps87e/RZme4nk9R8vkHarZ5SIAivway4dwjFHOqKTavyU09tA/zpRn2mOIKoKkW6IDieMlGIP/jOlLZ9p41PS7RfD5WOHsXs/pvwiaQd9X05y87/dL8nmvU6CT+CmhsEcmTAEnwRQBExhk1Y/P1paDXuZsNHqy4939R24DfCbs/20tCt6UFQVkMIOHIXaCnl6b+/C/ZSyZXC9tY2w9d09JeuhJHPUtnwUIA5W8Mj4kppSV2w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bk6/FgwoYPKtvMhzumFR15ZfyJUZpApmcqQ1Rr546Uc=; b=jGiODz6h1vkXVusAS90DavGwGmUFu7wm/nwKVrGgXMD8+TEDxc5lyUyPSt8iBlLgXy8/fvQUlplC+IBrNcMmB7hww5Ys3Ojn+5hEao0C4PzkOXmiX8HqVx/uc5SLOOS7BdAkLhelsInPiXCmcpmTKwYLSqkHWXQzyo8FNgXvaaw=
Received: from AM0PR0702MB3603.eurprd07.prod.outlook.com (2603:10a6:208:22::25) by AM0PR07MB6340.eurprd07.prod.outlook.com (2603:10a6:20b:155::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.19; Tue, 16 Feb 2021 17:34:29 +0000
Received: from AM0PR0702MB3603.eurprd07.prod.outlook.com ([fe80::3851:5264:9c3e:a251]) by AM0PR0702MB3603.eurprd07.prod.outlook.com ([fe80::3851:5264:9c3e:a251%6]) with mapi id 15.20.3868.019; Tue, 16 Feb 2021 17:34:29 +0000
From: Balázs Varga A <balazs.a.varga@ericsson.com>
To: Niklas Widell <niklas.widell@ericsson.com>, "iot-directorate@ietf.org" <iot-directorate@ietf.org>
CC: "detnet@ietf.org" <detnet@ietf.org>, "draft-ietf-detnet-ip-over-tsn.all@ietf.org" <draft-ietf-detnet-ip-over-tsn.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Iotdir telechat review of draft-ietf-detnet-ip-over-tsn-06
Thread-Index: AQHXA7R+/BPnqDf2G0OaApEntCHmpapbAQNg
Date: Tue, 16 Feb 2021 17:34:29 +0000
Message-ID: <AM0PR0702MB36036493BDBD1D25236FA4E7AC879@AM0PR0702MB3603.eurprd07.prod.outlook.com>
References: <161340516304.11578.12630851114853164201@ietfa.amsl.com>
In-Reply-To: <161340516304.11578.12630851114853164201@ietfa.amsl.com>
Accept-Language: hu-HU, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: ericsson.com; dkim=none (message not signed) header.d=none;ericsson.com; dmarc=none action=none header.from=ericsson.com;
x-originating-ip: [188.143.101.39]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9ef68b0c-d35d-4910-805e-08d8d2a11d0a
x-ms-traffictypediagnostic: AM0PR07MB6340:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <AM0PR07MB63406495C06141ADC1E67339AC879@AM0PR07MB6340.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: kY3nU8jMVV3QqY8XFMN/ItcYGXSz3/HmQ4sEuapkbYoZfbJjBsIhcZVuMl02eDxDwBd/NH3Y3VQmsZocPQvQZEu2myxKDEfnF5yIG92DgVrDTuEmVdHiBj9LqCpx4yfgTkTUjU9+stwGiso7vmXlTQ2SSvEQnNSf7MWRqp4oKhFzS5HaWCzrIYpeoynuzTku+l8pgrLZClsQOWdj2RJkdkXq5bLhY97PjDVjbvlbAhRW3H7vmYF71lRw4uPZTNEpMB1bkxrFnjal8cjkVW2PktjCAKPSHFaZI2Qmibo9bvIzgJwgyaeSUVBT8VlDktLjtsk6mHrmP8vEIy1uAlMvyF41yXSx0rQOcIx5Wf539A1yvw3ktyTORapoxnVgNLnMjYxawW/GhjiTk6sc3D/P+IesLaqwvBL43OwZUfopCck826jsYnvkANuTapz9rktRQfVmOC3rDl4OlvKUteWe+a3Sn2KBkwAEJ39OFm62Evh/wEUJxnr+VlsB+wJXAlBfQ6sDKjAGJEWMIQAAT5CU+g==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0702MB3603.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(376002)(396003)(39860400002)(346002)(55016002)(316002)(9686003)(5660300002)(110136005)(8936002)(478600001)(2906002)(66476007)(52536014)(4326008)(450100002)(83380400001)(8676002)(7696005)(66946007)(26005)(53546011)(186003)(64756008)(6506007)(33656002)(66556008)(85202003)(54906003)(86362001)(85182001)(66446008)(71200400001)(76116006); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: 1NRkHA5G7HiUvDg9ypJ7GRsznOjFHJdQ0grlRjZkHvNh74GX8wyNwsSiWkUWLat84KpIGVErT9wcDMsLxTMMA7XjLSWlfQ/zbZv9Gj/2P/Hzl5bF1QhTnixMQotbb508hLxPP5OnClYwjfi3C47/B3fKznSm+vWPL2t8jEcRq/QcBIVjCPnut0Kb7dcU8DxXIXT/MnF5t3z3DFJm+kHyzj9BNB+EdfaSoKlax+RHXmNPTahSkNUmn1y3TpOzImU21OGWIiwQkR2wUHFspKnB0bJhVBjCxpLLM4arLDZPHxm68QChEHAM47SZnFMWXO7HTMuI/JKB+8NnQKFWWPsz7f7qsW3v9+24ObvL1fD6LHxpKiR8y11a/ZuMfoGzGyYobRCUt850uEdv6P5nXWTSWevwvmpMpRSRJde3O6vJcFujTc87WP7S/R33G6j3MLr51SxziAIBpElnyaj7nHd83kIr/X7HZeg1nf34Wbu6yvEZ6N7Di9EKQDWLQEAcrYnt3YwTka5u5HVpTOLxjiwW+j0ZY+flb3tKh4XwJn3x56ZO7420xrDjex0v5/Rfg5M/reEecoIA64AA3rgfB88x7jliPYiUMMhHUe7af6bbZPm7g+F6BNlqTXdoZ2a4k/8iaOXRiFGAxoVXql57e5Nm90s3+SNH43k9X7cLXAlNa7bQutyZj1LAHt6GCN2JedE//8/q7SP7mNeTlMps0BGB/BTwnOcGsmhuJ10CHNhTUFJuvcZWXYZCoeUqV49O5HWzd3pCeH9JV5JXIZbaQ200uJCwS8Uk2ze1P6ZlvlMV71L1QIJ3Dh/4VG42PXvS1dJ1CzJC/Bnu7erXHHBNwX9hCzRPtWiDd2DOsho7jCmc6Pw3x2RNEpf3ahwwFxdxHjrY1z7vKnRXMpBsPQCPsqrqomRG+iw5mME+tANYBfmRAD8sq+v1Hlv+6N10adXtxHUy76MraB6xXeFHR7GEbc02mndJd+/m9nwGP6IIJj4q4NefW4iD1cFyvAagQk3oHZ7voCpDnC9eVkOUYQjfRQpK2Wj44Yaj+tOVS6w51Edi8ohtQReAIwpRslX6vPj3DDKv1u623Q7/QugpgolOzXSV4TPIr9R5LUz0nbGsD/lXnRy5M23IgAvTP+f/x4Q7ngx4NJHA9aa/hW83WkwGCQ2Ou77sMGxzbLUrmv7FyJBS3zIgzMawcY7vbvneaVBSd+zl16MgmAQflp/IBUSV/sGmekDCfY40vmIt+K1sFiW+yJ0pDDOpJZLgf4D0GumbHIO1eeQ2ueDHARkFt7sCM7N4ym532ZDaNYAdpYmyqhsISPn44Oebe/jceiNS6Qj094lN
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR0702MB3603.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ef68b0c-d35d-4910-805e-08d8d2a11d0a
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2021 17:34:29.1050 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: b/lrWBq0j1Kkc8nBYV8w5vMmbi2hkKG17ntlXHhoL1xi4dPcvm3pJeV+H+IsF2z7RX6EKNfPxwm01sL+XBtR0SdrwZxg7uRFvjZc+ClE8Og=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR07MB6340
Archived-At: <https://mailarchive.ietf.org/arch/msg/detnet/_grxFV1Nnh6kbwyyKBKgbzPHgZw>
Subject: Re: [Detnet] Iotdir telechat review of draft-ietf-detnet-ip-over-tsn-06
X-BeenThere: detnet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussions on Deterministic Networking BoF and Proposed WG <detnet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/detnet>, <mailto:detnet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/detnet/>
List-Post: <mailto:detnet@ietf.org>
List-Help: <mailto:detnet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/detnet>, <mailto:detnet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Feb 2021 17:34:37 -0000

Hi Niklas,

Many thanks for your review and comments.
Please see proposed changes inline.

Thanks
Bala'zs

-----Original Message-----
From: Niklas Widell via Datatracker <noreply@ietf.org> 
Sent: Monday, February 15, 2021 5:06 PM
To: iot-directorate@ietf.org
Cc: detnet@ietf.org; draft-ietf-detnet-ip-over-tsn.all@ietf.org; last-call@ietf.org
Subject: Iotdir telechat review of draft-ietf-detnet-ip-over-tsn-06

Reviewer: Niklas Widell
Review result: Ready with Nits

I have reviewed  draft-ietf-detnet-ip-over-tsn from IoT point of view, as part of IoT directorate document reviews.

The document specifies the DetNet IP data plane when operating on a TSN sub-network, and builds on RFC8939 and RFC8565 to do so.

The document is well-written and appears to be Ready (with some minor nits).

I did not identify any IoT related issues with the document.

Nits:

-  RFC8939 reference does not render as link in section 1, first paragraph, but works in the second paragraph. In section 3 again no link.
<Bala'zs> Reference seems to work now.

- Section 1, third paragraph: This sentence is strange: "As described in [RFC8939] no DetNet specific headers are added to support DetNet IP flows, only the forwarding sub-layer functions are supported inside the DetNet domain."
<Bala'zs> OK. I will separate sentences. Proposed change.
OLD TEXT
   As described in [RFC8939] no DetNet specific headers are added to 
   support DetNet IP flows, only the forwarding sub-layer functions 
   are supported inside the DetNet domain.
NEW TEXT
   As described in [RFC8939] no DetNet specific headers are added to 
   support DetNet IP flows. Only the forwarding sub-layer functions 
   are supported inside the DetNet IP domain.
END

- section 2.2. Abbreviations DF and PREOF not used in rest of document.
<Bala'zs> OK, I will fix this.

- general, mix of using L2 and Layer-2
<Bala'zs> OK, I will fix this.

- general, there are some long, complex to parse, sentences that could perhaps be split or rephrased into something clearer. E.g. 4.2, third paragraph, "In cases of TSN-unaware IP DetNet nodes the TSN relay nodes within the TSN sub-network must modify the Ethernet encapsulation of the DetNet IP flow (e.g., MAC translation, VLAN-ID setting, Sequence number addition, etc.) to allow proper TSN specific handling inside the sub-network."
<Bala'zs> OK, I will discuss with native speaker co-authors.

- general, IEEE specs are referred to as "IEEE 802.1CB [IEEE8021CB]", which makes the many references to clauses long to read. Can't you just say e.g., "Clause 6.6 of [IEEE8021CB]" instead of ""Clause 6.6 of IEEE8021CB [IEEE8021CB]", except for maybe the first reference?
<Bala'zs> OK, I will fix this.