Re: [Detnet] Benjamin Kaduk's No Objection on draft-ietf-detnet-mpls-over-tsn-06: (with COMMENT)

Balázs Varga A <balazs.a.varga@ericsson.com> Thu, 18 February 2021 10:56 UTC

Return-Path: <balazs.a.varga@ericsson.com>
X-Original-To: detnet@ietfa.amsl.com
Delivered-To: detnet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B0F8D3A103F; Thu, 18 Feb 2021 02:56:00 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.671
X-Spam-Level:
X-Spam-Status: No, score=-2.671 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.57, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TKL3azCmL3yz; Thu, 18 Feb 2021 02:55:45 -0800 (PST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60055.outbound.protection.outlook.com [40.107.6.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D822D3A103C; Thu, 18 Feb 2021 02:55:44 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Prkl1xgODME80WjQC7y4Wta0HiaOV88H6rX/ieB8kIKzDRpm0vcbohJCy6e4jGnwtO9LGDiQIQDBXFS4z7QHSA859JFXAuJhdZXILtSnZadlOVHkvQ7IOsAlcfFnRJ2CZgTTdf1Fhd6TmRde2mqIiAop61eCTBTFnPz5lQhLO/abIcWj846okKGDWLF4UqpaaKDc/GmX6VSzdz93BlPzV70lOJD53lzYvLU1UwAZ4QEUtqpy2th4g1USrpIq2CatYbt2Z4rEk5bLT4zfuc8AWngN/g8nSdnJ/swDKeDb5aBKpT1LshqNbWtunJ9xe4Y/gV/37MtAtIKXMJjbEyTq4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gGS/r1fRCfm+3TfhzjZm62jDeIkTTsRts//37NxcHQc=; b=lAj5J4+Wx0RGQsqZ52cp4GfXw8PfGdl0LWk12p7GtnrGFWLM1Z6FRK7QZRMxEoIh7oDuq7Zjc7LRfAl/nOU9AmDy0fH357MWw5+tpI45wuvpdreeFOY4Agv30kyHI0P/SApEUmu8kUJdliXxGQ3W43RYZ53xXrb8W8RNGpGOEDlPCUlpXNO4qCHwIlsV9o26sf4FzEI+PvidaEeNEeBGZeBTOxpq647Pl4FttWEsKMSA2HM5J0fb0vwTkkc1zsthNAQkdEbNZUhUGWdZviUF07zlzzd2Dl51+ZrnBC6BvLxsp6irWWHRXLJ3ivyF87m+DpZhz2Xwx4aa+6QO7PFrwA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gGS/r1fRCfm+3TfhzjZm62jDeIkTTsRts//37NxcHQc=; b=O7AqIZu7+M7l+cr9n/zUuYKKtRYrIWjjrU/HwjFJyoSvu9Rj4xwMTMok1He6qguBsUPpxzn6n61fKtqg/1T3u2lnO40AvE/VeQabp/whG8dhhH62hNW2nrbzp7HePQntOXwwfvOuAAlfAKM/u6F3j4+wldwbEO370J3f35goW3Y=
Received: from (2603:10a6:208:22::25) by AM4PR07MB3380.eurprd07.prod.outlook.com (2603:10a6:205:a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.9; Thu, 18 Feb 2021 10:55:42 +0000
Received: from AM0PR0702MB3603.eurprd07.prod.outlook.com ([fe80::3851:5264:9c3e:a251]) by AM0PR0702MB3603.eurprd07.prod.outlook.com ([fe80::3851:5264:9c3e:a251%6]) with mapi id 15.20.3868.019; Thu, 18 Feb 2021 10:55:42 +0000
From: =?iso-8859-1?Q?Bal=E1zs_Varga_A?= <balazs.a.varga@ericsson.com>
To: Benjamin Kaduk <kaduk@mit.edu>, The IESG <iesg@ietf.org>
CC: "draft-ietf-detnet-mpls-over-tsn@ietf.org" <draft-ietf-detnet-mpls-over-tsn@ietf.org>, "detnet@ietf.org" <detnet@ietf.org>, "lberger@labn.net" <lberger@labn.net>, "detnet-chairs@ietf.org" <detnet-chairs@ietf.org>
Thread-Topic: [Detnet] Benjamin Kaduk's No Objection on draft-ietf-detnet-mpls-over-tsn-06: (with COMMENT)
Thread-Index: AQHXBdWtDvWWOvyGFEeD939xQo+SYqpdvAkA
Date: Thu, 18 Feb 2021 10:55:42 +0000
Message-ID: <AM0PR0702MB360359F750457FB72EE51854AC859@AM0PR0702MB3603.eurprd07.prod.outlook.com>
References: <161363931724.28226.4690227321627053128@ietfa.amsl.com>
In-Reply-To: <161363931724.28226.4690227321627053128@ietfa.amsl.com>
Accept-Language: hu-HU, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: mit.edu; dkim=none (message not signed) header.d=none;mit.edu; dmarc=none action=none header.from=ericsson.com;
x-originating-ip: [188.143.101.39]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7a23479e-867f-4cf1-943b-08d8d3fbbca0
x-ms-traffictypediagnostic: AM4PR07MB3380:
x-microsoft-antispam-prvs: <AM4PR07MB3380D6EDA2B9EB9CFE5DF9A5AC859@AM4PR07MB3380.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: +wSTE3vlOPfzQvpNADzlB+svvUjiw5aJ8pagM/0/psCPVbMtVkUY2F7B5f+A1yb0cT7epY3eilk2FHRFYtmk/c6WRR87PxJvgbte84PqgWT+i0rN5Wbs3KOg8wVksemx4vcUW2lK4zpyYSRi2X8bYrUAVWUt6Ag00xpymKTnpFyP8bwsBb3FEn39/wWZK0wdoU9TdTAiBlMhrmKKEWfSH0KnRueNmwYU05/m+y3HVHMnEezJNkrf+lLAbZUz1/G9aJnmxG3YXKLopGtM7XkO2FsYsCwfTO0G8cG03FTTNl/HWF7zzsn6VuLWHCnAwoR4xBVIoV8GOyA1SLreMVTNC30Hc4Fp1d3h/t0+QEP+6TY8VqPGWCxCBVu5o6KFlgRJkLVLGcX/L4qfEVVKsvZAvjhkD1a53e8w6FkRXHu9Nyhx2sn99KR/6Hrv9Nx1pW+ZD8V24BYh/dnsDFo05M+0thfkLoFZJphpyZ/N6SDuax4XyRAentq4CUs/UCLdDIrFYPcOUbb4JjkTl245gURmhyazO7T4qcni5udq48BE+d4cxCzTghBpp5ZmMc8GaYZ/Sb5LuLg0yRfAIltq5SaM+JiGB5LTym+h5Per8yD+Qtg=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0702MB3603.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(66476007)(66946007)(86362001)(76116006)(66556008)(33656002)(83380400001)(64756008)(186003)(55016002)(4326008)(52536014)(66446008)(8676002)(7696005)(53546011)(2906002)(71200400001)(9686003)(6506007)(26005)(316002)(110136005)(478600001)(8936002)(54906003)(5660300002)(966005); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?gsLyfN9j9apBMo02EjH5zSBhzgjE3Yp7CNEt8dFiZM9kZhJl9vIIZyI9/J?= =?iso-8859-1?Q?hSAeAE99BZbAuS0tR63g1vyKIyc714R40fqC9ZXY/cUXjLhwiGg2JUPg39?= =?iso-8859-1?Q?MPlQDUljEgf9roooNb0mLNwAIsPizRnHECBjeqTxsHEcfvRYvTljsRo46+?= =?iso-8859-1?Q?XC9YN5+sU7JGn2wuHwd+lOO17QiN5dAApQtddvIKbeYG+4Dlbk1SUQjfWf?= =?iso-8859-1?Q?Rso28E++PoUDyIr/vEPpIvPFUoNPDwhqW8OP8Alf/P+/8uHXaJXJd/sg1g?= =?iso-8859-1?Q?sEuiI6j1Zd3BDISJlZ4jQYSUgFtmdL2zSFQVqPb3wCeLl8Lc23wopOG4Od?= =?iso-8859-1?Q?d8sOGHrH9ZOG2Fq+1tHQyqMQMYtk7vZbekeLJvvLIlrA0PtPGBKMsnlZCd?= =?iso-8859-1?Q?TA2WWWNUdI3qiL8KNIiDXwpldYPtTq56MqGhD4un3q/ca16yXp7wfmCKlL?= =?iso-8859-1?Q?mX1vuTn8+Iw69/PoAb4NJ5kp8qfaWsgc6RNrQ002lRaBEMPFr4F5CtFQqh?= =?iso-8859-1?Q?35Xad38R1QH59VJJKLmDltBQXEryU7wAm+UrzQMIZc/6m+r+f5CPRyQUTw?= =?iso-8859-1?Q?OTvAHMYXY7eG2MQochIk03gNDocljb+N/mhxNBsELYYgihLTtaJF08us9b?= =?iso-8859-1?Q?ue+KF3QmfYJUTMRUidjP0Ql8jo+VSfBfErx0XDT0gOz8Rjt/TrctTdiSoo?= =?iso-8859-1?Q?wth6oV1dppSGGOuXPo33oyyHm9q6keEZXXE5ZbjUrAFlfSEA0fAJ8E4vk5?= =?iso-8859-1?Q?rGJap22oLgmdxVjP7ER/Q2sbxlnWceqzy8mfaMBhnriFXOzCagpLlmcEWV?= =?iso-8859-1?Q?/rgf40rfO8BZFzS2GMiN9zYtnuaBOP209kuwoMdfbHFaEKviqRmySxuV/k?= =?iso-8859-1?Q?4RFjMHhaw9omb1oCsBx1NUYcKHOz+12qdVOMX9c5yy1UW5idH1UwXO0rjS?= =?iso-8859-1?Q?AERbbkVfx2lJ0pt4K623a2be9epQOg0wlt+RRL1jCT10WvgM5ZZ3le8pLf?= =?iso-8859-1?Q?d7gd0+ZYn73KGelRG6jYw1QYi++7c8nkRCck1eFSMsKT8hF4o0bXEVJA5l?= =?iso-8859-1?Q?xKyNDE/Ej7j5reNRdOLVH9dYmtWakaaF71Qkiocb0uvU5+8Y6JEi+8QGYY?= =?iso-8859-1?Q?+rez65+gcJbJhsJxJ32PzeSXjSlSMI5SnQzzwpus+DioWUZzuj+VeedZsv?= =?iso-8859-1?Q?yoczBagjDRk4c7QusJDF25h3CnZpMcXrJnfUfrC7UhoRLKwo7RQ0ZDfxmW?= =?iso-8859-1?Q?TW1xktVHn/W9B+X9b4OEPsP9t0gy+6390WIwKDBcDIN4ELewDl5zmfVpal?= =?iso-8859-1?Q?U8rK4z1iL4lW1kusGEx4KdNiYofVStETRbNBQqOtJXgMEkIZJxQNBZq+pN?= =?iso-8859-1?Q?GWonOxVpRo?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR0702MB3603.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a23479e-867f-4cf1-943b-08d8d3fbbca0
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2021 10:55:42.6538 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Y+ysmXtdlgBTSTBVofY8vz+1nl028n2TuID/Esx7zkeJKBx6bLHv3oktrTlKiz1txTTyKR6RdwNw06kEY92pIA7ROZOZ6ZTszmuQjeXMiK8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR07MB3380
Archived-At: <https://mailarchive.ietf.org/arch/msg/detnet/1r5iAQKBKMJqt1OzuqQKxN6vmjI>
Subject: Re: [Detnet] Benjamin Kaduk's No Objection on draft-ietf-detnet-mpls-over-tsn-06: (with COMMENT)
X-BeenThere: detnet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussions on Deterministic Networking BoF and Proposed WG <detnet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/detnet>, <mailto:detnet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/detnet/>
List-Post: <mailto:detnet@ietf.org>
List-Help: <mailto:detnet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/detnet>, <mailto:detnet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Feb 2021 10:56:01 -0000

Hi Benjamin,

Many thanks for your review. See my answers inline.

Thanks
Bala'zs

-----Original Message-----
From: detnet <detnet-bounces@ietf.org> On Behalf Of Benjamin Kaduk via Datatracker
Sent: Thursday, February 18, 2021 10:09 AM
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-detnet-mpls-over-tsn@ietf.org; detnet@ietf.org; lberger@labn.net; detnet-chairs@ietf.org
Subject: [Detnet] Benjamin Kaduk's No Objection on draft-ietf-detnet-mpls-over-tsn-06: (with COMMENT)

Benjamin Kaduk has entered the following ballot position for
draft-ietf-detnet-mpls-over-tsn-06: No Objection

When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-detnet-mpls-over-tsn/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Roman's comment is a good one.

Section 3

   and process d-CWs, S-Labels and F-labels as needed.  MPLS DetNet
   nodes and transit nodes include DetNet forwarding sub-layer
   functions, support for notably explicit routes, and resources
   allocation to eliminate (or reduce) congestion loss and jitter.

Akin to my remarks on draft-ietf-detnet-tsn-vpn-over-mpls, I'd suggest "notably support for explicit routes, and resource allocation to eliminate (or reduce) congestion loss and jitter".

<Bala'zs> OK, I will fix.

Section 4.2

   A TSN-aware MPLS (DetNet) node implementation must support the
   Sequencing function and the Sequence encode/decode function as
   defined in Clause 7.4 and 7.6 of IEEE 802.1CB [IEEE8021CB] if FRER is
   used inside the TSN sub-network.
   [...]
   A TSN-aware MPLS (DetNet) node implementation must support the Stream
   splitting function and the Individual recovery function as defined in
   Clause 7.7 and 7.5 of IEEE 802.1CB [IEEE8021CB] when the node is a
   replication or elimination point for FRER.

(nit) I suggest phrasing these as "in order for FRIR to be used inside the TSN sub-network" and "in order for that node to be a replication or elimination point for FRER".  The current phrasing implies some surprising causality, as if changing the network's configuration spontaneously imposes a requirement on the node.

<Bala'zs> OK, I will fix.

Section 4.4

   Implementations of this document shall use management and control
   information to map a DetNet flow to a TSN Stream.  N:1 mapping
   (aggregating DetNet flows in a single TSN Stream) shall be supported.

I note that in draft-ietf-detnet-tsn-vpn-over-mpls this was a normative "SHALL be supported" (which was itself the strongest criterion I could find for that document being standards-track).  Is there a simple description for what's different between these documents?

<Bala'zs> The major difference of these documents is the network scenario they focus on. IP-over-TSN and MPLS-over-TSN describes the scenario when DetNet nodes are interconnected by a TSN sub-network. These documents are on informational track and contains no conformance language. Whereas TSN-over-MPLS describes how TSN domains can be interconnected by a DetNet MPLS network and it is on standard track with conformance language.

Section 5

   requirements.  Note that, as the TSN sub-network is just a portion of
   the end2end DetNet path (i.e., single hop from MPLS perspective),

nit: please write out "end-to-end".

<Bala'zs> OK, I will fix.

   In some case it may be challenging to determine some TSN Stream
   related information.  [...]

nit: "In some cases".

<Bala'zs> OK, I will fix.

_______________________________________________
detnet mailing list
detnet@ietf.org
https://www.ietf.org/mailman/listinfo/detnet