[Detnet] Some more Comments on detnet-yang-15 Re: [Last-Call] Yangdoctors last call review of draft-ietf-detnet-yang-14

tom petch <daedulus@btconnect.com> Tue, 28 December 2021 11:08 UTC

Return-Path: <daedulus@btconnect.com>
X-Original-To: detnet@ietfa.amsl.com
Delivered-To: detnet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2EFFF3A1272; Tue, 28 Dec 2021 03:08:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.881
X-Spam-Level:
X-Spam-Status: No, score=-0.881 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, MISSING_HEADERS=1.021, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Pe0EBZAiMkzf; Tue, 28 Dec 2021 03:08:41 -0800 (PST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40111.outbound.protection.outlook.com [40.107.4.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 09C403A1271; Tue, 28 Dec 2021 03:08:40 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DtR1qy1ORXjjorl8hfi9NlTbanyTLp0NSH9hi2KNGQXed7Jg/ucNSQm9Q6FrJH5y3M1DIKeJe6CCBLUXrLFeu1KXR1ZMjoBpQaCqyT8V/s0u+cx+FfRR009bVAbGup9pVRMtn1S5tR2v2pucSEJ1eT4tgKbPdoziM2lNnTdlemkvVQCizFU6M2N8gD53cQRF5+OqyUZ2obeJL34oaAxMGXcmUo0KPktWRVgMZuTvSJsIY01MZbwFG9XvZXuJBmgGthihpHm5+l1pCkkqTnAxL91Qj1wd5tiZDBoxlnREGyc7la4T81FVgghMP78Eqjw8SIgi+trMMEk+Lob5v2XR0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lqQy2L8b6UKXANpZPnCsDyBHdERIA/CrR41+msfOI+g=; b=VjB4uONtA9R5Wl6ew0PbyDejcorYQkKOZiguHT0REslaR2AqyYNNfR8C3ngVEYaQxwiO63KhkwAHQhkWy2O2tfd2P4Ata0NZ21fa6lGnYn3I402MZUdKbwyM/nvzfh/iM4crkBDXgnzaOXPUES8Vi3weIlm8n2EggGwYVQyivAJrAiM/gKX7TlxLx5Do9NwAOAl9dlrnATH+8nnhy0U9gxw4jK26Yj8Ur0vjKS/KQh1x29y1u1vIb1A7dBnM8/W5HIMT163oIQZbLSMkoA0CxiShlmiptjqhoQcdUMsB5L2XqiFHZ32rlUS3rAjQijve/OUz8Ka8xyTmtWrWaXExUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lqQy2L8b6UKXANpZPnCsDyBHdERIA/CrR41+msfOI+g=; b=TTB8RCTqie3PaGwqvmL/8euCJGsnWsAYLjESS8NAlhE4hTRzCOvig7aeajWp7tZsojZUNih8biCp7MBiZLq7lN3NxEUMSoIMwzJHhf0S3YMmokTTCkpNG7hFKbkEVxh6Wi+SkpFBQqbZpnhAK4aKHWHy8HdkgQL6oO7rker/FO4=
Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=btconnect.com;
Received: from VI1PR07MB6704.eurprd07.prod.outlook.com (2603:10a6:800:18b::8) by HE1PR0701MB2457.eurprd07.prod.outlook.com (2603:10a6:3:74::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.13; Tue, 28 Dec 2021 11:08:37 +0000
Received: from VI1PR07MB6704.eurprd07.prod.outlook.com ([fe80::bce7:a118:523c:ba54]) by VI1PR07MB6704.eurprd07.prod.outlook.com ([fe80::bce7:a118:523c:ba54%4]) with mapi id 15.20.4844.013; Tue, 28 Dec 2021 11:08:37 +0000
Cc: detnet@ietf.org, draft-ietf-detnet-yang.all@ietf.org
References: <163648840575.19216.561627083204230489@ietfa.amsl.com> <61C46025.5040800@btconnect.com>
From: tom petch <daedulus@btconnect.com>
Message-ID: <61CAF02F.4090602@btconnect.com>
Date: Tue, 28 Dec 2021 11:08:31 +0000
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
In-Reply-To: <61C46025.5040800@btconnect.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0216.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::23) To VI1PR07MB6704.eurprd07.prod.outlook.com (2603:10a6:800:18b::8)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a36a9ce1-3140-4d89-afef-08d9c9f2654b
X-MS-TrafficTypeDiagnostic: HE1PR0701MB2457:EE_
X-Microsoft-Antispam-PRVS: <HE1PR0701MB24575F1C64C0865039A0D237C6439@HE1PR0701MB2457.eurprd07.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: uh0NYpKIJkUtBhzWvKQTQyztnPNuv4iqtEoR7YtEzEgeny9ZZwuPuYgVMprp+9yA9mCa6DW/o+9wPfpXUSF3aaboWRd7F4WVCaNqOlSNym60F4C5u1G3BA1j2daJV5+/6U4FlK5FhnyUb74s2VoLLR1v8fSISjzfmqcHPvnPPzyEdVL9343VYj7JsClshDbDvhiLutQcDy7NKQjajn5PAw3HQamVBTWexWjUI+HkR9WfVYbQ0lfiXzxVRjyKmt8wOAzBzQUb4rk+A8y3+gL+fO/Xz3YRT3wpRKW5Y+YVNsKm5relI3x1khZgMLWRIlRyTMzEDjC9mteNRKq9PaA2j8QxUubvg3zc2q5IoWB+d4hB4IK8RQoAyNYHH91zFSKX0h/XkfDsVIm3VO1Wu3/s+apFWWUzuC+9KmvbmHzFh0PDzduGOAqC2zts7WTucKMKjCdXtA5Bfa6AHCLLZLJ/mcyqSBIAgI/3T+ZWLgIZcnuTeijanGQo3Vl6V29Bq0n5FMEIR5m3DViKPh2zeewIDPgHHpk18MsP7O6le+lGkDv8pbu0eyp0z+OVW8rsNHp9AjbSvM3SKkxRcWfR89GP6hmLBTYvNDUqaJI3MGMA2ma4yaaRoBwl6fybRnEALXMDcsg87iEK2KaPU3e2FcGn8Ttc0FEBgMGNUFWg4kiOVsy4UvMpUZ3uEtKj0yjdpN4sAgEuvOcUy0c/ReHDvsY+SQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR07MB6704.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(38100700002)(38350700002)(109986005)(82960400001)(66946007)(26005)(186003)(36756003)(33656002)(2906002)(5660300002)(6486002)(316002)(8676002)(8936002)(6512007)(87266011)(508600001)(52116002)(6666004)(2616005)(966005)(53546011)(6506007)(83380400001)(66556008)(450100002)(66476007)(86362001)(4326008)(20210929001); DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUtDN1R2djQ0VjlBYTU1aWcydldLV1c5OHpWNU9xQVYvZWt5NERwNU5ydFUx?= =?utf-8?B?OHpwYlkwMHNobng0T3FneVVTeUlZMU41TnNMZTNCUmNiNXpxdENDNjd2b2lj?= =?utf-8?B?S1lSMnlnYUR6MGg4Y1lIZTFLVlBXMTVRTTZrdWxDZGpWM3JZT0hFMWVYK3h5?= =?utf-8?B?ZVE1UEhJVGVZSHVpQkwyR1ZXVHVGWGZjbTVhc1BqbGNkZTBVUkxFdVNFdnBR?= =?utf-8?B?ZVBEUEJCVHplbTUzVjJaejF6emwwMFIzelJYOVJndWQrNUU1MHExL2hSUmVV?= =?utf-8?B?K1cwKzRXTi9mZ29CaHFiOW5RY0JKamVrVWgyeldVQ29ZM2FKS2pLc05pL2x6?= =?utf-8?B?Tm0xaVBVMDVsYmlGZ2ZqRGlFWnEyTmtsV0VzUERzTjMyTTBKUlVTRStEeWZF?= =?utf-8?B?WUVBVWpEZEVieEtJUURFL0ZBSE1qK0xQNXlrMzBnbmNYMGVDSEwwUm1CU05J?= =?utf-8?B?ZHgvbkJxbkJFU2d0cTZmaTVBek5tbmNrOWVCaGJRSm1rWEpBbUttL3o4S2hP?= =?utf-8?B?QUZqeHJwQk5Hc3B3cjJHbjBHbE5pWWFndDVGRmd3MVEvU3RTNVBKN1p4aHNq?= =?utf-8?B?NjhHUmhJVG5NYnF1U1ZUUGkvMzZrdDhRNzBvOVNsSmJCVXpVdTlaVVFkT2N3?= =?utf-8?B?MWtxOTVPcHZWN2dyZmRaakgxUjk1OFNFM1B2MWZIQ3VxcVZWZy9Hd21qTGJN?= =?utf-8?B?NzV1SGFaZU9MaW82bXFJOTNEeVJUMWJOeUJpSVVkMUl6SXR5N2RRT3hSYU56?= =?utf-8?B?Yk4yUDltaTFlaTREc1d4TVVqOS9xdXJUZWFBcVRMaDVIWFFWWndkZXZ4bE56?= =?utf-8?B?Mmc5RUROY2hTUElxdHFTb1JkcE04b21paDZmV2Zic01lQVFhMDZwOWlWS1d2?= =?utf-8?B?ZC91Z2FXaXkzV04xa3lsVDNnZC9HV3ZFdE5xcThWTUh5UlAzQURVeGFaRG5I?= =?utf-8?B?YVA3VUdHa0xIOHZSNFFuRmpieG56QVJmakN6SDNuOTVYY2xlOGxta2cyQytH?= =?utf-8?B?RnNaYVVFRk5LOGZGNGxiUnF1NktJUFA1T2pPbmdZNWJlM0QrU3RtLytsWkZZ?= =?utf-8?B?SjFVcGplc0hMb0FEeW5lbFRrWk5CTFlVL0JRejZxR3BQc0VLSmhtVHJWOGtP?= =?utf-8?B?U2VBQytpR0wrRWNwdTBER2FMNUFoeGppdm9FdkxYNjVtZnVodExCVFVYYmp6?= =?utf-8?B?b2REMmFkcmZ6MjhjU1pSODNReDU1VlBQbjNZSFpEOE90THhNVFhXRjNRREFy?= =?utf-8?B?Y3V5QlpVYWxJbG02bmZMWmRsamNzNWZqMnNhM3F4UXN5OXRWektDcEJPdTVu?= =?utf-8?B?VUpCaXVTTkxSV2NwUzdzZnV5ZGlBZitGTEJ6SnF0aXVXNm5MU2tYd2dSOVBW?= =?utf-8?B?L2lyRzZ0b0FCc09mZEc1dm01UTdodXN4WW1KejJDOWxkUkNxcjg3azlKSTZE?= =?utf-8?B?cDNmczIyQm9aTVZneHFpN0VPMW91cmRHS2J1SHkvQUpmSXR6VzBacTdWUFJk?= =?utf-8?B?OFhSK1lLc21tcUFQK2l6RnozcFJnVkh3SWxZOXdzS1FkelZpVWxxQ283S3JF?= =?utf-8?B?OExXS2Y5YnhGZnlLMGhlbkFvOU9TZWRmUWdROEdSbEh0RmlEazV0VW05WXNq?= =?utf-8?B?aWNKOGc3RE9JZWo3M2dRejVCUTZjS0pNL1RvN1RRT2EzRGF3WUJlTzVRWnhQ?= =?utf-8?B?YUhXa0hGTXlMc1ZKZWRMZGtYbzBCVnFEbDNPcU9uU1gxYWJUaTk4eTd1aW5t?= =?utf-8?B?ZjlrcFZhbzJHTWc3Zks0MWFiUzB4U2tPS2lIdVF4SnVXOThYc1YzN05wVWR2?= =?utf-8?B?Z1BFZWY1ejVjSWxSVTRWbWhxV2wwczd4cEdxVzNEbWJNY3RHcHVsSURWT3FR?= =?utf-8?B?UGQ5dVdIR011VHBPVXQ5L1lpZUpJalN4THJlN2oxMnVVNFhaRUx3S1Z0U01S?= =?utf-8?B?c1NTUWEyaEk1Zk9WR1YvaXcxbVV0Vm1keUJQSDlLdVpRODhiNlkreW9kN0tQ?= =?utf-8?B?MXFHVnBnYmtONW1PMWVyMHc0TklQN2JUbzVqbGNrNnZESXo0WTc4bkVkTnJ0?= =?utf-8?B?Qlk5T0x1cmczclArRk9NdXVBTnRxTXFsTERxNUdWejBPOWJNZWQrRXA4YkNI?= =?utf-8?B?bzFTM05UbklFTEFFVDU3S2hLRjlveml3Ujg2NWRNTVJQWDhUNm1pR1FCVTBU?= =?utf-8?Q?E0fHUEiFAg3yjGih5lLv6K0=3D?=
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a36a9ce1-3140-4d89-afef-08d9c9f2654b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR07MB6704.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2021 11:08:37.1818 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8sj7zqLhbDiAaHV01pxBsIwP3+OsEdGZU58nj7PWF+2+vhhgzkRG5ITUyBnw/SwUiv768Sdyoh8WURBUa1b96w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0701MB2457
Archived-At: <https://mailarchive.ietf.org/arch/msg/detnet/fylC-2iUGH9csB-wMAoWj6-ZQH4>
Subject: [Detnet] Some more Comments on detnet-yang-15 Re: [Last-Call] Yangdoctors last call review of draft-ietf-detnet-yang-14
X-BeenThere: detnet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussions on Deterministic Networking BoF and Proposed WG <detnet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/detnet>, <mailto:detnet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/detnet/>
List-Post: <mailto:detnet@ietf.org>
List-Help: <mailto:detnet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/detnet>, <mailto:detnet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Dec 2021 11:08:46 -0000

On 23/12/2021 11:40, tom petch wrote:
Also

"IP six tuple"
perhaps 'sextuple' That said, I do not know what the six are and cannot 
find a reference to six in either RFC8939 or RFC8964


"   Outgoing is viewed as going up the stack from"
Looking at fig 1 I would have assumed the opposite, going down the 
stack; perhaps IETF versus IEEE.


" enum copy-from-app-flow {
     description
       "This type means copy the app-flow sequence number to the "
Mmm it looks like an enum to me and not a type


"  enum generate-by-detnet-flow {
      description
         "This type means generate the sequence number by the "
Ditto


"     grouping detnet-flow-spec {
        choice detnet-flow-type {
          case ip-detnet-flow {
          case mpls-detnet-flow { "
elsewhere the case are 'ip' and 'mpls'; is this different?


      "RFC 9016 Section 5.5, IEEE802.1Q";
I would find this clearer with the two references on two separate lines


"       F-label for DetNet service or service-to-forwarding "
Perhaps a reference to "RFC 8964 Section 4.2.3";

Tom Petch


> Borrowing a useful cc: with a related topic
>
> two documents in the YANG module need adding to the I-D References
> RFC8938
> IEEE 802.1Qcx-2020
>
> contact URL
> insecure, obsolete - https://datatracker ...
>
> Editor: Mach Chen
> not in the authors of the I-D
>
> TLP out of date
>
> Reference: this ID when published
> Reference: "RFC XXXX: Deterministic Networking (DetNet) YANG Model
>
>
> Tom Petch
>
>
> On 09/11/2021 20:06, Xufeng Liu via Datatracker wrote:
>> Reviewer: Xufeng Liu
>> Review result: Ready with Nits
>>
>> Thanks to authors for addressing the previous review comments.
>>
>> The updates look good. The followings are a few additional nits:
>>
>> 1) In the model, “container flow-spec” has been changed to “container
>> traffic-spec”, but the description has not been updated, shown as below:
>>
>>           container traffic-spec {
>>             description
>>               "Flow-specification specifies how the Source transmits
>>                packets for the flow.  This is the promise/request of the
>>                Source to the network.  The network uses this flow
>>                specification to allocate resources and adjust queue
>>                parameters in network nodes.";
>>
>> 2) Most names of list and leaf-list have been fixes. The following
>> three were
>> missed: “leaf-list member-apps” should be “leaf-list member-app”
>> “leaf-list
>> member-services” should be “leaf-list member-service” “leaf-list
>> member-fwd-sublayers” should be “leaf-list member-fwd-sublayer”
>>
>> 3) Section 10.  Security Considerations would need to include a list of
>> “sensitive or vulnerable” nodes.  RFC 8349 shows an example.
>>
>> Thanks,
>> - Xufeng