Re: [Detnet] Yangdoctors early review of draft-ietf-detnet-yang-12

Don Fedyk <dfedyk@labn.net> Wed, 30 June 2021 13:40 UTC

Return-Path: <dfedyk@labn.net>
X-Original-To: detnet@ietfa.amsl.com
Delivered-To: detnet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 25C233A1CF8; Wed, 30 Jun 2021 06:40:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.902
X-Spam-Level:
X-Spam-Status: No, score=-1.902 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=labn.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h1s3jpECb-wG; Wed, 30 Jun 2021 06:40:13 -0700 (PDT)
Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2117.outbound.protection.outlook.com [40.107.244.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 570213A1CF5; Wed, 30 Jun 2021 06:40:13 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HF+I9ucnyh8XuF/PYIhm/FHvgbRTrOdeCRnKDJjJE3/5JpE7mVzYwnAIVJt/I46qqcOnAmcqRAOwVFXUBE1ozU52w3oVPl8tov9Bz8FiM0KjoMOrBmM4wglsnbi/YAhg1oen6gaGnCnfnvAhwxWCq+lmf7xy1GsvP87idhIOJrhO+aejF3PBpusVJbVMU6gfa9oq759MLoaXvkUown0fHhw2KU6PfejfEh+GM9rvL/en6kDMagHbLa4AyxWn0J2TYWxHCcoxNI4ewN4Opvv3Z6we3v1+hwrK5hZPz5VmmIaVoHxqmDwa0FAjKjoVE0rA5F/J8LxYqIcAWcTQUj7ucg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jDGRMo1JfjgnVOgJyaQJx+CjSO36KjTAD8K2C+aNzqM=; b=g7mise6KHA1aolb4+GavwiLzbd/YXdvsjwTr9iJY8fLEilangg7pSTZzYfY+xM6tqLE5WxMHCwdzmmXBeEzruOzQv2HzpvHg15X0cAkl58A5uATw2OZLm2MBD233qV5P8RWj2mfOOcJkJ4q+8aRlVm0YGaVM1MNJ7A/LEX6ioiKvhaDpNCJ3TtfCtnePzmaV4YapUgg4dQBdKAHIJLWZ4WsW6IxKeRdaA6hxRtogp1HKw7Ti55oDC/lpTzvNuAbheVfJc5V5ughN2R8GfKcET7j416v17nojTbfqF1Qcz8uoGeLYi0zy4S+waUkaEhDTSro1C2G3QO7eb1dovcfptQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=labn.net; dmarc=pass action=none header.from=labn.net; dkim=pass header.d=labn.net; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labn.onmicrosoft.com; s=selector2-labn-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jDGRMo1JfjgnVOgJyaQJx+CjSO36KjTAD8K2C+aNzqM=; b=hGJWvw/tP3eld0XsqPsPCVm2m98eLKim5oLFbGMpwr6QgubluPZOcMAJ9gxqqjRrF34Gbl2so1Ecsq57NbTxA9bD8Rmo6baiaP20Eyzh9I5U5Ff2le6B1RM2E45oSAy9hUC1+RIyvEbRtj7qljAeNFC7euYG9P1L4WDKaoVaO4s=
Received: from MN2PR14MB4030.namprd14.prod.outlook.com (2603:10b6:208:1dc::14) by MN2PR14MB4077.namprd14.prod.outlook.com (2603:10b6:208:1d6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.19; Wed, 30 Jun 2021 13:40:10 +0000
Received: from MN2PR14MB4030.namprd14.prod.outlook.com ([fe80::905a:7886:33e9:534b]) by MN2PR14MB4030.namprd14.prod.outlook.com ([fe80::905a:7886:33e9:534b%7]) with mapi id 15.20.4287.023; Wed, 30 Jun 2021 13:40:09 +0000
From: Don Fedyk <dfedyk@labn.net>
To: Don Fedyk <dfedyk@labn.net>, Xufeng Liu <xufeng.liu.ietf@gmail.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "detnet@ietf.org" <detnet@ietf.org>
CC: "draft-ietf-detnet-yang.all@ietf.org" <draft-ietf-detnet-yang.all@ietf.org>
Thread-Topic: Yangdoctors early review of draft-ietf-detnet-yang-12
Thread-Index: AQHXa6FR+jTUdZ7hXkirvrAWreK31KsrmiaggADpIpA=
Date: Wed, 30 Jun 2021 13:40:09 +0000
Message-ID: <MN2PR14MB4030E0D5D01CD34D32F0B2ECBB019@MN2PR14MB4030.namprd14.prod.outlook.com>
References: <162483184905.11951.18366537346797539633@ietfa.amsl.com> <MN2PR14MB40304BBE8F9D17405F4031DFBB029@MN2PR14MB4030.namprd14.prod.outlook.com>
In-Reply-To: <MN2PR14MB40304BBE8F9D17405F4031DFBB029@MN2PR14MB4030.namprd14.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: labn.net; dkim=none (message not signed) header.d=none;labn.net; dmarc=none action=none header.from=labn.net;
x-originating-ip: [173.48.105.206]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ce42dc6c-a2b0-4549-4741-08d93bcc9478
x-ms-traffictypediagnostic: MN2PR14MB4077:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <MN2PR14MB407775C83F73817431B00C7ABB019@MN2PR14MB4077.namprd14.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: IjapErWlGdX5sLWIegYf1LAlf+EF3BqgkvU4FIN0yYbWL5giPzvFpho/dwhlDEsTu1Se19n6xtt13yjEnJZlMLLb9HkqbvhTVivJATtLjgTCYYmRnhXR1gZkke0Vy3ayRhHbhuf7XAhDiomfX10/hgMUrMsbadhbehpy8QTMladziTIc39mlOIJgWfjIHnOWVOLv+fHnkl11A23R1welaaFhcxmetmUM6k3HfFf4rZMy3ocHy3nx8VTqCR9vWfCcmOweUbsuielsk/yp424S9Ycur3gnDbXuXGV3aL7gK5r92RVsMyro3sg96ZwWwVfUPEoKxVo7+4QPV1GtGYALe/XKiyn3N3M/gdJh6y5OccE8Q02TcoRa2KLXCQK1wORxldTd+LHy2Kc4aGweAkHI6oG+9U3/pwk8gq9/lyWixlgt+k4LxrOEfI++p5Z5f4k5DFW+yT7wYygTzaUHxRDKM+SbWWaXbRWXqkmei5ImJNYM9dg5I6KhTbVi3UZ8geoakADRuya0n+sPtxhx/G7B0MZgWX0I19buk0RmT7DwTRZly59AWrsgvp0qpTlpH68VWfwNqFKBO9eHkLLNvzfdoIZ/SxBS9lETxjYsNGlXMwwFfqL77lA6GwMcXM30/kSHKdKjz5o27INaN5l61mLckw==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR14MB4030.namprd14.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(366004)(396003)(136003)(39830400003)(376002)(4326008)(2906002)(86362001)(478600001)(26005)(9686003)(6506007)(55016002)(33656002)(7696005)(186003)(83380400001)(38100700002)(66446008)(5660300002)(8676002)(64756008)(66556008)(66476007)(66946007)(76116006)(316002)(110136005)(52536014)(122000001)(8936002)(71200400001); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?b2YzNWZWQ25GUGlnMWNsYVdDazJNRHFnYnJKQ013K1dXREV3UWk5K2M2aEFw?= =?utf-8?B?c2FMOUNKMG8rRWM2ZW03bmFWSk5nOFFjUGM2Uis3alBJbGhmM1JPVmRNcGMv?= =?utf-8?B?UmtIQ0lSNUlVTG05MjRWa0EzR1BZb2o4NnBPVEZFV0N4ODkzMmV0S0Y0dzRL?= =?utf-8?B?TkU5aTJ5anlmOURTNjd2MzdYdkxIeGFVazZlZ2JOeEs3MEtKQnB4ZUxPaEk1?= =?utf-8?B?YVh1eFYydUNIVEhQZXhQUDZqOURuMU1vRlAzbzkzdEhHay9HWGgwTis3b0gr?= =?utf-8?B?YkFQTFNYQVZhMTN1MHhHMVFoWmR4TDRoQWlyL3YwTFZRRjVaN2puWjVweVcw?= =?utf-8?B?WW9pS2JGcHhJdEdjRUxCU0ZSNmZHcE10ZjRYZGoyZUxTOEJjbFRTbkJxWGtT?= =?utf-8?B?amVZQmFvbjFCRWhQbEloaWdjS2lLdWU0QTZpMElRTmRIOCtKcldOazhoOC9I?= =?utf-8?B?MU5QQXR5VmNlZmRhUDFINnlTaDk0a2kvU0ErYjJ5bCsreDVFUnh6NHdMNjNK?= =?utf-8?B?WXEvMXZ2TTlRSnd4ejUvaUh6UVlQTytiQmM4TE1tL2lNRmNPamlBVzVKSXhr?= =?utf-8?B?VVc0VEVOSGJLZGorSjRWdlF3U2xrNmlPN0xiQVNUVXQxTnhMOEIxcjROejd5?= =?utf-8?B?aGxOSU9jR05yejdnMmNJU1VFR0RsOE9wdm1pem04QUY4KzN2ak40UVIwVkY5?= =?utf-8?B?TEswSERJUnBjSVJpT2FqU05OeTI5RUJodmdIUjRnbGxiR1JqZEhMaWg5MUlx?= =?utf-8?B?M0l1bjc1amZrR2dON2FQL3N4alBKL1hSaVNvU3paM3ZVcWp4T1B1QzI5ekR6?= =?utf-8?B?NGQzRkhJdW9uYXo2SjdHenpKNDdScCt0bU5Jc256NnM0ZTN0OGdGaWoySjdw?= =?utf-8?B?ODREbEZPY1Z0OXE4MWxmRmNqQ3BDM3pHUkowaTFZRkpEZVc2cVY1a0N2OXBF?= =?utf-8?B?WWRvcEhTeFdqZG9qY21tNnVXc0Y0UXRYNjcyYm1BZmxSOFlyS2ErdHByenpo?= =?utf-8?B?R21qVlFoUGhGaFd0UVJmMWtaQ2owRndiNXZEVy9HcGI5LzJncWZjYnZqTEh1?= =?utf-8?B?QVEvUGpCbGp5bmJyc3pmbk1Gc0gvMFF4b2sySnFpQVlacTdibE5jUVZBc01O?= =?utf-8?B?aTBFMkJxSW5pWTNXek5kVW51VVhta0RPc2VvV0c1WTI4Y0NqTGVyU0JDaTIv?= =?utf-8?B?V25jeFBmcmZJT0g1R1doTGdDcXVhczZGaldrUHlzYitxNXROWmhQTlpHVFd3?= =?utf-8?B?NEpEUmpUanFSU2IrUXZueW1WaFlvRjJqOUF1aWhTbTRzRGptUG0xT3ExUzJ1?= =?utf-8?B?V3VBYkw5NGVkZE1iSk5pWDd4bnYrMlVEZ3lZMGZTeVBVRGtTYWdjTExzVk1L?= =?utf-8?B?dkNWS3p1SWlxWGF6ZEIrMndOV0hWU1NvSFRCeGo4QXlkYzAzSjBXSjV2bXRj?= =?utf-8?B?UVpISnBvTzBiTXVoWXlFYTUxWVVUZENpb1NDd1ljM3ArUDVwQzA2M3AzR2xj?= =?utf-8?B?ODZmeXl1SjJZRmJwNVZRbUFpVjg5MDZzcGsyM3JsMTUxQk92QmM0VnN4NFY1?= =?utf-8?B?Y1VRSEgwNXNLZi9yeFIvaU9uQmZGSGdScnV1QXRLK3dTdFh0MitOMHVsc2Y0?= =?utf-8?B?bzVFeGtiZnBGaXhjTmFrRHBIUWJtT3J4U3FmYU5PVlFwUDJTT3VBT0lSUTZO?= =?utf-8?B?ZnNYa21hNTMxSE94eEhVNmRYS2ZsdWxjT1J3elVyMHpSVlVZYi9xZmdOTysy?= =?utf-8?Q?hrst/dOX+YNqz8IPBogUtvc/c4Ysj17zetJH6hm?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: labn.net
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR14MB4030.namprd14.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce42dc6c-a2b0-4549-4741-08d93bcc9478
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2021 13:40:09.6926 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eb60ac54-2184-4344-9b60-40c8b2b72561
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EWnvwJFo1FUVxn551wLaLvxd/aJgrSIxh/PFLR7CbngTpP8dgQdSOHYIbezxhzwH0NybwMpCfnb3gzCRvgKLkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR14MB4077
Archived-At: <https://mailarchive.ietf.org/arch/msg/detnet/n7BYSBKUFFps__V-DLBTnUXhUdM>
Subject: Re: [Detnet] Yangdoctors early review of draft-ietf-detnet-yang-12
X-BeenThere: detnet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussions on Deterministic Networking BoF and Proposed WG <detnet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/detnet>, <mailto:detnet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/detnet/>
List-Post: <mailto:detnet@ietf.org>
List-Help: <mailto:detnet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/detnet>, <mailto:detnet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Jun 2021 13:40:16 -0000

DetNet

Currently The DetNet YANG uses Traffic Profile that contains the Traffic requirements and Traffic Specification (we use flow spec rather that the longer term). Xufeng thought the term Traffic Specification aligns more with the terminology in RFC 9016. In developing the YANG we had originally had (at one point anyway) the Traffic requirements and Traffic Specification in the application, service sub-layer etc there was no need for another grouping. At some point as we discussed the fact that many flows might have the same parameters we came up with a shared set of profiles that could be referenced by multiple objects. 


Rereading RFC 9016 the organization is:

App-Flow Characteristics
  Traffic Specification (also flow-spec)
 (other flow aspects) 

App-flow Requirements 
  Flow requirements.


The YANG has this grouping  (where the attributes are optional allowing the same structure to do requirements and/or specification). 

     +--rw traffic-profile* [profile-name]
     |  +--rw profile-name            string
     |  +--rw traffic-requirements
     |  |  +--rw min-bandwidth?                    uint64
     |  |  +--rw max-latency?                      uint32
     |  |  +--rw max-latency-variation?            uint32
     |  |  +--rw max-loss?                         uint32
     |  |  +--rw max-consecutive-loss-tolerance?   uint32
     |  |  +--rw max-misordering?                  uint32
     |  +--rw flow-spec
     |  |  +--rw interval?                uint32
     |  |  +--rw max-pkts-per-interval?   uint32
     |  |  +--rw max-payload-size?        uint32
     |  |  +--rw min-payload-size?        uint32
     |  |  +--rw min-pkts-per-interval?   uint32
     |  +--ro member-apps*            app-flow-ref
     |  +--ro member-services*        service-sub-layer-ref
     |  +--ro member-fwd-sublayers*   forwarding-sub-layer-ref

The question is, is there a better alignment of terms? 

I would argue the profile is about configuration grouping, a YANG construct. We can point this out in the text of the YANG and the document to make the linkage. 

(Also I have commented on this and other points raised by Xufeng - cc'd on the list - but this one I request we confirm consensus. Note the mapping of Flow Spec to YANG is not one to one because the Flow spec is a functional description and the DetNet YANG is a hierarchical in nature some of the App-Flow characteristics are in the application not the profile .) 

Please Comment
Thanks, 
Don

<Xuefeng's comment>       

7) In Sec 6. in the  sub-tree traffic-profile:
   The container flow-spec is not consistent with
   draft-ietf-detnet-flow-information-model-14, which defines the leaves under
   this container as TrafficSpecification in Sec 4.1.
[Don] It is up the to WG if they want to change the name. I will ask the work Group. The flow specification is a functional model. The DetNet model does not map 1:1.