[dhcwg] WGLC comments on draft-ietf-dhc-mac-assign-01

Tomek Mrugalski <tomasz.mrugalski@gmail.com> Sun, 17 November 2019 19:48 UTC

Return-Path: <tomasz.mrugalski@gmail.com>
X-Original-To: dhcwg@ietfa.amsl.com
Delivered-To: dhcwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A1A1912011D for <dhcwg@ietfa.amsl.com>; Sun, 17 Nov 2019 11:48:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wFN33Ei7iOg4 for <dhcwg@ietfa.amsl.com>; Sun, 17 Nov 2019 11:48:23 -0800 (PST)
Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 03FA01200B5 for <dhcwg@ietf.org>; Sun, 17 Nov 2019 11:48:23 -0800 (PST)
Received: by mail-pl1-x631.google.com with SMTP id h13so8431590plr.1 for <dhcwg@ietf.org>; Sun, 17 Nov 2019 11:48:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:references:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ae4kA94FDoCSYOUm0c/lkvr8/Om8uohunX17qdFoz3s=; b=Ay0UI6N+FJcnss350QQA1ZGhtIIh2eNuoaU7WlCUXBLYncgIb6TZOljpMx7HafgkU7 Qiv8mO4zjg4PtadizkSwydOKmhueTjC5feuDNVNQoE7exv6H/sR2D+QeOkCTV1v8KmGP BmAxqY7rP8DlaqOGsvlmnwGl/G7j3bsZmjckSNk/a6GCt0QZMCDq6cTVx5HtnsKHH2ZH HFf57eHfnOyXO0xc0MD1Izh00ZbPoZGrT+W0n9tLPn7D3kpZ8SMhk8TBc8Axev5xN5y2 tcnkJp+3xp2oYDzacfyfsEXLukisfyHPDFbR6ZHRNDccHclrZ6zO+uVcoeZXlNwmwbHb 9UIQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ae4kA94FDoCSYOUm0c/lkvr8/Om8uohunX17qdFoz3s=; b=Mj6P0mVgPx/w1IAT9PeUSgNOoaUm7aHLI6N293M61SL1lRFiGvs+M9TE7kuuTFdP8B wh+WptTYQNxf+gtiTZ1Y7VdDnsAiaUrf9p68NFWpPt94Taz71WtPb+KEr51DQgEY5+Lu CC5uC5O3bYkEkzXtfBv64U8EXOMpJPbXLiqsVxcRG6e6QJKECV8j1h0B92GML/64Qwym uGYUm/BuADuti/sl9l/gh4965EUJFm2AwHKTzWHv0M2vAsDnvs9kKWYbPTK/+2xaSFgM tew4i1degK8CYnFaqFgGcqdZe/Bm6nrdBGNyqSpgdEJB53ahgM/jDcte2DJTCqwZd4Pg 22ZQ==
X-Gm-Message-State: APjAAAXIxd3r94rT27dLbRnqlF+9ysGPOGct+HxmeziwlAXNd5gWdxNh llLS/rJkATJhOxR6Z2w2gS3EIuA6
X-Google-Smtp-Source: APXvYqzXNTrU00blcsMReQSaE7aKK2isFB1CK/keyi50EZIvgmymXqqgMGcLIY/A64D+4xmvC3Y6TA==
X-Received: by 2002:a17:902:4e:: with SMTP id 72mr10649038pla.270.1574020101831; Sun, 17 Nov 2019 11:48:21 -0800 (PST)
Received: from [192.168.1.71] ([118.200.216.106]) by smtp.gmail.com with ESMTPSA id w62sm19715818pfb.15.2019.11.17.11.48.19 for <dhcwg@ietf.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Nov 2019 11:48:20 -0800 (PST)
From: Tomek Mrugalski <tomasz.mrugalski@gmail.com>
To: dhcwg@ietf.org
References: <c9976d83-7243-cf44-a9c6-ff858afb5247@gmail.com>
Openpgp: preference=signencrypt
Autocrypt: addr=tomasz.mrugalski@gmail.com; prefer-encrypt=mutual; keydata= mQINBFnoiMwBEADTmiPRnreg9BKxRAq5IixkTT6sMqpueC9kf3UGP3KAeO032wLkEdLd/ELW bhXv2Z0k2Jeq8N9qSsn0uiwlizPz1trH/lad/xQolv6529jhMdWvpt9iNpmjY/M0bdwG8E3e pSpYLg2p9TSa/N3XOIJYqcMHlWaqTlU+//5w2KXQd585+X68bfWmLJQvA371kUAp75PzwHJt zmL6SI5jZOhONPrisUnvEic1cW/VVLQ0RUc6O9+fmpyzoDKKXO/mKxjXScyE7hGmZI2Yr3X5 bf+wixXRnM6mYSocRbMYtPSotWo9UNRQCM3ns4Q8wf99Hbpy0kdLL3aD1NdgdJbIDcbONBj4 YX0bDiaWMKBuUsbBXe1wEUsmkwYxFSdKKJGiOQpDaOFSbiyn0HXAjj9iOcEOSjls03RHS0RV F59Ra0HTaIQIoqgPimjzZK3D7Yee8UKgzNQ/kvowJvom2H+GI6c4YXhluyDE1k869V/EIRO/ kxyznUaXT1kgD+v8YZESm/s5JG6gPYf2Whxp4zW0mRwJE1nJWUdrR/T5aYJatBhwdiYqhOzt qJm6HRihoAz7DxebsVtv/pH/EdX9K0yMdjw4y9cElrXQkUa5jFiPk5fhYcJFp1lxcMy+IZps FR4JUYUkB2gEKbLRp3o7g3PlA1DmeGOv3ojMAWOw9l1l9UDxHwARAQABtCBUb21layBNcnVn YWxza2kgPHRvbWFzekBpc2Mub3JnPokCVAQTAQgAPhYhBBGZCpIDRNb+ndZDaYPU7qyYlWHJ BQJZ6IjMAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEIPU7qyYlWHJ4d0Q AL46OqfV4zKmAqnHykElhm8hXmWkHHeIhkNIsmX5LdnkigxqAhg/K4nws74Zq9U53T1CBaTa SlxOGnWf+4LW/ZGN6mfp7IS5RcUL7O4O523dY+QRAy/goLBvnzzYL3wXFzmFRNyCoSUHJzwY h2R7PEeGZ8IpEuQA4lNodIKSXK3+iGQAi1kpWfuxD/Nd7bMtpvdmDJ74ZdtuOfgCqQPwvNMN xECTzDEM7K8+1AZtJ9Vk2YR5qNmlHSq/eQoyG3gAQ57Ym/duPTc2qacoJHFO6KGwHpbcnUo8 k5RZYPW5Cr84d4TXg0JmkgIMkDxrc+CgWMJDFIlbC2eS9TmOG3OALjqQ/0iy9athCkCPlq46 PJMKuMHbM5zhwkxJ4nPieLjpGtkewmkTMrQJUWcyuxJNLMdlIvZuioXrXcN9a5/N+UISaWaf tpZAhEK7J8LGTJzVfKP4j0CBRyFklKsuxw4mbZloJYe7JGEybwIArXF1LgXnFUS6S4xV4wyV mfZtd08nugTo407c2snWgNUHjt7g4VvKEXfss4cSg0B2MnBD8BSKcjCp16CDKZCOOKuNJELj outedf2FEGRMsSs26Xiz9uiS4UPjzuv9ZFGSL6fZ0cGaN3isKF4oDXG/YvXIoGwmRdzt+w7N OnU6rB7icW0fyccScFRxqFfImGdXZO20x8lIuQINBFnoiMwBEADBPSEGUwIayl//i6LJWoy+ xJaMSdsiCvcIKcUUSFFRPvbpJ5vYeqoVVRr+EvobpwEYeoy9MGGXamPO6jC8E2Ufq/pxZAof 5x7Kt5GYs/qEgbJyLvQ+Fc9PADhfoJAZQU5Jm/oQ8lIl0CLPmIv62jtYlAPesK/YjPYoFzdQ fS9jOVso/WJrYVkKIG3+0RN8LOonR82Z1NIm1TXDuXVDLjLAr+M0k3UZwviup3eT/lh6xJkT Sg8/+DXIWv0SNtEkvNjxZPQwPB9WuvtqD/5SVR7QJifyqqq9T0EovFg0KHZognMPqIKiYfuZ 7SGFHBQZut58Fdg7C9kKwv3QoSwJc9jkMfMw2vcPJUoj41JwATAPSwF28Xqa4hBFHZZ/nY3p /3oJOXFW9ubYyf+YrsCbN30FxFN2bCerSZRahb2vkSgibxNjjvemM7YyuabUFfd5MXqBwS6M zFjeUEI/CWMAxfWWFykMisGT+w+rTAC9/YusuoeEAFldvOrSgN4anmQ85CHWGEx3lqNNCLEn hSi9W62MOptfHSGoLLJTz5V2AvGgXX1r4AKhr0upea3ALwXHB41/+wQYPD4uBGQvMb9wFavq 3bSglBZ9gvnk+P0EZ2Sfw8BU+AywDJF0PkFwK4on7zLMntgr73B6RNbsIDzWxXEUq1g94PEL B9nE7O+zEi7N1wARAQABiQI8BBgBCAAmFiEEEZkKkgNE1v6d1kNpg9TurJiVYckFAlnoiMwC GwwFCQlmAYAACgkQg9TurJiVYcmkeg/9Ha9VvXZFUEAEdiKlYJd+nSwdq3QVp5C44EHopblM /AO43OxJREaelc+OPeRo7OaAGtNosLNb1+ocYG6azZjaGyB8UcGXUpKakqzGapJZxbe5ugiI g2HgWsQx2cshfMLAz00z+gYjVkvvrffJeATnVSRJ3/VDxNfXt1SRNp20aw2r6FPTkMq+wQYj HKi4rW3NXMnnTVJd3zNepXEdaLl4o5wggOeWePKFN1bTpLZiBTJG7aWTltrRLzYC1z+4WIut GO1ytQbQV5PDtWncbsbcjtiegpJqNu6q8ThvzvHn1UyP/lx25Sjhgp9/5wOwiyDbZbrrNTks NtHkC36ObM9rRw+CfOkf+aTcM+zZB7TUlj924XzuhzqlLQcjuJZ1Tq4foNz2EeRVDvovZfyh JqO81nNEND4MQi8yumTm4G60IdMPSmJCl4TyIPQJ886h+omcE8hSpbEaMAuV0sLyNKcW3Zgs cQqyaeqX3EB3uHhT7cw6NEOkgzyN9tURCMtfnpVGKFA2fSZh1rXhB1yftxOxaBYTw1Wxp2KN DGllsvKOXjz57O9EI4dhqpd+Wl8z+q1jFc5+8g5Fkv8PWvFNF9h2C/knfNm+qj9w5PCcjkXJ EH3imij2e89rWloVAkSQK14sZNuAykzIUSjQv5gpcUPUpNqIJN4G7PqTiVUOrUt+SYc=
Message-ID: <460043b2-bb13-7d40-bd16-26dd3695077d@gmail.com>
Date: Mon, 18 Nov 2019 03:48:17 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <c9976d83-7243-cf44-a9c6-ff858afb5247@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/dhcwg/-gL9Zx1JIlWnnc2WUHbhKF1iCKI>
Subject: [dhcwg] WGLC comments on draft-ietf-dhc-mac-assign-01
X-BeenThere: dhcwg@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <dhcwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dhcwg>, <mailto:dhcwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dhcwg/>
List-Post: <mailto:dhcwg@ietf.org>
List-Help: <mailto:dhcwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dhcwg>, <mailto:dhcwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Nov 2019 19:48:25 -0000

Disclaimer: I used to be involved in the draft-ietf-dhc-mac-assign a
year ago. I asked the other authors to remove my name from it, but they
feel my contributions were significant enough to keep it on.

So it's with my co-chair and co-author hats off, I support this work
moving forward. However, I have some comments that should be addressed.

Nitpicks:
Section 6, bullet numbering is wrong (no item 2)
Section 6, bullet 3: block of address => block of addresses

Section 6 properly explains that the client is supposed to set the valid
lifetime field to 0. I'd like to see a text for the other side: the
server MUST ignore the valid lifetime value.

Nitpick: "a IA_LL" => "an IA_LL". RFC8415 uses an for all IA options.

"The server MAY alter the allocation at this time." This is technically
incorrect. Server doesn't have any allocation yet, it's about to make
one. Better text would be: "The server allocates block of addresses
according to its configured policy. The server MAY assign a different
block than requested in the Request message."

Text in section 10.2: "This value can be only sent by a client that
requests a new block.". There are two issues with this text. First, I
would rephrase this text. The sentence as written now suggests that the
only entity allowed to set this field is a client and only under certain
circumstances. Maybe something like this: "A client is only allowed to
set this value when requesting a new block?". The second problem with
this text is that it's not really true, is it? What about renewals?
Client is expected to send the block it already has for renewal.

"extra-addresses - A four octets long field". Would be useful to clarify
that it's an unsigned field encoded in network byte order.

End of section 10.2: "More than one LLADDR option can appear in an IA_LL
option." This seems to be in contradiction with earlier text that says
"Therefore, if a client wants more addresses at a later stage, it SHOULD
send an IA_LL option with a different IAID to create another "container"
for more addresses.". So what are the circumstances when more than one
LLADDR is present in IA_LL? If there are none, perhaps best would be to
remove this sentence?

Section 13 should probably mentioned that there is no duplicate
detection mechanism such as DAD for IPv6. It's not really a problem,
though. A malicious node can start using any MAC address and doesn't
have to go through the hassles of implementing this protocol.

I hope to review the second draft in the coming days. Will send a
separate mail.

Thanks,
Tomek