Re: [dhcwg] WGLC on draft-ietf-pcp-dhcp-03

"Bernie Volz (volz)" <volz@cisco.com> Thu, 19 July 2012 16:08 UTC

Return-Path: <volz@cisco.com>
X-Original-To: dhcwg@ietfa.amsl.com
Delivered-To: dhcwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0EC8521F87BF; Thu, 19 Jul 2012 09:08:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.999
X-Spam-Level:
X-Spam-Status: No, score=-9.999 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, J_CHICKENPOX_23=0.6, RCVD_IN_DNSWL_HI=-8]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TTNE7FSlADDc; Thu, 19 Jul 2012 09:07:59 -0700 (PDT)
Received: from rcdn-iport-3.cisco.com (rcdn-iport-3.cisco.com [173.37.86.74]) by ietfa.amsl.com (Postfix) with ESMTP id BA66321F87DC; Thu, 19 Jul 2012 09:07:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=volz@cisco.com; l=3900; q=dns/txt; s=iport; t=1342714132; x=1343923732; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=TZn7Iq93d0RNs/YY9qDESm2XaZdyafxJPSmQoUWPsec=; b=HOY8gWDcb9UUWqs6/7984VjHBneE0TCN5DG/ZjXoM+DEx3oMWtR9EViI AVyC+tvq+10TQ4xoMiRmxiubxqvipn58bsau96pY0Mne/xs/fhmlCb+Bw aVHFmsVQAtsYBCU7ISqVP7VvqtHWgcDQR1hTJIvIEctb1twPcGMIwuC1B c=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: Av8EAOovCFCtJXG9/2dsb2JhbABFuUCBB4IgAQEBBAEBAQ8BJzQLDAQCAQgOAwQBAQsUCQcnCxQJCAEBBAENBQgah2sLnkKgBASLTIYwYAOjZ4Fmgl+BXw
X-IronPort-AV: E=Sophos;i="4.77,615,1336348800"; d="scan'208";a="103509158"
Received: from rcdn-core2-2.cisco.com ([173.37.113.189]) by rcdn-iport-3.cisco.com with ESMTP; 19 Jul 2012 16:08:42 +0000
Received: from xhc-aln-x06.cisco.com (xhc-aln-x06.cisco.com [173.36.12.80]) by rcdn-core2-2.cisco.com (8.14.5/8.14.5) with ESMTP id q6JG8gGl025295 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 19 Jul 2012 16:08:42 GMT
Received: from xmb-rcd-x04.cisco.com ([169.254.8.177]) by xhc-aln-x06.cisco.com ([173.36.12.80]) with mapi id 14.02.0298.004; Thu, 19 Jul 2012 11:08:42 -0500
From: "Bernie Volz (volz)" <volz@cisco.com>
To: Dave Thaler <dthaler@microsoft.com>, "pcp@ietf.org" <pcp@ietf.org>
Thread-Topic: WGLC on draft-ietf-pcp-dhcp-03
Thread-Index: Ac1lKbWyQQI76YWORI2Pw5j/xa2lTwABZYWwACWnwdA=
Date: Thu, 19 Jul 2012 16:08:41 +0000
Message-ID: <489D13FBFA9B3E41812EA89F188F018E026F74@xmb-rcd-x04.cisco.com>
References: <9B57C850BB53634CACEC56EF4853FF653B70B231@TK5EX14MBXW604.wingroup.windeploy.ntdev.microsoft.com> <9B57C850BB53634CACEC56EF4853FF653B70B380@TK5EX14MBXW604.wingroup.windeploy.ntdev.microsoft.com>
In-Reply-To: <9B57C850BB53634CACEC56EF4853FF653B70B380@TK5EX14MBXW604.wingroup.windeploy.ntdev.microsoft.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.86.254.72]
x-tm-as-product-ver: SMEX-10.2.0.1135-7.000.1014-19050.003
x-tm-as-result: No--43.652000-8.000000-31
x-tm-as-user-approved-sender: No
x-tm-as-user-blocked-sender: No
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dhcwg@ietf.org" <dhcwg@ietf.org>
Subject: Re: [dhcwg] WGLC on draft-ietf-pcp-dhcp-03
X-BeenThere: dhcwg@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: <dhcwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dhcwg>, <mailto:dhcwg-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dhcwg>
List-Post: <mailto:dhcwg@ietf.org>
List-Help: <mailto:dhcwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dhcwg>, <mailto:dhcwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jul 2012 16:08:00 -0000

The document seems OK (reviewing from the DHC WG perspective).

Minor nits:

1)

2. Terminology
   o  DHCP refers to both DHCPv4 [RFC2131] and DHCPv6 [RFC3315].
   o  DHCP client (or client) denotes a node that initiates requests to
      obtain configuration parameters from one or more DHCP servers
      [RFC3315].
   o  DHCP server (or server) refers to a node that responds to requests
      from DHCP clients [RFC3315].

Why are DHCP client / DHCP server just RFC 3315 and use of "DHCP" here implies RFC 2131 and 3315 from the earlier terminology.

2)

4.1.  Format

       0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
      +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
      |      OPTION_PCP_SERVER        |         Option-length         |
      +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
      |                                                               |
      :                    PCP Server Domain Name                     :
      |                                                               |
      +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

                  Figure 1: PCP Server Name DHCPv6 Option

   The fields of the option shown in Figure 1 are as follows:

   o  Option-code: OPTION_PCP_SERVER (TBA, see Section 9.1)
   o  Option-length: Length of the 'PCP Server Domain Name' field in
      octets.
   o  PCP Server Domain Name: The domain name of the PCP Server to be
      used by the PCP Client.  The domain name is encoded as specified
      in Section 8 of [RFC3315].

   The OPTION_PCP_SERVER option can include multiple PCP Server Domain
   Names; each Name is treated as a separate PCP Server.

Would it not be appropriate to change the "PCP Server Domain Name" to be "PCP Server Domain Name(s)"? And make the description clear that it can be one or more rather than adding this later (where it easily might be missed).

The same applies to the DHCPv4 option (section 5.1).

3)

Be nice if the DHCPv4 domain name encoding clarified that compression was not allowed (though RFC 1035 section 3.1 does not say anything about that topic)? Perhaps use the RFC 3315 Section 8 text:

   A domain name, or list of domain  names, in DHCP MUST NOT be stored in compressed form, as described in
   section 4.1.4 of RFC 1035.


- Bernie

-----Original Message-----
From: dhcwg-bounces@ietf.org [mailto:dhcwg-bounces@ietf.org] On Behalf Of Dave Thaler
Sent: Wednesday, July 18, 2012 5:50 PM
To: pcp@ietf.org
Cc: dhcwg@ietf.org
Subject: Re: [dhcwg] WGLC on draft-ietf-pcp-dhcp-03

Correcting DHC WG email address.

> -----Original Message-----
> From: pcp-bounces@ietf.org [mailto:pcp-bounces@ietf.org] On Behalf Of 
> Dave Thaler
> Sent: Wednesday, July 18, 2012 2:21 PM
> To: pcp@ietf.org
> Cc: dhc@ietf.org
> Subject: [pcp] WGLC on draft-ietf-pcp-dhcp-03
> 
> As discussed at last IETF, the authors believe that all issues raised 
> so far have been addressed.  No new issues have been raised since 
> then, so this message begins a Working Group Last Call on draft-ietf-pcp-dhcp-03.
> 
> This call would normally conclude in two weeks but that is during IETF 
> week, so the last call is extended to conclude at the end of IETF (as 
> of the Friday PCP meeting).
> 
> We also agreed in Vancouver that this last call will be cross-posted 
> to the DHC list, hence cc'ing the DHC WG.
> 
> We need at least 5 reviewers.  Please send comments to the list.
> 
> Thanks,
> -Dave Thaler
> 
> _______________________________________________
> pcp mailing list
> pcp@ietf.org
> https://www.ietf.org/mailman/listinfo/pcp


_______________________________________________
dhcwg mailing list
dhcwg@ietf.org
https://www.ietf.org/mailman/listinfo/dhcwg