Re: [dhcwg] Robert Wilton's No Objection on draft-ietf-dhc-dhcpv6-yang-24: (with COMMENT)

ianfarrer@gmx.com Fri, 28 January 2022 14:54 UTC

Return-Path: <ianfarrer@gmx.com>
X-Original-To: dhcwg@ietfa.amsl.com
Delivered-To: dhcwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AC8063A11AF; Fri, 28 Jan 2022 06:54:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=gmx.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CnW3DotRdg96; Fri, 28 Jan 2022 06:54:20 -0800 (PST)
Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8103D3A11D5; Fri, 28 Jan 2022 06:54:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1643381653; bh=9/diFugNoalQyNaPjmLoAcwjaqfsfPhsNMzYmuEXcUw=; h=X-UI-Sender-Class:Subject:From:In-Reply-To:Date:Cc:References:To; b=QerCUl6KpesYWYJRYqAdC1HeeLXmgaWUEcELYwLwCe/uCsFxPcc0uVJOU4MZ3Oeef yB3e4StIZwZzy7BuDdfqvajMupjTqxD14o68zmhVbJaNJpsqjmZ4qclPQvNJ6M2wB+ 08k3x2gqdkk6vJTtbGPqGGUihx5M4X/cBlpHnzQk=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from smtpclient.apple ([78.35.54.88]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MowGU-1mSugU3RYk-00qRnm; Fri, 28 Jan 2022 15:54:12 +0100
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\))
From: ianfarrer@gmx.com
In-Reply-To: <163966610986.326.18125841975372071697@ietfa.amsl.com>
Date: Fri, 28 Jan 2022 15:54:10 +0100
Cc: The IESG <iesg@ietf.org>, dhc-chairs@ietf.org, draft-ietf-dhc-dhcpv6-yang@ietf.org, dhcwg@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <AFFA4554-89BF-42A2-BD66-C779A606398C@gmx.com>
References: <163966610986.326.18125841975372071697@ietfa.amsl.com>
To: Robert Wilton <rwilton@cisco.com>
X-Mailer: Apple Mail (2.3693.40.0.1.81)
X-Provags-ID: V03:K1:P/bYfWO9ytKy5Z7m/NRk+wazzWyxTwDRGttXYiLtJXsBpur8Uym TL4+3pYRiKdRnwP8zGe5n/YHcf5T3OFmPeg48Iv4lIbRE20s3RFJxM+6aGzu3CRAQfHAFYE M295mPlfswYMzPuz+g5WRs+TtRpWKjfKCjcgfTQcp92O0SVAT/Y7z7ARkmsQgQGQpah+5cx IZ3Lfftzdk1ZVuuU1b9sg==
X-UI-Out-Filterresults: notjunk:1;V03:K0:Chfr26/LiNg=:98TajsNpU3qB33D3GyY0Cl 6gbYksonwWvp2ybRH3jl4STLKSxp2M0OwCLqhSFT9xrAXI56pnXb5qwZO3PBgU7kQPP7QpQ0J LafvII2kzCm/5pYf8yvz8kCJ/Pah+KEm/IWDQZARGlUP2UojcPVOyJzWWAprUJovyv5h6Ydl4 pypdp0szIakPVRPVXypRAktWy/DVoaOkH9xXyveCDaW4YO+L1BhA7Fkmfvc79AKZkrwLU7Kdn /WEVSm58JibPz7v/D+Gz0CGAru7QIDEfIWRpxqQkehqumnVz9pbmD47Ym/4HVqkGkEaqkQdf0 ZW0XH2cUVc37DjqKLXOtBjpxf58WttoXUmafnMezTEVz1RcfNBYH24U/arsEd5zVVFNzSgFgD NVgVr9KLYYpxQQLikO2KUbHYNy7M7BfnoOw9qee7ufpwie1o4lQ1sUAR2M332zwYxsQ+3vfP+ bss/mobUfgFhd3UnwsTD+CIg/jzEqCB23atuMxqUbgbBIY7GcRRw8eDl7RUcKsxpkp0N1Jqe5 hLmu/3jsD8rJt8n5fWpTFYDDmoO2sNLlBT0LJkVrnGvlqUHtcGnrXDwuTJfhEpPcalNWeONaJ 0X+7r7UESRfrtmxGG+b+SwcpkyeIz4qz/Nc+Kgb+Xgl8D7iSXf76y7jkfc2A5yV18j7c2ARIL fUWCXuEVK2dpDfeBJuM396bOuD7/WEIKYGFfpt+g8VU6eHlQmQbsms3OB19qMcfEkgU7g6O2H dNTF+N0x8I/9Vj+K2474BNv9lNZ4aSPLxYEpsdjCJnpTfAoBa2qoYLtKYLkoj0ATmkknZGCgt J93GnsgWuE6HC2VOR4aslyAGv3z99jtS3ihq0Qyrb/HvAEIwrsEXkCFpTnkzidY/WyofK9/xk e693nh2hWVQ9NpO/JZDzRpH6GhSYtDAjhbBlrH0qNGNB5OCoZDyCyYfjRqfLfaaHXr5ix9KaA E0p5k6tD81gitNaxq6VyAkO3fe8T2pGOqOUxxjqkK0G7vTqClmnjGVslEGMu5D7/iSXSuTDr2 QNpuj0FhKC2J8HpdUP81NyfyMCpJfpO+HcWx+wk851IBP2HpCOQXijK/wEWhZBoxRCwd609vl otCNlPzycigbVc=
Archived-At: <https://mailarchive.ietf.org/arch/msg/dhcwg/YjU0OkmEblWZiAL-FD4OMiiWmdk>
Subject: Re: [dhcwg] Robert Wilton's No Objection on draft-ietf-dhc-dhcpv6-yang-24: (with COMMENT)
X-BeenThere: dhcwg@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Dynamic Host Configuration <dhcwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dhcwg>, <mailto:dhcwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dhcwg/>
List-Post: <mailto:dhcwg@ietf.org>
List-Help: <mailto:dhcwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dhcwg>, <mailto:dhcwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Jan 2022 14:54:25 -0000

Hi Rob,

First of all, many thanks for your review and my apologies that it’s taken so long for me to
reply. The suggestion you have made will be in the next update.

Thanks,
Ian

> On 16. Dec 2021, at 15:48, Robert Wilton via Datatracker <noreply@ietf.org> wrote:
> 
> Robert Wilton has entered the following ballot position for
> draft-ietf-dhc-dhcpv6-yang-24: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/blog/handling-iesg-ballot-positions/
> for more information about how to handle DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-dhc-dhcpv6-yang/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> Thanks for publishing another YANG module.
> 
> I found this document well written, and in particular I thought that the
> section on options extensibility and examples in the appendix to be thoughtful
> and helpful.  I ​only have a few minor (non blocking) comments on the structure
> of the YANG module that you may wish to consider:
> 
> 1. You may want to consider putting the counters under a container to group
> them together, and perhaps to make it easier for a targeted telemetry
> subscription.

[if - Added statistics containers for client/server and relay (global and per-interface)]

> 
> 2. The paths on your RPCs and top level Notifications are using relative paths
> - it would probably be clearer to use absolute paths here.

[if - Changed to absolute.]

> 
> 3. I would remove "container" from the Option description strings, to improve
> help string readability.

[if - removed]

> 
> 4. Please make sure that you fix the 3 idnits YANG warnings (e.g., alignment of
> the revision-date to the extracted file date).

[if - Fixed]

> 
> Perhaps in a future draft the IETF will manage to standardize common
> configuration for the class selection function since that will help interop but
> I can appreciate that is tricky to get consensus on if the existing models/CLIs
> are far apart, and you seem to have taken a pragmatic approach here.
> 
> Regards,
> Rob
> 
> 
> 
> _______________________________________________
> dhcwg mailing list
> dhcwg@ietf.org
> https://www.ietf.org/mailman/listinfo/dhcwg