Re: [dhcwg] Review of draft-ietf-dhc-topo-conf-01

"Bernie Volz (volz)" <volz@cisco.com> Sat, 29 March 2014 14:22 UTC

Return-Path: <volz@cisco.com>
X-Original-To: dhcwg@ietfa.amsl.com
Delivered-To: dhcwg@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 891F91A0347 for <dhcwg@ietfa.amsl.com>; Sat, 29 Mar 2014 07:22:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.51
X-Spam-Level:
X-Spam-Status: No, score=-9.51 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lClQ9JzpO2dB for <dhcwg@ietfa.amsl.com>; Sat, 29 Mar 2014 07:22:40 -0700 (PDT)
Received: from alln-iport-8.cisco.com (alln-iport-8.cisco.com [173.37.142.95]) by ietfa.amsl.com (Postfix) with ESMTP id 5693B1A00FA for <dhcwg@ietf.org>; Sat, 29 Mar 2014 07:22:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=22797; q=dns/txt; s=iport; t=1396102958; x=1397312558; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=LcjTGwsMztREbWBxdq4rUmNQF5cZWkMbYwKoT7vWIrs=; b=T1WnAFugr8RXB+P2gUHK5z8zsgfZHhBOLe6xLUQDpEgVQ87fraGc+rRd h4TLNFWL/vRtPpngye5zoWOKuPmQpkjwFIoAFsgiiCygK5eX/9nfNcmS+ el8Cf+X88HPQe1CICh1iNQDTswl3PtsL0M6w633qIKUfWBfdHsiGQUlfl 8=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AncFAE/WNlOtJXG+/2dsb2JhbABOCoJCRDtXuhGIdIETFnSCJQEBAQQtXAIBCBEEAQELFgcHMhQJCAIEEwiHcQ3RLReJUIRTKzcBgySBFASaAZECgzCCKw
X-IronPort-AV: E=Sophos; i="4.97,756,1389744000"; d="scan'208,217"; a="31395904"
Received: from rcdn-core2-3.cisco.com ([173.37.113.190]) by alln-iport-8.cisco.com with ESMTP; 29 Mar 2014 14:22:37 +0000
Received: from xhc-aln-x03.cisco.com (xhc-aln-x03.cisco.com [173.36.12.77]) by rcdn-core2-3.cisco.com (8.14.5/8.14.5) with ESMTP id s2TEMbru029863 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for <dhcwg@ietf.org>; Sat, 29 Mar 2014 14:22:37 GMT
Received: from xmb-rcd-x04.cisco.com ([169.254.8.5]) by xhc-aln-x03.cisco.com ([173.36.12.77]) with mapi id 14.03.0123.003; Sat, 29 Mar 2014 09:22:36 -0500
From: "Bernie Volz (volz)" <volz@cisco.com>
To: "<dhcwg@ietf.org>" <dhcwg@ietf.org>
Thread-Topic: [dhcwg] Review of draft-ietf-dhc-topo-conf-01
Thread-Index: AQHPSOkkV1seZO603UeTuAbaLBoRupr4IGwQ
Date: Sat, 29 Mar 2014 14:22:36 +0000
Message-ID: <489D13FBFA9B3E41812EA89F188F018E1AF7A95B@xmb-rcd-x04.cisco.com>
References: <53319F93.7010902@viagenie.ca> <5D36713D8A4E7348A7E10DF7437A4B923AE2DE1C@nkgeml512-mbx.china.huawei.com> <EAE87BF9-62F5-48C7-81A2-3AA68A42EFD8@gmail.com>
In-Reply-To: <EAE87BF9-62F5-48C7-81A2-3AA68A42EFD8@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.86.253.241]
Content-Type: multipart/alternative; boundary="_000_489D13FBFA9B3E41812EA89F188F018E1AF7A95Bxmbrcdx04ciscoc_"
MIME-Version: 1.0
Archived-At: http://mailarchive.ietf.org/arch/msg/dhcwg/hifTj98pcFOMhWe_Q7a5HAJ2W1M
Subject: Re: [dhcwg] Review of draft-ietf-dhc-topo-conf-01
X-BeenThere: dhcwg@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <dhcwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dhcwg>, <mailto:dhcwg-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dhcwg/>
List-Post: <mailto:dhcwg@ietf.org>
List-Help: <mailto:dhcwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dhcwg>, <mailto:dhcwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Mar 2014 14:22:44 -0000

Below are some comments I had sent to Tomek a while back ... I think some (or all) of these might have already been noted by others.

I also believe it is worth mentioning RFC 3257, Link Selection sub-option for the Relay Agent Information Option for DHCPv4 - as using these avoids the overloading of giaddr to be both the "location" of the client and the relay address.

---



Section 10.  Mutliple subnets on the same link



Multiple is misspelled in section title.



Section 4, figure is labeled as both Figure 2 and Figure 3?



   {"prefixes":

     {"10.0.0.0/24": {"options": {"routers": ["10.0.0.1"]}

              "on-link": ["a"]}}

      "10.0.1.0/24": {"options": {"routers": ["10.0.1.1"}}

              "on-link": ["b"]}

      "10.0.2.0/24": {"options": {"routers": ["10.0.2.1"}}

              "on-link": ["f"]}

      "10.0.3.0/24": {"options": {"routers": ["10.0.3.1"}}

              "on-link": ["g"]}}





   Figure 2



                                 Figure 3



I also think the text which follows this figure should refer to figure 2, not 3.



Actually the problem is that this should be Figure 3, not 2. And the later "Figure 3" (Section 7) should be Figure 4.



(As a side issue, I wonder whether for v4 example the "prefixes" would be better as "subnet"? Also,


- Bernie

From: dhcwg [mailto:dhcwg-bounces@ietf.org] On Behalf Of Qi Sun
Sent: Wednesday, March 26, 2014 7:47 AM
To: <dhcwg@ietf.org>
Subject: Re: [dhcwg] Review of draft-ietf-dhc-topo-conf-01

Dear all,

I volunteered to review the document. The document is well written and easy to review. I have some comments in addition to Simon and Sheng's.

1. Sec 2, Terminology:
   an IP address with a scope of use wider than the local link.

[Qi] Is this the definition for "Link-identifying IP address"?

  provider edge router.  The provider router closest to the customer.

[Qi] Suggest:
Provider Edge router (PE router): ...

  customer premise equipment device.  Typically a router belonging to
  the customer that connects directly to the provider link.

[Qi] Suggest:
Customer Premise Equipment device (CPE device): ...

2. Sec 3, on Page 6
   In either case, the DHCP server is able to obtain an IP address that
  it knows is on-link for the link to which the DHCP client is
  connected: either the DHCPv4 client's routable IPv4 address, or the
  relay agent's IP address on the link to which the client is
   connected.

[Qi] The word "obtain" here is confusing: it seems the DHCP server obtains an IP address for its own configuration. Obviously not.

3. The 1st paragraph on Page 7
   DHCPv6 also has support for more finely grained link identification,
  using Lightweight DHCPv6 Relay Agents [RFC6221<http://tools.ietf.org/html/rfc6221>] (LDRA).  In this
  case, in addition to receiving an IPv6 address that is on-link for
  the link to which the client is connected, the DHCPv6 server also
  receives an Interface Identifier option from the relay agent that can
  be used to more precisely identify the client's location on the
   network.

[Qi] IMHO, the word "receive" here is also confusing, as "obtain" in the previous note.

4. Section 5
   Relay agent is a DHCP software that may be run on any IP node.
  Although it is typically run on a a router, it doesn't have to be
  one.  Relay agent can be run on a host connected to two links.  That
  case is presented in Figure 2.  There is router B that is connected
  to links D and E. At the same time there is also a host that is
  connected to the same links.  The relay agent software is running on
   that host.  That is uncommon, but legal configuration.

s/on a a router/on a router/
BTW, where is the host that connects to the same links with the router B in Figure 2?

Thanks for writing this.

Best Regards,
Qi