Re: [dhcwg] WGLC on draft-ietf-dhc-relay-port-02 - respond by Apr 26

"Bernie Volz (volz)" <volz@cisco.com> Sat, 22 April 2017 18:31 UTC

Return-Path: <volz@cisco.com>
X-Original-To: dhcwg@ietfa.amsl.com
Delivered-To: dhcwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C073C12951E; Sat, 22 Apr 2017 11:31:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -17.303
X-Spam-Level:
X-Spam-Status: No, score=-17.303 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-2.8, RP_MATCHES_RCVD=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e58AR_ZuC7rn; Sat, 22 Apr 2017 11:31:12 -0700 (PDT)
Received: from rcdn-iport-1.cisco.com (rcdn-iport-1.cisco.com [173.37.86.72]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B853B129443; Sat, 22 Apr 2017 11:31:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4465; q=dns/txt; s=iport; t=1492885872; x=1494095472; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=x3awb7gulROQcPOWqPfkYWLQzu2MR6pSgQMKfXHbl0g=; b=ALXbNWofX/bQhQiiifiPp05vXzbfG5EGnCuJgI9YGv+/0kQcJL+nikIf GDJX63949nSsiJsSFvh7NHAXsvypgm056iPw5X4m61KfA652PY6H3+I1G jCJxBGqp55indW+pVpPF44Qz9teXYGKmMbY6gDu8+RItoevmRaVMV63Cn c=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0DPAACNoPtY/5tdJa1cGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBg1RhgQwHjXWRZ5Vlgg8hC4V4AoQMPxgBAgEBAQEBAQFrKIUVAQE?= =?us-ascii?q?BAQMBATg0FwQCAQgOAwMBAQEfCQcnCxQJCAIEARIIihQOrDmLGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQEBAQEBAQEBARgFiDCDGYE8gwWFewWWSYZ4AYcWi2aCCYUziGeBPYhviyk?= =?us-ascii?q?BHziBBmMVGiqGaHWIKYENAQEB?=
X-IronPort-AV: E=Sophos;i="5.37,235,1488844800"; d="scan'208";a="239857395"
Received: from rcdn-core-4.cisco.com ([173.37.93.155]) by rcdn-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Apr 2017 18:31:11 +0000
Received: from XCH-ALN-002.cisco.com (xch-aln-002.cisco.com [173.36.7.12]) by rcdn-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id v3MIVBgW001129 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Sat, 22 Apr 2017 18:31:11 GMT
Received: from xch-aln-003.cisco.com (173.36.7.13) by XCH-ALN-002.cisco.com (173.36.7.12) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Sat, 22 Apr 2017 13:31:11 -0500
Received: from xch-aln-003.cisco.com ([173.36.7.13]) by XCH-ALN-003.cisco.com ([173.36.7.13]) with mapi id 15.00.1210.000; Sat, 22 Apr 2017 13:31:11 -0500
From: "Bernie Volz (volz)" <volz@cisco.com>
To: Tomek Mrugalski <tomasz.mrugalski@gmail.com>, dhcwg <dhcwg@ietf.org>, "draft-ietf-dhc-relay-port@ietf.org" <draft-ietf-dhc-relay-port@ietf.org>
Thread-Topic: [dhcwg] WGLC on draft-ietf-dhc-relay-port-02 - respond by Apr 26
Thread-Index: AQHSrkJ4jGafpAaCIk+/kF5HBW5FkaHRyhDA
Date: Sat, 22 Apr 2017 18:31:10 +0000
Message-ID: <7ba7b94f31bb41dbb404ef1c33026431@XCH-ALN-003.cisco.com>
References: <4cb9bdab-f3a2-a9d0-1056-302b5ecdeae7@gmail.com>
In-Reply-To: <4cb9bdab-f3a2-a9d0-1056-302b5ecdeae7@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.98.1.195]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/dhcwg/mN1nap6yC-GOXUMjHSz7ZD4KyAg>
Subject: Re: [dhcwg] WGLC on draft-ietf-dhc-relay-port-02 - respond by Apr 26
X-BeenThere: dhcwg@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: <dhcwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dhcwg>, <mailto:dhcwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dhcwg/>
List-Post: <mailto:dhcwg@ietf.org>
List-Help: <mailto:dhcwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dhcwg>, <mailto:dhcwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Apr 2017 18:31:15 -0000

Hi:

I reviewed the 04 version.

This document could use some updates. Below are my comments. I think these should be addressed before the document advances, but otherwise I think it should be mostly ready to move forward.

1. General - I would highly recommend this draft adopt and document the "DHCP" terminology as follows:
	DHCP means DHCPv4 and DHCPv6.
	DHCPv4 means the Dynamic Host Configuration  Protocol for IPv4 as documented in RFC2131.
	DHCPv6 means the Dynamic Host Configuration Protocol for IPv6 as documented in RFC3315.
And make use of these correctly.

The document currently uses DHCP to mean DHCPv4 or both DHCPv4 and DHCPv6.

Similarly, I 'd suggest using IPv4 and IPv6 (or IP when being general and apply to both or either).

2. Abstract - As currently written I don't see why this RFC is needed. Relay source ports in 2131/3315 are meaningless and the abstract "allows any valid number" which is already the case. It needs to be document that this provides the means for the relay to receive packets from a server or (upstream) relay on any port, not just the default port.

3. Introduction (1) - The "to remember inbound" may cause some concern with regards to relay's -- since they actually do not remember anything (they are supposed to be stateless).  I wonder if this text can be cleaned up -- servers need to "remember" while processing a packet; (cascading) relay's need to add this port information to the Relay-Forw packets.

4. Section 4.2 - there are several places where "non-DHCP UDP port" is used. I wonder whether we could just say "port other than 547. I know this is in the terminology, but in this case it is DHCPv6 specific text so why make someone look it up? I guess you could use: "non-DHCP UDP Port (not 547)" or similar if you wanted to keep the reference to that term?

This same comment applies to section 5.1 and 5.2 (though in 5.1 port 67 applies). 

In the end, it may be that the definition isn't that useful and perhaps that would even be better to remove it and just use the explicit port numbers? I think this would help readability. But review and consider.

5. Section 7 (IANA). Please look at a document such as https://tools.ietf.org/html/rfc7839#section-8. To avoid confusion, we have put the URL of the tables in the IANA considerations. This practice should be followed here to that it is clear to IANA exactly which set of tables to update.

6. Section 8 (Security Considerations). This should reference the security considerations of RFC 2131 and 3315.

The text that is there is more of an operational consideration rather than what security issues this new work might expose - which may be nothing new over 2131/3315. But pointing out that firewalls need to be adjusted is a good thing.

7. Section 10 (Document Change Log). Usually an RFC Editor note is added to request that they REMOVE this material in the RFC publication process.

- Bernie

-----Original Message-----
From: dhcwg [mailto:dhcwg-bounces@ietf.org] On Behalf Of Tomek Mrugalski
Sent: Wednesday, April 05, 2017 3:26 PM
To: dhcwg <dhcwg@ietf.org>;
Subject: [dhcwg] WGLC on draft-ietf-dhc-relay-port-02 - respond by Apr 26

Hi,
draft-ietf-dhc-relay-port-02 defines a small extension to the DHCPv4 and
DHCPv6 protocols that allows usage of other UDP source ports to be used by relay agents. Authors believe this document is ready. The discussions so far on the mailing list were a bit modest, but the concept is simple, the draft was presented twice (in Buenos Aires and Berlin) and enjoyed a favourable reception in the room. As such, we announce a working group last call on this document. Please review and comment.

This is a very short document. It has around 6 pages of actual text.

Many WG participants may celebrate upcoming Easter and take some days off, therefore this WGLC is a bit longer than typical two weeks.

Title: Generalized UDP Source Port for DHCP Relay
Authors: N. Shen, E. Chen
Filename: draft-ietf-dhc-relay-port-02
Pages: 10 (around 6 of actual technical text)
Date: 2017-02-28
Link: https://tools.ietf.org/html/draft-ietf-dhc-relay-port-02

Responses by April 26th are appreciated.

Thanks,
Bernie and Tomek

_______________________________________________
dhcwg mailing list
dhcwg@ietf.org
https://www.ietf.org/mailman/listinfo/dhcwg