[dhcwg] AD Evaluation: draft-ietf-dhc-dhcpv4-active-leasequery

Brian Haberman <brian@innovationslab.net> Fri, 21 August 2015 17:23 UTC

Return-Path: <brian@innovationslab.net>
X-Original-To: dhcwg@ietfa.amsl.com
Delivered-To: dhcwg@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 06A231ACC8F; Fri, 21 Aug 2015 10:23:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r2YtjWGsgbUZ; Fri, 21 Aug 2015 10:22:59 -0700 (PDT)
Received: from uillean.fuaim.com (uillean.fuaim.com [206.197.161.140]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BE6801ACC91; Fri, 21 Aug 2015 10:22:59 -0700 (PDT)
Received: from clairseach.fuaim.com (clairseach-high.fuaim.com [206.197.161.158]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by uillean.fuaim.com (Postfix) with ESMTP id 97924880E5; Fri, 21 Aug 2015 10:22:59 -0700 (PDT)
Received: from clemson.jhuapl.edu (swifi-nat.jhuapl.edu [128.244.87.133]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by clairseach.fuaim.com (Postfix) with ESMTP id 50E97328081A; Fri, 21 Aug 2015 10:22:59 -0700 (PDT)
To: "draft-ietf-dhc-dhcpv4-active-leasequery@ietf.org" <draft-ietf-dhc-dhcpv4-active-leasequery@ietf.org>, "dhcwg@ietf.org" <dhcwg@ietf.org>
From: Brian Haberman <brian@innovationslab.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <55D75E6E.9030800@innovationslab.net>
Date: Fri, 21 Aug 2015 13:22:54 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.2.0
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="dn15cU4qoPjJT7ch3k0PvDPdFgAb6bKwG"
Archived-At: <http://mailarchive.ietf.org/arch/msg/dhcwg/nCj9xeMuebPmimS_bWbvgfdUINA>
Subject: [dhcwg] AD Evaluation: draft-ietf-dhc-dhcpv4-active-leasequery
X-BeenThere: dhcwg@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <dhcwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dhcwg>, <mailto:dhcwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dhcwg/>
List-Post: <mailto:dhcwg@ietf.org>
List-Help: <mailto:dhcwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dhcwg>, <mailto:dhcwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Aug 2015 17:23:01 -0000

All,
     I have completed my AD evaluation of
draft-ietf-dhc-dhcpv4-active-leasequery as a part of the publication
process.  Please let me know if you have questions/concerns with the
following comments.  Some of these comments address perceived
consistency questions between this draft and the recently approved
DHCPv6 active lease query draft.

1. The inclusion of normative statements (i.e., 2119 keywords) in the
Introduction is worrisome. The statements with 2119 keywords can be
written without them and the same point will be made.

2. There seems to be some inconsistency within the document (and between
this draft and the DHCPv6 version) with the use of "IPv4 addresses",
"IPv4 bindings", and "IPv4 address bindings". Consistent terminology
will help with comprehension.

3. Should Section 4 be talking about the content of packets or the
content of messages?

4. The following paragraph appears in section 6.1 of the DHCPv6 version
of this function.  Should it also appear in section 5.1 of this draft?

   The intent in using the same format is that code which currently
   knows how to deal with a message returned from DHCPv6 Bulk Leasequery
   [RFC5460] will be able to deal with the message held inside of the
   TCP framing.

5. Section 7.2 has some inconsistent capitalization of 2119 keywords.
The normative statements should use consistent capitalization. Those
statements that aren't normative should be re-worded to avoid confusion.

6. The following paragraph appears in section 8.4 of the DHCPv6 version
of this function.  Should it also appear in section 7.4 of this draft?

   The updates sent by the DHCPv6 server during the catch-up phase are
   not in the order that the lease state data was updated.  Therefore,
   the OPTION_LQ_BASE_TIME option from messages during this phase MUST
   NOT be saved and used to compute the subsequent ACTIVELEASEQUERY
   message's OPTION_LQ_START_TIME option.

7. Should this draft have an equivalent discussion on time value
processing as section 8.5 of the DHCPv6 version of the draft?

8. Should section 8.1 have some discussion of mutual authentication or
signaling an error prior to closing the connection?

Regards,
Brian