Re: [Dime] Martin Duke's No Objection on draft-ietf-dime-group-signaling-13: (with COMMENT)

Marco Liebsch <Marco.Liebsch@neclab.eu> Wed, 03 February 2021 16:43 UTC

Return-Path: <Marco.Liebsch@neclab.eu>
X-Original-To: dime@ietfa.amsl.com
Delivered-To: dime@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 59B973A09DE; Wed, 3 Feb 2021 08:43:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0lhmV7dCVSqX; Wed, 3 Feb 2021 08:43:40 -0800 (PST)
Received: from mailer1.neclab.eu (mailer1.neclab.eu [195.37.70.40]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4E4553A09BC; Wed, 3 Feb 2021 08:43:39 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by mailer1.neclab.eu (Postfix) with ESMTP id 2EEF6FFCFD; Wed, 3 Feb 2021 17:43:37 +0100 (CET)
X-Virus-Scanned: Amavisd on Debian GNU/Linux (atlas-a.office.hd)
Received: from mailer1.neclab.eu ([127.0.0.1]) by localhost (atlas-a.office.hd [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HtZtRKPv7o91; Wed, 3 Feb 2021 17:43:37 +0100 (CET)
X-ENC: Last-Hop-TLS-encrypted
X-ENC: Last-Hop-TLS-encrypted
Received: from titania.office.hd (titania.office.hd [192.168.24.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailer1.neclab.eu (Postfix) with ESMTPS id 018AFFF9E1; Wed, 3 Feb 2021 17:43:37 +0100 (CET)
Received: from puck.office.hd (192.168.24.91) by titania.office.hd (192.168.24.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 3 Feb 2021 17:43:36 +0100
Received: from puck.office.hd ([192.168.126.12]) by puck.office.hd ([192.168.126.12]) with mapi id 15.01.2106.006; Wed, 3 Feb 2021 17:43:36 +0100
From: Marco Liebsch <Marco.Liebsch@neclab.eu>
To: Martin Duke <martin.h.duke@gmail.com>, The IESG <iesg@ietf.org>
CC: "draft-ietf-dime-group-signaling@ietf.org" <draft-ietf-dime-group-signaling@ietf.org>, "dime-chairs@ietf.org" <dime-chairs@ietf.org>, "dime@ietf.org" <dime@ietf.org>, "jounikor@gmail.com" <jounikor@gmail.com>
Thread-Topic: Martin Duke's No Objection on draft-ietf-dime-group-signaling-13: (with COMMENT)
Thread-Index: AQHW9dG9rIPG5Dpfvk+dqM8U/p4O16pGq2Rw
Date: Wed, 3 Feb 2021 16:43:36 +0000
Message-ID: <367a7dadc48e438b9d2b32609c9d56e7@neclab.eu>
References: <161187841539.26744.16694158082239595671@ietfa.amsl.com>
In-Reply-To: <161187841539.26744.16694158082239595671@ietfa.amsl.com>
Accept-Language: de-DE, en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-originating-ip: [192.168.24.96]
Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg=SHA1; boundary="----=_NextPart_000_0084_01D6FA54.18D77AA0"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/dime/6ltVG_Mutyanzo5NfGEXRGhZEfQ>
Subject: Re: [Dime] Martin Duke's No Objection on draft-ietf-dime-group-signaling-13: (with COMMENT)
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dime/>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Feb 2021 16:43:42 -0000

Thanks, Martin, for spotting this. You're absolutely right and it's already 
fixed.

marco

-----Original Message-----
From: Martin Duke via Datatracker <noreply@ietf.org>
Sent: Freitag, 29. Januar 2021 01:00
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-dime-group-signaling@ietf.org; dime-chairs@ietf.org; 
dime@ietf.org; jounikor@gmail.com
Subject: Martin Duke's No Objection on draft-ietf-dime-group-signaling-13: 
(with COMMENT)

Martin Duke has entered the following ballot position for
draft-ietf-dime-group-signaling-13: No Objection

When responding, please keep the subject line intact and reply to all email 
addresses included in the To and CC lines. (Feel free to cut this introductory 
paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-dime-group-signaling/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Sec 4.2.3

"The server responds with a  service-specific auth response and includes one 
or multiple Session- Group-Info AVP with the SESSION_GROUP_ALLOCATION_ACTION 
flag set and
   the Session-Group-Id AVP identifying the session group, to which the
   identified session is to be assigned.  With the same response  message, the
   server may send one or multiple Session-Group-Info AVPs with the
   SESSION_GROUP_ALLOCATION_ACTION flag cleared and the Session-Group-Id AVP
   identifying the session groups from which the identified session is to be
   removed."

s/may/MAY, to match similar text in 4.2.2. Much as in that section, it is a 
little subtle that the state can be totally inferred by the first requirement, 
and the second MAY requirement is purely advisory.