Re: [Dime] Éric Vyncke's No Objection on draft-ietf-dime-group-signaling-13: (with COMMENT)

Marco Liebsch <Marco.Liebsch@neclab.eu> Wed, 24 February 2021 15:39 UTC

Return-Path: <Marco.Liebsch@neclab.eu>
X-Original-To: dime@ietfa.amsl.com
Delivered-To: dime@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C1A743A1856; Wed, 24 Feb 2021 07:39:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d9cgdCV8Pz3y; Wed, 24 Feb 2021 07:39:32 -0800 (PST)
Received: from mailer1.neclab.eu (mailer1.neclab.eu [195.37.70.40]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1B9333A1783; Wed, 24 Feb 2021 07:39:10 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by mailer1.neclab.eu (Postfix) with ESMTP id 4B89C103941; Wed, 24 Feb 2021 16:39:09 +0100 (CET)
X-Virus-Scanned: Amavisd on Debian GNU/Linux (atlas-a.office.hd)
Received: from mailer1.neclab.eu ([127.0.0.1]) by localhost (atlas-a.office.hd [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wzF1pfHIJ026; Wed, 24 Feb 2021 16:39:09 +0100 (CET)
X-ENC: Last-Hop-TLS-encrypted
X-ENC: Last-Hop-TLS-encrypted
Received: from titania.office.hd (titania.office.hd [192.168.24.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailer1.neclab.eu (Postfix) with ESMTPS id 1DE57FFE9C; Wed, 24 Feb 2021 16:39:09 +0100 (CET)
Received: from puck.office.hd (192.168.24.91) by titania.office.hd (192.168.24.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 24 Feb 2021 16:39:08 +0100
Received: from puck.office.hd ([192.168.126.12]) by puck.office.hd ([192.168.126.12]) with mapi id 15.01.2106.008; Wed, 24 Feb 2021 16:39:08 +0100
From: Marco Liebsch <Marco.Liebsch@neclab.eu>
To: =?utf-8?B?w4lyaWMgVnluY2tl?= <evyncke@cisco.com>, The IESG <iesg@ietf.org>
CC: "draft-ietf-dime-group-signaling@ietf.org" <draft-ietf-dime-group-signaling@ietf.org>, "dime-chairs@ietf.org" <dime-chairs@ietf.org>, "dime@ietf.org" <dime@ietf.org>, "jounikor@gmail.com" <jounikor@gmail.com>
Thread-Topic: =?utf-8?B?w4lyaWMgVnluY2tlJ3MgTm8gT2JqZWN0aW9uIG9uIGRyYWZ0LWlldGYtZGlt?= =?utf-8?Q?e-group-signaling-13:_(with_COMMENT)?=
Thread-Index: AQHW+VU1KfEkap6/OU6yMeprqG89H6pnjh5g
Date: Wed, 24 Feb 2021 15:39:08 +0000
Message-ID: <5420872c5a904a24b7b447b006bf78c5@neclab.eu>
References: <161226473720.3689.6553919994209922910@ietfa.amsl.com>
In-Reply-To: <161226473720.3689.6553919994209922910@ietfa.amsl.com>
Accept-Language: de-DE, en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-originating-ip: [192.168.24.96]
Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg=SHA1; boundary="----=_NextPart_000_005D_01D70ACB.91ED8420"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/dime/DLnXtjnKzy3dd2AB0hTbyJLyyYQ>
Subject: Re: [Dime] =?utf-8?q?=C3=89ric_Vyncke=27s_No_Objection_on_draft-ietf?= =?utf-8?q?-dime-group-signaling-13=3A_=28with_COMMENT=29?=
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dime/>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Feb 2021 15:39:41 -0000

Thanks a lot for your comments, Éric. Please find our feedback inline [ml] below.


-----Original Message-----
From: Éric Vyncke via Datatracker <noreply@ietf.org> 
Sent: Dienstag, 2. Februar 2021 12:19
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-dime-group-signaling@ietf.org; dime-chairs@ietf.org; dime@ietf.org; jounikor@gmail.com
Subject: Éric Vyncke's No Objection on draft-ietf-dime-group-signaling-13: (with COMMENT)

Éric Vyncke has entered the following ballot position for
draft-ietf-dime-group-signaling-13: No Objection

When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-dime-group-signaling/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Thank you for the work put into this document. Like Barry and other ADs, I found this document difficult to read: long and complex sentences do not help the reader (but I am not a native English speaker). Therefore, I trust the responsible AD for the correctness of all the details in the specification.
E.g., FSM or time line diagrams would have been helpful.

[ml] We address Barry's and other ADs' comments in separate eMails and also discussed between co-authors where and how to improve some description in revision 14.
 

Please find below some non-blocking COMMENT points (but replies would be appreciated), and some nits.

I hope that this helps to improve the document,

[ml] absolutely.

Regards,

-éric

== DISCUSS ==

== COMMENTS ==

Any reason why the authors affiliation is not shown ?

[ml] no particular reason, only a change of affiliation in one case. Missing information will be added to revision 14.


The shepherd write-up is dated back in 2018... Is it still applicable ?

[ml] yes, Jouni's comments have been addressed at that point in time and we built on that version to address Ben's comments. Despite some delay, the draft progresses according to the defined procedure.


-- Section 7.2 --
About the flag bits, I wonder why the values are not 0x01 and 0x02 rather than
0x01 and 0x10. Isn't this a waste of bits ? Should the IANA sub-registry for those flags be mentioned?

[ml] The AVP with type Unsigned32 is treated as bit mask. Two bits for the Session-Group-Control-Vector AVP are defined in the draft, one for the Session-Group-Capability-Vector AVP. 
Combinations of bits in a mask can be set and make sense in some cases, whereas some other combinations don't. For example, clearing the
SESSION_GROUP_STATUS_IND bit while setting the SESSION_GROUP_ALLOCATION_ACTION bit in an intance of a Session-Group-Control-Vector AVP
does not make sense. Since IANA also asked for clarification, we proposed updated text for the IANA considerations section, which will go into revision 14 of the draft.

marco