Re: [Dime] [dime] #44 (draft-docdt-dime-ovli): Incorrect sequence number behavior

Ben Campbell <ben@nostrum.com> Thu, 27 March 2014 14:15 UTC

Return-Path: <ben@nostrum.com>
X-Original-To: dime@ietfa.amsl.com
Delivered-To: dime@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F40A31A0720 for <dime@ietfa.amsl.com>; Thu, 27 Mar 2014 07:15:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.91
X-Spam-Level:
X-Spam-Status: No, score=-1.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fl-G-UO9QrXv for <dime@ietfa.amsl.com>; Thu, 27 Mar 2014 07:15:40 -0700 (PDT)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) by ietfa.amsl.com (Postfix) with ESMTP id A3E261A071A for <dime@ietf.org>; Thu, 27 Mar 2014 07:15:40 -0700 (PDT)
Received: from [10.0.1.29] (cpe-173-172-146-58.tx.res.rr.com [173.172.146.58]) (authenticated bits=0) by nostrum.com (8.14.8/8.14.7) with ESMTP id s2REFaCJ094243 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Thu, 27 Mar 2014 09:15:38 -0500 (CDT) (envelope-from ben@nostrum.com)
X-Authentication-Warning: raven.nostrum.com: Host cpe-173-172-146-58.tx.res.rr.com [173.172.146.58] claimed to be [10.0.1.29]
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\))
From: Ben Campbell <ben@nostrum.com>
In-Reply-To: <5332F680.9030102@usdonovans.com>
Date: Thu, 27 Mar 2014 09:15:36 -0500
X-Mao-Original-Outgoing-Id: 417622536.350549-bab3eda9534291dea97f85e9be5cd517
Content-Transfer-Encoding: quoted-printable
Message-Id: <C010A857-7447-4739-ADE7-F3942A2FB3EC@nostrum.com>
References: <057.7c5fb5d661b97d2b4cb140cc4965cf36@trac.tools.ietf.org> <072.6892b07263eb158352dabe97ef8b9ed4@trac.tools.ietf.org> <5332F680.9030102@usdonovans.com>
To: Steve Donovan <srdonovan@usdonovans.com>
X-Mailer: Apple Mail (2.1874)
Archived-At: http://mailarchive.ietf.org/arch/msg/dime/JXR9GcYTQDlCib5DdGwQ-bPUzJw
Cc: dime@ietf.org, draft-docdt-dime-ovli@tools.ietf.org
Subject: Re: [Dime] [dime] #44 (draft-docdt-dime-ovli): Incorrect sequence number behavior
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dime/>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Mar 2014 14:15:42 -0000

WFM

On Mar 26, 2014, at 10:47 AM, Steve Donovan <srdonovan@usdonovans.com> wrote:

> All,
> 
> When looking to make the change documented below, I realized that this wording had already been changed as a result of a previous agreed to change.  I haven't searched down which one, but the new wording in the current -02 snapshot is as following.  I believe that this is consistent with the proposed wording below and, as such, have not further updated the paragraph.
> 
> If the value of the OC-Sequence-Number AVP contained in the received
>    OC-OLR AVP is equal to or less than the value stored in an existing
>    overload condition state, the received OC-OLR AVP SHOULD be silently
>    discarded.  If the value of the OC-Sequence-Number AVP contained in
>    the received OC-OLR AVP is greater than the value stored in an
>    existing overload condition state or there is no previously recorded
>    sequence number, the reacting node MUST update the overload condition
>    state associated with the realm or the specific node is the realm.
> 
> Regards,
> 
> Steve
> On 3/24/14 3:17 PM, dime issue tracker wrote:
>> #44: Incorrect sequence number behavior
>> 
>> Changes (by 
>> srdonovan@usdonovans.com
>> ):
>> 
>>  * status:  new => closed
>>  * resolution:   => fixed
>> 
>> 
>> Comment:
>> 
>>  Change the last sentence of section 4.3, paragraph 3 to “The reacting node
>>  SHOULD discard an OC-OLR AVP with a sequence number that is less than or
>>  equal to the previously received sequence number.”
>> 
>> 
>