Re: [Dime] AD Evaluation of draft-ietf-dime-rfc4006bis-06

Misha Zaytsev <misha.zaytsev.rus@gmail.com> Wed, 28 February 2018 10:26 UTC

Return-Path: <misha.zaytsev.rus@gmail.com>
X-Original-To: dime@ietfa.amsl.com
Delivered-To: dime@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 01EF612EAF8; Wed, 28 Feb 2018 02:26:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.718
X-Spam-Level:
X-Spam-Status: No, score=-1.718 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_FONT_FACE_BAD=0.981, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id in-eAyd1yFaq; Wed, 28 Feb 2018 02:26:29 -0800 (PST)
Received: from mail-lf0-x22f.google.com (mail-lf0-x22f.google.com [IPv6:2a00:1450:4010:c07::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AF738127909; Wed, 28 Feb 2018 02:26:28 -0800 (PST)
Received: by mail-lf0-x22f.google.com with SMTP id g72so2733396lfg.3; Wed, 28 Feb 2018 02:26:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=aeEDzX1kEbu7oV7klUsfXO2yEENV0Sj/Z4KVswxLN0E=; b=RIMMpm130w8iu4zFS7i0IdZ6s+RiAakk/ezZOeo9MdiOWTNw1RFrR1zuNgRuMhWUQA UxWJjq6+LkmHfBC+kZIiMBvvQXf5dgqd0BnrDvyCPauG70uabGV/xxXxNpl6/22ODNe7 beJoSP2OCh/FzNjiPK7B3u7/5jXYVZoYtoGR4+tC760Eotkb+SjcbXxBJfNdzgyexHZT DPmwi3Fdk5O6i0GPR5gtnGvhecx7Xn3y8030+oTTc5uEZ4p9pqlgEDYLO4npHFoT2Gei oaEkzP+ngwUsqmTOtnDmYeWAE1fAprrb4rOGxWBXs9WhERv8ViQlVfAB9V4jdvcBniHz BLuQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=aeEDzX1kEbu7oV7klUsfXO2yEENV0Sj/Z4KVswxLN0E=; b=DE6rAKKwvLY0f8JtKX4Ht4/TcRzkMyfETxSjACWVAo4ny6hwQaZ4hRa+EXc1q2Dmi5 L6cYy+UsXKcffoUQ1oHBIz7+AgpUp5Iv+q2xEXU776E8jhWQtjivIWc9rg62o8ePqiIp nRs0YnlUqCN9D1H3OURr5JnpTPI67+sUoyy8onUHX60Lbzc4GahsCeJVgn76ek6nJ8Tr uVzro8BZigfPSA0oS0ypS557LEfCdXYjFPLXt8L2d8zvXl6Fce9TjpgmuiM4I4gQv0uv MzW34wAN7PKcfDjZ4C6nwnncycmKkta3BtcXgDWHvMubfy/BmsnHrGNrlmFInkBvuC8L VsHQ==
X-Gm-Message-State: APf1xPCNFZgvnYX/Z7NRdpYy4meOUuU4aoAfrbvXShjezYy/IOCsHvyh 0PdvCbJn79xPVTbyRQczsGU7kmk4EC0o4e/FjY0=
X-Google-Smtp-Source: AG47ELup+T5NG/2ZxTjEO3hrgCt1AHYhzTdQn8JMdaOEpmjm4WBn3jlV/PsW+wkp1aKamBdljv7fsaCta5sMAi2IfIw=
X-Received: by 10.46.41.157 with SMTP id p29mr12051211ljp.137.1519813586923; Wed, 28 Feb 2018 02:26:26 -0800 (PST)
MIME-Version: 1.0
Received: by 10.25.154.13 with HTTP; Wed, 28 Feb 2018 02:26:26 -0800 (PST)
In-Reply-To: <1911118245.6898746.1519740058412@mail.yahoo.com>
References: <3C03A895-53C5-44D9-905F-9DD5248D3675@nostrum.com> <608352900.888044.1518623812177@mail.yahoo.com> <868034109.936629.1518628004592@mail.yahoo.com> <AB34D1EC-2C25-4EB8-9EE8-604CD5201893@nostrum.com> <2108881588.5977405.1519629280512@mail.yahoo.com> <CABPQr25ZxfEx36FC1HXq3pJ5-UTP83tyW+QMm5Fj2NoJFuPT8A@mail.gmail.com> <1911118245.6898746.1519740058412@mail.yahoo.com>
From: Misha Zaytsev <misha.zaytsev.rus@gmail.com>
Date: Wed, 28 Feb 2018 13:26:26 +0300
Message-ID: <CABPQr24+soSpTY-zv3+HwOW1AA_8Qo5YEWxmToboa8vhdpQ=Ng@mail.gmail.com>
To: Yuval Lifshitz <yuvalif@yahoo.com>, dime@ietf.org, ops-ads@ietf.org, draft-ietf-dime-rfc4006bis.all@ietf.org
Content-Type: multipart/alternative; boundary="001a114afba6f935930566432c24"
Archived-At: <https://mailarchive.ietf.org/arch/msg/dime/UkopYPFyK4NM5eIzGHbhU7YiqYc>
Subject: Re: [Dime] AD Evaluation of draft-ietf-dime-rfc4006bis-06
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dime/>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Feb 2018 10:26:33 -0000

Hi Yuval,

Thanks for your answers!

(3) Why Destination-Realm AVP (mandatory for CCR) cannot be used by DRL for
making routing decisions?
In the referred section 2.8.1. RFC6733, I think this is NAS that may try to
parse NAS id to extract a realm value.
In my understanding, when routing DRL should deal only with so called
routing AVPs, section 6.7 in RFC6733.

(4) I think you can list both 2 options to cover a privacy aspect.

/Misha



2018-02-27 17:00 GMT+03:00 Yuval Lifshitz <yuvalif@yahoo.com>:

> Hi Misha,
> Thank you very much for the comments!
>
> (1) will fix
>
> (2) "credit-control" is the common form in RFC4006 - will fix in the doc.
> Will use "privacy-sensitive", though I could not find other references to
> this term (not used in RFC6973)
>
> (3) Will add the following text: "
> For example, a relay agent may need to look into the Subscription-Id-NAI
> AVP, in order to extract the realm of the user, and use it to lookup the
> destination to which the request should be routed (see: section 2.8.1 in
> [RFC6733])
> "
>
> (4) will fix the typo.
> Regarding AVP level encryption, this is more complicated. This idea
> existed in RFC3588 (the old diameter base RFC), but removed from
> RFC6733.Actually, section 13.3 (in RFC6733) deals with security-sensitive
> AVPs, and recommend end2end encryption (At message level) as well as
> avoiding agents, or making sure that the agents are trusted and don't
> create a security issue. Given the privacy guidelines in RFC6973, this is
> not sufficient, as security and privacy are two different things.
> There was an effort to reintroduce that here:
> https://tools.ietf.org/html/draft-korhonen-dime-e2e-security-03 but seems
> like this did not materialized into a formal specification.
>
> So, I see 2 options here:
> * Use the security guidelines for privacy. This would mean that privacy is
> going to be compromised unless the agent is managed by the same entity as
> the credit-control server
> * Recommend AVP level encryption and mention that the actual mechanism is
> outside the scope of the diameter RFC
>
> Unrelated question to the group - do you think it is worthwhile to revive
> the end2end security work? Do you know why was it abandoned?
>
> Yuval
>
> On Tuesday, February 27, 2018, 12:36:45 PM GMT+2, Misha Zaytsev <
> misha.zaytsev.rus@gmail.com> wrote:
>
>
> Hi Yuval,
>
> Just firstly some editorial comments + questions:
>
> 1. As the Diameter protocol, and especially credit control application,
>    deals with subscribers and their actions, extra care should be taken
>    regarding the privacy of the subscribers.  In terms of [RFC6973],
>    both the credit-control client and credit-control server are
>    intermediary entities, wherein the subscribers' privacy may be
>    compromised even if no security issues *exist*, and only authorized
>    entities have access to the privacy-sensitive information.
>
> 2. Let's use one form of writing: either "credit-control" or "credit control". The same is related to "privacy-sensitive" and "privacy sensitive"
>
> 3. What are privacy-sensitive AVPs used for making routing decisions meant here? Please list some of them.
>
> In some cases, the Diameter agent requires access into privacy-
>    sensitive AVPs, in order to take correct routing decisions, or even
>    modify the content of these AVPs.
>
> 4. What do you mean under "encrypt AVPs"? Encryption is not part of
> Diameter functions... Could you elaborate your idea?
>
> To prevent *from (typo?)* privacy sensitive information from leaking
>    into them, it is RECOMMENDED to encrypt AVPs holding such
>    information, as listed in Section 15.1
>
> Thanks in advance!
>
> /Misha
>
>
> 2018-02-26 10:14 GMT+03:00 Yuval Lifshitz <yuvalif@yahoo.com>:
>
> Hi All,
> Would appreciate if you can review/comment on the the following new
> section:
>
> 15.  Privacy Considerations
>
>    As the Diameter protocol, and especially credit control application,
>    deals with subscribers and their actions, extra care should be taken
>    regarding the privacy of the subscribers.  In terms of [RFC6973],
>    both the credit-control client and credit-control server are
>    intermediary entities, wherein the subscribers' privacy may be
>    compromised even if no security issues exists, and only authorized
>    entities have access to the privacy-sensitive information.
>
> 15.1.  Privacy Sensitive AVPs
>
>    The following AVPs contain privacy-sensitive information at different
>    levels:
>
>    1.   CC-Correlation-Id AVP: may contain privacy-sensitive information
>         as the service-provider may encode personal information that
>         helps it correlate different subscriptions and access
>         technologies.
>
>    2.   Check-Balance-Result AVP: contains information on the balance
>         status of the subscriber.
>
>    3.   Currency-Code AVP: contains information on the subscriber's
>         locale.
>
>    4.   Cost-Unit AVP: contains privacy-sensitive information, as a
>         human readable format of the Cost-Information AVP.
>
>    5.   Service-Identifier AVP: may contain privacy-sensitive
>         information about the subscriber's internet activity.
>
>    6.   Rating-Group AVP: may contain privacy-sensitive information
>         about the subscriber's internet activity.
>
>    7.   Restriction-Filter-Rule AVP: the information inside IPFilterRule
>         may be used to infer services used by the subscriber.
>
>    8.   Redirect-Server-Address AVP: the service-provider may embed
>         personal information on the subscriber in the URL/I (e.g. to
>         create a personalized message).  Similar AVPs are: Redirect-
>         Address-URL, Redirect-Address-SIP-URI.
>
>    9.   Service-Context-Id AVP: depending with how the service-provider
>         use it, it may contain privacy-sensitive information about the
>         service (e.g. access technology).
>
>    10.  Service-Parameter-Info AVP: depending with how the service-
>         provider use it, it may contain privacy-sensitive information
>         about the subscriber (e.g. location).
>
>    11.  Subscription-Id-Data AVP: contains the identity of the
>         subscriber.  Similar AVPs are: Subscription-Id-E164,
>         Subscription-Id-IMSI, Subscription-Id-SIP-URI, Subscription-Id-
>         NAI, Subscription-Id-Private.
>
>    12.  User-Equipment-Info-Value AVP: contains the identity of the
>         device of the subscriber.  Similar AVPs are: User-Equipment-
>         Info-IMEISV, User-Equipment-Info-MAC, User-Equipment-Info-EUI64,
>         User-Equipment-Info- ModifiedEUI64, User-Equipment-Info-IMEI.
>
>    13.  QoS-Final-Unit-Indication AVP: grouped AVP which may contains
>         privacy-sensitive information in its sub-AVPs (e.g IPFilterRule,
>         redirect address).
>
>    Note that some AVPs which are used in this document are defined in
>    [RFC6733] and may contain privacy-sensitive information.  These AVPs
>    are not listed above.
>
> 15.2.  Data Minimization
>
>    Due to the nature of the credit control application, some personal
>    data and identity information must be stored in both credit-control
>    client and credit control server.  This, however, could be minimized
>    by following these guidelines:
>
>    1.  Data stored in the credit-control client does not need to be
>        persisted across sessions.  All data could be deleted once the
>        session end, and reconstructed once a new session is initialized.
>        Note that, while the credit-control server is usually owned by
>        the service provider with which the subscriber already has some
>        direct legal or business relationship (where privacy level could
>        be agreed upon), this is not always true for the credit-control
>        client, that may be owned by a third-party.
>
>    2.  Some information about the subscriber has to be stored in
>        persistent storage in the credit-control server (e.g. identity,
>        balance), however, per transaction information does not have to
>        be stored in persistent storage, and per session information may
>        be deleted from persistent storage once the session ends.
>
>    3.  In some cases, per transaction information has to be stored on
>        the credit-control server, client, or both, for regulatory,
>        auditability or debugging reasons.  However, this could be
>        minimized by following these guidelines:
>
>        A.  Data retention SHOULD NOT exceed the required durations
>
>        B.  Transaction information SHOULD be aggregated as much as
>            possible.  E.g.  prefer information per sessions vs.
>            information per rating-group; prefer hourly byte summary vs.
>            per transaction byte counts.
>
>        C.  If not strictly needed, the more sensitive information (E.g.
>            location, equipment type) SHOULD be filtered out from such
>            logs.  Such information is often used to make rating
>            decisions, and in this case, the rating decision should be
>            logged instead of the data used to make them
>
>        D.  The credit-control server SHOULD be preferred over the
>            credit-control client as the place where per transaction
>            information is stored, if needed.  This is due to the reasons
>            explained in 1.
>
> 15.3.  Diameter Agents
>
>    Diameter agents, as described in [RFC6733], may be owned by third-
>    parties.  To prevent from privacy sensitive information from leaking
>    into them, it is RECOMMENDED to encrypt AVPs holding such
>    information, as listed in Section 15.1.
>
>    In some cases, the Diameter agent requires access into privacy-
>    sensitive AVPs, in order to take correct routing decisions, or even
>    modify the content of these AVPs.  In such a case it is RECOMMENDED
>    to anonymize the identity of the subscriber, and encrypt any other
>    AVP not used by the agent and can be used to identify the subscriber.
>
>
>
>
>
> On Wednesday, February 14, 2018, 7:12:49 PM GMT+2, Ben Campbell <
> ben@nostrum.com> wrote:
>
>
> Even if we add privacy considerations to the base protocol, I think
> 4006bis would still need privacy considerations that discuss the specific
> AVPs it defines. So I would go ahead and add considerations to 4006bis and
> avoid the delay. The WG can discuss whether it would like to add more
> general considerations to the base protocol (either in a bis draft or an
> update).
>
> Thanks!
>
> Ben.
>
> > On Feb 14, 2018, at 11:06 AM, Yuval Lifshitz <yuvalif@yahoo.com> wrote:
> >
> > Regarding "privacy considerations". Note that the base protocol RFC does
> not have that.
> > Ideally, this is added to base Diameter first, as many of the sensitive
> AVPs come from there.
> > Should we try to tackle that first (though this would delay the
> RFC4006bis process)?
> > Should we cover only 4006 AVPs and issues?
> >
> > Best Regards,
> >
> > Yuval
> >
> >
> > On Wednesday, February 14, 2018, 5:56:52 PM GMT+2, Yuval Lifshitz <
> yuvalif@yahoo.com> wrote:
> >
> >
> > Ben,
> > First, thanks for the comments!
> >
> > Regarding the major comment, agree this should be added, it was already
> agreed in the meeting we had in IETF96, but somehow slipped :-(
> >
> > Sections 12: all the AVPs mentioned in this section exists in RFC4006,
> and has values that are already registered. As part of RFC4006bis we did
> not add any AVP that requires values enumeration (this was actually one of
> the issue we tried to tackle). What would you like to see different in this
> section?
> > What is the process for updating IANA with the references to the new
> doc? Can this happen before RFC4006bis is officially accepted?
> >
> > Appendix B: the new AVPs do not impact the flows, therefore not added to
> the sample flows
> >
> > 8.34 agree, this is pretty bad. How about:
> > If the Final-Unit-Action AVP is set to RESTRICT_ACCESS or REDIRECT
> >    and the classification of the restricted traffic cannot be expressed
> >    using IPFilterRule, or different actions (e.g., QoS) than just
> >    allowing traffic needs to be enforced, then the QoS-Final-Unit-
> >    Indication AVP SHOULD be used instead of the Final-Unit-Indication
> >    AVP.
> >
> >
> > 14. agree we should simplify as you suggested
> >
> > Best Regards,
> >
> > Yuval
> > On Tuesday, February 13, 2018, 1:33:22 AM GMT+2, Ben Campbell <
> ben@nostrum.com> wrote:
> >
> >
> > Hi,
> >
> > This is my AD Evaluation of draft-ietf-dime-rfc4006bis-06. Thanks for
> the work on this; it’s overall a good update. However, I have one major
> comment and a few minor or editorial comments. I’d like to discuss the
> major comment prior IETF last call. The rest can be handled along with any
> last call feedback.
> >
> > Note that for all but the major comment, I mostly reviewed the diff from
> RFC 4006.
> >
> > Thanks!
> >
> > Ben.
> >
> > —————————————
> >
> > Major Comment:
> >
> > I strongly suggest that you add more privacy considerations. I realize
> that it inherits its existing privacy considerations from RFC 4006, but
> that was published in 2005. The IETF’s focus on privacy has evolved
> considerably since then, and I think this draft will get objections during
> IESG review without adding some more.
> >
> > I suggest the following:
> > — Create a “Privacy Considerations” section separate from the security
> considerations.
> > — Enumerate the AVPs that you think contain user identifiable
> information, persistent identifiers, or other privacy sensitive data.
> > — Make some non-normative recommendations concerning data minimization.
> That is, add a few sentences recommending that clients and servers avoid
> capturing and/or log personal information beyond that needed for the
> application's purpose.
> >
> > Minor Comments:
> >
> > -Section 12 and subsections: Please clarify that many of these elements
> were already registered by RF 4006, and are not being “re-registered” here.
> ( It’s perfectly okay to pull the registration information forward into the
> bis draft; it just needs clarification.) Also, please consider wether
> existing registrations should be updated to point to this document rather
> than 4006.
> >
> > Appendices: Would any of the example flows benefit from including one or
> more of the new AVPs?
> >
> > Editorial and Nits:
> >
> > -Section 8.34: “ If the Final-Unit-Action AVP is set to RESTRICT_ACCESS
> or REDIRECT
> > and the classification of the restricted traffic cannot be expressed
> > using IPFilterRule, or different actions (e.g., QoS) than just
> > allowing QoS needs to be enforced traffic, … “
> >
> > I have trouble parsing the sentence.
> >
> > -14: "Even without any modification to the messages, an adversary can
> >  invite a security threat by eavesdropping, as the transactions contain
> private information about the user.
> > ”
> > I suggest “ … an adversary can eavesdrop on transactions that contain
> privacy-sensitive imformation”
> >
> >
> >
> >
> >
> >
> >
> >
> > ______________________________ _________________
> > DiME mailing list
> > DiME@ietf.org
> > https://www.ietf.org/mailman/ listinfo/dime
> <https://www.ietf.org/mailman/listinfo/dime>
>
> ______________________________ _________________
> DiME mailing list
> DiME@ietf.org
> https://www.ietf.org/mailman/ listinfo/dime
> <https://www.ietf.org/mailman/listinfo/dime>
>
>
>