Re: [Dime] [dime] #54: OC-Report-Type as mandatory AVP

Ben Campbell <ben@nostrum.com> Fri, 14 February 2014 22:12 UTC

Return-Path: <ben@nostrum.com>
X-Original-To: dime@ietfa.amsl.com
Delivered-To: dime@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DF36A1A0028 for <dime@ietfa.amsl.com>; Fri, 14 Feb 2014 14:12:44 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.036
X-Spam-Level:
X-Spam-Status: No, score=-1.036 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HELO_MISMATCH_COM=0.553, HOST_MISMATCH_NET=0.311] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UPjruIF5RIrf for <dime@ietfa.amsl.com>; Fri, 14 Feb 2014 14:12:43 -0800 (PST)
Received: from shaman.nostrum.com (nostrum-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:267::2]) by ietfa.amsl.com (Postfix) with ESMTP id F097B1A004A for <dime@ietf.org>; Fri, 14 Feb 2014 14:12:42 -0800 (PST)
Received: from [10.0.1.29] (cpe-173-172-146-58.tx.res.rr.com [173.172.146.58]) (authenticated bits=0) by shaman.nostrum.com (8.14.3/8.14.3) with ESMTP id s1EMCXGP054473 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Fri, 14 Feb 2014 16:12:34 -0600 (CST) (envelope-from ben@nostrum.com)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\))
From: Ben Campbell <ben@nostrum.com>
In-Reply-To: <EE7D3FEB-CD2A-45D9-9700-5CCA118D9A14@gmail.com>
Date: Fri, 14 Feb 2014 16:12:32 -0600
Content-Transfer-Encoding: quoted-printable
Message-Id: <546C1F19-2B53-4054-9C26-DDE6D0DF3C9F@nostrum.com>
References: <075.72da31b401c033905a4fb81d09a8b4aa@trac.tools.ietf.org> <7077_1392216348_52FB891B_7077_4146_1_6B7134B31289DC4FAF731D844122B36E49E1A4@PEXCVZYM13.corporate.adroot.infra.ftgroup> <E194C2E18676714DACA9C3A2516265D2026649A3@FR712WXCHMBA11.zeu.alcatel-lucent.com> <EE7D3FEB-CD2A-45D9-9700-5CCA118D9A14@gmail.com>
To: Jouni Korhonen <jouni.nospam@gmail.com>
X-Mailer: Apple Mail (2.1827)
Received-SPF: pass (shaman.nostrum.com: 173.172.146.58 is authenticated by a trusted mechanism)
Archived-At: http://mailarchive.ietf.org/arch/msg/dime/cQb4TkkaWT86O8nW3T9iVPXYELM
Cc: "dime@ietf.org" <dime@ietf.org>
Subject: Re: [Dime] [dime] #54: OC-Report-Type as mandatory AVP
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dime/>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Feb 2014 22:12:45 -0000

I actually prefer making it mandatory. The cost of adding it is trivial--even more so for a reporting node that only supports the default. The value of having it is less opportunity for interop errors.

On Feb 13, 2014, at 6:05 AM, Jouni Korhonen <jouni.nospam@gmail.com> wrote:

> 
> Agree that it is a small optimization, which I put there
> because at the beginning there seemed to be a lot of worry
> on every extra AVP ;-)
> 
> I prefer having the AVP optional but with a default value
> just like it is now. We have the same for the reduction
> percentage and the validity time as well.
> 
> - Jouni
> 
> On Feb 13, 2014, at 10:55 AM, "TROTTIN, JEAN-JACQUES (JEAN-JACQUES)" <jean-jacques.trottin@alcatel-lucent.com> wrote:
> 
>> Hi Mcruz
>> 
>> The current description indicates that when not present the OLR is of type Host, which was fine for me and keeps my preference. 
>> We may have  deployments where Realm OLR is not used, or where statistically the HOST type is the most frequent, so to have the grouped OLR-AVP containing a minimum of AVPs minimizes parsing. I agree it is a small optimization.
>> 
>> Best regards
>> 
>> JJacques 
>> 
>> 
>> 
>> 
>> -----Message d'origine-----
>> De : DiME [mailto:dime-bounces@ietf.org] De la part de lionel.morand@orange.com
>> Envoyé : mercredi 12 février 2014 15:46
>> À : dime@ietf.org; maria.cruz.bartolome@ericsson.com
>> Objet : Re: [Dime] [dime] #54: OC-Report-Type as mandatory AVP
>> 
>> Hi Maria Cruz,
>> 
>> I'm assuming that you mean "required" instead of "mandatory", right?
>> 
>> So instead of:
>> 
>>  OC-OLR ::= < AVP Header: TBD2 >
>>             < OC-Sequence-Number >
>>             [ OC-Report-Type ]
>>             [ OC-Reduction-Percentage ]
>>             [ OC-Validity-Duration ]
>>           * [ AVP ]
>> 
>> You would prefer:
>> 
>>  OC-OLR ::= < AVP Header: TBD2 >
>>             < OC-Sequence-Number >
>>             { OC-Report-Type }
>>             [ OC-Reduction-Percentage ]
>>             [ OC-Validity-Duration ]
>>           * [ AVP ]
>> 
>> And I'm fine with this proposal.
>> 
>> Cheers,
>> 
>> Lionel
>> 
>> -----Message d'origine-----
>> De : DiME [mailto:dime-bounces@ietf.org] De la part de dime issue tracker Envoyé : mercredi 12 février 2014 15:26 À : maria.cruz.bartolome@ericsson.com Cc : dime@ietf.org Objet : [Dime] [dime] #54: OC-Report-Type as mandatory AVP
>> 
>> #54: OC-Report-Type as mandatory AVP
>> 
>> Now in chapter 4.6:
>> 
>>   The default value of the OC-Report-Type AVP is 0 (i.e. the host
>>   report).
>> 
>> This AVP is always required, right? Then, I think it is more precise that  we define this AVP as mandatory.
>> 
>> -- 
>> -----------------------------------------------+------------------------
>> -----------------------------------------------+---
>> Reporter:  maria.cruz.bartolome@ericsson.com  |      Owner:  MCruz
>>    Type:  defect                             |  Bartolomé
>> Priority:  major                              |     Status:  new
>> Component:  draft-docdt-dime-ovli              |  Milestone:
>> Severity:  Active WG Document                 |    Version:  1.0
>>                                              |   Keywords:
>> -----------------------------------------------+------------------------
>> -----------------------------------------------+---
>> 
>> Ticket URL: <http://trac.tools.ietf.org/wg/dime/trac/ticket/54>
>> dime <http://tools.ietf.org/wg/dime/>
>> 
>> _______________________________________________
>> DiME mailing list
>> DiME@ietf.org
>> https://www.ietf.org/mailman/listinfo/dime
>> 
>> _________________________________________________________________________________________________________________________
>> 
>> Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.
>> 
>> This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation.
>> If you have received this email in error, please notify the sender and delete this message and its attachments.
>> As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
>> Thank you.
>> 
>> _______________________________________________
>> DiME mailing list
>> DiME@ietf.org
>> https://www.ietf.org/mailman/listinfo/dime
>> _______________________________________________
>> DiME mailing list
>> DiME@ietf.org
>> https://www.ietf.org/mailman/listinfo/dime
> 
> _______________________________________________
> DiME mailing list
> DiME@ietf.org
> https://www.ietf.org/mailman/listinfo/dime