Re: [Dime] [dime] #44: Incorrect sequence number behavior

Jouni Korhonen <jouni.nospam@gmail.com> Fri, 28 February 2014 18:15 UTC

Return-Path: <jouni.nospam@gmail.com>
X-Original-To: dime@ietfa.amsl.com
Delivered-To: dime@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D74741A0144 for <dime@ietfa.amsl.com>; Fri, 28 Feb 2014 10:15:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hS4N1KoERzAz for <dime@ietfa.amsl.com>; Fri, 28 Feb 2014 10:15:10 -0800 (PST)
Received: from mail-lb0-x22a.google.com (mail-lb0-x22a.google.com [IPv6:2a00:1450:4010:c04::22a]) by ietfa.amsl.com (Postfix) with ESMTP id 3BDD51A0252 for <dime@ietf.org>; Fri, 28 Feb 2014 10:15:09 -0800 (PST)
Received: by mail-lb0-f170.google.com with SMTP id s7so2985603lbd.29 for <dime@ietf.org>; Fri, 28 Feb 2014 10:15:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=FaBJbN/kS1cj/NMtnyqlhZE96CzM30RUwCxnoE8PS8s=; b=oUNXP7XuPwa8deCoEa/UL7WXzpp8vD+OkRG6JUeJDDBYPj2exvbxNFL2vmX4RsNJVB xIhLDz47a/Q8ILC6sxQX3/AKqIPc8LREQfAQptiCByhQp/g9Thiwo97aytdRZk7UKSpA hFsbYh5xYnYuqgh+8r+RVVhRtuMnVPaZrtswTzdD45m84E/XSglBh+QGYZlTR+RxFz8N 47kzK33fV3x8gqw1GOc/GRljjhYc3QsujK8tju0L5ibMLgGjPTTecQ9UwmsOkMF+l9F4 5RRi3aDCIJnFAdPDkqWMatYyzWr7GodB/xm8CIOPzh6VKi1YoyahlwYFGcGsw6smGyEb mRCg==
X-Received: by 10.112.72.40 with SMTP id a8mr2096773lbv.68.1393611306362; Fri, 28 Feb 2014 10:15:06 -0800 (PST)
Received: from [188.117.15.108] ([188.117.15.108]) by mx.google.com with ESMTPSA id q6sm14803780lal.3.2014.02.28.10.15.01 for <multiple recipients> (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 28 Feb 2014 10:15:01 -0800 (PST)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
From: Jouni Korhonen <jouni.nospam@gmail.com>
In-Reply-To: <530BB87A.2000807@usdonovans.com>
Date: Fri, 28 Feb 2014 20:15:00 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <1B4649DF-1F73-4CD9-BA81-803F841C729F@gmail.com>
References: <057.7c5fb5d661b97d2b4cb140cc4965cf36@trac.tools.ietf.org> <10919_1391878439_52F66127_10919_17464_1_6B7134B31289DC4FAF731D844122B36E4938F4@PEXCVZYM13.corporate.adroot.infra.ftgroup> <530BB87A.2000807@usdonovans.com>
To: Steve Donovan <srdonovan@usdonovans.com>
X-Mailer: Apple Mail (2.1510)
Archived-At: http://mailarchive.ietf.org/arch/msg/dime/cS0cggBmaKSDOTGDBN59elnf1vg
Cc: "ben@nostrum.com" <ben@nostrum.com>, "dime@ietf.org" <dime@ietf.org>, "draft-docdt-dime-ovli@tools.ietf.org" <draft-docdt-dime-ovli@tools.ietf.org>
Subject: Re: [Dime] [dime] #44: Incorrect sequence number behavior
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dime/>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Feb 2014 18:15:15 -0000

I am ok with the proposed wording here.

- Jouni


On Feb 24, 2014, at 11:24 PM, Steve Donovan <srdonovan@usdonovans.com> wrote:

> Lionel,
> 
> I believe that Ben's issue was with the following wording in section 4.3 
> 
>  
>    The Sequence-Number AVP indicates the "freshness" of the OC-OLR AVP.
>    It is possible to replay the same OC-OLR AVP multiple times between
>    the overload control endpoints, however, when the OC-OLR AVP content
>    changes or sending endpoint otherwise wants the receiving endpoint to
>    update its overload control information, then the OC-Sequence-Number
>    AVP MUST contain a new greater value than the previously received.
>    The receiver SHOULD discard an OC-OLR AVP with a sequence number that
>    is less than previously received one.
> 
> 
> The wording you reference is in section 5.5.2.
> 
> The above wording can be improved by changing the last sentence to "The reacting node SHOULD discard an OC-OLR AVP with a sequence number that is less than or equal to the previously received sequence number."
> 
> Steve
> 
> On 2/8/14 10:53 AM, lionel.morand@orange.com wrote:
>> Hi Ben,
>> 
>> The case "equal" is discussed in the previous sentence.
>> 
>> Check the following:
>> 
>>    The received OC-Supported-Features AVP does not change the existing
>>    overload condition and/or traffic abatement algorithm settings if the
>>    OC-Sequence-Number AVP contains a value that is equal to the
>>    previously received/recorded one.  If the OC-Supported-Features AVP
>>    is received for the first time for the reporting node or the OC-
>>    Sequence-Number AVP value is less than the previously received/
>>    recorded one (and is outside the valid overflow window), then either
>>    the sequence number is stale (e.g. an intentional or unintentional
>>    replay) and SHOULD be silently discarded.
>> 
>> The first sentence implies that the received OLR is ignored. 
>> 
>> And actually, there is something wrong in the last sentence. At the end, 
>> 
>>    recorded one (and is outside the valid overflow window), then either
>>    the sequence number is stale or replay (e.g. an intentional or unintentional
>>    replay) and SHOULD be silently discarded.
>> 
>> The "either" in the first line should be removed.
>> 
>> Regards,
>> 
>> Lionel
>> 
>> 
>> -----Message d'origine-----
>> De : DiME [
>> mailto:dime-bounces@ietf.org
>> ] De la part de dime issue tracker
>> Envoyé : vendredi 7 février 2014 22:49
>> À : 
>> draft-docdt-dime-ovli@tools.ietf.org; ben@nostrum.com
>> 
>> Cc : 
>> dime@ietf.org
>> 
>> Objet : [Dime] [dime] #44: Incorrect sequence number behavior
>> 
>> #44: Incorrect sequence number behavior
>> 
>>  section 4.3 says that the receiver should discard an OLR with a sequence
>>  number less than the most recent. That should be less than or equal.
>>  Technically, re-applying the same OLR should make no difference, but it's
>>  never needed, and could be error prone if the sender screwed something up.
>> 
>> 
> 
> _______________________________________________
> DiME mailing list
> DiME@ietf.org
> https://www.ietf.org/mailman/listinfo/dime