Re: [Dime] OVLI: comments to 4.1

Ben Campbell <ben@nostrum.com> Fri, 06 December 2013 21:45 UTC

Return-Path: <ben@nostrum.com>
X-Original-To: dime@ietfa.amsl.com
Delivered-To: dime@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2E2ED1AE0D3 for <dime@ietfa.amsl.com>; Fri, 6 Dec 2013 13:45:32 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.036
X-Spam-Level:
X-Spam-Status: No, score=-1.036 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HELO_MISMATCH_COM=0.553, HOST_MISMATCH_NET=0.311] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pAx2qdcZtfbV for <dime@ietfa.amsl.com>; Fri, 6 Dec 2013 13:45:31 -0800 (PST)
Received: from shaman.nostrum.com (nostrum-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:267::2]) by ietfa.amsl.com (Postfix) with ESMTP id 22CBD1ADFD6 for <dime@ietf.org>; Fri, 6 Dec 2013 13:45:31 -0800 (PST)
Received: from [10.0.1.29] (cpe-173-172-146-58.tx.res.rr.com [173.172.146.58]) (authenticated bits=0) by shaman.nostrum.com (8.14.3/8.14.3) with ESMTP id rB6LjAdM031818 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Fri, 6 Dec 2013 15:45:12 -0600 (CST) (envelope-from ben@nostrum.com)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1822\))
From: Ben Campbell <ben@nostrum.com>
In-Reply-To: <6CDCFC84-3048-40B9-91A4-1451FCC65F60@gmail.com>
Date: Fri, 06 Dec 2013 15:45:10 -0600
Content-Transfer-Encoding: quoted-printable
Message-Id: <B76274BB-D2DA-4219-85E8-6294549CF4DE@nostrum.com>
References: <5BCBA1FC2B7F0B4C9D935572D90006681519DA3E@DEMUMBX014.nsn-intra.net> <6CDCFC84-3048-40B9-91A4-1451FCC65F60@gmail.com>
To: Jouni Korhonen <jouni.nospam@gmail.com>
X-Mailer: Apple Mail (2.1822)
Received-SPF: pass (shaman.nostrum.com: 173.172.146.58 is authenticated by a trusted mechanism)
Cc: "dime@ietf.org" <dime@ietf.org>
Subject: Re: [Dime] OVLI: comments to 4.1
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dime/>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Dec 2013 21:45:32 -0000

On Dec 6, 2013, at 4:17 AM, Jouni Korhonen <jouni.nospam@gmail.com> wrote:

[...]

>> 3. The OC-Sequence-Number within OC-Feature-Vector only makes sense if the receiving reporting endpoint can determine the identity of the reacting endpoint (which is not necessarily the origin host (client),
> 
> My original proposal was to have seqnr as a timestamp. Some folks argued
> it is no good and suggested seqnr. I still think time makes more sense than
> seqnr.
> 

Whether it's a timestamp, sequence number, or random number, we should describe the required uniqueness properties. (i.e. unique for that sender, unique across all senders, unique over a short period of time vs long period of time, etc.)

There may be other reasons to identify who sent the OC-Feature-Vector. Should we consider including the sender identity?

>> it may be an agent and it may not always be the same agent), and if the reporting endpoint is required to store the OC-Feature-Vector / reacting-endpoint-identity pair (which I think both is not required). The reporting endpoint can base its processing logic on the actually received OC-Feature-Vector value, no matter whether it is brand-new or old but stil valid. Proposal is to delete OC-Sequence-Number AVP from OC-Feature-Vector.
> 
> Do not agree removing it.

I concur with Jouni. IIRC, the point of having a sequence number here was so that if a reacting-node chooses to send the feature vector in every request, the reacting node can easily determine if the contents have changed, and ignore it if not. But it might be reasonable to consider whether that saves enough work to make it worth the trouble.

[...]