Re: [Dime] [dime] #54: OC-Report-Type as mandatory AVP

Jouni Korhonen <jouni.nospam@gmail.com> Fri, 28 February 2014 16:11 UTC

Return-Path: <jouni.nospam@gmail.com>
X-Original-To: dime@ietfa.amsl.com
Delivered-To: dime@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 166C21A00F3 for <dime@ietfa.amsl.com>; Fri, 28 Feb 2014 08:11:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1
X-Spam-Level:
X-Spam-Status: No, score=-1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id broThS2bmLUj for <dime@ietfa.amsl.com>; Fri, 28 Feb 2014 08:10:57 -0800 (PST)
Received: from mail-la0-x22f.google.com (mail-la0-x22f.google.com [IPv6:2a00:1450:4010:c03::22f]) by ietfa.amsl.com (Postfix) with ESMTP id 7822F1A00DE for <dime@ietf.org>; Fri, 28 Feb 2014 08:10:57 -0800 (PST)
Received: by mail-la0-f47.google.com with SMTP id y1so2838981lam.34 for <dime@ietf.org>; Fri, 28 Feb 2014 08:10:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=2qEbRCQkEYjOo3lvv2hib21F/1AchVkFiyN+zm49ug0=; b=bGKYJaeVs7NKMa+uslMFNVHozDE8W+tzdmutrDJeecvtRVKUFqT7FUYF8ZLiViyPRB dHL6qVilJ9Aw2PausJMZ3XidMeN8EIQ8bnFoesHJYcVlNGttMTsx9Kl3M5qp23K019dg i13ucIO5azfUdDjxPp9sGSd1Vl/phpXUqE3A5PJZjDAVrEEQn+AZ5VozV87lz19kLpWG lnHBG5U6v4ssEKqAPfMctRb2qbmrNojru4nO8IbL3v3EazS4TVmf3M+Wb4UZuYFRQPJM vCOxckbJxjY6tsyXat6AAqdSeTv4wdiexCTqZaluym9C7LJDIKhS/ub82B9oQfRAieUX H69g==
X-Received: by 10.112.169.10 with SMTP id aa10mr1721388lbc.72.1393603854926; Fri, 28 Feb 2014 08:10:54 -0800 (PST)
Received: from [188.117.15.108] ([188.117.15.108]) by mx.google.com with ESMTPSA id w2sm14310805lad.4.2014.02.28.08.10.52 for <multiple recipients> (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 28 Feb 2014 08:10:52 -0800 (PST)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
From: Jouni Korhonen <jouni.nospam@gmail.com>
In-Reply-To: <52FCBEA4.3020000@usdonovans.com>
Date: Fri, 28 Feb 2014 18:10:51 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <612C78B4-6D66-487B-9C49-9CD6504027F7@gmail.com>
References: <075.72da31b401c033905a4fb81d09a8b4aa@trac.tools.ietf.org> <7077_1392216348_52FB891B_7077_4146_1_6B7134B31289DC4FAF731D844122B36E49E1A4@PEXCVZYM13.corporate.adroot.infra.ftgroup> <E194C2E18676714DACA9C3A2516265D2026649A3@FR712WXCHMBA11.zeu.alcatel-lucent.com> <EE7D3FEB-CD2A-45D9-9700-5CCA118D9A14@gmail.com> <52FCBEA4.3020000@usdonovans.com>
To: Steve Donovan <srdonovan@usdonovans.com>
X-Mailer: Apple Mail (2.1510)
Archived-At: http://mailarchive.ietf.org/arch/msg/dime/hwyEGz5nMwmDuticeFTAqCDoDdE
Cc: dime@ietf.org
Subject: Re: [Dime] [dime] #54: OC-Report-Type as mandatory AVP
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dime/>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Feb 2014 16:11:06 -0000

Steve,

Optimization as having the optional OC-Report-Type and when not present
using the default value. This was there to reduce the amount of transported
AVPs.

- JOuni

On Feb 13, 2014, at 2:46 PM, Steve Donovan <srdonovan@usdonovans.com> wrote:

> Jouni,
> 
> Which optimization, defining a default value or Lionel's proposal to make it a required AVP?
> 
> Steve
> 
> On 2/13/14 6:05 AM, Jouni Korhonen wrote:
>> Agree that it is a small optimization, which I put there
>> because at the beginning there seemed to be a lot of worry
>> on every extra AVP ;-)
>> 
>> I prefer having the AVP optional but with a default value
>> just like it is now. We have the same for the reduction
>> percentage and the validity time as well.
>> 
>> - Jouni
>> 
>> On Feb 13, 2014, at 10:55 AM, "TROTTIN, JEAN-JACQUES (JEAN-JACQUES)" 
>> <jean-jacques.trottin@alcatel-lucent.com>
>>  wrote:
>> 
>> 
>>> Hi Mcruz
>>> 
>>> The current description indicates that when not present the OLR is of type Host, which was fine for me and keeps my preference. 
>>> We may have  deployments where Realm OLR is not used, or where statistically the HOST type is the most frequent, so to have the grouped OLR-AVP containing a minimum of AVPs minimizes parsing. I agree it is a small optimization.
>>> 
>>> Best regards
>>> 
>>> JJacques 
>>> 
>>> 
>>> 
>>> 
>>> -----Message d'origine-----
>>> De : DiME [
>>> mailto:dime-bounces@ietf.org] De la part de lionel.morand@orange.com
>>> 
>>> Envoyé : mercredi 12 février 2014 15:46
>>> À : 
>>> dime@ietf.org; maria.cruz.bartolome@ericsson.com
>>> 
>>> Objet : Re: [Dime] [dime] #54: OC-Report-Type as mandatory AVP
>>> 
>>> Hi Maria Cruz,
>>> 
>>> I'm assuming that you mean "required" instead of "mandatory", right?
>>> 
>>> So instead of:
>>> 
>>>   OC-OLR ::= < AVP Header: TBD2 >
>>>              < OC-Sequence-Number >
>>>              [ OC-Report-Type ]
>>>              [ OC-Reduction-Percentage ]
>>>              [ OC-Validity-Duration ]
>>>            * [ AVP ]
>>> 
>>> You would prefer:
>>> 
>>>   OC-OLR ::= < AVP Header: TBD2 >
>>>              < OC-Sequence-Number >
>>>              { OC-Report-Type }
>>>              [ OC-Reduction-Percentage ]
>>>              [ OC-Validity-Duration ]
>>>            * [ AVP ]
>>> 
>>> And I'm fine with this proposal.
>>> 
>>> Cheers,
>>> 
>>> Lionel
>>> 
>>> -----Message d'origine-----
>>> De : DiME [
>>> mailto:dime-bounces@ietf.org] De la part de dime issue tracker Envoyé : mercredi 12 février 2014 15:26 À : maria.cruz.bartolome@ericsson.com Cc : dime@ietf.org
>>>  Objet : [Dime] [dime] #54: OC-Report-Type as mandatory AVP
>>> 
>>> #54: OC-Report-Type as mandatory AVP
>>> 
>>> Now in chapter 4.6:
>>> 
>>>    The default value of the OC-Report-Type AVP is 0 (i.e. the host
>>>    report).
>>> 
>>> This AVP is always required, right? Then, I think it is more precise that  we define this AVP as mandatory.
>>> 
>>> -- 
>>> -----------------------------------------------+------------------------
>>> -----------------------------------------------+---
>>> Reporter:  
>>> maria.cruz.bartolome@ericsson.com
>>>   |      Owner:  MCruz
>>>     Type:  defect                             |  Bartolomé
>>> Priority:  major                              |     Status:  new
>>> Component:  draft-docdt-dime-ovli              |  Milestone:
>>> Severity:  Active WG Document                 |    Version:  1.0
>>>                                               |   Keywords:
>>> -----------------------------------------------+------------------------
>>> -----------------------------------------------+---
>>> 
>>> Ticket URL: 
>>> <http://trac.tools.ietf.org/wg/dime/trac/ticket/54>
>>> 
>>> dime 
>>> <http://tools.ietf.org/wg/dime/>
>>> 
>>> 
>>> _______________________________________________
>>> DiME mailing list
>>> 
>>> DiME@ietf.org
>>> https://www.ietf.org/mailman/listinfo/dime
>>> 
>>> 
>>> _________________________________________________________________________________________________________________________
>>> 
>>> Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.
>>> 
>>> This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation.
>>> If you have received this email in error, please notify the sender and delete this message and its attachments.
>>> As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
>>> Thank you.
>>> 
>>> _______________________________________________
>>> DiME mailing list
>>> 
>>> DiME@ietf.org
>>> https://www.ietf.org/mailman/listinfo/dime
>>> 
>>> _______________________________________________
>>> DiME mailing list
>>> 
>>> DiME@ietf.org
>>> https://www.ietf.org/mailman/listinfo/dime
>> _______________________________________________
>> DiME mailing list
>> 
>> DiME@ietf.org
>> https://www.ietf.org/mailman/listinfo/dime
>> 
>> 
>> 
> 
> _______________________________________________
> DiME mailing list
> DiME@ietf.org
> https://www.ietf.org/mailman/listinfo/dime