Re: [Dime] [dime] #44: Incorrect sequence number behavior

<lionel.morand@orange.com> Sat, 08 February 2014 16:54 UTC

Return-Path: <lionel.morand@orange.com>
X-Original-To: dime@ietfa.amsl.com
Delivered-To: dime@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8B7A41A01E8 for <dime@ietfa.amsl.com>; Sat, 8 Feb 2014 08:54:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IwJiT9GQAdJi for <dime@ietfa.amsl.com>; Sat, 8 Feb 2014 08:53:59 -0800 (PST)
Received: from relais-inet.francetelecom.com (relais-ias92.francetelecom.com [193.251.215.92]) by ietfa.amsl.com (Postfix) with ESMTP id 612931A0413 for <dime@ietf.org>; Sat, 8 Feb 2014 08:53:59 -0800 (PST)
Received: from omfedm07.si.francetelecom.fr (unknown [xx.xx.xx.3]) by omfedm13.si.francetelecom.fr (ESMTP service) with ESMTP id ABD723244F8; Sat, 8 Feb 2014 17:53:59 +0100 (CET)
Received: from Exchangemail-eme1.itn.ftgroup (unknown [10.114.1.186]) by omfedm07.si.francetelecom.fr (ESMTP service) with ESMTP id 8F0454C06E; Sat, 8 Feb 2014 17:53:59 +0100 (CET)
Received: from PEXCVZYM13.corporate.adroot.infra.ftgroup ([fe80::cc7e:e40b:42ef:164e]) by PEXCVZYH01.corporate.adroot.infra.ftgroup ([::1]) with mapi id 14.03.0174.001; Sat, 8 Feb 2014 17:53:59 +0100
From: lionel.morand@orange.com
To: "dime@ietf.org" <dime@ietf.org>, "draft-docdt-dime-ovli@tools.ietf.org" <draft-docdt-dime-ovli@tools.ietf.org>, "ben@nostrum.com" <ben@nostrum.com>
Thread-Topic: [Dime] [dime] #44: Incorrect sequence number behavior
Thread-Index: AQHPJE5xFgHh+FiMkUemW8Uvvhb8WZqrkCvw
Date: Sat, 08 Feb 2014 16:53:59 +0000
Message-ID: <10919_1391878439_52F66127_10919_17464_1_6B7134B31289DC4FAF731D844122B36E4938F4@PEXCVZYM13.corporate.adroot.infra.ftgroup>
References: <057.7c5fb5d661b97d2b4cb140cc4965cf36@trac.tools.ietf.org>
In-Reply-To: <057.7c5fb5d661b97d2b4cb140cc4965cf36@trac.tools.ietf.org>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.197.38.3]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-PMX-Version: 6.0.3.2322014, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.2.8.31815
Subject: Re: [Dime] [dime] #44: Incorrect sequence number behavior
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dime/>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Feb 2014 16:54:01 -0000

Hi Ben,

The case "equal" is discussed in the previous sentence.

Check the following:

   The received OC-Supported-Features AVP does not change the existing
   overload condition and/or traffic abatement algorithm settings if the
   OC-Sequence-Number AVP contains a value that is equal to the
   previously received/recorded one.  If the OC-Supported-Features AVP
   is received for the first time for the reporting node or the OC-
   Sequence-Number AVP value is less than the previously received/
   recorded one (and is outside the valid overflow window), then either
   the sequence number is stale (e.g. an intentional or unintentional
   replay) and SHOULD be silently discarded.

The first sentence implies that the received OLR is ignored. 

And actually, there is something wrong in the last sentence. At the end, 

   recorded one (and is outside the valid overflow window), then either
   the sequence number is stale or replay (e.g. an intentional or unintentional
   replay) and SHOULD be silently discarded.

The "either" in the first line should be removed.

Regards,

Lionel


-----Message d'origine-----
De : DiME [mailto:dime-bounces@ietf.org] De la part de dime issue tracker
Envoyé : vendredi 7 février 2014 22:49
À : draft-docdt-dime-ovli@tools.ietf.org; ben@nostrum.com
Cc : dime@ietf.org
Objet : [Dime] [dime] #44: Incorrect sequence number behavior

#44: Incorrect sequence number behavior

 section 4.3 says that the receiver should discard an OLR with a sequence
 number less than the most recent. That should be less than or equal.
 Technically, re-applying the same OLR should make no difference, but it's
 never needed, and could be error prone if the sender screwed something up.

-- 
-------------------------+-------------------------------------------------
 Reporter:               |      Owner:  draft-docdt-dime-
  ben@nostrum.com        |  ovli@tools.ietf.org
     Type:  defect       |     Status:  new
 Priority:  trivial      |  Milestone:
Component:  draft-       |    Version:
  docdt-dime-ovli        |   Keywords:
 Severity:  Active WG    |
  Document               |
-------------------------+-------------------------------------------------

Ticket URL: <http://trac.tools.ietf.org/wg/dime/trac/ticket/44>
dime <http://tools.ietf.org/wg/dime/>

_______________________________________________
DiME mailing list
DiME@ietf.org
https://www.ietf.org/mailman/listinfo/dime

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.