Re: [Dime] [dime] #54: OC-Report-Type as mandatory AVP

Jouni Korhonen <jouni.nospam@gmail.com> Fri, 28 February 2014 16:27 UTC

Return-Path: <jouni.nospam@gmail.com>
X-Original-To: dime@ietfa.amsl.com
Delivered-To: dime@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5AFB11A032B for <dime@ietfa.amsl.com>; Fri, 28 Feb 2014 08:27:22 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5h_dZjaMEwII for <dime@ietfa.amsl.com>; Fri, 28 Feb 2014 08:27:19 -0800 (PST)
Received: from mail-la0-x236.google.com (mail-la0-x236.google.com [IPv6:2a00:1450:4010:c03::236]) by ietfa.amsl.com (Postfix) with ESMTP id EE87E1A02D0 for <dime@ietf.org>; Fri, 28 Feb 2014 08:27:18 -0800 (PST)
Received: by mail-la0-f54.google.com with SMTP id mc6so2922918lab.27 for <dime@ietf.org>; Fri, 28 Feb 2014 08:27:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=RPzI+9KeRr/nOmsEwjn0y/UxaB0keJjiPhE18Ugk8c8=; b=Q12kRzC4iO+LGpiPGB32C/l+kYuCtlmE/M+lJ01KyxSJCpZLB9ckEHpNK1FNP8aKLm ljuS1ACFXlbEaNtz2G2819PoYff1IgqRxMY0R8Xja80ZKBH6gllyAKvxTfTQQZcumyAL nCC+WC0Nz5hGrgcqU5JWqyn15g/aBG8AHaBxmMirRo9We3cACYU2rVytsWmc02igfaTn +oXzxyyV4hRo/hoDmUpk/DTshfCIIhl5t+5Gv9XlVMB/+mAU7PyM+iYvxoP2cBXw/Amk IcYJ6+D4CTPCHetShfnQ1Um3lmBFy8L/1YNL0gm41Znog+kRghnTCYoWGBzWVF7VRK64 fEPQ==
X-Received: by 10.153.4.43 with SMTP id cb11mr7433394lad.42.1393604836269; Fri, 28 Feb 2014 08:27:16 -0800 (PST)
Received: from [188.117.15.108] ([188.117.15.108]) by mx.google.com with ESMTPSA id cu8sm4499713lbb.12.2014.02.28.08.27.13 for <multiple recipients> (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 28 Feb 2014 08:27:13 -0800 (PST)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
From: Jouni Korhonen <jouni.nospam@gmail.com>
In-Reply-To: <087A34937E64E74E848732CFF8354B92097840F1@ESESSMB101.ericsson.se>
Date: Fri, 28 Feb 2014 18:27:12 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <FC3C0F25-F8BE-4B4B-AF30-4CF2029A2520@gmail.com>
References: <075.72da31b401c033905a4fb81d09a8b4aa@trac.tools.ietf.org> <7077_1392216348_52FB891B_7077_4146_1_6B7134B31289DC4FAF731D844122B36E49E1A4@PEXCVZYM13.corporate.adroot.infra.ftgroup> <E194C2E18676714DACA9C3A2516265D2026649A3@FR712WXCHMBA11.zeu.alcatel-lucent.com> <EE7D3FEB-CD2A-45D9-9700-5CCA118D9A14@gmail.com> <546C1F19-2B53-4054-9C26-DDE6D0DF3C9F@nostrum.com> <087A34937E64E74E848732CFF8354B92097840F1@ESESSMB101.ericsson.se>
To: Maria Cruz Bartolome <maria.cruz.bartolome@ericsson.com>
X-Mailer: Apple Mail (2.1510)
Archived-At: http://mailarchive.ietf.org/arch/msg/dime/oHozVgizsyyGkd0v9GxWuUZEDTM
Cc: "dime@ietf.org" <dime@ietf.org>
Subject: Re: [Dime] [dime] #54: OC-Report-Type as mandatory AVP
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dime/>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Feb 2014 16:27:22 -0000

Hi,

How having the AVP could be less error prone if it has a default
value and the receiver knows exactly how to proceed when the AVP
is not present?

If a node does not include it when it should, the implementation
is broken. Wouldn't a broken node be able to put wrong report
type into the AVP even if the AVP is mandatory?

Anyway, if it is my statement keeping issue #54 still open, consider
it resolved from my side. I am OK making the OC-Report-Type AVP as
required/mandatory AVP. Should we also consider it having a fixed
position just after the OC-Sequence-Number AVP as well since it is
going to in every OC-OLR?

- Jouni



On Feb 21, 2014, at 11:47 AM, Maria Cruz Bartolome <maria.cruz.bartolome@ericsson.com> wrote:

> 
> Hello all,
> 
> I understand JJ point of view, but I still tend to prefer to make it mandatory, since I think this is less error-prone, since the only node that knows the requested Report-Type is the reporting, if for any reason a reporting is omitting it (since it is optional), it will be always interpreted as HOST, but this type may be wrong.
> 
> I think DEFAULT values should never be error-prone, but used in "general cases", as a simplification, like e.g. a default for the Validity-Duration. Default Validity-Duration will never be an "error", it could be not the best value (compared with another value perfectly tuned to reporting node overload situation) but never the use of a Default value should lead to an erroneous behavior.
> 
> Best regards
> /MCruz
> 
> -----Original Message-----
> From: DiME [mailto:dime-bounces@ietf.org] On Behalf Of Ben Campbell
> Sent: viernes, 14 de febrero de 2014 23:13
> To: Jouni Korhonen
> Cc: dime@ietf.org
> Subject: Re: [Dime] [dime] #54: OC-Report-Type as mandatory AVP
> 
> I actually prefer making it mandatory. The cost of adding it is trivial--even more so for a reporting node that only supports the default. The value of having it is less opportunity for interop errors.
> 
> On Feb 13, 2014, at 6:05 AM, Jouni Korhonen <jouni.nospam@gmail.com> wrote:
> 
>> 
>> Agree that it is a small optimization, which I put there because at 
>> the beginning there seemed to be a lot of worry on every extra AVP ;-)
>> 
>> I prefer having the AVP optional but with a default value just like it 
>> is now. We have the same for the reduction percentage and the validity 
>> time as well.
>> 
>> - Jouni
>> 
>> On Feb 13, 2014, at 10:55 AM, "TROTTIN, JEAN-JACQUES (JEAN-JACQUES)" <jean-jacques.trottin@alcatel-lucent.com> wrote:
>> 
>>> Hi Mcruz
>>> 
>>> The current description indicates that when not present the OLR is of type Host, which was fine for me and keeps my preference. 
>>> We may have  deployments where Realm OLR is not used, or where statistically the HOST type is the most frequent, so to have the grouped OLR-AVP containing a minimum of AVPs minimizes parsing. I agree it is a small optimization.
>>> 
>>> Best regards
>>> 
>>> JJacques
>>> 
>>> 
>>> 
>>> 
>>> -----Message d'origine-----
>>> De : DiME [mailto:dime-bounces@ietf.org] De la part de 
>>> lionel.morand@orange.com Envoyé : mercredi 12 février 2014 15:46 À : 
>>> dime@ietf.org; maria.cruz.bartolome@ericsson.com Objet : Re: [Dime] 
>>> [dime] #54: OC-Report-Type as mandatory AVP
>>> 
>>> Hi Maria Cruz,
>>> 
>>> I'm assuming that you mean "required" instead of "mandatory", right?
>>> 
>>> So instead of:
>>> 
>>> OC-OLR ::= < AVP Header: TBD2 >
>>>            < OC-Sequence-Number >
>>>            [ OC-Report-Type ]
>>>            [ OC-Reduction-Percentage ]
>>>            [ OC-Validity-Duration ]
>>>          * [ AVP ]
>>> 
>>> You would prefer:
>>> 
>>> OC-OLR ::= < AVP Header: TBD2 >
>>>            < OC-Sequence-Number >
>>>            { OC-Report-Type }
>>>            [ OC-Reduction-Percentage ]
>>>            [ OC-Validity-Duration ]
>>>          * [ AVP ]
>>> 
>>> And I'm fine with this proposal.
>>> 
>>> Cheers,
>>> 
>>> Lionel
>>> 
>>> -----Message d'origine-----
>>> De : DiME [mailto:dime-bounces@ietf.org] De la part de dime issue 
>>> tracker Envoyé : mercredi 12 février 2014 15:26 À : 
>>> maria.cruz.bartolome@ericsson.com Cc : dime@ietf.org Objet : [Dime] 
>>> [dime] #54: OC-Report-Type as mandatory AVP
>>> 
>>> #54: OC-Report-Type as mandatory AVP
>>> 
>>> Now in chapter 4.6:
>>> 
>>>  The default value of the OC-Report-Type AVP is 0 (i.e. the host
>>>  report).
>>> 
>>> This AVP is always required, right? Then, I think it is more precise that  we define this AVP as mandatory.
>>> 
>>> --
>>> -----------------------------------------------+---------------------
>>> -----------------------------------------------+---
>>> -----------------------------------------------+---
>>> Reporter:  maria.cruz.bartolome@ericsson.com  |      Owner:  MCruz
>>>   Type:  defect                             |  Bartolomé
>>> Priority:  major                              |     Status:  new
>>> Component:  draft-docdt-dime-ovli              |  Milestone:
>>> Severity:  Active WG Document                 |    Version:  1.0
>>>                                             |   Keywords:
>>> -----------------------------------------------+---------------------
>>> -----------------------------------------------+---
>>> -----------------------------------------------+---
>>> 
>>> Ticket URL: <http://trac.tools.ietf.org/wg/dime/trac/ticket/54>
>>> dime <http://tools.ietf.org/wg/dime/>
>>> 
>>> _______________________________________________
>>> DiME mailing list
>>> DiME@ietf.org
>>> https://www.ietf.org/mailman/listinfo/dime
>>> 
>>> _____________________________________________________________________
>>> ____________________________________________________
>>> 
>>> Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.
>>> 
>>> This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation.
>>> If you have received this email in error, please notify the sender and delete this message and its attachments.
>>> As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
>>> Thank you.
>>> 
>>> _______________________________________________
>>> DiME mailing list
>>> DiME@ietf.org
>>> https://www.ietf.org/mailman/listinfo/dime
>>> _______________________________________________
>>> DiME mailing list
>>> DiME@ietf.org
>>> https://www.ietf.org/mailman/listinfo/dime
>> 
>> _______________________________________________
>> DiME mailing list
>> DiME@ietf.org
>> https://www.ietf.org/mailman/listinfo/dime
> 
> _______________________________________________
> DiME mailing list
> DiME@ietf.org
> https://www.ietf.org/mailman/listinfo/dime
> 
> _______________________________________________
> DiME mailing list
> DiME@ietf.org
> https://www.ietf.org/mailman/listinfo/dime