[Dime] AD review of draft-ietf-dime-4over6-provisioning-03

Stephen Farrell <stephen.farrell@cs.tcd.ie> Mon, 06 July 2015 10:49 UTC

Return-Path: <stephen.farrell@cs.tcd.ie>
X-Original-To: dime@ietfa.amsl.com
Delivered-To: dime@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 68C571A007E for <dime@ietfa.amsl.com>; Mon, 6 Jul 2015 03:49:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.21
X-Spam-Level:
X-Spam-Status: No, score=-4.21 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gHByoOC5k_76 for <dime@ietfa.amsl.com>; Mon, 6 Jul 2015 03:49:26 -0700 (PDT)
Received: from mercury.scss.tcd.ie (mercury.scss.tcd.ie [134.226.56.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 725531A0065 for <dime@ietf.org>; Mon, 6 Jul 2015 03:49:26 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mercury.scss.tcd.ie (Postfix) with ESMTP id AC04EBE2F for <dime@ietf.org>; Mon, 6 Jul 2015 11:49:24 +0100 (IST)
Received: from mercury.scss.tcd.ie ([127.0.0.1]) by localhost (mercury.scss.tcd.ie [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k4-2lvQySQr1 for <dime@ietf.org>; Mon, 6 Jul 2015 11:49:24 +0100 (IST)
Received: from [134.226.36.180] (stephen-think.dsg.cs.tcd.ie [134.226.36.180]) by mercury.scss.tcd.ie (Postfix) with ESMTPSA id 8EFBABDD8 for <dime@ietf.org>; Mon, 6 Jul 2015 11:49:24 +0100 (IST)
Message-ID: <559A5D34.2040807@cs.tcd.ie>
Date: Mon, 06 Jul 2015 11:49:24 +0100
From: Stephen Farrell <stephen.farrell@cs.tcd.ie>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: "dime@ietf.org" <dime@ietf.org>
OpenPGP: id=D66EA7906F0B897FB2E97D582F3C8736805F8DA2; url=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/dime/qGgLAjbidBuN7eio1xYMIcvyEQ8>
Subject: [Dime] AD review of draft-ietf-dime-4over6-provisioning-03
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dime/>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Jul 2015 10:49:28 -0000

Hiya,

I've done my AD review of draft-ietf-dime-4over6-provisioning-03

Seems to me like all's well. I'll start IETF LC shortly. My few
nitty comments are below, please treat then as IETF LC comments.

Thanks,
S.

- intro, 3rd last para: You use both MAP-E and MAP
(without a -E) here. Are they the same or is that an
implicit subtlty that'd be better explicit? I'd say
either use MAP-E in both cases, or explain in general
what's meant when you use each.

- intro; The last para is very unclear. What does
"doesn't specify <x> and that the AVPs...." mean? I'd say
split into two sentences.

- section 2, 2nd para: Why "allowed to use"? That's wrong
anyway, a customer could do other things as well as what
one operator provisions for that customer.  S/is
allowed/wants/ would be fine.

- 2.2 and 2.3: Are we only talking source ports for
outgoing traffic here, or is this the list of all ports
on which this customer can receive inbound traffic? Would
it help to say, since the latter can be bigger than the
former? I assume we mean the latter anyway. (This may be
a dumb question - sorry if my ignorance of LW4over6 and
MAP-E is showing there:-)

- 2.5, typo: s/Pv4/IPv4/

- 3.1, I'm surprised there wasn't already an AVP for
that. If there is one, or a similar one, it might be good
to say and give a bit of a hint when to use which.

- 8.1: the softwire I-D references are outdated. Does
everything still work ok with the latest draft versions?