Re: [Dime] [Technical Errata Reported] RFC6733 (5084)

Yuval Lifshitz <ylifshitz@sandvine.com> Wed, 16 August 2017 14:25 UTC

Return-Path: <ylifshitz@sandvine.com>
X-Original-To: dime@ietfa.amsl.com
Delivered-To: dime@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 806CC132195 for <dime@ietfa.amsl.com>; Wed, 16 Aug 2017 07:25:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LAYBccRPN6Ok for <dime@ietfa.amsl.com>; Wed, 16 Aug 2017 07:25:37 -0700 (PDT)
Received: from mail1.sandvine.com (Mail1.sandvine.com [64.7.137.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 97F6A1321AE for <dime@ietf.org>; Wed, 16 Aug 2017 07:25:37 -0700 (PDT)
Received: from WTL-EXCHP-2.sandvine.com ([fe80::68ac:f071:19ff:3455]) by wtl-exchp-1.sandvine.com ([::1]) with mapi id 14.03.0319.002; Wed, 16 Aug 2017 10:25:35 -0400
From: Yuval Lifshitz <ylifshitz@sandvine.com>
To: "Bertz, Lyle T [CTO]" <Lyle.T.Bertz@sprint.com>, Priyatosh Mandal <priyotoshtsp@gmail.com>, "dime@ietf.org" <dime@ietf.org>
Thread-Topic: [Dime] [Technical Errata Reported] RFC6733 (5084)
Thread-Index: AQHTFozFFiwznYlzkkG/tEqEsW/3D6KHCU4w
Date: Wed, 16 Aug 2017 14:25:35 +0000
Message-ID: <C43C255C7106314F8D13D03FA20CFE49A8ACB1CD@wtl-exchp-2.sandvine.com>
References: <CADTSkb3XRQQeeULWLcO3YNdKf7WpG=c=2LZmpD+CA0ncW=+8+g@mail.gmail.com> <C43C255C7106314F8D13D03FA20CFE49A8ACAD67@wtl-exchp-2.sandvine.com> <e37d9a0e462c453ca94f0e6afaf9154b@plswe13m04.ad.sprint.com>
In-Reply-To: <e37d9a0e462c453ca94f0e6afaf9154b@plswe13m04.ad.sprint.com>
Accept-Language: en-CA, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [192.168.142.1]
x-c2processedorg: b2f06e69-072f-40ee-90c5-80a34e700794
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/dime/rfeWJpmAZ2cCZIJ2_EgO9cWHc4Y>
Subject: Re: [Dime] [Technical Errata Reported] RFC6733 (5084)
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dime/>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Aug 2017 14:25:40 -0000

Not sure if errata is meant to capture "clarifications", but should probably be captured somewhere so it could be added to a future version.

-----Original Message-----
From: Bertz, Lyle T [CTO] [mailto:Lyle.T.Bertz@sprint.com] 
Sent: Wednesday, August 16, 2017 3:40 PM
To: Yuval Lifshitz; Priyatosh Mandal; dime@ietf.org
Subject: RE: [Dime] [Technical Errata Reported] RFC6733 (5084)

However, the spec is not wrong as much as there is no warning to ensure the reader is aware of the situation.   

-----Original Message-----
From: DiME [mailto:dime-bounces@ietf.org] On Behalf Of Yuval Lifshitz
Sent: Wednesday, August 16, 2017 12:20 AM
To: Priyatosh Mandal <priyotoshtsp@gmail.com>om>; dime@ietf.org
Subject: Re: [Dime] [Technical Errata Reported] RFC6733 (5084)

Don't think it should be rejected. Even if the implementation rollover 4M to 1 (and not to zero) there is still an issue of the fact that the origin-state-id is not incremented.
IMO, it should be addressed in the spec.

-----Original Message-----
From: DiME [mailto:dime-bounces@ietf.org] On Behalf Of Priyatosh Mandal
Sent: Wednesday, August 16, 2017 6:52 AM
To: dime@ietf.org
Subject: [Dime] [Technical Errata Reported] RFC6733 (5084)

Hello ,
Should I consider the Reported Errata ID: 5084, as rejected.

Kindly confirm.

Regards,
Dr. Priyatosh Mandal, Ph.D.

On Mon, 14 Aug 2017 19:47:28 +0530, Priyatosh Mandal wrote Kindly note that, with the incremental change of this origin-state-id the peer node clear sessions. So when the change is from the maximum value to the minimum value of origin-state-id then it is not an incremental change. This is an exceptional situation, which I feel to be part of rfc.

Regards,
Dr. Priyatosh Mandal, Ph. D.

On Aug 14, 2017 6:32 PM, "Bertz, Lyle T [CTO]" <Lyle.T.Bertz@sprint.com> wrote:

I believe what Dave is alluding to is that if one *does intend for the inferences to be made* then rolling over the value to 0 is not appropriate and avalue > 0, e.g. 1, MUST be used.

In a sense it is not an error as much as a note / warning for those who are allocating that AVP in a specific manner.


From: DiME [mailto:dime-bounces@ietf.org]On Behalf Of Priyatosh Mandal
Sent: Monday, August 14, 2017 6:19 AM
To: Dave Dolson <ddolson@sandvine.com>om>; RFC Errata System <rfc-editor@rfc-editor.org>rg>; vf0213@gmail.com; jari.arkko@ericsson.com; john.loughney@nokia.com; glenzorn@gmail.com; bclaise@cisco.com; warren@kumari.net; jouni.nospam@gmail.com; lionel.morand@orange.com
Cc: dime@ietf.org
Subject: Re: [Dime] [Technical Errata Reported] RFC6733 (5084)

Hello Sir,
The situation is a transition from the maximum value 4294967295 of Origin-State-Id. If after this, the value of Origin-State-Id is increased, it will automatically become 0. So the peer node which receives the value 0 after 4294967295, can assume the node whichsent this 0, faced a restart. Here the peer-node  is already aware that the previous value of origin-state-id was 4294967295. So it can easily conclude node restart.

I understand  the meaning of 0 as explained in RFC 6733 :"If an access device does not intend for such inferences to be made, it MUST either not include Origin-State-Id in any message or set its value to 0".But this is a special case, where the value of Origin-State-Id changes from  4294967295 to 0.

So kindly reconsider
this.

Thanking you,
Priyatosh

On Mon, 14 Aug 2017 10:51:25 +0000, Dave Dolson wrote In my opinion, the change should not be accepted.
In your roll-over special case, the device should skip over the value 0, using 1 or some other value instead of zero.

David Dolson
Sandvine

From: Priyatosh Mandal
Sent: Monday, August 14, 2017 12:57 AM
To: RFC Errata System; vf0213@gmail.com;jari.arkko@ericsson.com;
john.loughney@nokia.com; glenzorn@gmail.com;bclaise@cisco.com;
warren@kumari.net; jouni.nospam@gmail.com;lionel.morand@orange.com
Cc: dime@ietf.org
Subject: Re: [Dime] [Technical Errata Reported] RFC6733 (5084)

Dear All,
Kindly verify this.

Regards,
Priyatosh Mandal

On Thu, 10 Aug 2017 21:04:56 -0700 (PDT), RFC Errata System wrote The following errata report has been submitted for RFC6733, "Diameter Base Protocol".

--------------------------------------
You may review the report below and at:
https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.rfc-editor.org%2Ferrata%2Feid5084&data=02%7C01%7Clyle.t.bertz%40sprint.com%7C22cd07b0b7174d6fdc7608d4e4666ace%7C4f8bc0acbd784bf5b55f1b31301d9adf%7C0%7C0%7C636384575908897376&sdata=EITh8Z6bWAwU9pur6Zrospr9D%2Fd2UgKe%2BTBrmkh%2BDzA%3D&reserved=0

--------------------------------------
Type: Technical
Reported by: Priyatosh Mandal <priyatos@cdot.in>

Section: 8.16

Original Text
-------------
By including Origin-State-Id in a message, it allows other Diameter entities to infer that sessions associated with a lower Origin-State-Id are no longer active.
If an access device does not intend for such inferences to be made, it MUST either not include Origin-State-Id in any message or set its value to 0.

Corrected Text
--------------
By including Origin-State-Id in a message, it allows other Diameter entities to infer that sessions associated with a lower Origin-State-Id are no longer active.
If an access device does not intend for such inferences to be made, it MUST either not include Origin-State-Id in any message or set its value to 0.
As a special case when the value of Origin-State-Id changes from
4294967295 to 0, then also the access device  clear all the sessions.

Notes
-----
Origin-State-Id is defined as Unsigned32 in RFC 6733, Section 8.16. So the maximum value it can have is 4294967295. If the system restarts many times and the value of Origin-State-Id reaches the value which is same as its maximum value 4294967295.
Then what will happen for the next restart. At the next restart the value of Origin-State-Id will be 0 if we try to increase the value of Origin-State-Id.
It is not defined in the RFC 6733, that how the system should behave after 4294967295-th restart with respect to Origin-State-Id.

Generally when the peer receives an increased value of Origin-State-Id, then it clear all sessions.
If the value of Origin-State-Id reaches its maximum i.e., 4294967295, then after another restart its value will be 0. For a special case for transition of value of Origin-State-Id from
4294967295 to 0, the peer should clear its session.

Instructions:
-------------
This erratum is currently posted as "Reported". If necessary, please use "Reply All" to discuss whether it should be verified or rejected. When a decision is reached, the verifying party can log in to change the status and edit the report, if necessary.

--------------------------------------
RFC6733 (draft-ietf-dime-rfc3588bis-33)
--------------------------------------
Title               : Diameter Base Protocol
Publication Date    : October 2012
Author(s)           : V. Fajardo, Ed., J. Arkko, J. Loughney, G. Zorn, Ed.
Category            : PROPOSED STANDARD
Source              : Diameter Maintenance and Extensions
Area                : Operations and Management
Stream              : IETF
Verifying Party     : IESG

Priyatosh
Ext: 8517
Mob: 9810480266
--------------------------------------------------------------------------------
::Disclaimer::
--------------------------------------------------------------------------------
The contents of this email and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on C-DOT.
Any views or opinions presented in this email are solely those of the author
and  may  not  necessarily  reflect  the   opinions

Priyatosh
Ext: 8517
Mob: 9810480266
--------------------------------------------------------------------------------
::Disclaimer::
--------------------------------------------------------------------------------
The contents of this email and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on C-DOT.
Any views or opinions presented in this email are solely those of the author
and  may  not  necessarily  reflect  the   opinions

-----------------------------------------------------------------------

This e-mail may contain Sprint proprietary information intended for the sole use of the recipient(s). Any use by others is prohibited. If you are not the intended recipient, please contact the sender and delete all copies of the message.

_______________________________________________
DiME mailing list
DiME@ietf.org
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.org%2Fmailman%2Flistinfo%2Fdime&data=02%7C01%7Clyle.t.bertz%40sprint.com%7C22cd07b0b7174d6fdc7608d4e4666ace%7C4f8bc0acbd784bf5b55f1b31301d9adf%7C0%7C0%7C636384575908897376&sdata=OuKsSusa3%2FM8fjvTaKJ%2F%2FEgL%2FGwWDQUFCQu%2BqKTNJxg%3D&reserved=0

_______________________________________________
DiME mailing list
DiME@ietf.org
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.org%2Fmailman%2Flistinfo%2Fdime&data=02%7C01%7Clyle.t.bertz%40sprint.com%7C22cd07b0b7174d6fdc7608d4e4666ace%7C4f8bc0acbd784bf5b55f1b31301d9adf%7C0%7C0%7C636384575908897376&sdata=OuKsSusa3%2FM8fjvTaKJ%2F%2FEgL%2FGwWDQUFCQu%2BqKTNJxg%3D&reserved=0