Re: [Dime] Spencer Dawkins' Yes on draft-ietf-dime-doic-rate-control-10: (with COMMENT)

Steve Donovan <srdonovan@usdonovans.com> Mon, 04 February 2019 19:37 UTC

Return-Path: <srdonovan@usdonovans.com>
X-Original-To: dime@ietfa.amsl.com
Delivered-To: dime@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 08CF8130EEF for <dime@ietfa.amsl.com>; Mon, 4 Feb 2019 11:37:32 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.12
X-Spam-Level:
X-Spam-Status: No, score=-1.12 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_NEUTRAL=0.779] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C0bmlVflt6Yk for <dime@ietfa.amsl.com>; Mon, 4 Feb 2019 11:37:30 -0800 (PST)
Received: from biz131.inmotionhosting.com (biz131.inmotionhosting.com [173.247.247.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 023F7130EED for <dime@ietf.org>; Mon, 4 Feb 2019 11:37:30 -0800 (PST)
Received: from [97.99.21.33] (port=62457 helo=SDmac.lan) by biz131.inmotionhosting.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from <srdonovan@usdonovans.com>) id 1gqk3S-00GXhX-KU for dime@ietf.org; Mon, 04 Feb 2019 11:37:29 -0800
To: dime@ietf.org
References: <154820200372.13175.6427829494337126533.idtracker@ietfa.amsl.com>
From: Steve Donovan <srdonovan@usdonovans.com>
Message-ID: <32a4a01d-e5e4-450f-acdb-a6ddffe40297@usdonovans.com>
Date: Mon, 4 Feb 2019 13:37:18 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <154820200372.13175.6427829494337126533.idtracker@ietfa.amsl.com>
Content-Type: multipart/alternative; boundary="------------717831DAACAE5483E90D618A"
X-OutGoing-Spam-Status: No, score=-1.0
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - biz131.inmotionhosting.com
X-AntiAbuse: Original Domain - ietf.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - usdonovans.com
X-Get-Message-Sender-Via: biz131.inmotionhosting.com: authenticated_id: srdonovan@usdonovans.com
X-Authenticated-Sender: biz131.inmotionhosting.com: srdonovan@usdonovans.com
X-Source:
X-Source-Args:
X-Source-Dir:
Archived-At: <https://mailarchive.ietf.org/arch/msg/dime/vwBVr6dq_qQnVOvIP08qVUYX2B8>
Subject: Re: [Dime] Spencer Dawkins' Yes on draft-ietf-dime-doic-rate-control-10: (with COMMENT)
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dime/>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Feb 2019 19:37:32 -0000

Spencer,

Thanks for the review and comments.  Please see my comments inline.

Steve

On 1/22/19 6:06 PM, Spencer Dawkins wrote:
> Spencer Dawkins has entered the following ballot position for
> draft-ietf-dime-doic-rate-control-10: Yes
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-dime-doic-rate-control/
>
>
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> Thank you for doing this work, and for basing it on SIP Overload Control. It's
> nice when protocol designers adopt good ideas from each other.
>
> There are three SHOULDs in Section 5.1, Reporting Node Overload Control State,
> I'd like to understand better.
>
>    A reporting node that uses the rate abatement algorithm SHOULD
>    maintain reporting node Overload Control State (OCS) for each
>    reacting node to which it sends a rate Overload Report (OLR).
>
> ^^ This one - I'm guessing that this is "SHOULD unless you're still writing
> code upgrading an implementation that treats all reacting nodes the same way",
> based on this next sentence, but I'm guessing. Why wouldn't you do this?
SRD> If all reacting nodes are equal then an implementation could choose
to have a single OCS entry the applies to all nodes.
>
>       This is different from the behavior defined in [RFC7683] where a
>       single loss percentage sent to all reacting nodes.
>
>    A reporting node SHOULD maintain OCS entries when using the rate
>    abatement algorithm per supported Diameter application, per targeted
>    reacting node and per report type.
>
> ^^ Your answer to my previous question is likely to help me understand this
> one, but I'm guessing reasons why you wouldn't do this.
SRD> Same reason as above. 
>
>    A rate OCS entry is identified by the tuple of Application-Id, report
>    type and DiameterIdentity of the target of the rate OLR.
>
>    The rate OCS entry SHOULD include the rate allocated to the reacting
>    note.
>
> ^^ I'm really interested on this one - does the rate abatement algorithm work
> without knowing the rate that's allocated? but assuming that it does work, I'm
> still guessing why you wouldn't do this.
SRD> It's related to the above.  If the implementation chooses to always
calculate the rate sent to a reacting node based a simple calculation of
"max rate" divided by "number of reacting nodes", then it would not need
to store the rate in the OCS.
>
>    A reporting node that has selected the rate overload abatement
>    algorithm MUST indicate the rate requested to be applied by DOIC
>    reacting nodes in the OC-Maximum-Rate AVP included in the OC-OLR AVP.
>
>    All other elements for the OCS defined in [RFC7683] and
>    [I-D.ietf-dime-agent-overload] also apply to the reporting nodes OCS
>    when using the rate abatement algorithm.
>
>
> _______________________________________________
> DiME mailing list
> DiME@ietf.org
> https://www.ietf.org/mailman/listinfo/dime