[dispatch] draft-ietf-dispatch-mime-protobuf-03 ietf last call Artart review

Darrel Miller via Datatracker <noreply@ietf.org> Sun, 05 October 2025 22:50 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: dispatch@ietf.org
Delivered-To: dispatch@mail2.ietf.org
Received: from [10.244.8.182] (unknown [4.156.85.76]) by mail2.ietf.org (Postfix) with ESMTP id 6FC816DB4620; Sun, 5 Oct 2025 15:50:06 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Darrel Miller via Datatracker <noreply@ietf.org>
To: art@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.50.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <175970460635.3661604.8895346498018962965@dt-datatracker-6c6cdf7f94-h6rnn>
Date: Sun, 05 Oct 2025 15:50:06 -0700
Message-ID-Hash: IBRO4UBHOH2WZ2I4IBAYAUBXZWY2O34E
X-Message-ID-Hash: IBRO4UBHOH2WZ2I4IBAYAUBXZWY2O34E
X-MailFrom: noreply@ietf.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-dispatch.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: dispatch@ietf.org, draft-ietf-dispatch-mime-protobuf.all@ietf.org, last-call@ietf.org
X-Mailman-Version: 3.3.9rc6
Reply-To: Darrel Miller <darrel@tavis.ca>
Subject: [dispatch] draft-ietf-dispatch-mime-protobuf-03 ietf last call Artart review
List-Id: DISPATCH Working Group Mail List <dispatch.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/dispatch/ZwKNzNBrtk80i_8WmE1lxSveFkk>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dispatch>
List-Help: <mailto:dispatch-request@ietf.org?subject=help>
List-Owner: <mailto:dispatch-owner@ietf.org>
List-Post: <mailto:dispatch@ietf.org>
List-Subscribe: <mailto:dispatch-join@ietf.org>
List-Unsubscribe: <mailto:dispatch-leave@ietf.org>

Document: draft-ietf-dispatch-mime-protobuf
Title: Media Type Registration for Protocol Buffers
Reviewer: Darrel Miller
Review result: Ready with Issues

This is an ART area review of
https://www.ietf.org/archive/id/draft-ietf-dispatch-mime-protobuf-03.html

## Issues:

### Section 4. Encoding Considerations

> For binary forms that need to transit non-binary transports, a base64
Content-Transfer-Encoding (xref to [RFC4648]) is recommended.

I worry that this statement might lead people to think they should use this as
a header in HTTP, when RFC7231 says it should not be
https://www.rfc-editor.org/rfc/rfc7231#appendix-A.5.

Perhaps simply saying the following would be safer:

> For binary forms that need to transit non-binary transports, a base64
encoding (xref to [RFC4648]) is recommended.

### 7.1. Registration

> Protobuf implementations should accept all versions of wire encodings defined
at the time of implementation.

Is it appropriate to state this requirement in a media type registration?
Should this not be content of the protobuf specification instead?

## Nits:

### 6. Security Considerations

> While it is common for a protobuf definition to be used as input to a code
generator which then produces something executable, but that applies to the
schema language, not serializations.

There is something grammatically off with the "While ..., but" part of this
sentence. I think the "but" can be removed.

In general this doc looks good to me.

Darrel