Re: [dispatch] Yet Another Shepherd Review of draft-ietf-dispatch-javascript-mjs-04

Ben Campbell <ben@nostrum.com> Tue, 17 September 2019 23:15 UTC

Return-Path: <ben@nostrum.com>
X-Original-To: dispatch@ietfa.amsl.com
Delivered-To: dispatch@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EAF4312003E; Tue, 17 Sep 2019 16:15:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.28
X-Spam-Level:
X-Spam-Status: No, score=-1.28 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, KHOP_HELO_FCRDNS=0.399, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=nostrum.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SwfSIGONMjCs; Tue, 17 Sep 2019 16:15:37 -0700 (PDT)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CBA5212004A; Tue, 17 Sep 2019 16:15:37 -0700 (PDT)
Received: from bens-macbook.lan (cpe-66-25-20-105.tx.res.rr.com [66.25.20.105]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id x8HNFYdD074003 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Tue, 17 Sep 2019 18:15:35 -0500 (CDT) (envelope-from ben@nostrum.com)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nostrum.com; s=default; t=1568762136; bh=5h+iM9cWGO5Z1eb6I7g7qvootnZZ0haTv8W0ZpJqHuM=; h=From:Subject:Date:In-Reply-To:Cc:To:References; b=MA1AlEeLcPXTMXdeAhmIULQJvtMRZ5bdJxSSA08nMdsmVy8Lka5LWefnKrOkUhKtI /HtTILAxP71pUT51QCCe1tMQm5T4ZDxaieO3hWPY9qWnWP1BDCpAOpxh4/LPPQAce7 n3Mz5uA7mM6v36f2uaWuOtZ+KcHXp3zWO96S4XHk=
X-Authentication-Warning: raven.nostrum.com: Host cpe-66-25-20-105.tx.res.rr.com [66.25.20.105] claimed to be bens-macbook.lan
From: Ben Campbell <ben@nostrum.com>
Message-Id: <A44E48E1-B2AC-4091-9B1E-EB4B30223AD3@nostrum.com>
Content-Type: multipart/signed; boundary="Apple-Mail=_70F0AB23-94D2-4859-8427-96F8FBF1EBAB"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Date: Tue, 17 Sep 2019 18:15:27 -0500
In-Reply-To: <28af9e5b-9fef-ead8-89ec-c136d4e3653e@outer-planes.net>
Cc: draft-ietf-dispatch-javascript-mjs.all@ietf.org, dispatch@ietf.org
To: "Matthew A. Miller" <linuxwolf+ietf@outer-planes.net>
References: <C667B153-B02F-4952-BF5A-B6155D7DE57F@nostrum.com> <28af9e5b-9fef-ead8-89ec-c136d4e3653e@outer-planes.net>
X-Mailer: Apple Mail (2.3445.104.11)
Archived-At: <https://mailarchive.ietf.org/arch/msg/dispatch/bxraX26qew6ajYqBApkuAzIqtU0>
Subject: Re: [dispatch] Yet Another Shepherd Review of draft-ietf-dispatch-javascript-mjs-04
X-BeenThere: dispatch@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DISPATCH Working Group Mail List <dispatch.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dispatch>, <mailto:dispatch-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dispatch/>
List-Post: <mailto:dispatch@ietf.org>
List-Help: <mailto:dispatch-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dispatch>, <mailto:dispatch-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Sep 2019 23:15:39 -0000

Thanks for the response! Please see inline.

Ben.

> On Sep 17, 2019, at 6:12 PM, Matthew A. Miller <linuxwolf+ietf@outer-planes.net> wrote:
> 
> Thanks for the latest review, Ben.  We should be able to have the
> editorial changes done very soon, but the substantive comments will take
> longer.  I cannot provide a time frame right now, but should be able to
> update by next week.
> 
> More specific comments inline:
> 
> On 19/09/17 15:50, Ben Campbell wrote:
>> 
>> *** Material Comments/Questions ***
>> 
>> 1) There was at least one WGLC comment that this should obsolete RFC
>> 4329 rather than update it. I recall a comment from Matt that seemed to
>> be agreement with that change. Was there a specific decision not to make
>> the change?
>> 
> 
> I cannot find my original message, but I think was (probably
> unnecessarily) more nuanced than that: I could see how that is valid,
> and asked if doing so would require porting all the maintained content
> from RFC 4329 into this document.
> 
> I admittedly went the route of leaving it alone since I don't recall
> seeing any response to my question, and porting seemed like a
> significant amount of work.
> 
> If changing from "Updates" to "Obsoletes" is enough, I can do that
> fairly quickly.  If porting the content is needed, that will take me
> much longer, but will do that if that's the consensus.

Making it “obsoletes” would require porting content.

I am okay leaving it as is based on the “done is a feature” principle, but don’t be surprised if it gets brought up in IETF LC.

> 
>> 2) The document lacks a Security Considerations section. It may be that
>> there are no new security considerations beyond those in 4329, but if
>> that is the case this document needs to explicitly say (and justify)
>> that.  But please consider whether it is realistic to say we’ve learned
>> nothing new about the security considerations since 4329 was published
>> 13 years ago. (We can expect statements to that effect to get close
>> scrutiny from the secdir reviewer and security ADs.)
>> 
> 
> Reading RFC 4329's existing considerations again, I think they are still
> the most relevant, as surprising as that seems.
> 
> I'll consult with some of my colleagues to get their input before
> submitting an update.

Thanks.

> 
>> *** Editorial Comments ***
>> 
>> §2:
>> - First paragraph:
>> — Missing comma after “modular programs” in the first sentence.
> 
> Changing in my local copy.
> 
>> — Consider s/ “now defines “ / “defines “  ( time-specific language
>> becomes dated pretty quickly)
> 
> I suggest "(starting with 6th Edition) defines "; modules were first
> introduced in ES6, so there is some version sensitivity here.
> 
>> — Consider a brief (no more than one sentence) explanation of the
>> term “goal symbols”
>> 
>> - 2nd paragraph: This is the first mention of “Module or “Script”
>> grammar goals. A very brief explanation of those terms would be helpful.
>> 
> 
> Will do both in my working copy.
> 
>> §3, 2nd paragraph:
>> -  Inconsistent tense.
>> -  consider s/“… specification is using ....”/“… specification uses ...."
>> 
>> 
> 
> Changing both in my working copy.
> 
> 
> Thank you again, Ben!
> 
> - m&m
> 
> Matthew A. Miller
> < http://goo.gl/LM55L >