Re: [dispatch] Éric Vyncke's No Objection on draft-ietf-dispatch-javascript-mjs-12: (with COMMENT)

Mathias Bynens <mths@google.com> Mon, 03 January 2022 13:28 UTC

Return-Path: <mathiasb@google.com>
X-Original-To: dispatch@ietfa.amsl.com
Delivered-To: dispatch@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8D7263A073D for <dispatch@ietfa.amsl.com>; Mon, 3 Jan 2022 05:28:11 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -17.099
X-Spam-Level:
X-Spam-Status: No, score=-17.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x80Z2OOwZ4Is for <dispatch@ietfa.amsl.com>; Mon, 3 Jan 2022 05:28:05 -0800 (PST)
Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CDC643A0744 for <dispatch@ietf.org>; Mon, 3 Jan 2022 05:28:05 -0800 (PST)
Received: by mail-pg1-x52d.google.com with SMTP id s1so28603143pga.5 for <dispatch@ietf.org>; Mon, 03 Jan 2022 05:28:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Hij7PqrYQmMTw5Lcp0jTXiqK11zWDJB35rAlWaakAj8=; b=BRfjgqDiLg4sjg7d9a8u6HJhM/GilKfZtiseGI/06mJqTJqeEG8BjmvbHykvL03fE6 DGJc1ssKdvxd/2ck3PuSx0rzRPPjoSG9i50WSoemZQbzrC7/i8veHSSbGH1MzFiGeY6s rF0+HrGIxy4Kw+T4UTC1N6sXTjEDOEJtQYQvLt80GcOpyccuOHJ7BR5boIXGbIhYd9n7 RRZjEulAsHy5qwTAjJ9zS2nq4Ilrx3aPmk1yah1MHx+cd8tgxLw1mEgKYldGOcunoEPS 6VVWV1FUqa+ueKNBMAKUSbE2Lz9Xb08yFQsnUkFomexEY77uKIvXxORmEPENKTBWOHJF L9gw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hij7PqrYQmMTw5Lcp0jTXiqK11zWDJB35rAlWaakAj8=; b=ru9in5hA4iMORC+mHIFpCBW2UhxND16JRA6hYVx30zNO9/GHHYK68JC73iZH3HtFGI mfzPToIw94D0g4HU5cXlJihMQ68PlsE5XT9FJjM9JRW8hgFKvxgZfYGkiziL62WEcpT7 QqFcdiGN4F+YzRaEgeTARirSkduu3wnb/P4QWj21hbh9Gtd2qg6vCvVFXIlg8wSE8x6r ykOas3fAOatnvdRk1KvODGh8R3i8PP7IgCntrVnkQVUTHTD2YDtT+DdIMkByeT9MEWjy jshBhHzq9/Hh0Dzo3U4bkLr1dmlwBlIefmf6rLH2KpcAJbDuxfFvAlFJAYNw4EnpxG2a vKaw==
X-Gm-Message-State: AOAM531zqlEadnhOj+1LTucdWlLX89PjpgcBd/YbPaBujnclsLIXakDs 7a0cPNYakHCqZRPAP+w0nJu/3+GQPYJeUh93ZtpuZA==
X-Google-Smtp-Source: ABdhPJwuFruBgWJOxk36PQ2yEMQurda/fkcaiV4AqSIAmgsPmbkQaQ/FnNUW7E0fHSRtS4sS1PfNE9tcuzBIypiQd5w=
X-Received: by 2002:a63:141d:: with SMTP id u29mr40140135pgl.412.1641216483759; Mon, 03 Jan 2022 05:28:03 -0800 (PST)
MIME-Version: 1.0
References: <164121216097.11389.15651087256093939724@ietfa.amsl.com> <CADizRgaZE3TRKdH-uCruOikGGEnH1wQF2X6rtqmnLRHKiUKMMQ@mail.gmail.com> <FC6009D4-0D9F-4DF4-8779-E9DF34BD669B@cisco.com>
In-Reply-To: <FC6009D4-0D9F-4DF4-8779-E9DF34BD669B@cisco.com>
From: Mathias Bynens <mths@google.com>
Date: Mon, 03 Jan 2022 14:27:52 +0100
Message-ID: <CADizRga6CmTSE5-_p=fTFQy2+Rgwyt9A=20NUy2X2fdMeA1NAA@mail.gmail.com>
To: "Eric Vyncke (evyncke)" <evyncke@cisco.com>
Cc: The IESG <iesg@ietf.org>, "draft-ietf-dispatch-javascript-mjs@ietf.org" <draft-ietf-dispatch-javascript-mjs@ietf.org>, dispatch chairs <dispatch-chairs@ietf.org>, DISPATCH WG <dispatch@ietf.org>, Ben Campbell <ben@nostrum.com>
Content-Type: multipart/alternative; boundary="00000000000084616605d4ad7db9"
Archived-At: <https://mailarchive.ietf.org/arch/msg/dispatch/oei1YsJuiwEquOKXflZFj158gFA>
Subject: Re: [dispatch] Éric Vyncke's No Objection on draft-ietf-dispatch-javascript-mjs-12: (with COMMENT)
X-BeenThere: dispatch@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DISPATCH Working Group Mail List <dispatch.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dispatch>, <mailto:dispatch-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dispatch/>
List-Post: <mailto:dispatch@ietf.org>
List-Help: <mailto:dispatch-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dispatch>, <mailto:dispatch-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Jan 2022 13:28:12 -0000

Thank you! Patch amended:
https://github.com/linuxwolf/bmeck-ids/pull/59/files I’ll land this and
will cut a new draft version including these changes.

On Mon, Jan 3, 2022 at 2:04 PM Eric Vyncke (evyncke) <evyncke@cisco.com>
wrote:

> Thank you, Mathias, for your prompt reply.
>
>
>
> About the TC39 point, may I suggest the text "The ECMA Technical Committee
> 29 (TC29), the standards body for ECMAscript, has determined..." ?
>
>
>
> All other remarks accepted.
>
>
>
> Regards
>
>
>
> -éric
>
>
>
> *From: *Mathias Bynens <mths@google.com>
> *Date: *Monday, 3 January 2022 at 13:43
> *To: *Eric Vyncke <evyncke@cisco.com>
> *Cc: *The IESG <iesg@ietf.org>, "
> draft-ietf-dispatch-javascript-mjs@ietf.org" <
> draft-ietf-dispatch-javascript-mjs@ietf.org>, dispatch chairs <
> dispatch-chairs@ietf.org>, DISPATCH WG <dispatch@ietf.org>, Ben Campbell <
> ben@nostrum.com>
> *Subject: *Re: Éric Vyncke's No Objection on
> draft-ietf-dispatch-javascript-mjs-12: (with COMMENT)
>
>
>
> Thanks for taking a look, Éric. On behalf of the authors, I’ll respond to
> your comments inline:
>
>
>
> On Mon, Jan 3, 2022 at 1:16 PM Éric Vyncke via Datatracker <
> noreply@ietf.org> wrote:
>
> Éric Vyncke has entered the following ballot position for
> draft-ietf-dispatch-javascript-mjs-12: No Objection
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to https://www.ietf.org/blog/handling-iesg-ballot-positions/
> for more information about how to handle DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-dispatch-javascript-mjs/
>
>
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> Thank you for the work put into this document.
>
> Please find below ssome non-blocking COMMENT points (but replies would be
> appreciated even if only for my own education), and some nits.
>
> Special thanks to Ben Campbell for the shepherd's write-up including the
> section about the WG consensus for this update and on RFC 4329.
>
> I hope that this helps to improve the document,
>
> Regards,
>
> -éric
>
> == COMMENTS ==
>
> -- Section 3 --
>
> Is TC39 so well-known by the IETF community that no expansion/explanation
> is
> required?
>
>
>
> TC39 is the standards body in charge of ECMAScript, a.k.a. the JavaScript
> language. The only mention of “TC39” in the draft gives the following
> context:
>
>
>
> ```
>
>    The TC39 standards body for ECMAScript has determined that media
>
>    types are outside of their scope of work [TC39-MIME-ISSUE].
>
> ```
>
>
>
> What would you consider to be missing? Happy to expand on this.
>
>
>
> -- Section 5 --
> This security section is pretty extensive (good thing) and I wonder
> whether it
> is relevant to this document as it is not related to the media types
> themselves
> but more on the scripting language itself.
>
>
>
> Two notes:
>
>
>
> 1. The security section builds upon the one from RFC4329 (
> https://datatracker.ietf.org/doc/html/rfc4329#section-5) which our draft
> aims to supersede. Removing it would be a regression.
>
> 2. I see your point — the security risks are *mostly* related to the
> language. IMHO the security section is still worth including, as for e.g.
> browser implementations, the MIME type is what determines whether a given
> resource is processed as a script or not. Thus, failing to respect the
> media types as stated (e.g. accepting additional, non-standard media types
> as if they were JavaScript) would constitute a security risk.
>
>
>
> == NITS ==
>
> -- Section 4.2 --
> Suggestion, add "else" on steps 2 and 3 to be clear.
>
>
>
> This section was inherited from RFC4329 as-is, and we’ve been hesitant to
> make changes to it. However, this change seems small and harmless enough,
> so I’ve prepared a patch here:
> https://github.com/linuxwolf/bmeck-ids/pull/59
>