Re: [dispatch] Yet Another Shepherd Review of draft-ietf-dispatch-javascript-mjs-04

"Matthew A. Miller" <linuxwolf+ietf@outer-planes.net> Tue, 17 September 2019 23:12 UTC

Return-Path: <linuxwolf+ietf@outer-planes.net>
X-Original-To: dispatch@ietfa.amsl.com
Delivered-To: dispatch@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 52CFB12004F for <dispatch@ietfa.amsl.com>; Tue, 17 Sep 2019 16:12:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=outer-planes-net.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FR2-l9yoFSMH for <dispatch@ietfa.amsl.com>; Tue, 17 Sep 2019 16:12:19 -0700 (PDT)
Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 425E812004A for <dispatch@ietf.org>; Tue, 17 Sep 2019 16:12:19 -0700 (PDT)
Received: by mail-io1-xd2b.google.com with SMTP id k5so11713002iol.5 for <dispatch@ietf.org>; Tue, 17 Sep 2019 16:12:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outer-planes-net.20150623.gappssmtp.com; s=20150623; h=sender:subject:to:cc:references:from:openpgp:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9uxGVeqH0e6OjGlvweRBfTCXd2kEwKZPj/sMCpp4MqI=; b=0/piybiHEmmzR+ucDHVlB8Knwt6PJdOefp/u1xMeGrTPLZGKwR7MziW55qULUZ01Dg Biuo/bsVo/MLf7LZ1Q2f7agZJPvb0OGjc++MSUoE7fQ3/28pAJL+51UfIMJtU9OKcOV0 FxqDzaGbeCUlAO8Pt91m6P9tG52AylX2lXevomsSMWMFCzTMAvsE0eemL9e2vtLj/IDE vqwWXGQVpf4ySrtOB782B77jPLDV187O7W/auhLPdZa8HDBHi7/YtlbR7FlruJAEuSlD Z0yo7lYo4JpoT7zZH9oat8KKHA+jVnmLq4gpUpgF+eaqIUCk63YjifMMeWOmRw7CPepC x7cw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:openpgp :autocrypt:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=9uxGVeqH0e6OjGlvweRBfTCXd2kEwKZPj/sMCpp4MqI=; b=n60t9oNw6M5JhyoSLUgaAIAdl5aLKpdJB9+hAfPx/A9PP020G/IgfNes4Ny1LoIJ92 TTrCS8Ggm/S8FCaAItOjEsivUo31eXU8TnUi+ZFj9SnQ8Dnl/cu7/vdo7x2OVXxhRFA4 ewet31wGDprm8C5H8A78RPuWGPJr+B6Ua2pktmK6sPLdkkJS49VcwJ5Pszw8Su/t5EK+ 0FH7qY6egJlWsDg3WjMQEbYoPa44QCqfPH1ufU5MJ8iWmrb4md5IYjpdHmLa+9jVqJCu p6tQv/d/p65p1RtMqLdEBXaEKEcrQu3puUifx3qtnVbOwsczGeWESI7J1Iv9hgjKhDGX fc3Q==
X-Gm-Message-State: APjAAAUPA2hXUqWALO9PXZADP6ZX4gQAxsr8OYyGw6eWw68YDIXGYI+U lE7FWEblGdAoGjvx4RQr5bX+a+QKZ9kslqJ9
X-Google-Smtp-Source: APXvYqz0G+VzLSC1C6ZX2Fs89eprPC4Z9TpOL7wdytLvO/V1d60XdCPvakcwW4dta4e6umB4Iq38Lg==
X-Received: by 2002:a6b:bd42:: with SMTP id n63mr1784731iof.53.1568761938092; Tue, 17 Sep 2019 16:12:18 -0700 (PDT)
Received: from mmiller-44677.local ([74.220.34.132]) by smtp.gmail.com with ESMTPSA id l186sm5686466ioa.54.2019.09.17.16.12.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Sep 2019 16:12:17 -0700 (PDT)
Sender: Matthew Miller <linuxwolf@outer-planes.net>
To: Ben Campbell <ben@nostrum.com>, draft-ietf-dispatch-javascript-mjs.all@ietf.org
Cc: dispatch@ietf.org
References: <C667B153-B02F-4952-BF5A-B6155D7DE57F@nostrum.com>
From: "Matthew A. Miller" <linuxwolf+ietf@outer-planes.net>
Openpgp: preference=signencrypt
Autocrypt: addr=linuxwolf+ietf@outer-planes.net; prefer-encrypt=mutual; keydata= mQENBFJoAooBCADQmEtpbpY/4wTeKgZIuyG7HkxIFgiUeqOvtiBKj/pCA73d7Q5hCvQdGcKJ 6uZsYz3Il9oKoKFxVt90iEXspbE39g6ek19e6RsB4j0Q10l4QvH+EqeD760gs0H2yf/eYj9i uk9/VY6axdQlPsmid1zoQgCNjSM7X4/K26WGMs03sbXJpKdoonelzIlJSNfzi0q546iplo72 D2cCm9BriMkQvcGnsm4B9eBIBn3GKmVx1tsmPNeNTyun2DvaLnrYxbA0Ivo1DzZReds9NZ25 uROI/+b+lcg9/kmHzhK+q8NMQCFWmqpS/lZRKxVBSijKGpGr5h8VLVf5iURHtwG+B/QxABEB AAG0M01hdHRoZXcgQS4gTWlsbGVyIDxsaW51eHdvbGYraWV0ZkBvdXRlci1wbGFuZXMubmV0 PokBPQQTAQoAJwUCWKsJ1AIbAwUJC8ckMQULCQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRDs 9HJOEJ4Fu1iBCADAcW06d/7GTlBjTlYuMGgjzDBoWeQ9/zxgMnSrgNb6yO7wHzE65CeFs6OI 6LQ4A34CNM3hhcWDIzlqrV25fVyy7qCh6bCNMs1pOT63+Od4kcjHtUnGGTONT5fXSGY7mCtl XJFjb3TwyLUZXQCifhCIaUdF/4SVoGk96W9ssbDKN+5xq7B7gyVkwB0WM67zxt/kC6TPcXXL 5m7jsNRpRmFQqOlIF+HrQAcSr1lKRWgetb1VHfXCgcmDaTKn1QC7s0Ml+27dc0SoIkBI8cnv inJ4oFYWrvnTlOvv+v8AFXZnPrxZ/JYvnVD/y5PX7v08Z8RFXm1AmVxIWjXPI6TySkGvuQEN BFJoAooBCADA/ruHwYlQ7pdjJY6twkZcMmedkQNL6r5tNBeQkwVrvitUjHTKKipjxB2kEkUZ oxPgMI1h7/enDrVlMMMqq6RIJ86H+yx13zNIZNBlJfmVHgHj7TT8spa6A/qIccdiIRNsFVvl vFxpH8sTjVbHfPYexbdOR5kHpZWTzYxNyVLXMK5jen0B4K+vjbgFJAvsoLfzLZ5Bz3kb6dpu xUNzqhDyhk5/UPaCIFvZWBtiRKmkqPwEq8G2aMJq5Z4Sr8CRkpoMB25rxCPS8R+ByiHxpq+U 8mKuqPVg1LJzcA7hHmms8aBN6lxSlbyKnzEg8AWgld+6+xlJXu5U/fqDAClTj5mfABEBAAGJ ATwEGAEKACYCGwwWIQQx11iN7JBpDWvMmODs9HJOEJ4FuwUCWm+kiwUJC8tagQAKCRDs9HJO EJ4Fu40cB/9xyEnuQegivmL6OBVG5HvUAaXGUxtWiWdLm3NrduL0h7rctF060xQTekNRCjbl xZ1w/unPDBEEIMPYbF8i7IwJZoRLTG1B1MjI04AUU60G0IU6uw0ST6IsC7oYGvhDNJApbVBb j9u9x+kzaktCftl3qdpSKgRh9McIyZgevuFBdo80RDtX8niktUA3xsfJWBD1yJA33UNSzqOe 54wFRbsM2+4erREPMD659h2lACPCXjPW/6ucnv0/cdPF8V2JNMCT0yPJVCSUfFLTrtyYtiRI 6S52cI4eEOZIXCQp30TA4E27O2mMLOYzlKA5P5T+Icf4gz8e/puNUKIBDlY6KF7p
Message-ID: <28af9e5b-9fef-ead8-89ec-c136d4e3653e@outer-planes.net>
Date: Tue, 17 Sep 2019 17:12:16 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:60.0) Gecko/20100101 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <C667B153-B02F-4952-BF5A-B6155D7DE57F@nostrum.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/dispatch/rd1RWowBShwxc5NlgFm9RsiJT88>
Subject: Re: [dispatch] Yet Another Shepherd Review of draft-ietf-dispatch-javascript-mjs-04
X-BeenThere: dispatch@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DISPATCH Working Group Mail List <dispatch.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dispatch>, <mailto:dispatch-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dispatch/>
List-Post: <mailto:dispatch@ietf.org>
List-Help: <mailto:dispatch-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dispatch>, <mailto:dispatch-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Sep 2019 23:12:21 -0000

Thanks for the latest review, Ben.  We should be able to have the
editorial changes done very soon, but the substantive comments will take
longer.  I cannot provide a time frame right now, but should be able to
update by next week.

More specific comments inline:

On 19/09/17 15:50, Ben Campbell wrote:
> 
> *** Material Comments/Questions *** 
> 
> 1) There was at least one WGLC comment that this should obsolete RFC
> 4329 rather than update it. I recall a comment from Matt that seemed to
> be agreement with that change. Was there a specific decision not to make
> the change?
> 

I cannot find my original message, but I think was (probably
unnecessarily) more nuanced than that: I could see how that is valid,
and asked if doing so would require porting all the maintained content
from RFC 4329 into this document.

I admittedly went the route of leaving it alone since I don't recall
seeing any response to my question, and porting seemed like a
significant amount of work.

If changing from "Updates" to "Obsoletes" is enough, I can do that
fairly quickly.  If porting the content is needed, that will take me
much longer, but will do that if that's the consensus.

> 2) The document lacks a Security Considerations section. It may be that
> there are no new security considerations beyond those in 4329, but if
> that is the case this document needs to explicitly say (and justify)
> that.  But please consider whether it is realistic to say we’ve learned
> nothing new about the security considerations since 4329 was published
> 13 years ago. (We can expect statements to that effect to get close
> scrutiny from the secdir reviewer and security ADs.)
> 

Reading RFC 4329's existing considerations again, I think they are still
the most relevant, as surprising as that seems.

I'll consult with some of my colleagues to get their input before
submitting an update.

> *** Editorial Comments ***
> 
> §2:
> - First paragraph:
> — Missing comma after “modular programs” in the first sentence.

Changing in my local copy.

> — Consider s/ “now defines “ / “defines “  ( time-specific language
> becomes dated pretty quickly)

I suggest "(starting with 6th Edition) defines "; modules were first
introduced in ES6, so there is some version sensitivity here.

> — Consider a brief (no more than one sentence) explanation of the
> term “goal symbols”
> 
> - 2nd paragraph: This is the first mention of “Module or “Script”
> grammar goals. A very brief explanation of those terms would be helpful.
> 

Will do both in my working copy.

> §3, 2nd paragraph: 
> -  Inconsistent tense.
> -  consider s/“… specification is using ....”/“… specification uses ...."
> 
> 

Changing both in my working copy.


Thank you again, Ben!

- m&m

Matthew A. Miller
< http://goo.gl/LM55L >