Re: [DMM] YANG validation issue in draft-ietf-dmm-fpc-cpdp-06.txt

Radek Krejčí <rkrejci@cesnet.cz> Mon, 13 March 2017 13:39 UTC

Return-Path: <rkrejci@cesnet.cz>
X-Original-To: dmm@ietfa.amsl.com
Delivered-To: dmm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3A408129625; Mon, 13 Mar 2017 06:39:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.3
X-Spam-Level:
X-Spam-Status: No, score=-4.3 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cesnet.cz
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1ut_mgFwIzLx; Mon, 13 Mar 2017 06:39:32 -0700 (PDT)
Received: from office2.cesnet.cz (office2.cesnet.cz [IPv6:2001:718:1:101::144:244]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F382E12961D; Mon, 13 Mar 2017 06:39:31 -0700 (PDT)
Received: from [IPv6:2001:67c:1220:80c:921b:eff:fe59:4360] (unknown [IPv6:2001:67c:1220:80c:921b:eff:fe59:4360]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by office2.cesnet.cz (Postfix) with ESMTPSA id 94FD6200E1; Mon, 13 Mar 2017 14:39:29 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cesnet.cz; s=office2; t=1489412369; bh=XCoycGEkI/3My5iQ564ddwYBpUXF7H+Dm8GNRrUz/fk=; h=Subject:To:References:From:Date:In-Reply-To; b=qi3L/+rkHFh2z2bkYUZawc+dzIJd/ggFUE+bOk35bNyDliK4rrWN0ca59zmBuQBvq 6XNm06ye2kPnX+Ve+5Zw1/TlaeKFUZ3cwxjTIPg0G2M5+D8YXZ1+ai+SnRbBxV9H5O 8eyFxLFZ0sJyfPbW618dr34isDPIYrdxVmaHzRBE=
To: Benoit Claise <bclaise@cisco.com>, "Bertz, Lyle T [CTO]" <Lyle.T.Bertz@sprint.com>, "draft-ietf-dmm-fpc-cpdp@ietf.org" <draft-ietf-dmm-fpc-cpdp@ietf.org>, "dmm@ietf.org" <dmm@ietf.org>, Per Hedeland <per@tail-f.com>
References: <18543b91-876c-7f41-f31f-1f670117a811@cisco.com> <86fd433ecc0c48adbc304eb22401ec4b@plswe13m04.ad.sprint.com> <723ff824-19a5-768b-754e-85216c63cd43@cisco.com>
From: Radek Krejčí <rkrejci@cesnet.cz>
Message-ID: <4e559c8d-7a72-3878-9197-e6aaba8da4cd@cesnet.cz>
Date: Mon, 13 Mar 2017 14:39:13 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <723ff824-19a5-768b-754e-85216c63cd43@cisco.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/dmm/r7RjhS_JHN8FKOZQnclZe6TnwM0>
Subject: Re: [DMM] YANG validation issue in draft-ietf-dmm-fpc-cpdp-06.txt
X-BeenThere: dmm@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Distributed Mobility Management Working Group <dmm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dmm>, <mailto:dmm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dmm/>
List-Post: <mailto:dmm@ietf.org>
List-Help: <mailto:dmm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dmm>, <mailto:dmm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Mar 2017 13:39:34 -0000

Hi,
some notes to warnings from yanglint:

- each two warnings are actually connected in this case, so let's look to the first issue:
warn: Schema node "attributetype" not found (../attributetype).
warn: Invalid when condition "../attributetype = 'Per-MN-Agg-Max-DL-Bit-Rate-type'". (/ietf-dmm-fpc:tenants/tenant/fpc-mobility/contexts/ul/qos-profile-parameters/value/ietf-dmm-fpc-pmip:qos-pmip/attribute-choice/per-mn-agg-max-dl-case) 

- attributetype node, used in the when condition as "../attributetype", was not found
- the when condition is placed in the node with the path printed at the end of the second message in the brackets
- when you look into the schema, the node with when is actually placed into ietf-dmm-fpc-pmip via uses in one of the augments, used grouping qosattribute is from ietf-pmip-qos
- so the actual bug is in ietf-pmip-qos schema in grouping qosattribute - instead of ../attributetype there should be ./attributetype because the context node for the when in case statement is the closets ancestor node to the node with the "when" statement that is a data node

Regards,
Radek


Dne 13.3.2017 v 14:19 Benoit Claise napsal(a):
> Including Radek (developing yanglint) and Per (confd), in case they've got the bandwidth to help you.
>
> Regards, Benoit
>> We will as soon as we can isolate the error.  The error is unhelpful.  Do you have any guidance on it?
>>
>> Also, is there any way to rid ourselves of those tailf warnings?  They happen quite often and our developers now ignore most errors coming from confd as noise.
>>
>> -----Original Message-----
>> From: dmm [mailto:dmm-bounces@ietf.org] On Behalf Of Benoit Claise
>> Sent: Monday, March 13, 2017 6:17 AM
>> To: draft-ietf-dmm-fpc-cpdp@ietf.org; dmm@ietf.org
>> Subject: [DMM] YANG validation issue in draft-ietf-dmm-fpc-cpdp-06.txt
>>
>> Dear authors,
>>
>> I see that you have posted a new draft version. Great.
>> Note that ietf-dmm-fpc-pmip@2017-03-08.yang still fails validation.
>> See https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.claise.be%2FIETFYANGPageCompilation.html&data=02%7C01%7Clyle.t.bertz%40sprint.com%7C05650ca67a00476a5b9008d46a03b748%7C4f8bc0acbd784bf5b55f1b31301d9adf%7C0%7C0%7C636250011571481523&sdata=RwDlcOxUAxOoCew0qs9nMQsjbtZ0vXQ4HgUKL8ABdn8%3D&reserved=0
>> Please correct the mistake and post a new version.
>>
>> Regards, Benoit
>>
>> _______________________________________________
>> dmm mailing list
>> dmm@ietf.org
>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.org%2Fmailman%2Flistinfo%2Fdmm&data=02%7C01%7Clyle.t.bertz%40sprint.com%7C05650ca67a00476a5b9008d46a03b748%7C4f8bc0acbd784bf5b55f1b31301d9adf%7C0%7C0%7C636250011571481523&sdata=u5sSjji78baaTpWJkQWc0Wk2Y1AjtzRhWkSJAn5cgcQ%3D&reserved=0
>>
>> ________________________________
>>
>> This e-mail may contain Sprint proprietary information intended for the sole use of the recipient(s). Any use by others is prohibited. If you are not the intended recipient, please contact the sender and delete all copies of the message.
>> .
>>

-- 
Radek Krejci
mobile  : +420 732 212 714
office  : +420 234 680 256
e-mail  : rkrejci@cesnet.cz
LinkedIn: http://www.linkedin.com/in/radekkrejci

CESNET, Association of Legal Entities
Zikova 4
160 00 Praha 6
Czech Republic