Re: [dns-privacy] [Gen-art] Genart last call review of draft-ietf-dprive-xfr-over-tls-09

Lars Eggert <lars@eggert.org> Fri, 30 April 2021 13:26 UTC

Return-Path: <lars@eggert.org>
X-Original-To: dns-privacy@ietfa.amsl.com
Delivered-To: dns-privacy@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 84E243A17E2; Fri, 30 Apr 2021 06:26:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zGgH2QFRctMP; Fri, 30 Apr 2021 06:25:57 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [91.190.195.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 87D1C3A17DF; Fri, 30 Apr 2021 06:25:56 -0700 (PDT)
Received: from smtpclient.apple (unknown [IPv6:2a00:ac00:4000:400:e984:d163:77c6:d3e5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id BA25E600349; Fri, 30 Apr 2021 16:25:45 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1619789146; bh=8KcPgdHSke6UEdUx5qxeu5h5UPPlTHQ+Gh1Y2TxZQQY=; h=From:Subject:Date:In-Reply-To:Cc:To:References; b=UFlVk/9pPQH+qh5y33wU+twpU2neuRgeQX25RgynIugtaqHPl5ztE7WmfvTIi+HTk me8qoHsjyCj4gMJL31dlmBkN0EKXrNF30P8ho2l3q7KjxdVHLrIn4SnkMUCQX9EDLK 9Iw0MakxNR/3urF8YfGwfMmls44vUVmyyMexW/oc=
From: Lars Eggert <lars@eggert.org>
Message-Id: <28B23EE0-FB59-49A3-8739-88C2FF6387CF@eggert.org>
Content-Type: multipart/signed; boundary="Apple-Mail=_6369EC88-FEF7-48FD-ACFE-BB4E285531B9"; protocol="application/pgp-signature"; micalg=pgp-sha512
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.80.0.2.43\))
Date: Fri, 30 Apr 2021 16:25:45 +0300
In-Reply-To: <161865263565.11494.11842811379172646764@ietfa.amsl.com>
Cc: gen-art@ietf.org, last-call@ietf.org, dns-privacy@ietf.org, draft-ietf-dprive-xfr-over-tls.all@ietf.org
To: Dan Romascanu <dromasca@gmail.com>
References: <161865263565.11494.11842811379172646764@ietfa.amsl.com>
X-Mailer: Apple Mail (2.3654.80.0.2.43)
X-MailScanner-ID: BA25E600349.A43A4
X-MailScanner: Found to be clean
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/dns-privacy/HAOMHFgboyuGUO8PF-c5uun5Wus>
Subject: Re: [dns-privacy] [Gen-art] Genart last call review of draft-ietf-dprive-xfr-over-tls-09
X-BeenThere: dns-privacy@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <dns-privacy.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dns-privacy>, <mailto:dns-privacy-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dns-privacy/>
List-Post: <mailto:dns-privacy@ietf.org>
List-Help: <mailto:dns-privacy-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dns-privacy>, <mailto:dns-privacy-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Apr 2021 13:26:02 -0000

Dan, thank you for your review. I have entered a No Objection ballot for this document.

Lars


> On 2021-4-17, at 12:43, Dan Romascanu via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Dan Romascanu
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-dprive-xfr-over-tls-09
> Reviewer: Dan Romascanu
> Review Date: 2021-04-17
> IETF LC End Date: 2021-04-20
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> 
> Ready with nits.
> 
> This document specifies XFR-over-TLS (XoT) i.e. the use of TLS, rather than
> clear text, to prevent zone content collection via passive monitoring of DNS
> zone transfers. This is a very clear and well-written document. I had to do
> further reading to understand some of the specified or referred concepts and
> mechanisms, but after doing it all aligned nicely. I especially appreciate the
> inclusion and level of detail of Section 7 which explains the updates to the
> existing specifications, including the RFCs updated by this document and
> clarifies the issues of backwards compatibility. There are a few nits that I
> suggest to address before publication.
> 
> Major issues:
> 
> Minor issues:
> 
> Nits/editorial comments:
> 
> 1. In Section 3:
> 
>> XoT: Generic XFR-over-TLS mechanisms as specified in this document
> 
> What does 'Generic' mean here? Are there also non-generic / specific mechanisms
> similar to XoT that should be referenced? If not, consider dropping 'Generic'
> 
> 2. In Section 5 there are two Design Considerations labelled both Performance.
> Is this the intent? If yes, maybe they should be grouped together. If not maybe
> at least one of the name may be changed.
> 
> 3. Should not the fact that implementations MUST use TLS 1.3 or higher, which
> is specified in Section 8.1, be also mentioned in the Introduction?
> 
> 4. Section 9 uses in one instance the term 'multi-master'. Can an alternative
> term be considered, taking into account the work summarized in I-Ds such as
> https://datatracker.ietf.org/doc/draft-knodel-terminology/?
> 
> 5. I assume that Section 20 - Changelog will be removed before publication
> 
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art