[dnsdir] Dnsdir last call review of draft-ietf-opsawg-add-encrypted-dns-07
Ralf Weber via Datatracker <noreply@ietf.org> Wed, 11 January 2023 12:14 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: dnsdir@ietf.org
Delivered-To: dnsdir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id AEAE3C14CE24; Wed, 11 Jan 2023 04:14:04 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Ralf Weber via Datatracker <noreply@ietf.org>
To: dnsdir@ietf.org
Cc: draft-ietf-opsawg-add-encrypted-dns.all@ietf.org, last-call@ietf.org, opsawg@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 9.5.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <167343924470.16375.13847025325924435887@ietfa.amsl.com>
Reply-To: Ralf Weber <ralf.weber@akamai.com>
Date: Wed, 11 Jan 2023 04:14:04 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/dnsdir/i_NsZg-HDWP3fdA29NlWy_nL6N0>
Subject: [dnsdir] Dnsdir last call review of draft-ietf-opsawg-add-encrypted-dns-07
X-BeenThere: dnsdir@ietf.org
X-Mailman-Version: 2.1.39
List-Id: DNS Directorate <dnsdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dnsdir>, <mailto:dnsdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dnsdir/>
List-Post: <mailto:dnsdir@ietf.org>
List-Help: <mailto:dnsdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dnsdir>, <mailto:dnsdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jan 2023 12:14:04 -0000
Reviewer: Ralf Weber Review result: Ready with Nits Moin! I'm the assigned reviewer of the DNS Directorate for this draft. Given that the add working group defines drafts for getting encrypted DNS resolver settings to clients I was initially surprised to see this draft coming from ops area to the DNS directorate for review. However looking into while reviewing it is this has become clear as the attributes defined by add DNR draft are just one user of the specification of this draft. The draft uses and existing specifications on interactions between DHCP and Radius and adds DNR as one use case. As such while the draft was started with, explains this use case and does so fine there is not much for the DNS directorate to review. I see this draft as ready with the following nits: - The table of attributes under 7 Table of attributes only have two values which both start with 0. As the main distinction is that attributes MUST NOT appear when 0 is there and MAY appeare when 0+ is defined making this boolean with e.g Y/N seems easier to understand IMHO. - In 8.1 New Radius Attributes the table is called "Table 1: Encrypted DNS RADIUS Attributes", while the table describer generic DHCP Options attributes. The table name should reflect that. So long -Ralf
- [dnsdir] Dnsdir last call review of draft-ietf-op… Ralf Weber via Datatracker
- Re: [dnsdir] Dnsdir last call review of draft-iet… mohamed.boucadair
- Re: [dnsdir] Dnsdir last call review of draft-iet… Joe Clarke (jclarke)
- Re: [dnsdir] [OPSAWG] Dnsdir last call review of … Eric Vyncke (evyncke)
- Re: [dnsdir] Dnsdir last call review of draft-iet… Ralf Weber