Re: [DNSOP] I-D Action: draft-ietf-dnsop-extended-error-12.txt

Tim Wattenberg <mail@timwattenberg.de> Sat, 16 November 2019 08:51 UTC

Return-Path: <mail@timwattenberg.de>
X-Original-To: dnsop@ietfa.amsl.com
Delivered-To: dnsop@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9817112004D for <dnsop@ietfa.amsl.com>; Sat, 16 Nov 2019 00:51:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f7XRNmZxKmeY for <dnsop@ietfa.amsl.com>; Sat, 16 Nov 2019 00:51:18 -0800 (PST)
Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0C33D120127 for <dnsop@ietf.org>; Sat, 16 Nov 2019 00:51:17 -0800 (PST)
Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 47FTTb2973zKmdM for <dnsop@ietf.org>; Sat, 16 Nov 2019 09:51:15 +0100 (CET)
X-Virus-Scanned: amavisd-new at heinlein-support.de
Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id x-qAAHzrlVEP for <dnsop@ietf.org>; Sat, 16 Nov 2019 09:51:11 +0100 (CET)
From: Tim Wattenberg <mail@timwattenberg.de>
Content-Type: multipart/signed; boundary="Apple-Mail=_D2586798-BDA8-4883-A40F-B5BE82EE9995"; protocol="application/pkcs7-signature"; micalg=sha-256
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Date: Sat, 16 Nov 2019 16:51:07 +0800
References: <156997343802.26389.15326556193059712475@ietfa.amsl.com>
To: dnsop <dnsop@ietf.org>
In-Reply-To: <156997343802.26389.15326556193059712475@ietfa.amsl.com>
Message-Id: <E5E70A25-353F-4EB6-BDCD-36381A756B86@timwattenberg.de>
Archived-At: <https://mailarchive.ietf.org/arch/msg/dnsop/4w15caxSGhod8EgRTBIdQGqmY8I>
Subject: Re: [DNSOP] I-D Action: draft-ietf-dnsop-extended-error-12.txt
X-BeenThere: dnsop@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF DNSOP WG mailing list <dnsop.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dnsop>, <mailto:dnsop-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dnsop/>
List-Post: <mailto:dnsop@ietf.org>
List-Help: <mailto:dnsop-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dnsop>, <mailto:dnsop-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Nov 2019 08:51:22 -0000

(Sorry for the belated feedback.)

I was just reading the document to work on some early implementation during the Hackathon and noticed a small inconsistency:
Section 2 defines the wire-format and states for the OPTION-LENGTH it „[…] should be 4 plus the length of the EXTRA-TEXT section (which may be a zero-length string)“.
However, I think the length is meant to be *2* plus the length of the text and this is still a remnant of an earlier version.

For the sake of consistency, you might also think about using the „2-octets/16-bits“ notation for the INFO-CODE definition as well.

	– Tim

> Am 02.10.2019 um 07:43 schrieb internet-drafts@ietf.org:
> 
> 
> A New Internet-Draft is available from the on-line Internet-Drafts directories.
> This draft is a work item of the Domain Name System Operations WG of the IETF.
> 
>        Title           : Extended DNS Errors
>        Authors         : Warren Kumari
>                          Evan Hunt
>                          Roy Arends
>                          Wes Hardaker
>                          David C Lawrence
> 	Filename        : draft-ietf-dnsop-extended-error-12.txt
> 	Pages           : 14
> 	Date            : 2019-10-01
> 
> Abstract:
>   This document defines an extensible method to return additional
>   information about the cause of DNS errors.  Though created primarily
>   to extend SERVFAIL to provide additional information about the cause
>   of DNS and DNSSEC failures, the Extended DNS Errors option defined in
>   this document allows all response types to contain extended error
>   information.  Extended DNS Error information does not change the
>   processing of RCODEs.
> 
> 
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-dnsop-extended-error/
> 
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-dnsop-extended-error-12
> https://datatracker.ietf.org/doc/html/draft-ietf-dnsop-extended-error-12
> 
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-dnsop-extended-error-12
> 
> 
> Please note that it may take a couple of minutes from the time of submission
> until the htmlized version and diff are available at tools.ietf.org.
> 
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
> 
> _______________________________________________
> DNSOP mailing list
> DNSOP@ietf.org
> https://www.ietf.org/mailman/listinfo/dnsop