[DNSOP] Genart last call review of draft-ietf-dnsop-session-signal-10

Joel Halpern <jmh@joelhalpern.com> Fri, 15 June 2018 10:17 UTC

Return-Path: <jmh@joelhalpern.com>
X-Original-To: dnsop@ietf.org
Delivered-To: dnsop@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id E7DB3130DE7; Fri, 15 Jun 2018 03:17:46 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Joel Halpern <jmh@joelhalpern.com>
To: <gen-art@ietf.org>
Cc: draft-ietf-dnsop-session-signal.all@ietf.org, dnsop@ietf.org, ietf@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.81.2
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <152905786692.616.15447306397991349016@ietfa.amsl.com>
Date: Fri, 15 Jun 2018 03:17:46 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/dnsop/Eg9zE9eHJ3CQPp3oNClDqyt4Bus>
Subject: [DNSOP] Genart last call review of draft-ietf-dnsop-session-signal-10
X-BeenThere: dnsop@ietf.org
X-Mailman-Version: 2.1.26
List-Id: IETF DNSOP WG mailing list <dnsop.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dnsop>, <mailto:dnsop-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dnsop/>
List-Post: <mailto:dnsop@ietf.org>
List-Help: <mailto:dnsop-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dnsop>, <mailto:dnsop-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jun 2018 10:17:47 -0000

Reviewer: Joel Halpern
Review result: Ready with Issues

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-dnsop-session-signal-10
Reviewer: Joel Halpern
Review Date: 2018-06-15
IETF LC End Date: 2018-06-25
IESG Telechat date: Not scheduled for a telechat

Summary: This document is ready for publication as a Proposed Standard.
    Also, the document is well-written and clear.

Major issues:

Minor issues:
    Section 5.1.3 places some requirements on application level middleboxes,
    and includes a very clear explanation of why it places these requirements. 
    While it may be "obvious" to one who lives and breathes DNS, I think it
    would help to explain why the usual operation of an existing middlebox will
    (typically? always?  inherently?) meet this requirement.

    The third and fourth paragraphs of section 5.2.2 do not talk about optional
    additional TLVs.  It would be helpful if the document stated that in
    addition to those additional TLVs required by the primary TLV, other TLVs
    may be included based on their individual definition, independent of the
    definition of the primary TLV.  (Both the Encryption padding and the delay
    retry TLVs may be included in suitable messages without being called out in
    the definition of the primary TLVs.)

Nits/editorial comments:
    Section 5.4 talks about by default the TCP data ack and the DSO reply
    message being combined.  Doesn't this depend upon the responsiveness of the
    DSO engine?  Is there an implicit assumption about such timeliness (sub 200
    ms)?

    In section 7.1, the description of the Keepalive message seems to be
    missing the explicit sentence that a keepalive response MUST contain a
    Keepalive TLV.  I realize this is implicit in much of the description, but
    it seems a good practice to be clear about the requriement, and we should
    establish that practice in this document.  (This would seem to belong in
    the next-to-last paragraph of section 7.1.)