Re: [DNSOP] Adam Roach's No Objection on draft-ietf-dnsop-refuse-any-07: (with COMMENT)

[Ólafur Guðmundsson <[e-mail]>]

On Tue, Sep 11, 2018 at 10:27 AM, Adam Roach <[e-mail]> wrote:

> Adam Roach has entered the following ballot position for
> draft-ietf-dnsop-refuse-any-07: No Objection
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-dnsop-refuse-any/
>
>
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> Thanks for the work that went into the mechanism, and especially to the
> early
> deployers who found issues to be addressed. I have a small handful of
> comments
> that the authors may wish to address prior to advancing the document to
> publication.
>
> ------------------------------------------------------------
> ---------------
>
> §4.1:
>
> >  A DNS responder which receives an ANY query MAY decline to provide a
> >  conventional ANY response
>
> Nit: "A DNS responder that receives..."
>
Noted


>
> ------------------------------------------------------------
> ---------------
>
>

> §4.2:
>
> >  The CPU field of the HINFO RDATA SHOULD be set to RFCXXXX
>
> Then, in §5:
>
> >  A DNS initiator MAY suppress queries with QTYPE=ANY in the event that
> >  the local cache contains a matching HINFO resource record with
> >  RDATA.CPU field, as described in Section 4.
>
> This looks like it's asking for a comparison. If such is the case, I think
> you
> need to indicate whether the value being compared is done so in a
> case-sensitive
> fashion. You probably also want to be pretty explicit about the literal
> string
> value to be used (e.g., be clear that the value doesn't contain a space).
>
>
Good point
it should just return the HINFO no matter what is in it
when we started with this document we had no numbers on usage of HINFO
but now we know it historical use is "almost none"


> ------------------------------------------------------------
> ---------------
>
> §4.2:
>
> >  The
> >  specific value used is hence a familiar balance when choosing TTL for
> >  any RR in any zone, and be specified according to local policy.
>
> Nit: This sentence appears to be missing a word. Perhaps "...and will be
> specified..." or similar.
>
> Noted


> ------------------------------------------------------------
> ---------------
>
> §4.2:
>
> >  In particular, systems SHOULD NOT rely upon the HINFO
> >  RDATA described in this seection to distinguish between synthesised
> >  and non-synthesised HINFO RRSets.
>
> Nit: "section"
>
> More substantive comment: Since the CPU field SHOULD indicate this
> document,
> implementations could reasonably infer that the HINFO RRSet is synthesized
> based
> on its value, right? That seems worth mentioning here.
>

overkill


>
> ------------------------------------------------------------
> ---------------
>
> §5:
>
> >  A DNS initiator which sends a query with QTYPE=ANY and receives a
>
> Nit: "...initiator that sends..."
>
>
> noted




-- 
Ólafur Gudmundsson | Engineering Director
www.cloudflare.com blog.cloudflare.com