Re: [DNSOP] Passive DNS - Common Output Format (draft-dulaunoy-kaplan-passive-dns-cof-01)

Tony Finch <dot@dotat.at> Thu, 16 January 2014 14:27 UTC

Return-Path: <fanf2@hermes.cam.ac.uk>
X-Original-To: dnsop@ietfa.amsl.com
Delivered-To: dnsop@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 054281AE35E for <dnsop@ietfa.amsl.com>; Thu, 16 Jan 2014 06:27:58 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.438
X-Spam-Level:
X-Spam-Status: No, score=-2.438 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-0.538] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KSNxljXs5ev6 for <dnsop@ietfa.amsl.com>; Thu, 16 Jan 2014 06:27:56 -0800 (PST)
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [IPv6:2001:630:212:8::e:f32]) by ietfa.amsl.com (Postfix) with ESMTP id CBBCF1AE356 for <dnsop@ietf.org>; Thu, 16 Jan 2014 06:27:55 -0800 (PST)
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/
Received: from hermes-2.csi.cam.ac.uk ([131.111.8.54]:37031) by ppsw-32.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.156]:25) with esmtpa (EXTERNAL:fanf2) id 1W3nv4-0003Xy-23 (Exim 4.82_3-c0e5623) (return-path <fanf2@hermes.cam.ac.uk>); Thu, 16 Jan 2014 14:27:42 +0000
Received: from fanf2 by hermes-2.csi.cam.ac.uk (hermes.cam.ac.uk) with local id 1W3nv4-0007eA-Ji (Exim 4.72) (return-path <fanf2@hermes.cam.ac.uk>); Thu, 16 Jan 2014 14:27:42 +0000
Date: Thu, 16 Jan 2014 14:27:42 +0000
From: Tony Finch <dot@dotat.at>
X-X-Sender: fanf2@hermes-2.csi.cam.ac.uk
To: Paul Vixie <paul@redbarn.org>
In-Reply-To: <52D6E0AB.807@redbarn.org>
Message-ID: <alpine.LSU.2.00.1401161404280.13642@hermes-2.csi.cam.ac.uk>
References: <52D298FB.3080100@redbarn.org> <52D6E0AB.807@redbarn.org>
User-Agent: Alpine 2.00 (LSU 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: Tony Finch <fanf2@hermes.cam.ac.uk>
Cc: "dnsop@ietf.org" <dnsop@ietf.org>
Subject: Re: [DNSOP] Passive DNS - Common Output Format (draft-dulaunoy-kaplan-passive-dns-cof-01)
X-BeenThere: dnsop@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: IETF DNSOP WG mailing list <dnsop.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dnsop>, <mailto:dnsop-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dnsop/>
List-Post: <mailto:dnsop@ietf.org>
List-Help: <mailto:dnsop-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dnsop>, <mailto:dnsop-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jan 2014 14:27:58 -0000

Paul Vixie <paul@redbarn.org>; wrote:

> speaking for the authors of the draft below, i request adoption by
> dnsop. --vixie
>
> https://datatracker.ietf.org/doc/draft-dulaunoy-kaplan-passive-dns-cof/

A few questions / comments:

The ws non-terminal isn't defined. I guess it is supposed to be

	ws = *( %x10 / %x09 )

i.e. no newlines within a JSON object, which is different from the
definition of ws in RFC 4627. (Maybe use core ABNF WSP instead?)

The ABNF specifies that the field names are not quoted (the quotes are
part of the ABNF metasyntax not part of the language it specifies) which
is incompatible with JSON and disagrees with the examples in the appendix.

The appendix could do with some rubric to explain the backslashes.

Are numeric rrtypes represented as JSON numbers? Or a "TYPEnnn" string?

I guess time stamps are represented as JSON numbers.

How are sensor_id octet strings encoded as JSON strings?

Tony.
-- 
f.anthony.n.finch  <dot@dotat.at>;  http://dotat.at/
Forties, Cromarty: East, veering southeast, 4 or 5, occasionally 6 at first.
Rough, becoming slight or moderate. Showers, rain at first. Moderate or good,
occasionally poor at first.