Re: [DNSOP] Roman Danyliw's No Objection on draft-ietf-dnsop-iana-class-type-yang-03: (with COMMENT)

Roman Danyliw <rdd@cert.org> Fri, 04 June 2021 12:23 UTC

Return-Path: <rdd@cert.org>
X-Original-To: dnsop@ietfa.amsl.com
Delivered-To: dnsop@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0C3363A07A3; Fri, 4 Jun 2021 05:23:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3y-w-J_y4eBj; Fri, 4 Jun 2021 05:23:11 -0700 (PDT)
Received: from taper.sei.cmu.edu (taper.sei.cmu.edu [147.72.252.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1FE793A0602; Fri, 4 Jun 2021 05:23:11 -0700 (PDT)
Received: from korb.sei.cmu.edu (korb.sei.cmu.edu [10.64.21.30]) by taper.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id 154CN91x022584; Fri, 4 Jun 2021 08:23:09 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 taper.sei.cmu.edu 154CN91x022584
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cert.org; s=yc2bmwvrj62m; t=1622809389; bh=NTtLf7LKA7TuwWKnZa5cfPo+gYQx6IBDCDzlpTs0VkM=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=JTN0Rs0JyTp3VbwAvqbhGBHQeN/W2vDAMk9VqYBSeLtE3hhGbe1kJH65DVwi6Zcl2 3bMBEEwaAZbI0Io+0kIMtuOmw6lWtf9V2evPnIQxmuTQHjglsYnWQe1XZQzOWkrAER hBb/OsbyMPXWrQKKqVXMrm31FS4CbzTSk0UiQGLw=
Received: from MORRIS.ad.sei.cmu.edu (morris.ad.sei.cmu.edu [147.72.252.46]) by korb.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id 154CN7ZK005047; Fri, 4 Jun 2021 08:23:08 -0400
Received: from MORRIS.ad.sei.cmu.edu (147.72.252.46) by MORRIS.ad.sei.cmu.edu (147.72.252.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 4 Jun 2021 08:23:07 -0400
Received: from MORRIS.ad.sei.cmu.edu ([fe80::555b:9498:552e:d1bb]) by MORRIS.ad.sei.cmu.edu ([fe80::555b:9498:552e:d1bb%13]) with mapi id 15.01.2242.008; Fri, 4 Jun 2021 08:23:07 -0400
From: Roman Danyliw <rdd@cert.org>
To: Ladislav Lhotka <ladislav.lhotka@nic.cz>, The IESG <iesg@ietf.org>
CC: "draft-ietf-dnsop-iana-class-type-yang@ietf.org" <draft-ietf-dnsop-iana-class-type-yang@ietf.org>, "dnsop-chairs@ietf.org" <dnsop-chairs@ietf.org>, "dnsop@ietf.org" <dnsop@ietf.org>, "benno@NLnetLabs.nl" <benno@NLnetLabs.nl>, "benno@NLnetLabs.nl" <benno@NLnetLabs.nl>
Thread-Topic: Roman Danyliw's No Objection on draft-ietf-dnsop-iana-class-type-yang-03: (with COMMENT)
Thread-Index: AQHXV97Ao6QXhM/uqE+r3uUOnv9lSKsDt2CAgAARfwA=
Date: Fri, 04 Jun 2021 12:23:06 +0000
Message-ID: <cabe792454fd48bfbe19a8f6ac107962@cert.org>
References: <162265919256.4095.5387300297626974526@ietfa.amsl.com> <87im2uhza6.fsf@nic.cz>
In-Reply-To: <87im2uhza6.fsf@nic.cz>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.64.202.236]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/dnsop/X18PZkTxr_dTl1RKVkcEoDZoO34>
Subject: Re: [DNSOP] Roman Danyliw's No Objection on draft-ietf-dnsop-iana-class-type-yang-03: (with COMMENT)
X-BeenThere: dnsop@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF DNSOP WG mailing list <dnsop.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dnsop>, <mailto:dnsop-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dnsop/>
List-Post: <mailto:dnsop@ietf.org>
List-Help: <mailto:dnsop-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dnsop>, <mailto:dnsop-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jun 2021 12:23:20 -0000

Hi Lada!

> -----Original Message-----
> From: Ladislav Lhotka <ladislav.lhotka@nic.cz>
> Sent: Friday, June 4, 2021 3:20 AM
> To: Roman Danyliw <rdd@cert.org>; The IESG <iesg@ietf.org>
> Cc: draft-ietf-dnsop-iana-class-type-yang@ietf.org; dnsop-chairs@ietf.org;
> dnsop@ietf.org; benno@NLnetLabs.nl; benno@NLnetLabs.nl
> Subject: Re: Roman Danyliw's No Objection on draft-ietf-dnsop-iana-class-type-
> yang-03: (with COMMENT)
> 
> Hi Roman,
> 
> thanks for your comments, please see below.
> 
> Roman Danyliw via Datatracker <noreply@ietf.org> writes:
> 
> ...
> 
> > ----------------------------------------------------------------------
> > COMMENT:
> > ----------------------------------------------------------------------
> >
> > Thank you to Valery Smyslov for the SECDIR review.
> >
> > I applaud the clever use of XSLT to autogenerate and keep the YANG
> > module up to date.
> >
> > ** Section 5.  Recommend refining the security considerations to defer
> > security issues to the modules that use import the data types defined in this
> document.
> > Roughly:
> >
> > OLD
> > This documents translates two IANA registries into YANG data types
> >    and otherwise introduces no technology or protocol.  Consequently,
> >    there are no security issues to be considered for this document.
> >
> > NEW
> >
> > This document translates two IANA registries into YANG data types for
> > use by other YANG modules.  When imported and used, the resultant
> > module schema will have data nodes that can be writable or readable
> > via a network management protocol.  Access or modification to such
> > data nodes may be considered sensitive in some network environments,
> > and this risk should be evaluated by the importing module.
> >
> 
> The iana-dns-class-rr-type module only defines data types, so it doesn't
> contribute any data nodes when imported or used. I suggest to use the
> following formulation, adopted from RFC 6991:
> 
> NEW
>   This documents translates two IANA registries into YANG data types and
>   otherwise introduces no technology or protocol. The definitions themselves
>   have no security impact on the Internet, but their use in concrete YANG
>   modules might have. The security considerations spelled out in the YANG
>   specification [RFC7950] apply for this document as well.
> 
> Is it sufficient?

Works for me!  Thanks for the improvement.

Regards,
Roman

> Thanks, Lada
> 
> >
> >
> 
> --
> Ladislav Lhotka
> Head, CZ.NIC Labs
> PGP Key ID: 0xB8F92B08A9F76C67