[DNSOP] Re: [Ext] Request: Review changes - draft-ietf-dnsop-rfc7958bis-03 → 04.

Petr Špaček <pspacek@isc.org> Thu, 15 August 2024 09:43 UTC

Return-Path: <pspacek@isc.org>
X-Original-To: dnsop@ietfa.amsl.com
Delivered-To: dnsop@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 302A1C151077 for <dnsop@ietfa.amsl.com>; Thu, 15 Aug 2024 02:43:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.107
X-Spam-Level:
X-Spam-Status: No, score=-7.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=isc.org header.b="aCDM3BkA"; dkim=pass (1024-bit key) header.d=isc.org header.b="Q49x1507"
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C9XQQbiCeqlq for <dnsop@ietfa.amsl.com>; Thu, 15 Aug 2024 02:43:51 -0700 (PDT)
Received: from mx.pao1.isc.org (mx.pao1.isc.org [149.20.2.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B0FC2C14F6BB for <dnsop@ietf.org>; Thu, 15 Aug 2024 02:43:51 -0700 (PDT)
Received: from zimbrang.isc.org (zimbrang.isc.org [149.20.2.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx.pao1.isc.org (Postfix) with ESMTPS id 836E23AB293; Thu, 15 Aug 2024 09:43:50 +0000 (UTC)
ARC-Filter: OpenARC Filter v1.0.0 mx.pao1.isc.org 836E23AB293
Authentication-Results: mx.pao1.isc.org; arc=none smtp.remote-ip=149.20.2.31
ARC-Seal: i=1; a=rsa-sha256; d=isc.org; s=ostpay; t=1723715030; cv=none; b=KGggCNbqkHjm0NT9q0VQydGnZmXzhMHKgpc4xcY+gDPQ3EIcIH3zNKuOXAgtnxi/U7HjdTs/d/nEU3BZcHhLSfCWfTK/XXDI5b8qlEa1PHU6P1dqyvuSYfFw017TAn76yuXDiwwUdtuVJ58Qg3YhPPi2BiA+W4BEqhAA6r+BisY=
ARC-Message-Signature: i=1; a=rsa-sha256; d=isc.org; s=ostpay; t=1723715030; c=relaxed/relaxed; bh=lwFKR2tG4kDOZaYSiotR7vYVTX1qu6ZPohZ2KCqwwBI=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=oXzRST6XehJjwOQolB6qpy+WbCUJjaUVemfCawCp5l6DfMu9vFMl63MnFPr1AJ6ylVFyDUZXp2pJhOgWNE/iAx9rwN6aeQQ0lppaH9KVQCSM1IvaFIWyZEo/KskKXcnQ98hYooapyzsoVEyh5pSaxHwwXE0/i5cCzRQVFojwELY=
ARC-Authentication-Results: i=1; mx.pao1.isc.org
DKIM-Filter: OpenDKIM Filter v2.10.3 mx.pao1.isc.org 836E23AB293
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=isc.org; s=ostpay; t=1723715030; bh=xtYlsCYnrQ9TxTNf5Tm5yjqZDASg38BdK8j6h68aL74=; h=Date:Subject:To:References:From:In-Reply-To; b=aCDM3BkAFzd45xqyLoDvbLbS3bnnDF1mTCMMCEZJvs4Aw6kRCZtptaI+kwNF5iZzd ckK0HD92+GuOg4sVqLuQYWWMQUR0Id1Zf+47XDSQdIixE6QJ/QXPe2IbEocqWoffIr pxhY45hx2/LTkU2i7Pe5q/3MieV4P4zoG6jxELNI=
Received: from zimbrang.isc.org (localhost.localdomain [127.0.0.1]) by zimbrang.isc.org (Postfix) with ESMTPS id 7F38C12C7885; Thu, 15 Aug 2024 09:43:50 +0000 (UTC)
Received: from localhost (localhost.localdomain [127.0.0.1]) by zimbrang.isc.org (Postfix) with ESMTP id 5CF9E12C7895; Thu, 15 Aug 2024 09:43:50 +0000 (UTC)
DKIM-Filter: OpenDKIM Filter v2.10.3 zimbrang.isc.org 5CF9E12C7895
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isc.org; s=05DFB016-56A2-11EB-AEC0-15368D323330; t=1723715030; bh=lwFKR2tG4kDOZaYSiotR7vYVTX1qu6ZPohZ2KCqwwBI=; h=Message-ID:Date:MIME-Version:To:From; b=Q49x1507d0gxQUoXft2hLlK22KTIVpPLTdIaEAiKpr46UFH4zjj3vm2xIeVfIv7ka mqaOhm2sLWjxN28gyztBX9Aq9PtJ0bTd81OCsoa74mPfFSO2E7YTHA3BvM2hruCzkf fsUTIxnX+k3upc4GpO8BIExGwVzJRA5hv8tKLtFA=
Received: from zimbrang.isc.org ([127.0.0.1]) by localhost (zimbrang.isc.org [127.0.0.1]) (amavis, port 10026) with ESMTP id Sr_3SdG1XEPG; Thu, 15 Aug 2024 09:43:50 +0000 (UTC)
Received: from [192.168.0.157] (ip-86-49-237-6.bb.vodafone.cz [86.49.237.6]) by zimbrang.isc.org (Postfix) with ESMTPSA id BD39412C7885; Thu, 15 Aug 2024 09:43:49 +0000 (UTC)
Message-ID: <45fd76e9-0e14-41bd-befe-74dd57dd6cdc@isc.org>
Date: Thu, 15 Aug 2024 11:43:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Paul Hoffman <paul.hoffman@icann.org>, dnsop <dnsop@ietf.org>
References: <CAHw9_iL-ZwwA_pckR+=7SndOvqjfcNX9FjZ9Bim24uSYgTxkyw@mail.gmail.com> <98896B9D-259E-4E46-8DC7-E873D8B25F55@icann.org>
From: Petr Špaček <pspacek@isc.org>
Content-Language: en-US
Autocrypt: addr=pspacek@isc.org; keydata= xsFNBF/OJ/4BEAC0jP/EShRZtcI9KmzVK4IoD/GEDtcaNEEQzPt05G8xtC0P4uteXUwW8jaB CdcKIKR4eUJw3wdXXScLNlyh0i+gm5mIvKPrBYNAMOGGnkbAmMQOt9Q+TyGeTSSGiAjfvd/N nYg7L/KjVbG0sp6pAWVORMpR0oChHflzKSjvJITCGdpwagxSffU2HeWrLN7ePES6gPbtZ8HY KHUqjWZQsXLkMFw4yj8ZXuGarLwdBMB7V/9YHVkatJPjTsP8ZE723rV18iLiMvBqh4XtReEP 0vGQgiHnLnKs+reDiFy0cSOG0lpUWVGI50znu/gBuZRtTAE0LfMa0oAYaq997Y4k+na6JvHK hhaZMy82cD4YUa/xNnUPMXJjkJOBV4ghz/58GiT32lj4rdccjQO4zlvtjltjp9MTOFbRNI+I FCf9bykANotR+2BzttYKuCcred+Q7+wSDp9FQDdpUOiGnzT8oQukOuqiEh3J8hinHPGhtovH V22D0cU6T/u9mzvYoULhExPvXZglCLEuM0dACtjVsoyDkFVnTTupaPVuORgoW7nyNl0wDrII ILBqUBwzCdhQpYnyARSjx0gWSG1AQBKkk5SHQBqi1RAYC38M59SkpH0IKj+SaZbUJnuqshXh UIbY1GMHbW/GDhz7pNQFFYm2S4OPUBcmh/0O0Osma151/HjF7wARAQABzR9QZXRyIMWgcGHE jWVrIDxwc3BhY2VrQGlzYy5vcmc+wsGXBBMBCABBAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4B AheAAhkBFiEEEVO2++xeDVoSYmDzq9WHzfBlga4FAmWT+REFCQelsxMACgkQq9WHzfBlga7y 2Q//Ug58UI9mlnD/guf9mHqpJIMrBs/vX8HlzylsDcZUBTp2TJpzNh/CygPWrHY+IvA9I9+t Ygp0sB+Z9OtVZgW3bpWJ0iWe6N89Q0kwOuhJ75LsfR1V73L5C826M6bLQjYTj6HiwS9Nf+N0 jADhEV/p1KtCuZfwBkYJ4ZM+Na0zWerGPkGw9T9O0gfs0ePehzJ5V0OK0nCqMuC1h8o/rhCb vRCmxdAbNjrOrgKa7HN5DadP/tKstJMM09aXlT5q96fRIyCQyqXQoCrijCWvgAxgjABdh1TB /XsYvBC8+4wy5ZBtTcnxXGrMhrSxU2/vIK6RjDju7OIRClMNepEzvt0gNzxwwxIXVOzl5ioC i/Okovk1rZneFFxbVvaMyIJgY/hShJV7Ei+5S9UZUv6UUmRQ6zukeiSVZrtXs6fWLVlUnBDl Cv/fXi25hrymqNfPSBSB0tyc6YepR1Rq9omTni6DYmEHQuhPMHJ2fuiNNyBaH+9EI7go5e0J LvXVLJGXkMdTcmYHja1pDjmQ1K71gewfPWGFmn0JTa92GuZJaR/4MVePvoV0NTpCP0HiKIg5 0+AOdpvkJReFKTQOX08SwkUkgvy9h9WjBMpD5ymMs4gjJwXtcT1+aVtj9Xcw6tQde9Yyjxde a6UZ3TUfys8qZ8ZKmMKTaCUFukKzWDJMZ91V1b/OwU0EX84n/gEQANARNXihDNc1fLNFZK5s O14Yg2TouK9eo9gGh4yLSrmZ3pjtnuJSpTWmGD4g0EYzhwWA/T+CqjUnrhsvzLQ1ECYVqLpM VqK2OJ9PhLRbx1ITd4SKO/0xvXFkUqDTIF6a5mUCXH5DzTQGSmJwcjoRv3ye+Z1lDzOKJ+Qr gDHM2WLGlSZAVGcUeD1S2Mp/FroNOjGzrFXsUhOBNMo8PSC4ap0ZgYeVBq5aiMaQex0r+uM4 45S1z5N2nkNRYlUARkfKirqQxJ4mtj5XPC/jtdaUiMzvnwcMmLAwPlDNYiU0kO5IqJFBdzmJ yjzomVk1zK9AYS/woeIxETs+s6o7qXtMGGIoMWr6pirpHk4Wgp4TS02BSTSmNzParrFxLpEU dFKq3M0IsBCVGvfNgWL2pKKQVq34fwuBhJFQAigR9B3O9mfaeejrqt73Crp0ng0+Q74+Llzj EIJLOHYTMISTJyxYzhMCQlgPkKoj+TSVkRzBZoYFkUt4OXvlFj73wkeqeF8Z1YWoOCIjwXH9 0u2lPEq0cRHHyK+KSeH1zQJ4xgj0QDGPmkvi81D13sRaaNu3uSfXEDrdYYc+TSZd2bVh2VCr xrcfzQ1uz9fsdC9NPdNd7/mHvcAaNc5e9IhNh67L54aMBkzlJi18d0sWXOOHkyLSvbHnC/OP wv7qCf69PUJmtoeHABEBAAHCwXwEGAEIACYCGwwWIQQRU7b77F4NWhJiYPOr1YfN8GWBrgUC ZZP5UgUJB6WzVAAKCRCr1YfN8GWBrgxpD/949Tz7EtrE9e2yJ4np+y7uW8EDusVM3QsBdkYk yaQTupITew8WWQtNF/QK/MKRi+e/382t78nBq+T7G9PrRi7E4WS9dXdgJiFz25h3mC4TABJZ b6MLcEreLWTaqnR/D6F3AnNXh7GJFY4E6PAwC60W0R9G6R0E+2XeZX011NEGiBMvgZnqzzjU L9h8Gz7a/EsQync4cvLbruPt/UaOV0khKTefsOFj3q3wLY6qN2qw7HfgFRBCh6ME2XRvnwAd iv0pF4HRbXoFalkAsNEYkWQ6mkJjdYCHOWm3TWqXhalgGKqIOrQyMpH2mJpZllKBQiBiQMUz qz0cO9OqBk3xvNLplI3VNcC0WeQ8LEqyYKth2T78hVaIw8K0IcVmZQwXVxL03gojaJ5bK2O+ 2FfqKMcIiU+bqaTXntx+FYRQKblsUBYD77uU9sPVyKWIiHvukLTx7GY1ttn6gZDSIek/tTR7 oaei+xLh5JUgZpMZ4JHnirDWHbrJzYN95e8HWA/+qAOTsa+igZGsc6yA1oJIAnCwkclcLAgc x3GVVeEL+/b9CugZ+1OfbxlRK7gAeu0kyKiEXrUvCQPnPByIIfj4I4IvZO4552cmmnbn31f9 X/9nw+M4qAqOK7bRg65ucv71TayUehNJrfJSYx6P1tXIwzu19tIgtdWTcsszNWALfaUFtg==
In-Reply-To: <98896B9D-259E-4E46-8DC7-E873D8B25F55@icann.org>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: quoted-printable
Message-ID-Hash: FZAPL2M3KL3WCNE6P2PVHBPK7X5F44IT
X-Message-ID-Hash: FZAPL2M3KL3WCNE6P2PVHBPK7X5F44IT
X-MailFrom: pspacek@isc.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-dnsop.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [DNSOP] Re: [Ext] Request: Review changes - draft-ietf-dnsop-rfc7958bis-03 → 04.
List-Id: IETF DNSOP WG mailing list <dnsop.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/dnsop/rbOyxQ5JCZCOQ5lj3TsFHqTnUbQ>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dnsop>
List-Help: <mailto:dnsop-request@ietf.org?subject=help>
List-Owner: <mailto:dnsop-owner@ietf.org>
List-Post: <mailto:dnsop@ietf.org>
List-Subscribe: <mailto:dnsop-join@ietf.org>
List-Unsubscribe: <mailto:dnsop-leave@ietf.org>

On 09. 08. 24 20:22, Paul Hoffman wrote:
> To everyone who reviewed draft-ietf-dnsop-rfc7958bis in WG Last Call: please carefully review the diff. Based on a very good IETF Last Call review from Petr Špaček, we had to make a significant technical change to the XML format, and we want to be sure that it works for everyone. We also updated the example (of course), and in doing so found a way to simplify the material around the example.
> 
> All comments welcome (until my birthday, August 18).
> 
> --Paul Hoffman
> 
> On Aug 9, 2024, at 11:05, Warren Kumari <warren@kumari.net> wrote:
>>
>>
>> Dear DNSOP,
>>
>> During the DNSDIR review of draft-ietf-dnsop-rfc7958bis-03, Petr Špaček identified an issue: if you include the DNSKEY material you also need to include the flags.
>>
>> The authors have published a new version addressing these changes, as well as addressing more minor comments received during IETF LC.
>>
>> As this required a change to the XML syntax, I'd like to get the DNSOP WGs review / feedback on these changes.
>>
>> The IANA is eagerly awaiting this becoming a standard so that they can update their trust anchor with the DNSKEY material - so, if you have any strong objections to these changes, please let me know by end of day (anywhere!) on Aug 18th
>>
>> Latest version: https://datatracker.ietf.org/doc/draft-ietf-dnsop-rfc7958bis/
>> Diff from -03: https://author-tools.ietf.org/iddiff?url1=draft-ietf-dnsop-rfc7958bis-03&url2=draft-ietf-dnsop-rfc7958bis-04&difftype=--html

I've re-reviewed the -04 version. It addresses the major problem of the 
format - the inability to represent some DNSSEC TAs.

-04 changes resulted in some omissions in the new text, see below.


 > 2.3. XML Example

Between versions -03 and -04 we have lost text with explicit 
instructions how to reconstruct text representation of DS and DNSKEY. 
I'm fine with doing it in the new section 2.3 but there are two 
omissions in the -04 text:

A.
Missing example of DNSKEY RR reconstruction. It was formerly present in 
the draft -03 section 2.4. Most notably -04 text is missing instruction 
about DNSKEY "Protocol" field which is not represented in the XML.

I think it needs a reference to RFC 4034 section 2.1.2 and an 
unambiguous instruction that constant "3" needs to be put in place of 
the Protocol field of the DNSKEY RR under (re)construction.


B.
Missing instruction about implicit class "IN". RFC 4034 defined all RR 
types as class-independent. I think it's fine to say "add constant 'IN' 
and be done with this", but I'm not aware of any RFC which would say 
that non-IN classes are not to be ever used.

C.
Besides these two protocol omissions I think it would be good to expand 
the example to cover corner case created by optional publickeyinfo elements.

I would recommend to base the 2.3 XML example section on the current 
version of http://data.iana.org/root-anchors/root-anchors.xml _with 
DNSKEY added_ for the 20326 keytag.

I.e. we would show three KeyDigest elements:
- 19036 which is expired (validUntil in the past)
- 20326 which is currently valid and also contains (PublicKey, Flags)
- 38696 which is also valid but does NOT contain (PublicKey, Flags)

Then the text should show how to reconstruct:
- DS set with two valid DSes (20326, 38696)
- DNSKEY set with just one DNSKEY (20326 only because material for 38696 
is missing)

... and say that the relying party needs to deal with this discrepancy 
between DS and DNSKEY sets.


Personally I still think it's a mistake to make publickeyinfo optional 
but with the current safeguards in place (last paragraph of sect 3.2) 
I'm hesitantly okay with leaving it optional.

Ad

>  5. IANA Considerations 

I wonder if this section needs some words about how to handle REVOKE 
flag and similar DS-hash-affecting situations. Setting REVOKE flag on a 
(former) TA will change its DS hash. This means that a relying party 
which stored just the DS RR cannot match pre-REVOKEd and post-REVOKEd DS.

Maybe IANA should have an instruction to NOT include REVOKEd TAs in the 
file at all? Or maybe IANA should included only the pre-REVOKEd DS hash 
with validUntil set to the past?

This mess is partially a consequence of the former refusal to assign any 
meaning to KeyDigest.id elements so the relying parties have a new 
guesswork to do when matching old and new trust anchors, but I gather 
this was already discussed (and refused to change) on the mailing 
list... So let's not open that question again and deal only with the 
consequences.

I'm not sure what to do about this.

-- 
Petr Špaček
Internet Systems Consortium