Re: [DNSOP] Working Group Last Call for draft-ietf-dnsop-server-cookies

Brian Dickson <brian.peter.dickson@gmail.com> Sat, 10 October 2020 21:13 UTC

Return-Path: <brian.peter.dickson@gmail.com>
X-Original-To: dnsop@ietfa.amsl.com
Delivered-To: dnsop@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 767453A08C0 for <dnsop@ietfa.amsl.com>; Sat, 10 Oct 2020 14:13:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a16ZF9NMUtIy for <dnsop@ietfa.amsl.com>; Sat, 10 Oct 2020 14:13:40 -0700 (PDT)
Received: from mail-ua1-x92a.google.com (mail-ua1-x92a.google.com [IPv6:2607:f8b0:4864:20::92a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 13BC53A08BD for <dnsop@ietf.org>; Sat, 10 Oct 2020 14:13:40 -0700 (PDT)
Received: by mail-ua1-x92a.google.com with SMTP id j20so2533811uaq.6 for <dnsop@ietf.org>; Sat, 10 Oct 2020 14:13:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M/IEeY4tgPLekT/gLXQSHFVw2Re9bYwcQCaSWnQ400U=; b=hKSjlZsjePbtAJv2PD7QQSTGNjVsAkcWIz2s3bHsqiF7JWfixZLhoLZc0AMdMnSvFB t8DPN41+rsmT7kfCc4aF0IECDu3qvIUdZhTX5EWvaZdMREHwwqN+Cld/MIokKxeY5ZzD xR5PScFIn1LpzhLn86U3B0NFoJ3U2M/wfo3TDisqIOIMxYFbXp6cJoT8vbPl/DJ6TsMO fOZ+p1ZwJ/bZ3MbOZd9JHh9BDdqg2XD7RfbZMkIJOi3qn/GdwDSiAb7t6xUhV+J1GDcr uiYzd2NlblWwoBmuCc0dAJyPm8EDupxNjY8GXrGmBFn98Z1/gQIAnYqoCr3p98bSBd24 GOng==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M/IEeY4tgPLekT/gLXQSHFVw2Re9bYwcQCaSWnQ400U=; b=FMgpIiEZcJDqfnzXiEdLSvdNG+jcYp8NpVPuW3B6qVvI5n3T6Y1vYwKeesXb2C5roU GBGWTvxMiScKsX1S0PnrEqPpcIszk17u9/s3Xiyhg/zd4gLp9131dxnjUZV9qwN3fmWB HCUbaK9vV+Amn+LvazyIgWwaU9ozfPCfct0cgPSYvPVF7ebXg4+Nm0Lv3Z/YGIc+v5fB +k2rHbJXWYWK36fm9irYRzXEgz0c8N5wqG2BO10NxoY2elJsIE/kmzS2q4sONO580QK2 s0CvwBYcDSXb7ZlpJACJcV4ybthVdOaftz58Vl40iS5L071wSNfRS7X9rPf5OWeHZS6N akaw==
X-Gm-Message-State: AOAM533GYHzfEHY7/S7G63X214gm4Tl+bcGdmEA0Q1GM8c6Fvcgh4qxf mBYn2vRVT1A/U0sVw7Pcj0X0XDmz88IsvMgP1U/4U4b5WxI=
X-Google-Smtp-Source: ABdhPJw2SsMGcccl8GUNSBMYKzsOqFtnTTy7B25l4d7LZJfKrZlfZ//mMgfNgjabX0kN5F7KKLMMhfzdUeSp9H7qycQ=
X-Received: by 2002:ab0:7313:: with SMTP id v19mr10139408uao.87.1602364419094; Sat, 10 Oct 2020 14:13:39 -0700 (PDT)
MIME-Version: 1.0
References: <894E9A77-1CE0-4513-AC89-15622A2ADABD@NLnetLabs.nl>
In-Reply-To: <894E9A77-1CE0-4513-AC89-15622A2ADABD@NLnetLabs.nl>
From: Brian Dickson <brian.peter.dickson@gmail.com>
Date: Sat, 10 Oct 2020 14:13:28 -0700
Message-ID: <CAH1iCiqMWogWLr1Cw-3LYo_wkem4zV1adqUc0xna5qd+H5x3YA@mail.gmail.com>
To: Benno Overeinder <benno@nlnetlabs.nl>
Cc: DNSOP Working Group <dnsop@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000003eb705b1578a7b"
Archived-At: <https://mailarchive.ietf.org/arch/msg/dnsop/xL4u2i5UVtKT6wbL4T7lwzLLNVw>
Subject: Re: [DNSOP] Working Group Last Call for draft-ietf-dnsop-server-cookies
X-BeenThere: dnsop@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF DNSOP WG mailing list <dnsop.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dnsop>, <mailto:dnsop-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dnsop/>
List-Post: <mailto:dnsop@ietf.org>
List-Help: <mailto:dnsop-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dnsop>, <mailto:dnsop-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Oct 2020 21:13:41 -0000

On Fri, Oct 9, 2020 at 8:38 AM Benno Overeinder <benno@nlnetlabs.nl> wrote:

> This starts a Working Group Last Call for draft-ietf-dnsop-server-cookies.
>
> Current versions of the draft is available here:
> https://datatracker.ietf.org/doc/draft-ietf-dnsop-server-cookies/
>
> The Current Intended Status of this document is: Standards Track
>
> FYI, I will not shepherd this document, as it was written with one of my
> coworkers.
> Tim Wicinski will be Document Shepherd.
>
> Please review the draft and offer relevant comments.
> If this does not seem appropriate please speak out.
> If someone feels the document is *not* ready for publication, please speak
> out with your reasons.
>

I have read the document, and support publication (modulo very minor nits
that should be fixed).

In addition to these nits, I do have one further suggestion for Section 8.

I'm not sure if it is too late to make such a suggestion, but on reading
(and thinking about) the spec,
it could be useful guidance (particularly for clients which may not be
aware of changes to their Client-IP address):

"o   In order to determine that a Server has detected a change to the
Client-IP, a Client may consider
      a BADCOOKIE error sooner than would be expected from a Server Cookie
refresh as a signal
      that the Client-IP may have changed, and thus that a new Client
Cookie should be created for each Server."

Nits:
Introduction - I believe "provides" should be "provide", to agree with the
singular "is" of the verb. (Sorry, grammar nit.)

Section 1.1 - I believe all the "Section Section" instances should really
just be "Section".

Section 4 - "too frequent" -> "too frequently".

Section 4.3 - "in the anycast." -> "in the anycast set."

Section 4.4 - hash calculation, end of first line "Client-IP," ->
"Client-IP |"

Section 5 - "anycast group" -> "anycast set"; "us used" -> "is used"

Section 8 - "like for example five minute." -> "for example five minutes."

Brian