Re: [dnssd] SRP Update - removing individual services (draft-ietf-dnssd-srp-06)

Kangping Dong <wgtdkp@google.com> Sat, 19 December 2020 15:11 UTC

Return-Path: <wgtdkp@google.com>
X-Original-To: dnssd@ietfa.amsl.com
Delivered-To: dnssd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 962D93A0936 for <dnssd@ietfa.amsl.com>; Sat, 19 Dec 2020 07:11:50 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -17.256
X-Spam-Level:
X-Spam-Status: No, score=-17.256 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.342, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WOfMKlg5qsLm for <dnssd@ietfa.amsl.com>; Sat, 19 Dec 2020 07:11:49 -0800 (PST)
Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 294963A091C for <dnssd@ietf.org>; Sat, 19 Dec 2020 07:11:49 -0800 (PST)
Received: by mail-yb1-xb29.google.com with SMTP id w135so4728713ybg.13 for <dnssd@ietf.org>; Sat, 19 Dec 2020 07:11:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rLF37zD0NDeHE++Q8VIEPGKYTUVZQiT/wFZc4NqPBAI=; b=TA099mTNp9N0TXs7npd6lwoz8ODS4ca80hfemyH2dUTa//94RsaF0+01/9ENyWp4HI 02gQ62/9HOyXGhqC3uKRZ2mlMyS1uMjFiNpDH/rBnRc6egMqiUI6Nd4+zMcMtw/xSKUD sHgxhWTxtS85eeFzSVTSpVgaoui75/EROk2RHUHTOIalczCHZZ83vr8w0OE57S8TSLQQ CzU0Ot2bH0bVS2cU6t2vOOyMZwNuk15Zk81pqNq3HHGroqWz/+RCScJlVpy7oei2/nNr +3KjDIWZSR071/AUyqPYNeHyYJWTd//HRUFbh9JvKeZapVxHHWVOD7qqxxJLesXbOJAJ 1kGg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rLF37zD0NDeHE++Q8VIEPGKYTUVZQiT/wFZc4NqPBAI=; b=bY6N08PIPEkEiI0KfKznr+FX5WUNjZlX81aATW41IEd+hl4W/uoXFbA2J0ub/ijiev U5Yg1ritlWUhzMYADnf62v81i8ITSF1i/9m6CDs697V8XYWWJhaYzYecYZUC0X9cUJQT s//BD9bViFMYt6E/gsI1Lk2/Y3dUsyC7wAXUOGjTL6lapf9ENtOEPmB4OLZC8JDs60d8 /5EBQZKgwxXg8hD9S2k41gT8TulOthjCLFacvwAiw/mEnS5a2ZjxyuCItgNG2kMxShUc eJkXWCT1cGO6bucGvuQDN3VS95q0ZMNxdMFXoqtH1HJ1aVRzNpjEz+8el6iN3PeRMqSu EpPQ==
X-Gm-Message-State: AOAM5319i3KIKkuQvE7vSrVYKQgkHnvq7aQLf13Jt739PWwwL2ylCY1v YlzZOqaGdW7w8sJLwm27Az0jzZVKuIpbJpjE05O3/Q==
X-Google-Smtp-Source: ABdhPJydcuBn6gMMlhA8nUrjH/qkHLFHS0zgL9pkvytA37MuMV0obSvBR61Ef2lcVVy/F6/oS89ehPRMsm91xyWqOyk=
X-Received: by 2002:a25:e048:: with SMTP id x69mr12744907ybg.353.1608390708079; Sat, 19 Dec 2020 07:11:48 -0800 (PST)
MIME-Version: 1.0
References: <CACce4dTbWCVwBityepJpb5FF4Rv43+DUev_0Ka+rVT9exZrJzA@mail.gmail.com> <031C980F-D8B6-4051-8DC0-D8417FDBBD0F@fugue.com> <CACce4dQZ708aaMdvmwhEurHDSdFAvLbzwpDWz=viig_2cX75Dw@mail.gmail.com> <680A60B6-BD88-475E-91ED-48F23036A7C8@fugue.com> <CAJ5Rr7bDSMv1uPDPXppG9e4OUEU7oriK9tVKD20=P3Kgb2q=0g@mail.gmail.com> <741BC8D6-CFEF-453B-8F89-A6B102A37DAA@fugue.com> <CAJ5Rr7Yw33y2k=wo-ZXzFNP77=bucRcr2LxJxf+98e5oqK+fsw@mail.gmail.com> <6B728DF0-5EE8-4EE6-9E95-98EF4D03D865@fugue.com> <CACce4dToa2+FiYgzp5AvZjO7-UfHy5VSSZ4ED+PkHMVPBZTQAA@mail.gmail.com> <87BDE0DB-9FB0-4BB2-872D-6D045897FCBD@fugue.com>
In-Reply-To: <87BDE0DB-9FB0-4BB2-872D-6D045897FCBD@fugue.com>
From: Kangping Dong <wgtdkp@google.com>
Date: Sat, 19 Dec 2020 23:11:12 +0800
Message-ID: <CAJ5Rr7ZmVWRp8H1Kg2QVXFJKnrUK09J2iPHsVTDvSxFioAznUQ@mail.gmail.com>
To: Ted Lemon <mellon@fugue.com>
Cc: Abtin Keshavarzian <abtink@google.com>, DNSSD <dnssd@ietf.org>, Jonathan Hui <jonhui@google.com>, Rongli Sun <rongli@google.com>
Content-Type: multipart/alternative; boundary="000000000000d1112a05b6d2a48e"
Archived-At: <https://mailarchive.ietf.org/arch/msg/dnssd/D9icyzsufKA0NY07FtBuBSpeyOw>
Subject: Re: [dnssd] SRP Update - removing individual services (draft-ietf-dnssd-srp-06)
X-BeenThere: dnssd@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Discussion of extensions to DNS-based service discovery for routed networks." <dnssd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dnssd>, <mailto:dnssd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dnssd/>
List-Post: <mailto:dnssd@ietf.org>
List-Help: <mailto:dnssd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dnssd>, <mailto:dnssd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 19 Dec 2020 15:11:51 -0000

Hi Ted,

Thanks for creating the 07 draft so quickly! The change overall looks good
to me and I agree we should check the KEY RR rather than the SRV RR.

I have some questions when reading the related sections:

1. in 2.2.5.5.2. Removing some published services
<https://www.ietf.org/archive/id/draft-ietf-dnssd-srp-07.html#section-2.2.5.5.2>,
we have:

> The second alternative is to send a normal SRP update, but as in the first
> alternative,

including a Service Discovery Instruction and a Service Description that
> *delete* the service being removed.

Should the "*delete*" be "*replace*"?

2. What's the use case of supporting multiple TXT RRs?
in section *2.3.1.2. Service Description Instruction
<https://www.ietf.org/archive/id/draft-ietf-dnssd-srp-07.html#name-service-description-instruc>*,
we have:

> zero or more "Add to an RRset" TXT RRs,
>

Are there real use cases that we need more than one TXT RRs? What is the
expected behavior
for the advertising proxy to publish this service with multiple TXT RRs? (I
think DNS-SD requires
a single TXT RR, is it correct?) Should multiple TXT RRs be concatenated to
form a new TXT RR?
If there is no such use case, should we require a single TXT RR? It will be
easier to implement on both
client and server side and consistent with DNS-SD. thoughts?


BRs,
Kangping

On Sat, Dec 19, 2020 at 8:17 PM Ted Lemon <mellon@fugue.com> wrote:

> Actually, on second thought, maybe the right thing to do is check for the
> KEY RR and not the SRV RR. If the key matches, the delete is okay. If there
> are no records on the name, the delete is okay.
>
> On Dec 19, 2020, at 12:25 AM, Abtin Keshavarzian <abtink@google.com>
> wrote:
>
> Does it sound ok?
>
>
>