Re: [dnssd] SRP Update - removing individual services (draft-ietf-dnssd-srp-06)

Kangping Dong <wgtdkp@google.com> Fri, 18 December 2020 14:24 UTC

Return-Path: <wgtdkp@google.com>
X-Original-To: dnssd@ietfa.amsl.com
Delivered-To: dnssd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4C5003A03F3 for <dnssd@ietfa.amsl.com>; Fri, 18 Dec 2020 06:24:00 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -17.256
X-Spam-Level:
X-Spam-Status: No, score=-17.256 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.342, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j0_PPcnLeu7v for <dnssd@ietfa.amsl.com>; Fri, 18 Dec 2020 06:23:55 -0800 (PST)
Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C224B3A03F1 for <dnssd@ietf.org>; Fri, 18 Dec 2020 06:23:55 -0800 (PST)
Received: by mail-yb1-xb34.google.com with SMTP id d37so2060545ybi.4 for <dnssd@ietf.org>; Fri, 18 Dec 2020 06:23:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7SqBU3Gv++kdEkTJ7B34Yr1UhHXbZSzm8ybn5wadO7E=; b=EbSMzTYwzmZ8995xNVUz/Dn0EPsXtgkAlIW7t2Kr66smUpTqUnxb5U2HHM1G0dKeJ/ i0hmitADiTETBUpzWZMPLI3f+k7GzKvzvSE+Bt40Y/ApL4Zj9kmYCk+6MzXfSI5fqhQ6 3rHBziPlN8PgoC7yWC1ksOU+GatwrJhyFTmAbE7zC/V1ygN9n34HdGzEKt9o0eDohcwR +mtM8AqGVRJ448oOmSmHkvKVkDr0vSbfwGAcRRfL+Qohqu61u6ASs3KT5EwPWm/E6Kbp 2V/YYM5KxymkAvp0YvgzU6m+ENGfcb7kWKooXohc106Ve5XIpa4akG9FEXD3B68pDhhS 5Teg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7SqBU3Gv++kdEkTJ7B34Yr1UhHXbZSzm8ybn5wadO7E=; b=LvuIdYIIzcA6p40YFwBgnqVI9ANQmFCMfku1mrIrHJl7gHw4n9bMpoRmn2lhG9dgev Uq3ELre6aC699r7C8ifU9JxvyUmEWFmQwQxGDtJYxbvWi6OGuUzKceZDqDB+t7kaQS9b z6RBOj4CEFoVjIc3HuCqCnNLgvJAPmBH9mk8vO0Ewkhne6S64hLW8BttU4Qn7HoRG2YN jUOFBT6VERQIO5aD+opyfuN3w1Qp8Yz2rtMbcaEiVXNT2BUSkkAZ34jX0mk2M0z5hxlT YXWxVlywyF1xluQcqp3cegP6RcG7V9w408SMeO3JyBYpm/KTfsMCap+I96oAARAtMN3o sdlg==
X-Gm-Message-State: AOAM530WVRhylqV3u2c9owo2CvCg7awpNV13ao8PKwtz7dzT00PkWBY6 agLv7/ZV0xo3+Zrk2rqgnXnhDzOhneozGuNc+uAqGw==
X-Google-Smtp-Source: ABdhPJyVEu5adNDTHk9jEDqe/lCDI+k8cOqPxSgW3j1XrF3V41G4vhWn290P6O0hG6olxtJZCdktX/cGcm6dnV1zUzI=
X-Received: by 2002:a25:d753:: with SMTP id o80mr5746563ybg.169.1608301434511; Fri, 18 Dec 2020 06:23:54 -0800 (PST)
MIME-Version: 1.0
References: <CACce4dTbWCVwBityepJpb5FF4Rv43+DUev_0Ka+rVT9exZrJzA@mail.gmail.com> <031C980F-D8B6-4051-8DC0-D8417FDBBD0F@fugue.com> <CACce4dQZ708aaMdvmwhEurHDSdFAvLbzwpDWz=viig_2cX75Dw@mail.gmail.com> <680A60B6-BD88-475E-91ED-48F23036A7C8@fugue.com> <CAJ5Rr7bDSMv1uPDPXppG9e4OUEU7oriK9tVKD20=P3Kgb2q=0g@mail.gmail.com> <741BC8D6-CFEF-453B-8F89-A6B102A37DAA@fugue.com>
In-Reply-To: <741BC8D6-CFEF-453B-8F89-A6B102A37DAA@fugue.com>
From: Kangping Dong <wgtdkp@google.com>
Date: Fri, 18 Dec 2020 22:23:18 +0800
Message-ID: <CAJ5Rr7Yw33y2k=wo-ZXzFNP77=bucRcr2LxJxf+98e5oqK+fsw@mail.gmail.com>
To: Ted Lemon <mellon@fugue.com>
Cc: Abtin Keshavarzian <abtink@google.com>, DNSSD <dnssd@ietf.org>, Jonathan Hui <jonhui@google.com>, Rongli Sun <rongli@google.com>
Content-Type: multipart/alternative; boundary="000000000000b28ea405b6bddbfc"
Archived-At: <https://mailarchive.ietf.org/arch/msg/dnssd/JS33rg-xXuS3nisDBmcRGtwHDyM>
Subject: Re: [dnssd] SRP Update - removing individual services (draft-ietf-dnssd-srp-06)
X-BeenThere: dnssd@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Discussion of extensions to DNS-based service discovery for routed networks." <dnssd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dnssd>, <mailto:dnssd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dnssd/>
List-Post: <mailto:dnssd@ietf.org>
List-Help: <mailto:dnssd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dnssd>, <mailto:dnssd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 19 Dec 2020 13:45:13 -0000

Sounds good, thanks! Looking forward to the 07 draft!

BRs,
Kangping

On Fri, Dec 18, 2020 at 9:20 PM Ted Lemon <mellon@fugue.com> wrote:

> On Dec 17, 2020, at 11:02 PM, Kangping Dong <wgtdkp@google.com> wrote:
>
> I'd like to summary my understanding of what current SRP-draft-06 is
> doing/allowing:
>
>    1. We can add services separately. like, we can add "service-1" and in
>    the first SRP update and "service-2" in the second SRP update.
>    2. We can only remove all the services together with its host because
>    "exactly one Host Description Instruction" is a MUST for each SRP update.
>
> But the spec seems, is not enforcing this behavior:
>
>> Therefore, SRP servers MAY remove all
>> service instances pointing to a host when a host is removed, even if
>> the SRP client doesn't remove them explicitly.
>>
>> If we cannot remove individual service without removing the host, should
> the "MAY" be a MUST?
> Otherwise, there may be no efficient way to clean up the service until the
> lease time expires.
>
>
> Yes, I think this is an oversight in the specification. What my
> implementation actually does is to remove all the entries when we see a
> “lease 0” update with a valid host record that’s signed with the right key.
>
> To remove a service registration, the SRP client retransmits its most
>> recent update with an Update Lease option that has a LEASE value of
>> zero.
>>
>> Does it remove only the services in my most recent update or all services
> I have ever registered?
>
>
> My implementation does the latter. It tracks what services are registered
> per host.
>
> This is what
> I was confused about and thought we can remove individual service. As we
> cannot remove individual service,
> I think we don't need to retransmit the most recent update: It may be more
> efficient to always transmit a
> SRP update with only Host Description Instruction and zero lease time.
> Thoughts?
>
>
> Yes.
>
> For the current use model, I agree it will work for most cases and
> removing individual service may be rare
> (even there are, it can be done with a "removing all" and an add). So I
> don't have a strong opinion to support it.
>
>
> I don’t think we really have enough data to say. In the interests of being
> general, I think it’s probably worth specifying how to remove individual
> services. This is what I’d originally intended—I did the “lease time 0”
> hack because it was expedient, not because it was the right thing to do.
>
> I’ll spin a -07 later today if I have time that makes this change and
> addresses your other concerns from above, and then if you’re willing, you
> guys can review my changes and see if they are sufficient.
>
>