IETF Logo Mail Archive

Re: [Dots] [Last-Call] Genart last call review of draft-ietf-dots-robust-blocks-05

Lars Eggert <lars@eggert.org> Fri, 30 September 2022 12:52 UTC

Return-Path: <lars@eggert.org>
X-Original-To: dots@ietfa.amsl.com
Delivered-To: dots@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DE2ABC14CF0D; Fri, 30 Sep 2022 05:52:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.107
X-Spam-Level:
X-Spam-Status: No, score=-2.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ANLmXHcmDruR; Fri, 30 Sep 2022 05:52:53 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [IPv6:2a00:ac00:4000:400:211:32ff:fe22:186f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F2166C14CF03; Fri, 30 Sep 2022 05:52:52 -0700 (PDT)
Received: from smtpclient.apple (unknown [IPv6:2a00:ac00:4000:400:96d:7258:2b5c:bed0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id 887651DBA10; Fri, 30 Sep 2022 15:52:45 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1664542365; bh=MGSup70eHyXTVyGxDDatbm7ShUYeALftBcgyTXuRMMA=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=c7LwDbOGla3SrLZQzKMhiAfBiLNSdljQ8Wy6wGv86p6LfHf3ka/76zh7uR2Orc0kh DZLW6VPI3Vlxy7Q7MwFAfxEMy7jE/GZfAppp3GIPs0CRIOWAS78dDBMvBn4Gzdc39N w/b2NUwM8p8mDJmjWL3wd8w1pLG2qIXKzGsxXJEY=
Content-Type: multipart/signed; boundary="Apple-Mail=_05424B75-3C2E-4062-9462-7722999E39FE"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <166424873911.33674.13795353189229005326@ietfa.amsl.com>
Date: Fri, 30 Sep 2022 15:52:45 +0300
Cc: General Area Review Team <gen-art@ietf.org>, dots@ietf.org, draft-ietf-dots-robust-blocks.all@ietf.org, last-call@ietf.org
Message-Id: <67128053-91F5-4F8E-9B48-ABCF6134B1FA@eggert.org>
References: <166424873911.33674.13795353189229005326@ietfa.amsl.com>
To: Tim Evens <tievens@cisco.com>
X-MailScanner-ID: 887651DBA10.A2B35
X-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/dots/-P1RkglG9cFwgTtlYQ2kpGQ6J9A>
Subject: Re: [Dots] [Last-Call] Genart last call review of draft-ietf-dots-robust-blocks-05
X-BeenThere: dots@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "List for discussion of DDoS Open Threat Signaling \(DOTS\) technology and directions." <dots.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dots>, <mailto:dots-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dots/>
List-Post: <mailto:dots@ietf.org>
List-Help: <mailto:dots-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dots>, <mailto:dots-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Sep 2022 12:52:57 -0000

Tim, thank you for your review. I have entered a No Objection ballot for this document.

Lars


> On 2022-9-27, at 6:18, Tim Evens via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Tim Evens
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-dots-robust-blocks-??
> Reviewer: Tim Evens
> Review Date: 2022-09-26
> IETF LC End Date: 2022-09-16
> IESG Telechat date: 2022-10-06
> 
> Summary: This document is ready with some minor comments.
> 
> Major issues:
> 
> Minor issues:
> 
> Nits/editorial comments:
> 
> 1) +1 to Paul's Nits
> 
> 2) Upon initial read, the abstract could suggest new parameters being
> introduced for configuration, yet that is not the case for this document. In
> Section 1 it is more clear by writing "This document augments the
> "ietf-dots-signal-channel" DOTS signal YANG module defined in Section 5.3 of
> [RFC9132]". It appears to me that this document adds the existing RFC9177
> non-confirming parameters to DOTS. I'm not suggesting that the abstract needs
> to be changed, but IMO it is a bit misleading till you read the intro.
> 
> 3) In section 1; "Nevertheless, the parameters listed in Table 1 are not
> supported in [RFC9132]". While "not supported" is correct, I believe that it
> would be more clear as "not included" considering the parameters do exist.
> 
> 4) In section 3, the parameters are restated from RFC9177 and RFC9132.
> 
> Each parameter looks to be a redefinition of what's documented in RFC9177 but
> with missing statements, truncated. I would prefer that if the parameter is
> unchanged to RFC9177, it should simply state that it's the same as defined in
> RFC9177.
> 
> Restating/documenting the parameters leads the reader to have to compare if
> there is a change from the source RFC.
> 
> 
> 
> --
> last-call mailing list
> last-call@ietf.org
> https://www.ietf.org/mailman/listinfo/last-call

v2.23.0 | Report a Bug | By Email