Re: [Dots] AD review of draft-ietf-dots-data-channel-25

[<[e-mail]>]

Hi Roman, all, 

The use of integer (not "integer") and "string" (not string) is on purpose because these examples are depicting the schema.

I update the text to clearly indicate schema examples. 

Hope this is OK.

Cheers,
Med

> -----Message d'origine-----
> De : Benjamin Kaduk [mailto:[e-mail]]
> Envoyé : mercredi 13 février 2019 18:53
> À : Roman Danyliw
> Cc : [e-mail]; [e-mail]
> Objet : Re: [Dots] AD review of draft-ietf-dots-data-channel-25
> 
> On Wed, Feb 13, 2019 at 05:35:01PM +0000, Roman Danyliw wrote:
> > Hi Ben and Data Channel Authors!
> >
> > > -----Original Message-----
> > > From: Dots [mailto:[e-mail]] On Behalf Of Benjamin Kaduk
> > > Sent: Wednesday, February 13, 2019 11:46 AM
> > > To: [e-mail]
> > > Cc: [e-mail]
> > > Subject: [Dots] AD review of draft-ietf-dots-data-channel-25
> >
> > > This is my AD review of the -25
> >
> > [snip]
> >
> > > Can someone (the shepherd?) confirm that an automated syntax checker
> > > has run over the JSON in examples?
> >
> > I'm the shepherd.  I validated the YANG in Section 4.3, but forgot to do
> the JSON.  I just ran the JSON in Figures 11, 12, 13, 14, 16, 17, 19, 23, 24,
> 25, 27, 29, and 31 through https://jsonlint.com/.  All but Figure 16 came
> back fine.
> >
> > Per Figure 16, the following edit is necessary (i.e., add a quote around
> integer, s/integer/"integer"/)
> 
> Hmm, that one is I think supposed to be more schema-like than example-like,
> so I actually was arguing to remove the quotes around "string" [and thus
> make the validator complain even more].
> 
> Thanks for checking!
> 
> -Ben
> 
> > OLD
> >            "target-port-range": [
> >              {
> >                "lower-port": integer,
> >                "upper-port": integer
> >              }
> >            ],
> >            "target-protocol": [
> >              integer
> >            ],
> > NEW
> >            "target-port-range": [
> >              {
> >                "lower-port": "integer",
> >                "upper-port": "integer"
> >              }
> >            ],
> >            "target-protocol": [
> >              "integer"
> >            ],
> >
> > Roman