Re: [Dots] Shepherd review of draft-ietf-dots-telemetry-use-cases

H Y <yuuhei.hayashi@gmail.com> Sat, 02 April 2022 01:13 UTC

Return-Path: <yuuhei.hayashi@gmail.com>
X-Original-To: dots@ietfa.amsl.com
Delivered-To: dots@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 19F593A1C19; Fri, 1 Apr 2022 18:13:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.108
X-Spam-Level:
X-Spam-Status: No, score=-7.108 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HHslYdPnYRxo; Fri, 1 Apr 2022 18:13:37 -0700 (PDT)
Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0F3B23A1C1C; Fri, 1 Apr 2022 18:12:35 -0700 (PDT)
Received: by mail-ed1-x530.google.com with SMTP id c62so4879182edf.5; Fri, 01 Apr 2022 18:12:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=KhgGHHMiS6VP3LJBelawiLAuPqFZdIGNmJ7CV5t/iw0=; b=M2ybZ7zYs8yQ/lo2vrJMffFBcP1wgXjNBmcSV5k+e18My5nSu3Dg1SX8rT0ACPcW1/ nPvyuthiNZagrPETlVfahnvN/jnp4pJngPOIl3FKXRXxK1G5cs5TBVe3SvoO1VGh3FGW UIrHbwfJ2p24IMdGGKm2qeloy7+HcuiLAn7TNubM4lmx838e1jT+gtlikiwPvqZd8PCu YtbdppnZ2FCJVxGys4Uw4fzRmci0ETQvQvJm+QLwTwTVk4Qf6WeWXc3ZS78SKfR8XPe8 qX3DPvn7YEdb4P9lWlk3hzMRdpWX41TuCD5g51r7Uhxpq/DOFgMsCv2aEH/Z1PFUpiH2 2+3A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=KhgGHHMiS6VP3LJBelawiLAuPqFZdIGNmJ7CV5t/iw0=; b=snyk/S3hQvU66D2WBfWrwCqTAYy+IHQ/tD5cP5n9LpiqEt7oYVirYpG63awrVLyxO6 tX6SPLEDowDuLIWNS/eIkVWWKSaG9xw1qdKLKOfC7LAeZNAXOU7T7iKYOl/d/rVawaIH +/+9Z/onzr4wwBaDVfyTMjvdFshyfjX47UbKhr76uQx11jGQoVend9G/5gqMSd9DQs7m 5+gnksDEufbdk0zywd0iFY1wstV9pdqbZU7jQk3H3jQg/LO0j76HMftCn9N/AfU/53Ut 8RJaaf7RCSo8pzfXohrrgj7LiHDZV5yaYS73hZp+2bpimoO8I0EjEk/ybVs3FynoIZsb okrg==
X-Gm-Message-State: AOAM533z7687M/frrLMPTovfDbE0ALV/eQi8DPSqoi4C0DRHnvnh49ed +I7DVzFJayN1aKXKPYgzQ94fGj14J20FMlXV6dpwNxFmlbw=
X-Google-Smtp-Source: ABdhPJz1qolp7rwvHB7FBJQiIV0qIp1cDOdbvp0jlbEzI7fY9N/bwpiHbkjsSfDKvSXlxmqlfyfSsvrca91s95psns0=
X-Received: by 2002:a50:bb08:0:b0:41b:6bb6:3be6 with SMTP id y8-20020a50bb08000000b0041b6bb63be6mr14708701ede.106.1648861953028; Fri, 01 Apr 2022 18:12:33 -0700 (PDT)
MIME-Version: 1.0
References: <19f101d84506$df98e810$9ecab830$@smyslov.net>
In-Reply-To: <19f101d84506$df98e810$9ecab830$@smyslov.net>
From: H Y <yuuhei.hayashi@gmail.com>
Date: Sat, 02 Apr 2022 10:12:24 +0900
Message-ID: <CAA8pjUN_aq7zJGxb9ErWCpVwpBgxa-E6UOuD9rWSf5wi9HSD5A@mail.gmail.com>
To: Valery Smyslov <valery@smyslov.net>
Cc: draft-ietf-dots-telemetry-use-cases@ietf.org, dots <dots@ietf.org>, dots-chairs <dots-chairs@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/dots/DpS81o0SESjW4Qv3fI7LrUAgc6I>
Subject: Re: [Dots] Shepherd review of draft-ietf-dots-telemetry-use-cases
X-BeenThere: dots@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "List for discussion of DDoS Open Threat Signaling \(DOTS\) technology and directions." <dots.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dots>, <mailto:dots-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dots/>
List-Post: <mailto:dots@ietf.org>
List-Help: <mailto:dots-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dots>, <mailto:dots-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Apr 2022 01:13:43 -0000

Hi Valery,

Thank you for your careful review.

We fixed the nits and posted it as draft-ietf-dots-telemetry-use-cases-10.

>4. Section 3.1.1.
>   After that, the orchestrator
>   orders the forwarding nodes to redirect as much of the top talker's traffic...
> Shouldn't it be top-talkers' ?
>7. Section 3.1.5.
> s/The forwarding nodes  send traffic statistics ... to the orchestrator the using "vendor-id" and "attack-id" telemetry attributes/
> The forwarding nodes  send traffic statistics ... to the orchestrator by using "vendor-id" and "attack-id" telemetry attributes

We found the same nits in draft-ietf-dots-telemetry-use-cases-9, so we
fixed them all.

Thanks,
Yuhei

2022年3月31日(木) 22:54 Valery Smyslov <valery@smyslov.net>:
>
> Hi,
>
> I reviewed the document and found some nits (mostly grammar and typos).
>
> 1. Abstract.
>
> The expansion of DOTS is "DDoS Open Threat Signaling". In the abstract it is expanded as "Denial-of-service Open Threat Signaling".
>
> 2. Figure 1, Figure 3, Figure 5, Figure 7, Figure 16, Figure 18.
>
> All contain the same typo:
>
> s/S is for DOTS client functionality/S is for DOTS server functionality
>
> 3. Section 3.1.1.
>
> IPFIX, BGP, SNMP aren't expanded on first use.
>
> 4. Section 3.1.1.
>
>    After that, the orchestrator
>    orders the forwarding nodes to redirect as much of the top talker's traffic...
>
> Shouldn't it be top-talkers' ?
>
> 5. Figure 7.
>
> s/BGP Flow spec/BGP Flowspec
>
> 6. Section 3.1.5.
>
> s/It may also necessary/It may also be necessary
>
> 7. Section 3.1.5.
>
> s/The forwarding nodes  send traffic statistics ... to the orchestrator the using "vendor-id" and "attack-id" telemetry attributes/
> The forwarding nodes  send traffic statistics ... to the orchestrator by using "vendor-id" and "attack-id" telemetry attributes
>
> 8. Section 3.2.
>
> s/Figure 15 provides ...  from the orchestrator to the network ./Figure 15 provides ...  from the orchestrator to the network.
>
> 9. Section 3.2.
>
> s/Then, the DDoS mitigation systems reports the status of DDoS countermeasures to the orchestrator sending "attack-detail" telemetry
> attributes./
> Then, the DDoS mitigation systems reports the status of DDoS countermeasures to the orchestrator by sending "attack-detail"
> telemetry attributes.
>
> 10. Section 3.2.
>
> s/After  that, the orchestrator integrates the reports ... and send it to a network administrator .../
> After  that, the orchestrator integrates the reports ... and sends them to a network administrator ...
>
> (two places)
>
> 11. Section 3.3.1.
>
>    On the other hand, DDoS detection based on the
>    DMSes is a more accurate method for detecting attack traffic better
>    than flow monitoring.
>
> I have trouble parsing this text. Probably:
>
>   On the other hand, DDoS detection based on the
>    DMSes is a more accurate method for detecting attack traffic
>    than flow monitoring.
>
> 12. Section 3.3.1.
>
> s/The aim of this use case is to increases flow collector's detection .../The aim of this use case is to increase flow collector's
> detection ...
>
> 13. Section 3.3.1.
>
> s/statisticsto/statistics to
>
> 14. Section 4.
>
> s/a DDoS attacks/DDoS attacks
>
> Regards,
> Valery.
>


-- 
----------------------------------
Yuuhei HAYASHI
08065300884
yuuhei.hayashi@gmail.com
iehuuy_0220@docomo.ne.jp
----------------------------------