Re: [Dots] Artart Last Call review of draft-ietf-dots-robust-blocks-04

mohamed.boucadair@orange.com Wed, 14 September 2022 05:43 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: dots@ietfa.amsl.com
Delivered-To: dots@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C51C6C14F73D; Tue, 13 Sep 2022 22:43:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.109
X-Spam-Level:
X-Spam-Status: No, score=-7.109 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=orange.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id J15HxWxCM7LQ; Tue, 13 Sep 2022 22:42:56 -0700 (PDT)
Received: from relais-inet.orange.com (relais-inet.orange.com [80.12.66.41]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 93DD0C14F73A; Tue, 13 Sep 2022 22:42:56 -0700 (PDT)
Received: from opfedar05.francetelecom.fr (unknown [xx.xx.xx.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by opfedar25.francetelecom.fr (ESMTP service) with ESMTPS id 4MS8PV1ypfz8tjX; Wed, 14 Sep 2022 07:42:54 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.com; s=ORANGE001; t=1663134174; bh=GG/72weSaPKser1oP2KrpMP2/bA4Q42xEzQ+HX3ePcs=; h=From:To:Subject:Date:Message-ID:Content-Type: Content-Transfer-Encoding:MIME-Version; b=G4oVh8ggZjFL0BG2t25X+XEGPdyzt/zZ0UPPZNyotrNMQyXnDvJpDggw3FBcm6ZFy zdsRWlCsLYxYw4iFy+wL3z/0OfCcmiy5ofOg0qx4SNbKrDGWI15U3sm2ntWF98COer TOIVziEl7s/aeo3WrAR1cM8xXexADh+s1ycr7PRbbjBRCNzkWqg3ASBROm6nfSMYGI Vh5NqWh6nm5dV+vRMJGTczhDPy9+CeqSYo3hnSslys10GCgOII15kAmIAD5hTpN9xI wWZWhjkeFpL9twLC+qdQlQFIzBY2V1jrVUXJ1Mfjx/3d595gd9KY7ERhV7cIjaInB0 kHQfBGuxBwjDA==
From: mohamed.boucadair@orange.com
To: Paul Kyzivat <pkyzivat@alum.mit.edu>, "art@ietf.org" <art@ietf.org>
CC: "draft-ietf-dots-robust-blocks.all@ietf.org" <draft-ietf-dots-robust-blocks.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "dots@ietf.org" <dots@ietf.org>
Thread-Topic: Artart Last Call review of draft-ietf-dots-robust-blocks-04
Thread-Index: AQHYx5ipty6vDOc9eUG/1UF/KBSp0a3eY2ug
Content-Class:
Date: Wed, 14 Sep 2022 05:42:53 +0000
Message-ID: <22708_1663134174_632169DE_22708_43_1_c0201ca845a744c986ca7795ca94c076@orange.com>
References: <70131de5-19f8-d73b-dc13-5f3273c465a2@alum.mit.edu>
In-Reply-To: <70131de5-19f8-d73b-dc13-5f3273c465a2@alum.mit.edu>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Enabled=true; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_SetDate=2022-09-14T05:39:29Z; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Method=Privileged; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Name=unrestricted_parent.2; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_SiteId=90c7a20a-f34b-40bf-bc48-b9253b6f5d20; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_ActionId=788ccb24-3b91-470f-a52e-589e4f7c6b6c; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_ContentBits=0
x-originating-ip: [10.115.27.51]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/dots/HjmxeryD-1GuiTVe5gfHQKRE4sw>
Subject: Re: [Dots] Artart Last Call review of draft-ietf-dots-robust-blocks-04
X-BeenThere: dots@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "List for discussion of DDoS Open Threat Signaling \(DOTS\) technology and directions." <dots.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dots>, <mailto:dots-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dots/>
List-Post: <mailto:dots@ietf.org>
List-Help: <mailto:dots-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dots>, <mailto:dots-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Sep 2022 05:43:00 -0000

Hi Paul, 

Thank you for the review. 

All good points. You can track the changes to address your review at: https://tinyurl.com/dots-robust-latest 

Cheers,
Med

> -----Message d'origine-----
> De : Paul Kyzivat <pkyzivat@alum.mit.edu>
> Envoyé : mardi 13 septembre 2022 19:46
> À : art@ietf.org
> Cc : draft-ietf-dots-robust-blocks.all@ietf.org; last-
> call@ietf.org; dots@ietf.org
> Objet : Artart Last Call review of draft-ietf-dots-robust-blocks-
> 04
> 
> Reviewer: Paul Kyzivat
> Review result: Ready with Nits
> 
> I am the assigned ARTART reviewer for this Internet-Draft.
> 
> Document: draft-ietf-dots-robust-blocks-04
> Reviewer: Paul Kyzivat
> Review Date: 2022-09-13
> IETF LC End Date: 2022-09-16
> IESG Telechat date: ?
> 
> Summary: Ready with Nits
> 
> Issues:
> 
> Major: 0
> Minor: 0
> Nits:  2
> 
> 1) NIT: "Parameter" vs. "Attribute"
> 
> Throughout the document the terms "Parameter" and "Attribute" are
> used more or less interchangeably. The term "Parameter" seems to
> be derived from RFCs 7252 and 9177 (e.g., in Table 1) and IIUC
> refers to abstract values without regard to how they are
> represented or transferred.
> Parameters are denoted by names in CAPITAL_LETTERS.
> 
> The term "Attribute" seems to come from the definition of a DOTS
> signal channel in RFC 9132. Attributes are denoted by lower-case-
> hyphenated-names.
> 
> I suggest it would be clearer to consistently use Parameter when
> discussing the former and Attribute when discussing the latter.
> (However, in the IANA registry table the column containing these
> "attributes" is labeled "Parameter Name", and so the template for
> the registry will have to refer to it that way. Unfortunate!)
> 
> 2) NIT: Relation of Parameters and Attributes
> 
> The Introduction ends with:
> 
>     ... Nevertheless,
>     the attributes listed in Table 1 are not supported in
> [RFC9132].
>     This document defines new DOTS signal channel attributes that
> are
>     used to customize the configuration of robust block
> transmission in a
>     DOTS context.
> 
> This seems to be the prime purpose of this document. Yet it fails
> to explicitly state the connection between the parameters listed
> in Table 1 and the "new DOTS signal channel attributes".
> 
> I see that there is a 1:1 correspondence between the two, with the
> exception of NON_TIMEOUT_RANDOM, which apparently need not
> transmitted because it is calculated. I think it would be helpful
> to state this explicitly here in the document. Perhaps:
> 
>     ... Nevertheless,
>     the parameters listed in Table 1 are not supported in
> [RFC9132].
>     This document defines new DOTS signal channel attributes,
>     corresponding to the parameters in Table 1, that are used to
>     customize the configuration of robust block transmission in a
>     DOTS context.


_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.