[Dots] Alexey Melnikov's Discuss on draft-ietf-dots-data-channel-28: (with DISCUSS and COMMENT)
Alexey Melnikov via Datatracker <noreply@ietf.org> Wed, 01 May 2019 13:15 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: dots@ietf.org
Delivered-To: dots@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 430001200E3; Wed, 1 May 2019 06:15:09 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Alexey Melnikov via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-dots-data-channel@ietf.org, Roman Danyliw <rdd@cert.org>, dots-chairs@ietf.org, rdd@cert.org, dots@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.95.1
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Alexey Melnikov <aamelnikov@fastmail.fm>
Message-ID: <155671650926.861.1001981088328880000.idtracker@ietfa.amsl.com>
Date: Wed, 01 May 2019 06:15:09 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/dots/ILlWGKX5uh1O-ZXvsDD3_YJc1jQ>
Subject: [Dots] Alexey Melnikov's Discuss on draft-ietf-dots-data-channel-28: (with DISCUSS and COMMENT)
X-BeenThere: dots@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "List for discussion of DDoS Open Threat Signaling \(DOTS\) technology and directions." <dots.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dots>, <mailto:dots-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dots/>
List-Post: <mailto:dots@ietf.org>
List-Help: <mailto:dots-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dots>, <mailto:dots-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 01 May 2019 13:15:09 -0000
Alexey Melnikov has entered the following ballot position for draft-ietf-dots-data-channel-28: Discuss When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html for more information about IESG DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-dots-data-channel/ ---------------------------------------------------------------------- DISCUSS: ---------------------------------------------------------------------- Thank you for a well written document. It was a pleasure to read. I have a small set of issues that I would like to be fixed before recommending approval of this document. 1) In 3.1: DOTS data channel configuration information as well as state information can be retrieved with the GET method. An HTTP status- line header field is returned for each request to report success or I know this text is copied from RFC 8040, but "status-line header field" is not correct. It is either "status-line" or "header field". (A header field always has ":" in it and HTTP status-line doesn't). I think you meant the former. If I misundestood and this is a part of payload itself, then your document should have an example. failure for RESTCONF operations (Section 5.4 of [RFC8040]). The "error-tag" provides more information about encountered errors (Section 7 of [RFC8040]). 2) 5.1. Registering DOTS Clients In order to make use of DOTS data channel, a DOTS client MUST register to its DOTS server(s) by creating a DOTS client ('dots- client') resource. To that aim, DOTS clients SHOULD send a POST request (shown in Figure 11). POST /restconf/data/ietf-dots-data-channel:dots-data HTTP/1.1 Host: {host}:{port} Content-Type: application/yang-data+json { "ietf-dots-data-channel:dots-client": [ { "cuid": "string" } ] } Your example is syntactically invalid, as you need an empty line after the Content-Type header field (before the payload). The same issue is pretty much in every example in your document. 3) In the same section 5.1: DOTS servers can identify the DOTS client domain using the 'cdid' parameter or using the client's DNS name specified in the Subject Alternative Name extension's dNSName type or SRV-ID in the client certificate. SRV-ID needs a Normative reference to RFC 6125. Also, can you give an example of how SRV-ID is going to be used? ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- In 6.1: name: Name of the alias. This is a mandatory attribute. Are there any restrictions on which characters can appear in aliases? In 7.1 (on page 49): Content-Type: application/yang-data+json { "ietf-dots-data-channel:capabilities": { This is not a valid response. Firstly, the status-line is missing Secondly, you are missing the empty line before the payload. In 7.2 (on page 52): The DOTS server indicates the result of processing the POST request using the status-line header. Again, drop "header" after status-line. For clarity you can say "the HTTP status-line".
- [Dots] Alexey Melnikov's Discuss on draft-ietf-do… Alexey Melnikov via Datatracker
- Re: [Dots] Alexey Melnikov's Discuss on draft-iet… mohamed.boucadair
- Re: [Dots] Alexey Melnikov's Discuss on draft-iet… Konda, Tirumaleswar Reddy